Re: [Wikitech-l] https via GPU?

[Asher Feldman]

>From the orig post "Recent Intel CPU has a fature called
AES-NI that
accelerates AES processing. A CPU with AES-NI can perform 5 to 10 times
faster than a CPU without it. We observe that a single core can perform 5
Gbps and 15 Gbps for encryption and decryption respectively." There's no
longer a need for specialized hardware solutions in this space, GPU based or
otherwise.

On Fri, Jul 29, 2011 at 12:10 PM, Brion Vibber  wrote:

> On Fri, Jul 29, 2011 at 11:53 AM, Jon Davis  wrote:
>
> > On Fri, Jul 29, 2011 at 11:29, Platonides  wrote:
> > > Our servers don't have a GPU, so that would need a hardware upgrade.
> > >
> > > Yes, but if large scale SSL deployment increased CPU usage to the point
> > of necessitating new hardware... the cost could be reduced by purchased
> > GPU's for servers rather than bunches of entirely new boxes.
> >
> > Conceptually I think it is a cool idea.
> >
>
> Most likely we'll end up with dedicated SSL termination subcluster, so
> those
> machines could be grabbed with whatever hardware they specifically needed.
> Certainly something to keep in mind!
>
> -- brion
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r91031.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c20441
Commit summary:

(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to 
r68904. Yay Roan finally taught me how to use the resourceloader :D

Comment:

Also fixed bug 28083.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93174]: New comment added

[MediaWiki Mail]

User "Jlemley" posted a comment on MediaWiki.r93174.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20440
Commit summary:

Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki

Comment:

REL1_17 currently mirrors trunk, and everything is functional in both places.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] https via GPU?

[Peter Youngmeister]

Hey,

I looked at this a little while ago for a previous job. I think that
it's a pretty awesome idea, but sadly I could never even find source
for their research, much less any reports of it being successfully
deployed in the wild, which made me sad. Hopefully they'll release it
and then some people here could go to town on it!

Best,
Peter

On Fri, Jul 29, 2011 at 12:10 PM, Brion Vibber  wrote:
> On Fri, Jul 29, 2011 at 11:53 AM, Jon Davis  wrote:
>
>> On Fri, Jul 29, 2011 at 11:29, Platonides  wrote:
>> > Our servers don't have a GPU, so that would need a hardware upgrade.
>> >
>> > Yes, but if large scale SSL deployment increased CPU usage to the point
>> of necessitating new hardware... the cost could be reduced by purchased
>> GPU's for servers rather than bunches of entirely new boxes.
>>
>> Conceptually I think it is a cool idea.
>>
>
> Most likely we'll end up with dedicated SSL termination subcluster, so those
> machines could be grabbed with whatever hardware they specifically needed.
> Certainly something to keep in mind!
>
> -- brion
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r91561]: New comment added

[MediaWiki Mail]

User "Aaron Schulz" posted a comment on MediaWiki.r91561.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91561#c20439
Commit summary:

(Bug 19725) Do not include suppressed edits in the "View X deleted edits" 
message, and when doing prefix search of special:undelete.

I'm not 100% sure this is the right thing to do, see the bug for the details. 
But basically this doesn't include an edit in the count if its text is hidden 
and its hidden from admins. (Not sure if it should not be included only if 
everything is hidden). Its also weird to show people different things depending 
if they have suppress rights, without really indicating that.

Minor db note: This causes the query to no longer use a covering index. I don't 
think that matters but just thought i'd mention.

p.s. The upload page show deleted edits link is broken right now, (from before) 
I'll fix in a follow-up.

Comment:

Wait, page histories (for live revs) don't do this, but Undelete does?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91608]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r91608.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91608#c0
Commit summary:

* (bug 28626) Validate JavaScript files and pages loaded via ResourceLoader 
before minification, protecting separate modules from interference

This is possibly not perfect but seems to serve for a start; follows up on 
r91591 that adds JSMin+ to use it in some unit tests. May want to adjust some 
related bits.

- $wgResourceLoaderValidateJs on by default (can be disabled)
- when loading a JS file through ResourceLoaderFileModule or 
ResourceLoaderWikiModule, parse it using JSMinPlus's JSParser class. If the 
parser throws an exception, the JS code of the offending file will be replaced 
by a JS exception throw listing the file or page name, line number (in original 
form), and description of the error from the parser.
- parsing results are cached based on md5 of content to avoid re-parsing 
identical text
- for JS pages loaded via direct load.php request, the parse error is thrown 
and visible in the JS console/error log

Issues:
- the primary use case for this is when a single load.php request implements 
multiple modules via mw.loader.implement() -- the loader catches the exception 
and skips on to the next module (good) but doesn't re-throw the exception for 
the JS console. It does log to console if present, but it'll only show up as a 
regular debug message, not an error. This can suppress visibility of errors in 
a module that's loaded together with other modules (such as a gadget).
- have not done performance testing on the JSParser
- have not done thorough unit testing with the JSParser

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91608]: New comment added

[MediaWiki Mail]

User "Aaron Schulz" posted a comment on MediaWiki.r91608.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91608#c20438
Commit summary:

* (bug 28626) Validate JavaScript files and pages loaded via ResourceLoader 
before minification, protecting separate modules from interference

This is possibly not perfect but seems to serve for a start; follows up on 
r91591 that adds JSMin+ to use it in some unit tests. May want to adjust some 
related bits.

- $wgResourceLoaderValidateJs on by default (can be disabled)
- when loading a JS file through ResourceLoaderFileModule or 
ResourceLoaderWikiModule, parse it using JSMinPlus's JSParser class. If the 
parser throws an exception, the JS code of the offending file will be replaced 
by a JS exception throw listing the file or page name, line number (in original 
form), and description of the error from the parser.
- parsing results are cached based on md5 of content to avoid re-parsing 
identical text
- for JS pages loaded via direct load.php request, the parse error is thrown 
and visible in the JS console/error log

Issues:
- the primary use case for this is when a single load.php request implements 
multiple modules via mw.loader.implement() -- the loader catches the exception 
and skips on to the next module (good) but doesn't re-throw the exception for 
the JS console. It does log to console if present, but it'll only show up as a 
regular debug message, not an error. This can suppress visibility of errors in 
a module that's loaded together with other modules (such as a gadget).
- have not done performance testing on the JSParser
- have not done thorough unit testing with the JSParser

Comment:

Why not make $jsParser a static member of the javaScriptParser() function?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91602]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r91602.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91602#c0
Commit summary:

Clean up the mess that is wfDie (resolves r85918). wfDie() doesn't exist 
anymore, so don't use it.

The only two usages left since r91590 are php version checks for 
index/load/api.php, and $wgAPIEnabled check in api.php. Consolidate all of the 
"bailing for invalid version" into PHPVersionError.php. Leaving $wgAPIEnabled 
as the only user was silly, so just echo and die like wfDie() would've done

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91742]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r91742.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91742#c0
Commit summary:

Fixes Bug #28838 — remove CSS references to div.editsection which grep
confirms isn't currently in use.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93861]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93861.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93861#c0
Commit summary:

added a description of myself

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93862]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93862.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93862#c0
Commit summary:

Add JSON view to the new demo

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93866]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93866.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93866#c0
Commit summary:

Use xlinks and ilinks instead of links

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91757]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r91757.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91757#c0
Commit summary:

HTMLForm: Add option to output a title for a fieldset & activate it for 
Special:Pref. Preliminary work for Bug 29672

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93861]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r93861.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93861#c20437
Commit summary:

added a description of myself

Comment:

Needs eol-style.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93863]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93863.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93863#c0
Commit summary:

whitespace change

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93863]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r93863.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93863#c20436
Commit summary:

whitespace change

Comment:

Thought so too. We should ping him about it :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93864]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93864.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93864#c0
Commit summary:

whitespace change

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93863]: New comment added

[MediaWiki Mail]

User "Peachey88" posted a comment on MediaWiki.r93863.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93863#c20435
Commit summary:

whitespace change

Comment:

I thought Tim changed it so root couldn't do commits anymore?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92044]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r92044.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92044#c0
Commit summary:

Per wikitech-l, run a bunch of URLs in the API output through wfExpandUrl(), so 
they become fully-qualified even if they were originally protocol-relative

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92454]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r92454.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92454#c0
Commit summary:

Bug #29874 - Image extension strict whitelist handling is inconsistent
Patch from Dan Collins

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93858]: New comment added

[MediaWiki Mail]

User "Aaron Schulz" posted a comment on MediaWiki.r93858.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93858#c20434
Commit summary:

Reverted r91942,r91943,r91949,r92156 per CR

Comment:

Tagging so that revdelete works in 1.18.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91942]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r91942.

Old Status: resolved
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91942#c0
Commit summary:

Followup r91871 per CR. Write back the actually executed action to . Ping r57415

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91949]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r91949.

Old Status: fixme
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c0
Commit summary:

Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible 
actions!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92156]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r92156.

Old Status: new
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92156#c0
Commit summary:

r91949 : EditWatchlist assumed that action was always empty for view

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93857]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r93857.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93857#c20433
Commit summary:

fix EOL style from r83856.

Comment:

Wrong revision tagged as followup

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91949]: New comment added

[MediaWiki Mail]

User "Aaron Schulz" posted a comment on MediaWiki.r91949.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91949#c20432
Commit summary:

Revert r91942, r91943 & reimplement. wgActions doesn't contain all possible 
actions!

Comment:

RevisionDelete broken for history buttons:
if ( $request->getVal( 'action' ) == 'historysubmit' ) {

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93607]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r93607.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c20431
Commit summary:

Being a father [X]
Checked!

Comment:

Are you providing the environment?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93847]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93847.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93847#c0
Commit summary:

Follow-up r93258, r93266, r93266: Move the defines to Defines.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93848]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93848.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93848#c0
Commit summary:

* Use local context instead of global variables
* Call Linker methods statically

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93851]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93851.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93851#c0
Commit summary:

r93683 missed return in line 1890

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93683]: Revision status changed

[MediaWiki Mail]

User "Platonides" changed the status of MediaWiki.r93683.

Old Status: ok
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93683#c0
Commit summary:

Add Profiling to trunk from r93681

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93607]: New comment added

[MediaWiki Mail]

User "ArielGlenn" posted a comment on MediaWiki.r93607.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c20430
Commit summary:

Being a father [X]
Checked!

Comment:

Too soon, still in development I believe. :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93426]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93426.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93426#c0
Commit summary:

MFT to REL1_18
r92634: typo in previous commit (fix r89029)
r92762: API must respect disabled query pages (fix r78824)
r92791: SpecialChangePassword used wrong message
r93141: mw.loader.load relative-protocol URLs support
r93303: typo for message autoblockedtext
HetWrapper:
r92854: Maintenance redefined TESTWIKI constant
r92958: Maitenance::shouldExecute() now allow multiple requires()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93607]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r93607.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c20429
Commit summary:

Being a father [X]
Checked!

Comment:

Needs unit tests!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93849]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93849.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93849#c0
Commit summary:

Initial import of a new demo that contains live preview of wikitext (not 
working yet)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93850]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93850.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93850#c0
Commit summary:

Just call $wgOut->parse() instead of doing a lot of things to call 
$wgParser->parse()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93476]: New comment added, and revision status changed

[MediaWiki Mail]

User "Platonides" changed the status of MediaWiki.r93476.

Old Status: new
New Status: fixme

User "Platonides" also posted a comment on MediaWiki.r93476.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93476#c20428
Commit summary:

Changed stash age parameter from a constant to a config option, switched to 
seconds for consistency.
followup to r92030

Comment:

Instance of $wgUploadStashMaxAge inside function stashFile (line 276) is a 
local variable, not the global.
in DefaultSettings.php

You shouldn't initialise variables in UploadStash.php or 
cleanupUploadStash.php. The default in DefaultSettings.php is enough and more 
sane.
If $wgUploadStashMaxAge wasn't set when you use it, that would be a bug with or 
without that duplicated code.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88039]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r88039.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88039#c0
Commit summary:

Fix Special:GlobalGroupPermissions checkboxes.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93838]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93838.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93838#c0
Commit summary:

Do chmod cleanup on multiversion/ too

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93841]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93841.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93841#c0
Commit summary:

array_key_exists

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93842]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93842.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93842#c0
Commit summary:

Solved the problem that duplicates could appear in OptionAttributeOptions lists

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93843]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93843.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93843#c0
Commit summary:

Removed unused global declaration

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93845]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93845.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93845#c0
Commit summary:

* Pushed implicit --wiki=aawiki param code up to MWScript.php, which avoids 
problems with files with the same name. It will no longer be assumed without 
the wrapper, but the callers using the scripts in the list were updated to use 
--wiki anyway.
* Added mctest.php & removed mergeMessageFileList.php (we don't want to run 
this on any random version) to implicit aawiki script list.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93840]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93840.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93840#c0
Commit summary:

Get rid of some old debug code

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90513]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r90513.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90513#c0
Commit summary:

* Made $useDB parameter of wfMsgGetKey() optional as in wfMsgReal() and removed 
it where possible
* Removed it from the call to wfMsgReal() in wfMsg() too

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91951]: New comment added

[MediaWiki Mail]

User "Aaron Schulz" posted a comment on MediaWiki.r91951.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91951#c20427
Commit summary:

Use createContext() instead of using the global context

Comment:

So is this FIXME or what? I'd like to get the CR backlog down.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93406]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93406.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93406#c0
Commit summary:

Passing a string to DifferenceEngine's constructor is really not a good idea 
since it expects a Title object or null

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93839]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93839.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93839#c0
Commit summary:

Call Linker methods statically

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93813]: New comment added

[MediaWiki Mail]

User "Helder.wiki" posted a comment on MediaWiki.r93813.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93813#c20426
Commit summary:

Don't show AFT if user is both logged out and on action=purge,
because in that scenario there is no article being shown (instead, in such 
scenario the user sees a form with a button to clear the cache, which is then 
redirected back to the article (action=view).

This bug was fairly rare though, since the MediaWiki interface doesn't contain 
any links to action=purge for logged-out users (or even logged-in users for 
that matter), but some gadgets and templates do link to it.


Resolves bug 30100 - Hide AFT for anonymous users on purge action.

Comment:

Shouldn't this be replicated to ApiArticleFeedback.php?

PS: There is a typo on "showiong".

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84233]: New comment added

[MediaWiki Mail]

User "Aaron Schulz" posted a comment on MediaWiki.r84233.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84233#c20425
Commit summary:

(bug 27403) saved user preferences which are subsequently disabled with 
$wgHiddenPrefs are not used in output, but are retained in the database in case 
the preference is subsequently re-enabled.

Comment:

Why would that effect the $defaultOverride parameter?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92083]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92083.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92083#c0
Commit summary:

Added 'fromdbmaster' param option to WikiPage::loadPageData()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92249]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92249.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92249#c0
Commit summary:

Removed loadFromDB() and use loadPageData() with new 'fromdbmaster' param 
(r92083)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92470]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92470.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92470#c0
Commit summary:

Fixed breakage due to r92083 and added tests

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93036]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93036.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93036#c0
Commit summary:

Added simple position tracking to populateRevTimestamp.php script

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92614]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92614.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92614#c0
Commit summary:

* Use SkinTemplateNavigation::Universal hook instead of 
SkinTemplateContentActions
* Use Skin's Title object instead of $wgTitle

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92618]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92618.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92618#c0
Commit summary:

Use wfMsgExt() instead of OutputPage::addWikiMsgArray() with third parameter

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93824]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93824.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93824#c0
Commit summary:

MFT r93823

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93823]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93823.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93823#c0
Commit summary:

Fix for bug 30195 (tag cloud is inexplicably shuffled), based on patch by Kalan

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93827]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93827.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93827#c0
Commit summary:

InlineScripts fixes:
* Rename several syntax elements in order to make things more JS-like
* Turn off the limit report hook for a while; currently broken
* Fix some annoying typos in syntax description

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92714]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92714.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92714#c0
Commit summary:

Fix table installer not working due to missing return value.
Add error message to table installer for unsupported data base types.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93467]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93467.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93467#c0
Commit summary:

added code For Extensions to generate html-text for the form

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92719]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92719.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92719#c0
Commit summary:

Resolve fixmes on r92436, r92439 by readding prefix to msg names

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93047]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r93047.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93047#c0
Commit summary:

Question randomizer now works with newly created pages. Value of poll randomize 
attribute is stored into poll description table, which is now used to 
distinguish non-randomized polls (no extra SQL query to load randomized 
questions list in such case anymore).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83433]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r83433.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83433#c0
Commit summary:

Add parser tests to this extension.

There are currently 2 broken tests. Thats because the extension is broken. 
(Clearly people use these
features). I'll try and fix them soonish. There's some tests also commented out 
that didn't
work due to issues with how parserTests work. (most notably, mysql doesn't like 
doing self-joins
on a temporary table, which this extension does quite a lot of, being so 
efficient and all).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93823]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r93823.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93823#c20424
Commit summary:

Fix for bug 30195 (tag cloud is inexplicably shuffled), based on patch by Kalan

Comment:

I happened to like the shuffling, but I can't help but think I'm in the 
minority here :(

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88391]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r88391.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88391#c0
Commit summary:

Makes sure wgAdditionalMailParams is null in safe mode

The global is used for a call to PHP mail() function as a way to add
additional parameters.  This will cause mail() to send E_NOTICE when
using safe mode.

Since we could use the global at different places, it makes sens to
ensure it has a sane value through Setup.php

Follow up r75557

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93635]: Revision status changed

[MediaWiki Mail]

User "MarkAHershberger" changed the status of MediaWiki.r93635.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93635#c0
Commit summary:

Fixes Bug #30061 - Command line installer $wgScriptPath

Patch from Edward Z. Yang

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93635]: New comment added

[MediaWiki Mail]

User "MarkAHershberger" posted a comment on MediaWiki.r93635.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93635#c20423
Commit summary:

Fixes Bug #30061 - Command line installer $wgScriptPath

Patch from Edward Z. Yang

Comment:

> I'm not sure why the wgScriptPath check is now a part of 
> setVarsFromRequest(), it seems out of place 

Why?  It is being set from information in the request, after all.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91728]: New comment added

[MediaWiki Mail]

User "Siebrand" posted a comment on MediaWiki.r91728.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91728#c20422
Commit summary:

Rewrite mwsuggest.js using j.ui.autocomplete. This gets rid of a lot of the 
little kinks of the previously implemenation: The suggestion list now contains 
regular anchors which can be openened in new indows or separate tabs. The 
carret doesn't jump around anymore when using the arrow keys to select an item. 
This should make it much easier to eventually merge Vectors simple search & 
mwsuggest.

Comment:

When? :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92833]: New comment added, and revision status changed

[MediaWiki Mail]

User "MarkAHershberger" changed the status of MediaWiki.r92833.

Old Status: fixme
New Status: new

User "MarkAHershberger" also posted a comment on MediaWiki.r92833.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92833#c20421
Commit summary:

Followup Bug #18831: Apply MZMcBride's patch do make the regex a
little better (according to my own testing).

Comment:

reedy fixed in r93776

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93823]: New comment added

[MediaWiki Mail]

User "Tim Starling" posted a comment on MediaWiki.r93823.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93823#c20420
Commit summary:

Fix for bug 30195 (tag cloud is inexplicably shuffled), based on patch by Kalan

Comment:

I don't understand why variable font size means you would want it shuffled.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93823]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r93823.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93823#c20419
Commit summary:

Fix for bug 30195 (tag cloud is inexplicably shuffled), based on patch by Kalan

Comment:

in pseudo code it could look like

if ( $wgCodeReviewEnableTagCloud ) {
or
if  ( $params['cloud'] ) {

  showCloud() // change font-size respective to number of revs, and randomize 
order

} else {

  showList() // something like this, without variable sizes or order:
  
  foreach( ... ) {
{tag} (### revs)
  }
  
}

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93823]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r93823.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93823#c20418
Commit summary:

Fix for bug 30195 (tag cloud is inexplicably shuffled), based on patch by Kalan

Comment:

Hm.. looks a little weird.

The reason it order was shuffled is because the sizes are variable (more common 
tags are bigger). So I think the configuration variable should be "enable tag 
cloud", not "enable alphabetic sorting in tag cloud".

If the variable* is set to false it would show an unordered list of tags with 
links to their revisions and their sizes in parentheses (all text the same 
size).


--
Krinkle

* Variable can either be a configuration variable, but preferably a url 
parameter or form element so that both are possible

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93821]: New comment added, and revision status changed

[MediaWiki Mail]

User "Platonides" changed the status of MediaWiki.r93821.

Old Status: new
New Status: ok

User "Platonides" also posted a comment on MediaWiki.r93821.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93821#c20417
Commit summary:

Fix r93820: PROT_ -> PROTO_

Comment:

Sorry, seems I confused you.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93819]: Revision status changed

[MediaWiki Mail]

User "Platonides" changed the status of MediaWiki.r93819.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93819#c0
Commit summary:

Followup r93266: also rename PROT_* to PROTO_* in the comments

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93822]: Revision status changed

[MediaWiki Mail]

User "Platonides" changed the status of MediaWiki.r93822.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93822#c0
Commit summary:

Fix syntax error in r93820

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93174]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r93174.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93174#c20416
Commit summary:

Followup r93154: Tweak extension credits and message files for consisteny
Add extension to Translatewiki

Comment:

Is that only 1.17? I was thinking of trunk.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93063]: New comment added

[MediaWiki Mail]

User "DieBuche" posted a comment on MediaWiki.r93063.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93063#c20415
Commit summary:

mw.user.js: Make sessionId public

Comment:

It's used in ajaxCats as a random number generator. I figured I don't need to 
duplicate that functionality. L876

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93817]: New comment added, and revision status changed

[MediaWiki Mail]

User "Brion VIBBER" changed the status of MediaWiki.r93817.

Old Status: new
New Status: ok

User "Brion VIBBER" also posted a comment on MediaWiki.r93817.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93817#c20414
Commit summary:

Fix noglobals exceptions from QUnit
* Test results prior to this commit: http://i.imgur.com/m8rbk.png
* http://localhost/trunkw/tests/qunit/?noglobals=1

- Missing var-statement, causes global scope implication
- Missing semi colon, causing next to be global

Comment:

Confirmed fix, shouldn't affect functionality negatively in any way.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93804]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r93804.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93804#c0
Commit summary:

In the protection form, show the current protection expiry time in the local 
time and not in UTC.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93131]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93131.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93131#c0
Commit summary:

1.17wmf1: Add EditPageTracking and MoodBar extensions from trunk

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93492]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r93492.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93492#c0
Commit summary:

adding strawberries as a default option

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93063]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r93063.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93063#c20413
Commit summary:

mw.user.js: Make sessionId public

Comment:

Ping.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r71991]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r71991.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71991#c20412
Commit summary:

Reorganized modules into more shallow structures. Using existing files for 
legacy, rather than porting them manually. Still need to force global scope for 
exported symbols for legacy code so it can cope with being wrapped. Removed 
test modules.

Comment:

There was a global leakage in jquery.textSelection.js, fixed in r93817.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r84233]: New comment added

[MediaWiki Mail]

User "Happy-melon" posted a comment on MediaWiki.r84233.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84233#c20411
Commit summary:

(bug 27403) saved user preferences which are subsequently disabled with 
$wgHiddenPrefs are not used in output, but are retained in the database in case 
the preference is subsequently re-enabled.

Comment:

The only nice way to do that is to repurpose the second parameter and refactor 
$ignoreHidden too, and I really can't see a clean way to do that...  :S

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93808]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r93808.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93808#c0
Commit summary:

removing a comment that doesn't make any sense after r91441 refactoring :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93233]: New comment added

[MediaWiki Mail]

User "Happy-melon" posted a comment on MediaWiki.r93233.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93233#c20410
Commit summary:

* Fix double-escaping from r85025
* Allow admins to modify blocks placed (probably accidentally) on themselves 
*by* themselves, whether or not they have the 'unblockself' permission.

Comment:

If the available accessors in User weren't so retarded, sure... :P

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] State of 1.18 code review/deployment

[Rob Lanphier]

On Tue, Aug 2, 2011 at 11:55 PM, Roan Kattouw  wrote:
> On Wed, Aug 3, 2011 at 8:47 AM, Brion Vibber  wrote:
>> Sounds good -- can we get a firm commitment that this is our schedule?
> I think RobLa wants the reverse: a firm commitment from *us* that this
> is our schedule. It looks good to me too.

Yup, that's basically the idea.  What I outlined is conservative in
some respects (I suspect many people probably still think we could
buckle down and get something out by end of August), but I haven't
exactly exhaustively planned for all contingencies.  We've got a lot
of unaccounted-for fixmes, and there's probably some blocking bugs
lurking in the database.  Also, there's not really a plan for formal
testing, and not a lot of room in that timeline to make it happen.

In short, there is much that could go wrong with this release, but I'm
guessing (rather blindly) there's just enough time to make it work if
we're committed to make this happen.  I'm willing to do my part.
Everyone else willing to do theirs?

Rob

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r93802]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r93802.

Old Status: new
New Status: reverted

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93802#c0
Commit summary:

Followup r92044: force HTTP on URLs output by the API, now that wfExpandUrl() 
has a flag for this

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93802]: New comment added

[MediaWiki Mail]

User "Catrope" posted a comment on MediaWiki.r93802.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93802#c20409
Commit summary:

Followup r92044: force HTTP on URLs output by the API, now that wfExpandUrl() 
has a flag for this

Comment:

After talking to Brion in person, we decided it'd be best to use PROT_CURRENT. 
Because that would introduce cache pollution though, we'll have to split the 
API cache into HTTP and HTTPS.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93802]: New comment added

[MediaWiki Mail]

User "Catrope" posted a comment on MediaWiki.r93802.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93802#c20408
Commit summary:

Followup r92044: force HTTP on URLs output by the API, now that wfExpandUrl() 
has a flag for this

Comment:

After talking to Brion in person, we decided it'd be best to use PROT_CURRENT. 
Because that would introduce cache pollution though, we'll have to split the 
API cache into HTTP and HTTPS.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89848]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r89848.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89848#c20407
Commit summary:

Follow-up: r89845: Forgot to commit changes in the other directory

Comment:

Done in r93805.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93792]: New comment added, and revision status changed

[MediaWiki Mail]

User "Brion VIBBER" changed the status of MediaWiki.r93792.

Old Status: new
New Status: ok

User "Brion VIBBER" also posted a comment on MediaWiki.r93792.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93792#c20406
Commit summary:

Tweak/add to documentation

Remove old compat constants for "1.6 compatibility"

Comment:

Don't seem to be used anywhere in the codebase including extensions. Yay!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r93802]: New comment added

[MediaWiki Mail]

User "Brion VIBBER" posted a comment on MediaWiki.r93802.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93802#c20405
Commit summary:

Followup r92044: force HTTP on URLs output by the API, now that wfExpandUrl() 
has a flag for this

Comment:

Does this mean an API client has no way of knowing that these URLs could be 
accessed over SSL as well?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview