[MediaWiki-CodeReview] [MediaWiki r93889]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93889. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93889#c20477 Commit summary: re r93871 — add release notes Comment: That's not exactly true, it's only granted for registered users. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Exemption from account creation throttle
A few month ago Frank Schulenburg asked me if it would be possible to exempt single IP addresses from the account creation throttle. He filed https://bugzilla.wikimedia.org/show_bug.cgi?id=25000 Besides the existing way of defining an exempt in the config files I hacked a bit and committed http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72959 An easy way, a bit too easy: it was reverted *hides*. Now he asked me again on Wikimania what to do because he will need in the future more exempts for bigger groups. All known ways seem not very nice: * Account creation by admin does not scale for 100 new accounts * Edit the config file is restricted to sysadmins I think about writing an extension with a special page where admins can define IP address, start and end time of the throttle exempt. What do you think? Have I missed an easier way to approach his needs? Raymond. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93897]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93897. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93897#c20478 Commit summary: Add borrowed xml string formatter [0] for help with output debugging Was slightly reformatted and tweaked per comments beneath [0] http://recursive-design.com/blog/2007/04/05/format-xml-with-php/ Comment: What's the followup given that is marked resolved? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93912]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93912. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93912#c20479 Commit summary: Reverted r91548 per CR Comment: Could you be more specific next time. It took me a while to guess that the reason is on long pages the scroll bar is now inconveniently on bottom of the page instead on bottom of the screen. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93751]: New comment added
User Krinkle posted a comment on MediaWiki.r93751. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93751#c20480 Commit summary: Fixes Bug #29311 - [OutputPage] Create a method to remove items from mModules Patch from John Du Hart, reviewed by Roan, Applying at Roan's request. Comment: I'm suggesting to revert this, see also comment left [https://bugzilla.wikimedia.org/show_bug.cgi?id=29311#c8 here]. What do you think ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93935]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93935. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93935#c20481 Commit summary: Adding Revision::newFromRow() function as alias for new Revision() More consistent with how we do stuff everywhere else Comment: Add @since when we know which version this goes in? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] SQL: Stored Procedures and MediaWiki
Hi Brion, thanks for the hint. Is there a tutorial or documentation on how to use stored procedures in MediaWiki? Do you - or anybody else - know an extension that makes use of this feature? Something we can take a look at? Greetings, Robert Vogel Hallo Welt! - Medienwerkstatt GmbH ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Using java applet for DJVU files ? (Retry)
Hi there, it seems that nobody can help? So: Does anybody know someone in- or outside Celartem who cares about that? Greetings Uwe ___ Schon gehört? WEB.DE hat einen genialen Phishing-Filter in die Toolbar eingebaut! http://produkte.web.de/go/toolbar ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Using java applet for DJVU files ? (Retry)
On Fri, Aug 5, 2011 at 2:28 PM, Uwe Baumbach u.baumb...@web.de wrote: Hi there, it seems that nobody can help? So: Does anybody know someone in- or outside Celartem who cares about that? I'm not sure if we have a good idea of the use case for a DjVu viewer applet; individual pages are thumbnailed as JPEGs for in-browser viewing already; while this isn't an efficient way to read a whole document, it handles the common case of look at this page of this document with no need for additional tools. Can you go into a little more detail on what an applet viewer might be used for? This would presumably require downloading the entire DjVu file (and then potentially doing it again next time you go back to the page). I also need to warn that Java applets are not so popular these days; in addition to classic problems with slow load time, some browsers now default to disabling the Java plugin by default for security reasons. So we might want to think about what it's intended to accomplish, how it's meant to be used, and then start thinking about whether a Java applet is a good way to accomplish it. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Protocol-relative URLs enabled on test.wikipedia.org
On Thu, Jul 14, 2011 at 8:55 PM, Ryan Lane rlan...@gmail.com wrote: Over the past couple days Roan Kattouw and I have been pushing out changes to enable protocol-relative URL support. We've gotten to a point where we think it is stable and working. We've enabled this on test.wikipedia.org, and plan on running it for two weeks before enabling it elsewhere. Please test if everything is working properly, especially with regards to the API and bots. Report bugs in bugzilla if any are found. After some issues popped up, especially with protocol relative URLs appearing in the wrong places (like e-mail notifications) or URLs being wrongly forced to HTTP (which caused the bug where logging in on HTTPS redirected you to HTTP), I've done some work to fix these issues in SVN while attending conferences in the past two weeks (rewriting wfExpandUrl() etc.). They're now fixed in trunk and the fixes are deployed to production. Apart from a FlaggedRevs bug where protocol-relative URLs are shown as internal links, HTTPS should now work correctly on https://test.wikipedia.org/ , https://wikimania2005.wikimedia.org/ and https://office.wikimedia.org/ (internal wiki). Please test this and report any remaining issues. If all goes well, we'll start rolling this out on production wikis in a few weeks, most likely in the week of Aug 15. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93911]: New comment added
User Reedy posted a comment on MediaWiki.r93911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93911#c20484 Commit summary: Remove no-op initialise from configuration. Nothing outside of Ext:Configure needs/uses it Comment: Though, if it's also a noop in 1.17 etc, we can just remove it out now (from wgConf.php) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93911]: New comment added
User ^demon posted a comment on MediaWiki.r93911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93911#c20485 Commit summary: Remove no-op initialise from configuration. Nothing outside of Ext:Configure needs/uses it Comment: If I broke stuff, feel free to revert. You won't hurt my feelings :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93911]: New comment added
User Reedy posted a comment on MediaWiki.r93911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93911#c20486 Commit summary: Remove no-op initialise from configuration. Nothing outside of Ext:Configure needs/uses it Comment: It's a noop in 1.17wmf1 too. Could just remove the initialise from the WMF config files, and push this into 1.18 too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] How To Hack MediaWiki coding standards/code review workshops
At the Wikimania Developer Days this week, several developers led a workshop for MediaWiki beginners, and a code review training covering our coding standards. First-draft notes for both are up: http://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker/Workshop http://www.mediawiki.org/wiki/Code_review_management/Aug_2011_training and I intend on improving them into a more productized curriculum for future hackathons. Thanks to Guillaume Paumier and to Waldir Pimenta for many of those notes, to Roan Kattouw, Timo Tijhof, Andrew Garrett, Brion Vibber, Tim Starling, Brandon Harris, and other developers for teaching, to Amir Aharoni for initiating the idea of the beginners' workshop, and to Florian Hackenberger for volunteering to have Tim Starling review his code live onstage. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93980]: New comment added
User ^demon posted a comment on MediaWiki.r93980. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93980#c20487 Commit summary: * Call Linker methods statically * Use INSERT IGNORE for the site_stats row (as for the interwiki entries); was throwing query error about duplicate row on my installation Comment: I ''just'' removed that IGNORE because it wasn't throwing errors for me anymore. See r93933, r88772. Stack trace? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93982]: Revision status changed
User ^demon changed the status of MediaWiki.r93982. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93982#c0 Commit summary: SD code handled in EditSchema ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93981]: Revision status changed
User ^demon changed the status of MediaWiki.r93981. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93981#c0 Commit summary: Whitespace and comment updates ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88629]: Revision status changed
User ^demon changed the status of MediaWiki.r88629. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88629#c0 Commit summary: Swift needs to rewrite entire files. We need this call to prevent N**2 operations while appending ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Exemption from account creation throttle
Raimond Spekking wrote: A few month ago Frank Schulenburg asked me if it would be possible to exempt single IP addresses from the account creation throttle. He filed https://bugzilla.wikimedia.org/show_bug.cgi?id=25000 Besides the existing way of defining an exempt in the config files I hacked a bit and committed http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72959 An easy way, a bit too easy: it was reverted *hides*. Now he asked me again on Wikimania what to do because he will need in the future more exempts for bigger groups. All known ways seem not very nice: * Account creation by admin does not scale for 100 new accounts * Edit the config file is restricted to sysadmins I think about writing an extension with a special page where admins can define IP address, start and end time of the throttle exempt. What do you think? Have I missed an easier way to approach his needs? I think your first approach was fine. The objection to this revision, at least in my understanding, was not that it was hackish or cumbersome (though it is). The objection was that it was hackish and cumberson _in core_. You could put the exact same system into an extension and then ask that the extension be enabled on Wikimedia wikis and be fine. I think that this is the best solution given current constraints. Rewriting the frontend and backend systems to be able to handle a feature like this (and many other features) in a sane and clean manner is a large undertaking. I understand (and agree with) the view that putting more configuration into the MediaWiki namespace, particularly in core, is bad. But doing it in an extension? Well, that's why extensions exist. :-) MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Exemption from account creation throttle
On Fri, Aug 5, 2011 at 1:02 PM, MZMcBride z...@mzmcbride.com wrote: Raimond Spekking wrote: A few month ago Frank Schulenburg asked me if it would be possible to exempt single IP addresses from the account creation throttle. He filed https://bugzilla.wikimedia.org/show_bug.cgi?id=25000 Besides the existing way of defining an exempt in the config files I hacked a bit and committed http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72959 An easy way, a bit too easy: it was reverted *hides*. Now he asked me again on Wikimania what to do because he will need in the future more exempts for bigger groups. All known ways seem not very nice: * Account creation by admin does not scale for 100 new accounts * Edit the config file is restricted to sysadmins I think about writing an extension with a special page where admins can define IP address, start and end time of the throttle exempt. What do you think? Have I missed an easier way to approach his needs? I think your first approach was fine. The objection to this revision, at least in my understanding, was not that it was hackish or cumbersome (though it is). The objection was that it was hackish and cumberson _in core_. You could put the exact same system into an extension and then ask that the extension be enabled on Wikimedia wikis and be fine. I think that this is the best solution given current constraints. Rewriting the frontend and backend systems to be able to handle a feature like this (and many other features) in a sane and clean manner is a large undertaking. I understand (and agree with) the view that putting more configuration into the MediaWiki namespace, particularly in core, is bad. But doing it in an extension? Well, that's why extensions exist. :-) As I was the primary objector in that revision, I think the idea of doing the same within an extension is suitable as an immediate solution. Should be very trivial to implement/review/deploy and would keep core clean. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93972]: Revision status changed
User ^demon changed the status of MediaWiki.r93972. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93972#c0 Commit summary: Fix boolean fail from r93971 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93977]: Revision status changed
User ^demon changed the status of MediaWiki.r93977. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93977#c0 Commit summary: Followup r93905 per comment on bug 30230 Make text parameter of ApiExpandTemplates required ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93970]: Revision status changed
User ^demon changed the status of MediaWiki.r93970. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93970#c0 Commit summary: Localisation update for ToolserverI18N messages from translatewiki.net (2011-08-06 14:00:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82426]: Revision status changed
User ^demon changed the status of MediaWiki.r82426. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82426#c0 Commit summary: Follow up r63584. The change of resetArticleID() could have all kinds of side effects, given that it stops lazy cache fillings. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86697]: Revision status changed
User ^demon changed the status of MediaWiki.r86697. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86697#c0 Commit summary: (bug 26603) Followup r82232: fix double-escaping of returnto and returntoquery. Was caused by using two sources ($this-thisurl and $wgRequest) where one was already escaped and the other wasn't, then unconditionally escaping the result. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87754]: Revision status changed
User ^demon changed the status of MediaWiki.r87754. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87754#c0 Commit summary: * [mediaWiki] Using mw-alias where possible + adding missing semi-colons and other JSHint nags * [mw.util.test] Moving CSS style check for div#js-message after the call to jsMessage(). In most skins this doesn't matter as the element already exists. But some skins this element isn't created untill the call to jsMessage(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88382]: Revision status changed
User ^demon changed the status of MediaWiki.r88382. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88382#c0 Commit summary: Applying patch by Ryan Kaldari (bug 28690): Adding border to jQuery UI 'vector' theme dialog ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88548]: Revision status changed
User ^demon changed the status of MediaWiki.r88548. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88548#c0 Commit summary: Changing float to text-align for conveniencelinks and editreasons links. Since headings have overflow:hidden this is causing the border to stop when this block is touched (atleast in Chrome/Safari), since headings don't clear float. This doesn't have to be a float from what I can see and is better done as text-align so that any later elements on the page will not be affected by the page flow. Remove the line from Vector's main.css since it was already in shared.css ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87744]: Revision status changed
User ^demon changed the status of MediaWiki.r87744. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87744#c0 Commit summary: .length has the same number of characters as length and saves a function all. whatever ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81583]: New comment added
User ^demon posted a comment on MediaWiki.r81583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81583#c20488 Commit summary: Switch editsection to mw:editsection and start hiding these editsection tags from Tidy so it doesn't break them. Comment: * Definitely needs some unit tests * If we're going to have a class for Tidy-related stuff, it might make sense to move more of Parser's tidy code into it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81978]: Revision status changed
User ^demon changed the status of MediaWiki.r81978. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81978#c0 Commit summary: Partial fix for bug 27310. Add domain information when doing password resets. Also, the login form being used for non-logged in users was failing because of a missing login token, so this adds a login token before the form is executed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How To Hack MediaWiki coding standards/code review workshops
Am 05.08.2011 17:21, schrieb Sumana Harihareswara: At the Wikimania Developer Days this week, several developers led a workshop for MediaWiki beginners, and a code review training covering our coding standards. First-draft notes for both are up: http://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker/Workshop http://www.mediawiki.org/wiki/Code_review_management/Aug_2011_training and I intend on improving them into a more productized curriculum for future hackathons. Pls. also make sure to update - if necessary - the content of the wiki pages which make the http://www.mediawiki.org/wiki/MDG MediaWiki Developer's Guide, thanks ! Tom signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93988]: Revision status changed
User ^demon changed the status of MediaWiki.r93988. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93988#c0 Commit summary: minor fixes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93651]: Revision status changed
User ^demon changed the status of MediaWiki.r93651. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93651#c0 Commit summary: aws-sdk 1.3.7 from 1.3.4 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93734]: New comment added
User ^demon posted a comment on MediaWiki.r93734. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93734#c20489 Commit summary: mft r93733 Comment: This affects way more than just merging r93733. Did you mean merging trunk through r93733? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93735]: Revision status changed
User ^demon changed the status of MediaWiki.r93735. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93735#c0 Commit summary: mft r93734 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93668]: Revision status changed
User ^demon changed the status of MediaWiki.r93668. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93668#c0 Commit summary: removed extranneous debugger call ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93856]: New comment added
User NeilK posted a comment on MediaWiki.r93856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93856#c20490 Commit summary: Add archive feed API list module for external archival services. Comment: Does the prefix al conflict with the alllinks API methods? http://www.mediawiki.org/wiki/API:Alllinks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93298]: Revision status changed
User ^demon changed the status of MediaWiki.r93298. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93298#c0 Commit summary: revert r93264 : breaks ton of parser tests. Please update the parser tests and reapply. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93332]: Revision status changed
User ^demon changed the status of MediaWiki.r93332. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93332#c0 Commit summary: Add OBSOLETE FILE Will be deleting this extension shortly as it is abandoned and unsupported by the upstream FCKeditor developers ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93414]: Revision status changed
User ^demon changed the status of MediaWiki.r93414. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93414#c0 Commit summary: Revert r93336 and r93332. The extension appears to work fine. Upstream support would be nice, but the extension is self-contained. I know Wikia and the WMF are working on new rich text editors, but in the meantime, many third-party users would like something that works, and this is the best option at the moment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93115]: Revision status changed
User ^demon changed the status of MediaWiki.r93115. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93115#c0 Commit summary: Revert r79408 and delete countryCodes.inc - were changes made immediately post-fundraiser but were never completed and are no longer applicable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92779]: Revision status changed
User ^demon changed the status of MediaWiki.r92779. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92779#c0 Commit summary: I was right the first time, revert r92778, restoring r92777 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92553]: Revision status changed
User ^demon changed the status of MediaWiki.r92553. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92553#c0 Commit summary: Revert self r92205 because that broke compatibility with 1.17; plus some formatting/documentation updates. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93912]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r93912. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93912#c20491 Commit summary: Reverted r91548 per CR Comment: There was only one CR comment raising a problem. I guess I could add the comment # in the link I guess, or quote it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91416]: Revision status changed
User ^demon changed the status of MediaWiki.r91416. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91416#c0 Commit summary: Revert old page navigation back to a subtitle Please reapply to trunk for inclusion in 1.19. reverts r85322 r90883 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90647]: Revision status changed
User ^demon changed the status of MediaWiki.r90647. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90647#c0 Commit summary: revert of r90646, committed some extraneous files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93806]: Revision status changed
User ^demon changed the status of MediaWiki.r93806. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93806#c0 Commit summary: Revert r93802 per CR. Will avoid cache pollution by splitting the cache instead ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89208]: Revision status changed
User ^demon changed the status of MediaWiki.r89208. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89208#c0 Commit summary: revert r84022 parser tests (code reverted by r89088) The code cause bug 29197 (PHP 5.3.x crash) and the parser tests are blocking cruise control. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92262]: New comment added
User ^demon posted a comment on MediaWiki.r92262. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92262#c20492 Commit summary: Move old projects to the new ATTIC directory. Projects moved: CommonsBrowser librdcp logwood loreley lucene-search mwblocker mwsearch rpms scavenger servmon sixdeg skirmish telnetreader tugelacache udpmcast yearbook zedler Comment: udpmcast doesn't seem abandoned. Mark was looking for it earlier ;-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89183]: Revision status changed
User ^demon changed the status of MediaWiki.r89183. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89183#c0 Commit summary: update parser tests for mw1.19 3 tests were failing since the header are followed with CRLF and we no more use a name=\d/a links. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93050]: Revision status changed
User ^demon changed the status of MediaWiki.r93050. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93050#c0 Commit summary: Test for external links in the sidebar follow up r90949 Note: this does NOT test the parser external links only externals links inside the sidebar. This might help rewrite r90949. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93250]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r93250. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r93250. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93250#c20493 Commit summary: Since r93249 SpecialPage::mName is explicitly private use getName() accessor instead. Comment: Won't hurt either way. Accessors are always nicer though :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93249]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r93249. Old Status: new New Status: resolved User ^demon also posted a comment on MediaWiki.r93249. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93249#c20494 Commit summary: makes SpecialPage::mName explicitly private Only one occurence in Core : SpecialRandompage. Extensions are done in a following commit. Comment: Was made protected in r93368, marking this resolved. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92262]: Revision status changed
User ^demon changed the status of MediaWiki.r92262. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92262#c0 Commit summary: Move old projects to the new ATTIC directory. Projects moved: CommonsBrowser librdcp logwood loreley lucene-search mwblocker mwsearch rpms scavenger servmon sixdeg skirmish telnetreader tugelacache udpmcast yearbook zedler ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90907]: New comment added, and revision status changed
User NeilK changed the status of MediaWiki.r90907. Old Status: deferred New Status: new User NeilK also posted a comment on MediaWiki.r90907. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90907#c20495 Commit summary: Cleanup ArchiveLinks.php and move the class into a separate file. Comment: in queueExternalLinks(): - could be better written with one if, ( if (no blacklist not already queued) ) since you don't do anything in the else clauses - commit() should only be called if we make master do anything - always returning true is a waste of time, just don't return anything. Or, return true if a job was successfully added, false otherwise. The caller may not care though. rewriteLinks(): - I thought we were going to have time in here somehow for archive.org? - agree on Html.php, or at least use some class where we can be certain these values are escaped properly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Image Licenses
priyank bagrecha wrote: Is it possible to get a list of licenses for all the images on wikipedia programmatically? Just the licenses, and a count of how many images have which particular license. Well, more or less. The licenses are noted with templates, and the templates also add categories, so if you look at the templates/categories that are in the image page, you can find out. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91048]: New comment added, and revision status changed
User NeilK changed the status of MediaWiki.r91048. Old Status: deferred New Status: ok User NeilK also posted a comment on MediaWiki.r91048. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91048#c20496 Commit summary: oops forgot install instructions... Comment: ok as intermediate notes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Exemption from account creation throttle
As I was the primary objector in that revision, I think the idea of doing the same within an extension is suitable as an immediate solution. Should be very trivial to implement/review/deploy and would keep core clean. -Chad Doing it in an extension seems appropiate. I would still create a Special page for introducing blocks, even if you ended up storing it on a MediaWiki page. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91319]: New comment added, and revision status changed
User NeilK changed the status of MediaWiki.r91319.
Old Status: deferred
New Status: ok
User NeilK also posted a comment on MediaWiki.r91319.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91319#c20498
Commit summary:
* follow up on r91317 to readd spider.php and setuptables.sql with the correct
lowercase name to adhere to coding conventions
* add function to spider.php to deal with replag on databases to prevent
duplication by mulitple instances of the spider
* fix setuptables.sql to actually have data instead of being empty (problem in
r91047)
Comment:
varchar(1) is kind of overkill. In practice URLs over 4K aren't handled by
browsers. But okay.
What's the point of the local file? That seems like another thing which can go
wrong; why not keep all the state about what you are doing in the db?
Minor nit, instead of
if ( $retval !== true ) {$retval = false; } return $retval;
you can say
return ($retval === true);
delete_dups -- try not to select '*', it's bad style
I like the way you did parse_wget_log, very clean that way
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91319]: New comment added
User NeilK posted a comment on MediaWiki.r91319. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91319#c20499 Commit summary: * follow up on r91317 to readd spider.php and setuptables.sql with the correct lowercase name to adhere to coding conventions * add function to spider.php to deal with replag on databases to prevent duplication by mulitple instances of the spider * fix setuptables.sql to actually have data instead of being empty (problem in r91047) Comment: Needs documentation for each method, BTW, otherwise okay. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Image Licenses
Is it possible to get a list of licenses for all the images on wikipedia programmatically? Just the licenses, and a count of how many images have which particular license. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] alternative PDF exporter
Hi *, New to the list, so please tell me to RTFM if I've missed anything or this is the incorrect place for my question. We've been using and hacking 2 different extensions (PdfBook and PdfExport) to render our wiki pages to PDF. Both extensions have been hacked enough to work quite well but now we I a requirement to include CSS so that the rendered PDF looks EXACTLY like the wiki. Since htmldoc doesn't support CSS as of yet, I've been looking at some different approaches to rendering wiki's to PDF. The first option I came across was PrinceXML. This does quite a nice job but at a cost of a license ~$6k USD. Unfortunately that's a deal breaker due to the nature of the projects (some of which are funded and others are completely open and not funded except for my time). I then ran across wkhtmltopdf which utilizes QTWebkit. After a few scripts to test externally, this seems to be a viable option that I would like to put some cycles towards. I've been using mediawiki for quite some time and know PHP, so writing an extension should not be to terribly hard. I've been reading through the manual on extension development (hooking, parsers, etc) and kinda get the idea of how to do it. I'm sure that after a little trial and error and looking at others source, I should be able to get what I need done and give the extension back if anyone would be interested. Has anyone gone down this road before with trying to render wiki's with CSS?? (We currently have custom Common.css and Print.css files on many wiki sites). Obviously I don't want to have to re-invent the wheel, but I have yet to see any extensions that support CSS. Any feedback would be greatly appreciated!! TIA, max ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91671]: New comment added
User NeilK posted a comment on MediaWiki.r91671. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91671#c20500 Commit summary: * add a spidering function for wget in spider.php * add rel=nofollow to Cache links Comment: You don't even have plans to support curl, the download_lib thing is a waste of space. Add it when you support curl. You already brought this up yourself, but replace shell_exec() with wfShellExec() - that seems not to be fixed in current version The path to wget should be a global and should default to where it usually is on Ubuntu Linux (/usr/bin/wget), see how we do it with $wgImageMagickConvertCommand in DefaultSettings.php Re: $ignore_in_prog_time, Testing for config variables and putting default values deep in code is bad, try to establish the config as early as possible -- think of config as an input to your function, not something you create in the middle of the function. Spelling mistake with $ingore / $ignore. At least try it once before committing. i see you fix this in later revs though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91671]: Revision status changed
User NeilK changed the status of MediaWiki.r91671. Old Status: deferred New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91671#c0 Commit summary: * add a spidering function for wget in spider.php * add rel=nofollow to Cache links ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91776]: New comment added
User NeilK posted a comment on MediaWiki.r91776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91776#c20501 Commit summary: start special page for viewing archived content. Comment: Also, stop it with figuring out the path to wget.exe this late in the game... we should know if wget is present way, way before we even attempt to run the spider ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] alternative PDF exporter
Also sprach N. Max Pierson: Has anyone gone down this road before with trying to render wiki's with CSS?? (We currently have custom Common.css and Print.css files on many wiki sites). Obviously I don't want to have to re-invent the wheel, but I have yet to see any extensions that support CSS. There's a set of case studies here: http://www.princexml.com/samples/#wiki You can use Prince for free for non-commercial purposes. Wikipedia's HTML markup is suboptimal for printing, ofte due to the use of the 'style' attribute which hardcodes presentations for screens. http://www.princexml.com/bb/viewtopic.php?f=2t=3823 In Norway, we have started a project to exterminate the 'style' attribute. Here's a description (in Norwegian): http://no.wikipedia.org/wiki/Wikipedia:Underprosjekter/Utryddelse_av_«style»-attributtet Good progress has been made in the templates. Most of the remaining issues are in the Mediawiki software itself. For example, in markup like this: div class=thumbinner style=width:222px;a href=/wiki/Fil:FeleHel_(2).jpg class=imageimg alt= src=http://upload.wikimedia.org/wikipedia/commons/thumb/b/bf/FeleHel_%282%29.jpg/220px-FeleHel_%282%29.jpg; width=220 height=431 class=thumbimage //a Perhaps one could create classes for the most common sizes? (220px seems quite common) Then there's these: div id=mw-js-message style=display:none;/div div id=p-logoa style=background-image: url(http://upload.wikimedia.org/wikipedia/no/b/bc/Wiki.png);href=/wiki/Portal:Forside title=Hovedside/a/div div style=clear:both/div Efforts to rmove these -- by turning them into classes -- will be much appreciated. Cheers, -hkon http://people.opera.com/howcome http://www.princexml.com/howcome ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93995]: Revision status changed
User Reedy changed the status of MediaWiki.r93995. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93995#c0 Commit summary: Update for usual locations of svnlook and php binaries ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93996]: Revision status changed
User Reedy changed the status of MediaWiki.r93996. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93996#c0 Commit summary: rm leftover comment from the code I hijacked ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93994]: Revision status changed
User Reedy changed the status of MediaWiki.r93994. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93994#c0 Commit summary: Initial rewrite of pre-commit hooks, with framework for post-commit too :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93989]: Revision status changed
User Reedy changed the status of MediaWiki.r93989. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93989#c0 Commit summary: Moving udpmcast back into trunk so mark can find it again. Ping r92262 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93954]: Revision status changed
User Reedy changed the status of MediaWiki.r93954. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93954#c0 Commit summary: Simplify ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93812]: Revision status changed
User Reedy changed the status of MediaWiki.r93812. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93812#c0 Commit summary: For SQLite compat, split up the multi-row insert statement into separate insert statements. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93805]: Revision status changed
User ^demon changed the status of MediaWiki.r93805. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93805#c0 Commit summary: Follows-up r89848 CR: Cleaner solution ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93811]: Revision status changed
User ^demon changed the status of MediaWiki.r93811. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93811#c0 Commit summary: Fix syntax error for SQLite compatibility. Previous version didn't work. Now it does :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93768]: Revision status changed
User ^demon changed the status of MediaWiki.r93768. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93768#c0 Commit summary: Changed the name of the label for the tags filter from 'Filter tags' to 'Hide tags' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93871]: Revision status changed
User ^demon changed the status of MediaWiki.r93871. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93871#c0 Commit summary: Fix bug #27132: Uncomment movefile right in default settings ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93989]: New comment added
User Hashar posted a comment on MediaWiki.r93989. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93989#c20502 Commit summary: Moving udpmcast back into trunk so mark can find it again. Ping r92262 Comment: My apologies to the ops team. Since the script hasn't been updated I thought it was obsolete. Looks like it is just exempt of bugs :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93250]: New comment added
User Hashar posted a comment on MediaWiki.r93250. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93250#c20503 Commit summary: Since r93249 SpecialPage::mName is explicitly private use getName() accessor instead. Comment: I would prefer sticking to accessor. I like inserting a call to wfDebug() in them. There might a performance penalty though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93290]: New comment added
User Hashar posted a comment on MediaWiki.r93290. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93290#c20504 Commit summary: Using addScriptFile , addStyle. Removed Gadget-rtl.css (not used) Comment: You probably want to start with a basic script to get familiar with the resourceloader. Then feel free to ask for help either on IRC or the mediawiki-l mailing list. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93999]: Revision status changed
User Platonides changed the status of MediaWiki.r93999. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93999#c0 Commit summary: Also add prevention of commits by root ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Pre-commit hooks are back!
Hi everyone, I've just rewritten our pre-commit hooks today (/trunk/tools/subversion/hooks) and deployed them to the MediaWiki repository. The following rules are in place: * No empty commit summaries * Lint test for all php files * No committing as root If anyone has any problems with the new hooks, let me know :) -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r92539]: New comment added, and revision status changed
User NeilK changed the status of MediaWiki.r92539. Old Status: new New Status: fixme User NeilK also posted a comment on MediaWiki.r92539. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92539#c20505 Commit summary: * fix SQL injection vulnerability in ArchiveLinks.class.php * start adding support for feed * add new table for history of what has appeared in the feed in the past Comment: Yeah, for the right way to do this see what Jeroen did for UploadWizard's new tables: in UploadWizardHooks.php; $wgHooks['LoadExtensionSchemaUpdates'][] = 'UploadWizardHooks::onSchemaUpdate'; And check out what's in UploadWizardHooks::onSchemaUpdate(). The related SQL files are defined in that function, and they have the proper magic comments for table prefixes and database options. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93998]: Revision status changed
User ^demon changed the status of MediaWiki.r93998. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93998#c0 Commit summary: Add index to help with SQL queries used for author stats ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93964]: Revision status changed
User ^demon changed the status of MediaWiki.r93964. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93964#c0 Commit summary: re: r93889: clarify that only registered users get movefile right by default. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93734]: Revision status changed
User Reedy changed the status of MediaWiki.r93734. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93734#c0 Commit summary: mft r93733 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93682]: Revision status changed
User Reedy changed the status of MediaWiki.r93682. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93682#c0 Commit summary: Merge live hack - Extra debugging on connection failures ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93684]: Revision status changed
User Reedy changed the status of MediaWiki.r93684. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93684#c0 Commit summary: MFT r93682 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93679]: Revision status changed
User Reedy changed the status of MediaWiki.r93679. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93679#c0 Commit summary: MFT r93678 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87268]: Revision status changed
User Reedy changed the status of MediaWiki.r87268. Old Status: new New Status: old Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87268#c0 Commit summary: PatchOutputMobile: stylize (+bump version number). Some of these methods and variables really should be renamed as per our coding standards... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93816]: Revision status changed
User Reedy changed the status of MediaWiki.r93816. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93816#c0 Commit summary: Disable magic word Li10n for ParserFunctions extension. Doing it the Special:Magic way sucks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92074]: Revision status changed
User Reedy changed the status of MediaWiki.r92074. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92074#c0 Commit summary: Resolve fixme on r56094: Cannot have abstract static functions in a class. Turned it to an interface--of course static interfaces are kind of debatable, but at least this doesn't give errors. Also moved global-scoped define to class constant. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93971]: New comment added
User Reedy posted a comment on MediaWiki.r93971. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93971#c20506 Commit summary: Use APC caching to send incremental TCP requests, rather than using rand(); Comment: s/TCP/UDP/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87741]: Revision status changed
User Reedy changed the status of MediaWiki.r87741. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87741#c0 Commit summary: ArticleFeedback: Set cache mode for query module ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88051]: Revision status changed
User Reedy changed the status of MediaWiki.r88051. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88051#c0 Commit summary: Followup r88006: Adjusted UnitTest ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93976]: Revision status changed
User ^demon changed the status of MediaWiki.r93976. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93976#c0 Commit summary: Localisation update for core and extension messages from translatewiki.net (2011-08-05 14:15:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93518]: Revision status changed
User ^demon changed the status of MediaWiki.r93518. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93518#c0 Commit summary: Release-notes for r93517 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93963]: Revision status changed
User ^demon changed the status of MediaWiki.r93963. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93963#c0 Commit summary: Add @since to Revision::newFromRow per Nikerabbit Follows up r93935 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84309]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84309. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84309#c0 Commit summary: Fix for Bug# 17463: New pages log doesn't remove/update item after suppression redirect Except for some whitespace changes, this is Baowolff's patch from http://bug-attachment.wikimedia.org/attachment.cgi?id=8312 which I am applying in the spirit of “apologize later”. Baowolff writes: Don't show new page entries in Special:newpage for supressed redirects. Patch to remove the new page entry from Special:RecentChange and special:newpages, if the new page gets moved with redirect supressed. I'm not a 100% sure this is a good idea. This will only suppress the initial new page line in the RC (And newpages), and won't supress any other edits to the page. Does this behaviour really make sense? (Thats not rhetorical). It seems somewhat different from deleting a page, where none of the content is relevent, but when you move a page, the edits don't go away, they're just in a new title. I suppose we could just change the new page entry in the RC to point to the other page, but that seems rather wrong too. So anyhow, not sure what the right approach is. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93986]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r93986. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93986#c0 Commit summary: Reverting r84309 (New pages log doesn't remove/update item after suppression redirect). Per the patch author and committer's own admission, this doesn't seem like the correct fix. I haven't dug into it deeply, but I tend to agree. Reverting to the status quo rather than have this make it into a release half-baked. Reopening bug 17463 so this can get some more discussion (also this definitely needed RELEASE-NOTES) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
