[MediaWiki-CodeReview] [MediaWiki r94079]: New comment added
User Kipmaster posted a comment on MediaWiki.r94079. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94079#c20531 Commit summary: freeResult, removed debug functions Comment: Thanks for the info! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Image Licenses
Hi Priyank, Op 5-8-2011 21:37, Platonides schreef: priyank bagrecha wrote: Is it possible to get a list of licenses for all the images on wikipedia programmatically? Just the licenses, and a count of how many images have which particular license. Well, more or less. The licenses are noted with templates, and the templates also add categories, so if you look at the templates/categories that are in the image page, you can find out. https://secure.wikimedia.org/wikipedia/commons/w/index.php?title=Special:MostLinkedTemplateslimit=500offset=0 and https://secure.wikimedia.org/wikipedia/commons/w/index.php?title=Special:MostLinkedCategorieslimit=500offset=0 might be of use. For example the GFDL license seems to be used almost 3 million times. Maarten ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94100]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r94100. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94100#c20532 Commit summary: improved: hiding format controls, minor JS cleanup Comment: Some style remarks: * It's convention to use lowerCamelCase for variable names. So $ignoredAttribs instead of $ignoredattribs and $flipStyle instead of $flip_style. * $ignoredattribs = array() should always be an array, so it's nice to specify this in the function with array $ignoredattribs = array(). Nice work though! :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94104]: Revision status changed
User ^demon changed the status of MediaWiki.r94104. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94104#c0 Commit summary: 1.2 RC1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91384]: Revision status changed
User ^demon changed the status of MediaWiki.r91384. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91384#c0 Commit summary: Removed raw SQL Queries, use wrappers instead. Thanks Roan! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91398]: Revision status changed
User ^demon changed the status of MediaWiki.r91398. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91398#c0 Commit summary: Produces wikitable formatted output ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91392]: Revision status changed
User ^demon changed the status of MediaWiki.r91392. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91392#c0 Commit summary: ParserFunction to display the project statistics Needs formatting work ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91727]: Revision status changed
User ^demon changed the status of MediaWiki.r91727. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91727#c0 Commit summary: Article moves are not logged ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94031]: New comment added
User ^demon posted a comment on MediaWiki.r94031. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94031#c20533 Commit summary: * Moved action=history to use an Action subclass * Removed obsolete aliases PageHistory and PageHistoryPager; unused * Maintained backward compatibility with HistoryPage; extensions using it will still work * Use local context instead of global variables * Removed calls to OutputPage::setPageTitleActionText() and OutputPage::setSyndicated(), the first one does nothing and the second one is overriden by the setFeedAppendQuery() call just below * Call Linker methods statically * Fixed bug where feedEmpty() was not called on empty history since casting a ResultWrapper object to boolean always returns true even when there's no row Comment: Can we please make this crap into Special Pages? Leave the action= urls for redirects. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94089]: Revision status changed
User ^demon changed the status of MediaWiki.r94089. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94089#c0 Commit summary: Use local context instead of global variables ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93061]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r93061. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r93061. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93061#c20534 Commit summary: Updated hooks docs per r91123. The UI methods are not part of the object anymore. Comment: Definitely needs release notes too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92643]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r92643. Old Status: new New Status: resolved User ^demon also posted a comment on MediaWiki.r92643. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92643#c20535 Commit summary: Documenting new parser hook, re r92506. This refers to an extension that's not checked in quite yet, FYI Comment: Don't refer to the passed object as $this, call it $parser or something. People will use $this in their code and then wonder why it breaks :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92643]: New comment added
User ^demon posted a comment on MediaWiki.r92643. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92643#c20536 Commit summary: Documenting new parser hook, re r92506. This refers to an extension that's not checked in quite yet, FYI Comment: Took care of it in the followup. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91065]: Revision status changed
User ^demon changed the status of MediaWiki.r91065. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91065#c0 Commit summary: Vector: Add maintenance script to switch a preference for users with the noexperiments preference enabled. This is needed for the upcoming WikiLove deployment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91068]: Revision status changed
User ^demon changed the status of MediaWiki.r91068. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91068#c0 Commit summary: 1.17wmf1: MFT r91065 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91089]: Revision status changed
User ^demon changed the status of MediaWiki.r91089. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91089#c0 Commit summary: 1.17wmf1: MFT r85616, r85617. This required meticulous conflict resolution due to differences in RL between 1.17wmf1 and trunk, mainly the TYPE_* and ORIGIN_* stuff ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91664]: Revision status changed
User ^demon changed the status of MediaWiki.r91664. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91664#c0 Commit summary: ClickTracking: Add support for logging events to files or UDP through $wgClickTrackingLog. Also allow disabling database logging through $wgClickTrackingDatabase. Smaller tweaks: * Change $eventId parameter of ClickTrackingHooks::trackEvent() to $eventName, and move the ID-name lookup into the if($wgClickTrackingDatabase) branch. This ensures the clicktracking DB tables are not written to if DB logging is disabled. This function is public, but has no callers outside this extension * Change the type of the 'namespacenumber' parameter in the API module to 'integer'. It was previously set to 'namespace', which barfs on negative values, which caused nasty errors when an event happened to originate on a special page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91899]: Revision status changed
User ^demon changed the status of MediaWiki.r91899. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91899#c0 Commit summary: 1.17wmf1: MFT r91664 (ClickTracking UDP), adapted a bit to apply ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92007]: Revision status changed
User ^demon changed the status of MediaWiki.r92007. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92007#c0 Commit summary: need initialized output buffers in find_first_bz2_block since it attempts a decompress ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92311]: Revision status changed
User ^demon changed the status of MediaWiki.r92311. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92311#c0 Commit summary: * (bug 28574) ProofreadPage toolbar additions now compatible with WikiEditor toolbar Took mybugs' script fragment at https://bugzilla.wikimedia.org/attachment.cgi?id=8778action=edit and merged it into ProofreadPage proper; now building the classic toolbar buttons from the array of data that we're making for WikiEditor so we don't have to define them twice. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93820]: Revision status changed
User ^demon changed the status of MediaWiki.r93820. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93820#c0 Commit summary: Some random URL protocol forcing for protocol-relative URLs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93807]: Revision status changed
User ^demon changed the status of MediaWiki.r93807. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93807#c0 Commit summary: we don't need to change charsets on our systems, as we already have BINARY all around we dont't set SQL modes either.. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93818]: Revision status changed
User ^demon changed the status of MediaWiki.r93818. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93818#c0 Commit summary: Introduce $wgVaryOnXFPToAPI which sends Vary: X-Forwarded-Proto (and the appropriate XVO, if needed) on cached API requests. This effectively splits the API cache between HTTP and HTTPS for people with an HTTPS termination setup in front of a caching proxy (like, say, WMF) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93890]: Revision status changed
User ^demon changed the status of MediaWiki.r93890. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93890#c0 Commit summary: 1.17wmf1: MFT rest of protocol-relative URL fixes and API cache splitting support from r93818, r93820, r93821, r93822 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92543]: Revision status changed
User ^demon changed the status of MediaWiki.r92543. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92543#c0 Commit summary: clean up use of the config var ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93241]: Revision status changed
User ^demon changed the status of MediaWiki.r93241. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93241#c0 Commit summary: MFT r93080 - another concurrency fix for CentralNotice ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92712]: Revision status changed
User ^demon changed the status of MediaWiki.r92712. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92712#c0 Commit summary: MFT r91368 - r92408 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92647]: Revision status changed
User ^demon changed the status of MediaWiki.r92647. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92647#c0 Commit summary: MFT r75956 - r92645 for LandingCheck.i18n.ph, r78862 - r92646 for SpecialLandingCheck.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92653]: Revision status changed
User ^demon changed the status of MediaWiki.r92653. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92653#c0 Commit summary: MFT r77974 through r92651 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92890]: Revision status changed
User ^demon changed the status of MediaWiki.r92890. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92890#c0 Commit summary: 1.17wmf1: Redo r92888 properly: copy jquery.localize.js from trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93699]: Revision status changed
User ^demon changed the status of MediaWiki.r93699. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93699#c0 Commit summary: breaks in this file cause odd things to happen with RTL, removing line breaks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93654]: New comment added
User ^demon posted a comment on MediaWiki.r93654. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93654#c20537 Commit summary: Follows-up r93515 CR: Whitespace Comment: The indentation looks weird here too. Why not just make it two var statements and then it's totally clear? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85804]: Revision status changed
User ^demon changed the status of MediaWiki.r85804. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85804#c0 Commit summary: Make ParserFunctions work with HipHop. * When using HipHop, is_callable() returns false for objects which have only a __call() method instead of the requested one. * Work around this by removing the ParserFunctions_HookStub hack. * To retain the behavior that the code of ParserFunctions_body.php is only loaded when needed, turn it into a static class. * Defer the registering of the ParserClearState hook until a relevant function is called. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Updated status on MobileFrontend testing
Thanks, for this Tomasz. — Patrick On Mon, Aug 8, 2011 at 5:12 PM, Tomasz Finc tf...@wikimedia.org wrote: Greetings all, I got a couple of reports that it was a bit confusing to track where we were with the MobileFrontend testing so I updated our deployment page. Hopefully its easier now to understand what the Ruby gateway is still doing vs mobile frontend. http://www.mediawiki.org/wiki/MobileFrontend/Deployment#Status Let me know if you have any questions. --tomasz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93654]: New comment added
User Krinkle posted a comment on MediaWiki.r93654. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93654#c20538 Commit summary: Follows-up r93515 CR: Whitespace Comment: I don't care how the indention is here, I changed it because someone thought it was better and I didn't disagree. Alternatives: source lang=javascript var // Foobar foo = 'bar', bar = 'barbarabar', // Lorem ipsum lorem = 'ipsum'; /source source lang=javascript var foo = 'bar', // Foobar bar = 'barbarabar', lorem = 'ipsum'; // Lorem ipsum /source source lang=javascript var foo = 'bar', // Foobar bar = 'barbarabar', lorem = 'ipsum'; // Lorem ipsum /source Currently: source lang=javascript // Foobar var foo = 'bar', bar = 'barbarabar', // Lorem ipsum lorem = 'ipsum'; /source Previously: source lang=javascript // Foobar var foo = 'bar', bar = 'barbarabar', // Lorem ipsum lorem = 'ipsum'; /source ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93654]: New comment added
User Krinkle posted a comment on MediaWiki.r93654. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93654#c20539 Commit summary: Follows-up r93515 CR: Whitespace Comment: I don't care how the indention is here, I changed it because someone thought it was better and I didn't disagree. Alternatives: source lang=javascript var // Foobar foo = 'bar', bar = 'barbarabar', // Lorem ipsum lorem = 'ipsum'; /source source lang=javascript var foo = 'bar', // Foobar bar = 'barbarabar', lorem = 'ipsum'; // Lorem ipsum /source source lang=javascript var foo = 'bar', // Foobar bar = 'barbarabar', lorem = 'ipsum'; // Lorem ipsum /source Currently: source lang=javascript // Foobar var foo = 'bar', bar = 'barbarabar', // Lorem ipsum lorem = 'ipsum'; /source Previously: source lang=javascript // Foobar var foo = 'bar', bar = 'barbarabar', // Lorem ipsum lorem = 'ipsum'; /source ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93654]: New comment added
User Krinkle posted a comment on MediaWiki.r93654. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93654#c20540 Commit summary: Follows-up r93515 CR: Whitespace Comment: So yeah, pick whatever you think is right. But I don't see why we should create multiple var statements when it can perfectly go into one. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94112]: Revision status changed
User ^demon changed the status of MediaWiki.r94112. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94112#c0 Commit summary: Sync to what is actually live ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94107]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r94107. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94107#c0 Commit summary: (bug 30264) MediaWiki installer uses require, de facto is require_once ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93654]: New comment added
User ^demon posted a comment on MediaWiki.r93654. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93654#c20542 Commit summary: Follows-up r93515 CR: Whitespace Comment: I'd go with option #3: pre var foo = 'bar', // Foobar bar = 'barbarabar', lorem = 'ipsum'; // Lorem ipsum /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94122]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r94122. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94122#c0 Commit summary: De-indent stuffs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92288]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r92288. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92288#c20543 Commit summary: ajaxCategories fixes: * Partial revert of r92264. mw.ajaxCategories has nothing to do with mediawiki.util.init, moved into separate initiation module, only loaded when ajax categories is enabled. * Removing instantiation from the script. mw.ajaxCategories is now a public accessible constructor * Fix Uncaught ReferenceError: wgUserGroups is not defined ($wgLegacyJavaScriptGlobals = false;) * Renamimng stripIllegals() to clean(), adding '#' to the regex as those are not allowed either. * Combining var statements by separating them with comma's ( var foo, bar, baz; ) instead of var foo; var bar; var baz;svn up * Using dot.notation for objects instead of array-like['string'] keys * Whitespace conventions * Using inArray utility instead of indexOf (cross-browser support, mostly IE6) ** $.inArray uses Array.prototype.indexOf if available, otherwise fallback to a loop. mw.util.inArray is a wrapper around $.inArray to return a boolean value (since inArray/indexOf may return 0) * Don't use $( '#bodyContent' ) (skin specific) but mw.util.$content * Using mw.Title * Re-using helper functions from the outer-closure instead of re-declaring them privately for every instance again (performance!) Follows-up: r92112, r92151, r92264 Comment: prevar newCategoryString = [[ + new mw.Titel( categoryNew, catNsId ) + sortkey + ']]';/pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94100]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r94100. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94100#c20544 Commit summary: improved: hiding format controls, minor JS cleanup Comment: camelCase, not_like_this. If the SMW docs say otherwise, they should be corrected. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92288]: New comment added
User Krinkle posted a comment on MediaWiki.r92288. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92288#c20545 Commit summary: ajaxCategories fixes: * Partial revert of r92264. mw.ajaxCategories has nothing to do with mediawiki.util.init, moved into separate initiation module, only loaded when ajax categories is enabled. * Removing instantiation from the script. mw.ajaxCategories is now a public accessible constructor * Fix Uncaught ReferenceError: wgUserGroups is not defined ($wgLegacyJavaScriptGlobals = false;) * Renamimng stripIllegals() to clean(), adding '#' to the regex as those are not allowed either. * Combining var statements by separating them with comma's ( var foo, bar, baz; ) instead of var foo; var bar; var baz;svn up * Using dot.notation for objects instead of array-like['string'] keys * Whitespace conventions * Using inArray utility instead of indexOf (cross-browser support, mostly IE6) ** $.inArray uses Array.prototype.indexOf if available, otherwise fallback to a loop. mw.util.inArray is a wrapper around $.inArray to return a boolean value (since inArray/indexOf may return 0) * Don't use $( '#bodyContent' ) (skin specific) but mw.util.$content * Using mw.Title * Re-using helper functions from the outer-closure instead of re-declaring them privately for every instance again (performance!) Follows-up: r92112, r92151, r92264 Comment: Fixed in r93351. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92241]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92241. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92241#c0 Commit summary: Fix bug 28600 by doing INSERT IGNORE, just like LinksUpdate does. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92229]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92229. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92229#c0 Commit summary: Changed the last occurence of WatchlistEditor to SpecialEditWatchlist since SpecialEditWatchlist is already called three lines below... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92190]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92190. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92190#c0 Commit summary: Fix typo from r90186. It's not inArray but isArray, which obviously does return a boolean value ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92167]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92167. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92167#c0 Commit summary: Fix expandableField.js dependencies ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92116]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92116. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92116#c0 Commit summary: New jquery.getAttrs module - A cross-browser compatible way of getting a direct key/value object of attributes - Will help making comparisons such as in r92113 easier and work cross-browser ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92065]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r92065. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92065#c0 Commit summary: Fix for r85876 by doing away with a potentially invalid user name parameter behind slash in Special:EmailUser ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91871]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91871. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c0 Commit summary: Add action-* class to body. Bug 4438. Based on patch by Subfader ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Image Licenses
Maarten Dammers wrote: Hi Priyank, Op 5-8-2011 21:37, Platonides schreef: priyank bagrecha wrote: Is it possible to get a list of licenses for all the images on wikipedia programmatically? Just the licenses, and a count of how many images have which particular license. Well, more or less. The licenses are noted with templates, and the templates also add categories, so if you look at the templates/categories that are in the image page, you can find out. https://secure.wikimedia.org/wikipedia/commons/w/index.php?title=Special:MostLinkedTemplateslimit=500offset=0 and https://secure.wikimedia.org/wikipedia/commons/w/index.php?title=Special:MostLinkedCategorieslimit=500offset=0 might be of use. For example the GFDL license seems to be used almost 3 million times. Maarten That will list just the most important ones. For a full list he should look at http://commons.wikimedia.org/wiki/Category:License_tags and all its descendants. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91855]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r91855. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r91855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91855#c20546 Commit summary: BetterDirectionality fixes: * SkinTemplate: also set div class=mw-content-ltr/rtl when action = historysubmit, so a diff displays correctly when you clicked on the compare selected revisions button on the history page * ImagePage: set a dir attribute (according to the site content language) for the user comment in the file history * FlaggedRevs: use CSS class sitedir-ltr/rtl instead of ambiguous rtl class Comment: I believe the 'print' action was removed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91832]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91832. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91832#c0 Commit summary: fix issues after failed renameUser; this script will ask for lots of confirmation, better safe than sorry. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91831]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91831. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91831#c0 Commit summary: Add a font-size to .redirectText in Vector and fix the vertical alignment of the arrow. Bug 26544 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91813]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91813. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91813#c0 Commit summary: Correct direction for review status on diff ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91812]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r91812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91812#c20547 Commit summary: (bug 29563 comment 11) Use feed-atom and feed-rss messages instead of RSS and ATOM. Personally this feels a little icky since its kind of lego-ey/resusing messages in different contexts, but I guess its ok. Most everywhere else in mediawiki doesn't put the type of feed in the feed description. Comment: What happens if the user language message exists but not the content one (in regards to codewfEmptyMsg( 'feed-' . $params['feed'] )/code? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94131]: Revision status changed
User Krinkle changed the status of MediaWiki.r94131. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94131#c0 Commit summary: Reverted r91871 per CR: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91871#c19474 Also, the related getAction() changes were already reverted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91736]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91736. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91736#c0 Commit summary: r91734: Do the same for search.css and remove module from resources.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91703]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91703. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91703#c0 Commit summary: * Sync script updates for improved privilege separation. A new user (mwdeploy) is created, which owns all the files in common-local. The texvc install is run as this user. Previously there was a potential for privilege escalation when root users executed scripts which were writable by wikidev. Now the scripts are only run as the unprivileged user, mwdeploy. * Merged sync-common-all and scap. The distinction was pretty stupid to start with, and only got more stupid as time went by, as functionality was copied from scap to sync-common-all. * Installed texvc to a directory writable by mwdeploy, instead of to /usr/local/bin. We would have needed to change the directory for HetDeploy anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94135]: Revision status changed
User Catrope changed the status of MediaWiki.r94135. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94135#c0 Commit summary: Use workaround so the What's this? link goes to a page depending on the content language rather than the user language ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] W3C validation links, and extended edit links
Hi there. I've made some modifications to MediaWiki 1.17.0 that others might be interested in. I'd be flattered if some or all of them made it into the official MediaWiki release. Firstly, I've added links to the W3C HTML validation service hosted by MIT. These show up as 'W3C HTML 5.0' icons next to the 'Powered by MediaWiki' icon at the bottom of the page, and link the user to the HTML validation service. I've found having this feature invaluable in helping me to get my wiki text that includes HTML valid. Unfortunately I've had to disable some features of MediaWiki in order for the validation service to pass the generated HTML. You can read about how I modified MediaWiki for W3C HTML validation at: http://www.progclub.org/wiki/Pcwiki#W3C_validation_icon Secondly, and more importantly I feel, I've added extended links to the 'section edit' links section. In addition to showing an 'edit' link, I include a 'link' link, and a 'top' link. 'top' just links to #top, nothing remarkable there. 'link' provides a link to the canonical URL for that section. My web-site is available via several domain names, www.progclub.org, progclub.org, progclub.info, etc. I have nominated 'www.progclub.org' as the 'canonical' domain name to be used when publishing links, and nominated 'http' (rather than 'https') as the 'canonical' scheme. In order to support canonical section links I had to make a few changes to the settings files, and update the linker, etc., as explained at: http://www.progclub.org/wiki/Pcwiki#Extended_edit_links Anyway, that's it. Thought some of you might like to know. If you like the ideas but don't like the implementation, then please feel free to BYO implementation. Mine's a little bit less than perfect owing to no i18n support and me not knowing the best file to put my functions in. So, I'd be happy if someone else gave my code a spruce up. Thanks! John. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94106]: Revision status changed
User Krinkle changed the status of MediaWiki.r94106. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94106#c0 Commit summary: Followup r92643: refer to the passed object as $parser, not $this ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91518]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91518. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c0 Commit summary: (bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also: * Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch) * Add direction mark to protection log * Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572) * Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however) * Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages... * Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91442]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91442. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91442#c0 Commit summary: MFT r91402: work around excessive locking in InnoDB by sharding across multiple tables. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91415]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91415. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91415#c0 Commit summary: jquery.client unit testing - More elaborate caching in the plugin in order for the code to be testable - Added support for passing custom user agents (although the default behavior remains unchanged) - Added support for passing custom profile-objects to $.client.test - Added test case for all supported browsers according to http://www.mediawiki.org/wiki/Compatibility#Browser - Replaced userAgent.toLowerCase() with userAgent since this string was already converted to lower case a few lines up This will likely prevent bugs like bug 27652 and bug 29446. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94134]: Revision status changed
User ^demon changed the status of MediaWiki.r94134. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94134#c0 Commit summary: Followup r93677: add missing ! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94130]: Revision status changed
User ^demon changed the status of MediaWiki.r94130. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94130#c0 Commit summary: Follow-up r92065: call userForm dynamically. Also made userForm protected as no one else calls it and it's not static anymore. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94136]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r94136. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94136#c0 Commit summary: Fix doc: wfLoadAllMessages() doesn't exists ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91379]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91379. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91379#c0 Commit summary: Fix Notice: Undefined property: WikiImporter::$nodeType when importing pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91340]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91340. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91340#c0 Commit summary: * Put float:left/right for images in shared.css with @noflip. This was inconsistent between skins, causing image alignment on RTL wikis to be dependent on your skin. Left is left and right is right, even for RTL languages :) * Also moving position: relative; from all skins to shared.css * Replacing .mw-content-ltr/rtl (added in r90743) with div#content [dir=ltr/rtl] so it also works on e.g. special pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] W3C validation links, and extended edit links
John Elliot wrote: Hi there. I've made some modifications to MediaWiki 1.17.0 that others might be interested in. I'd be flattered if some or all of them made it into the official MediaWiki release. Firstly, I've added links to the W3C HTML validation service hosted by MIT. These show up as 'W3C HTML 5.0' icons next to the 'Powered by MediaWiki' icon at the bottom of the page, and link the user to the HTML validation service. I've found having this feature invaluable in helping me to get my wiki text that includes HTML valid. Theoretically, the wiki should never generate invalid HTML, but it's not perfect. You can however install Tidy to have it clean up things for you. Unfortunately I've had to disable some features of MediaWiki in order for the validation service to pass the generated HTML. You can read about how I modified MediaWiki for W3C HTML validation at: http://www.progclub.org/wiki/Pcwiki#W3C_validation_icon Interesting. We should probably try to register rel=edit, or drop it out (opinions?). EditURI is already documented at http://microformats.org/wiki/existing-rel-values#POSH_usage The W3C validator ResourceLoaderDynamicStyles was purposefully added even though it is not conforming. I think that by removing it you disabled some ResourceLoader feature. Secondly, and more importantly I feel, I've added extended links to the 'section edit' links section. (...) In order to support canonical section links I had to make a few changes to the settings files, and update the linker, etc., You could have also just used the hook. Anyway, that's it. Thought some of you might like to know. If you like the ideas but don't like the implementation, then please feel free to BYO implementation. Mine's a little bit less than perfect owing to no i18n support and me not knowing the best file to put my functions in. So, I'd be happy if someone else gave my code a spruce up. Thanks! John. Thanks for sharing! I did a fast review of it below: You have an html injection problem in the extended links. What I don't understand is why you worked so hard to make the extended link use the canonical domain. A relative link would have worked fine. Also, all the $wgCanonical* pieces could have been replaced with setting $wgServer to the chosen domain and a few calls to getFullUrl. (if $wgCanonicalSecureHost != $wgCanonicalHost, $wgServer can be set conditionally) Finally, if you wanted to mark one of them as canonical, IMHO you should have added a link rel=canonical (but be careful with redirects, when MediaWiki adds one itself). ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On Tue, Aug 9, 2011 at 10:43 PM, Platonides platoni...@gmail.com wrote: ResourceLoaderDynamicStyles was purposefully added even though it is not conforming. AFAIK meta tags with made-up name= attributes are perfectly legal, at least in HTML5. I think that by removing it you disabled some ResourceLoader feature. Yes, you will have broken CSS precendence order for site/user CSS. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] On 11-08-09 12:40 PM, John Elliot wrote: Hi there. I've made some modifications to MediaWiki 1.17.0 that others might be interested in. I'd be flattered if some or all of them made it into the official MediaWiki release. Firstly, I've added links to the W3C HTML validation service hosted by MIT. These show up as 'W3C HTML 5.0' icons next to the 'Powered by MediaWiki' icon at the bottom of the page, and link the user to the HTML validation service. I've found having this feature invaluable in helping me to get my wiki text that includes HTML valid. Unfortunately I've had to disable some features of MediaWiki in order for the validation service to pass the generated HTML. You can read about how I modified MediaWiki for W3C HTML validation at: http://www.progclub.org/wiki/Pcwiki#W3C_validation_icon Please don't edit DefaultSettings.php; Your $wgFooterIcons change could have been done in LocalSettings.php without causing trouble for yourself when you upgrade. Secondly, and more importantly I feel, I've added extended links to the 'section edit' links section. In addition to showing an 'edit' link, I include a 'link' link, and a 'top' link. 'top' just links to #top, nothing remarkable there. 'link' provides a link to the canonical URL for that section. My web-site is available via several domain names, www.progclub.org, progclub.org, progclub.info, etc. I have nominated 'www.progclub.org' as the 'canonical' domain name to be used when publishing links, and nominated 'http' (rather than 'https') as the 'canonical' scheme. In order to support canonical section links I had to make a few changes to the settings files, and update the linker, etc., as explained at: http://www.progclub.org/wiki/Pcwiki#Extended_edit_links We have a DoEditSectionLink hook, adding those links should be possible without any modifications to core. Which is probably a good idea, because I reorganized the Linker in 1.18 so you're going to run into a conflict when you upgrade and end up undoing or having to re-do your code changes. Anyway, that's it. Thought some of you might like to know. If you like the ideas but don't like the implementation, then please feel free to BYO implementation. Mine's a little bit less than perfect owing to no i18n support and me not knowing the best file to put my functions in. So, I'd be happy if someone else gave my code a spruce up. Thanks! John. Since Platonides made a reply I won't say to much more. Though I don't really see anything we could add to MediaWiki. Most can already be done with hooks and config and fit more as extensions than default core features. And removing functionality of MediaWiki doesn't really count as adding something to core. I can't comprehend the obsession with killing de-facto standardized patterns just to shove a button on a site to a picky validator that only takes into account a single relevant standard. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91338]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91338. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91338#c0 Commit summary: * Use wgLang-formatNum for number of replies (reported by Translatewiki user Ebraminio) * Set correct page content language (wgLang) for Thread pages, follow-up to r91182 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91342]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91342. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91342#c0 Commit summary: * Fix broken post call to api in side-to-side diffs * Fix support for side-to-side diffs in section editing Reported in bug 29106. Patch by Michael M. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91315]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91315. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91315#c0 Commit summary: * Add release notes for my recent commits (bug 6100 and others like bugs 28030, 12406, 2834) * Add me to credits ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91091]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91091. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91091#c0 Commit summary: Align untranslated (English) messages as LTR. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 6:43 AM, Platonides wrote: Theoretically, the wiki should never generate invalid HTML, but it's not perfect. It was pretty close to perfect. I only had to comment out two features to get conformance with the (experimental) HTML5 validator. I assumed HTML5 output in my code, although AIUI MediaWiki also supports other varieties of HTML. You could have also just used the hook. Ah, but I don't know how to use the hook (yet), do I? :P I'll figure it out and fix up my code. Thanks for sharing! No worries. I did a fast review of it below: You have an html injection problem in the extended links. OK, I'll look into that. What I don't understand is why you worked so hard to make the extended link use the canonical domain. A relative link would have worked fine. Yeah, I have relative links if the canonical domain features aren't specified. (I added that as an after-thought, and you might have reviewed my code before I'd posted the update.) Also, all the $wgCanonical* pieces could have been replaced with setting $wgServer to the chosen domain and a few calls to getFullUrl. (if $wgCanonicalSecureHost != $wgCanonicalHost, $wgServer can be set conditionally) Ah, I didn't know about $wgServer. Finally, if you wanted to mark one of them as canonical, IMHO you should have added alink rel=canonical (but be careful with redirects, when MediaWiki adds one itself). I don't know anything about link rel=canonical, nor do I really know how/where to go about adding it. Maybe I'll look into that. Thanks. John. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 6:53 AM, Daniel Friesen wrote: Please don't edit DefaultSettings.php; Your $wgFooterIcons change could have been done in LocalSettings.php without causing trouble for yourself when you upgrade. Ah, didn't realise LocalSettings.php was the right place to do my edits. I guess I was coming from the perspective that I was contributing to core. We have a DoEditSectionLink hook, adding those links should be possible without any modifications to core. Yep, got that now. I'll fix that up. Thanks. Though I don't really see anything we could add to MediaWiki. Most can already be done with hooks and config and fit more as extensions than default core features. Fair enough. And removing functionality of MediaWiki doesn't really count as adding something to core. I kinda felt like I was adding more than I was taking away. I can't comprehend the obsession with killing de-facto standardized patterns just to shove a button on a site to a picky validator that only takes into account a single relevant standard. I'd rather not confuse my users who are trying to validate the HTML in their wiki text with noise from the platform. I don't control the validator, but I think it's a useful tool to incorporate on my web-site. Maybe there should be a setting for 'strict html' which leaves out features that services like validator.w3.org don't accept. John. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90992]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90992. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90992#c0 Commit summary: Removed 'decide login or signup' comment as this SpecialPage will handle only Signup requests ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90850]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90850. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90850#c0 Commit summary: Follow-up r90845: mw.get mw.config.get ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90767]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90767. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90767#c0 Commit summary: Correct alignment for RevisionDelete button ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90759]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90759. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90759#c0 Commit summary: Let $wgCategoryCollation take a class name as a value so that extensions can define new Collation classes. (I plan to commit such an extension shortly) Wasn't sure if it would be better to make an array mapping collation names = class names instead. However, that seemed to be unneededly complicated so I went with letting that variable take class names. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 6:50 AM, Roan Kattouw wrote: On Tue, Aug 9, 2011 at 10:43 PM, Platonidesplatoni...@gmail.com wrote: ResourceLoaderDynamicStyles was purposefully added even though it is not conforming. AFAIKmeta tags with made-up name= attributes are perfectly legal, at least in HTML5. There's a list: http://wiki.whatwg.org/wiki/MetaExtensions There's a bug filed in the validator.w3.org bug-tracker about the fact that some items that are on the list aren't being accepted: http://www.w3.org/Bugs/Public/show_bug.cgi?id=12928 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 6:53 AM, Daniel Friesen wrote: I can't comprehend the obsession with killing de-facto standardized patterns just to shove a button on a site to a picky validator that only takes into account a single relevant standard. One reason would be to help avoid embarrassments like this: http://validator.w3.org/check?uri=http://en.wikipedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90728]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90728. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90728#c0 Commit summary: Adding unit test for span presence in mw.util.addPortletLink * This is for bug 29567 * Also caching jQuery object while at it and renaming variables to be more descriptive here Test currently fails (as is supposed to) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90644]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90644. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90644#c0 Commit summary: Merged the DatabaseMysql::getLag() patch from trunk r90643 for immediate deployment, since this bug just hit dewiki pretty badly, locking the database for 10 minutes due to a brief lag spike. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90581]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90581. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90581#c0 Commit summary: Directionality improvements as part of bug 6100 (under $wgBetterDirectionality) for the File namespace: * exclude File namespace from div with lang dir attributes, since most information on file pages is in the user language * add div id=mw-imagepage-content around the actual wikitext that is in the content language ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] W3C validation links, and extended edit links
On Tue, Aug 9, 2011 at 6:37 PM, John Elliot j...@jj5.net wrote: On 10/08/2011 6:53 AM, Daniel Friesen wrote: I can't comprehend the obsession with killing de-facto standardized patterns just to shove a button on a site to a picky validator that only takes into account a single relevant standard. One reason would be to help avoid embarrassments like this: http://validator.w3.org/check?uri=http://en.wikipedia.org I guess that's only embarrassing if those sorts of things bother you. I'm with Dan on this one, I've never thought those validator buttons are very nice additions to a website. Remind me a little too much of the Optimized for NN4 buttons of old. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 8:47 AM, Chad wrote: I guess that's only embarrassing if those sorts of things bother you. I think it would be fair to have it both ways. There are a class of people who are bothered by things of that sort. I'm sure I'm not alone, at least on this issue. :P I'm with Dan on this one, I've never thought those validator buttons are very nice additions to a website. Remind me a little too much of the Optimized for NN4 buttons of old. I think there's a pretty big difference between providing a feature whereby a user can validate the HTML they've just authored and proclaiming browser patronage. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90734]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90734. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90734#c0 Commit summary: (bug 12406) Pages with names in RTL scripts are not listed correctly in Special:Whatlinkshere - add a direction mark The direction mark is no longer needed when bug 6100 is fixed, but this fixes it for the meantime. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] W3C validation links, and extended edit links
On Tue, Aug 9, 2011 at 6:52 PM, John Elliot j...@jj5.net wrote: On 10/08/2011 8:47 AM, Chad wrote: I guess that's only embarrassing if those sorts of things bother you. I think it would be fair to have it both ways. There are a class of people who are bothered by things of that sort. I'm sure I'm not alone, at least on this issue. :P I'm with Dan on this one, I've never thought those validator buttons are very nice additions to a website. Remind me a little too much of the Optimized for NN4 buttons of old. I think there's a pretty big difference between providing a feature whereby a user can validate the HTML they've just authored and proclaiming browser patronage. Most of our users won't know or care whether their pages validate. Those that do presumably know how to use a validator already. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 8:55 AM, Chad wrote: Most of our users won't know or care whether their pages validate. Those that do presumably know how to use a validator already. Isn't an unstated goal of MediaWiki/Wikipedia to decrease ignorance? If you already know how to use a validator you might still be pleased to have it easily integrated for you. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90742]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r90742. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r90742. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90742#c20548 Commit summary: Directionality and language improvements as part of bug 6100 (under $wgBetterDirectionality): * Make TOC numberings be in the page content language instead of wiki content language. * Update getPageLanguage() and add a hook (for bug 9360/28970). * Show redirects (when viewing a page with redirect=no) in the user language direction (not essential but nicer imo). Comment: PageContentLanguage is not in hooks.txt. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] W3C validation links, and extended edit links
John Elliot wrote: On 10/08/2011 6:53 AM, Daniel Friesen wrote: Please don't edit DefaultSettings.php; Your $wgFooterIcons change could have been done in LocalSettings.php without causing trouble for yourself when you upgrade. Ah, didn't realise LocalSettings.php was the right place to do my edits. I guess I was coming from the perspective that I was contributing to core. I assumed so, that's why I didn't mention it. You could have also just used the hook. Ah, but I don't know how to use the hook (yet), do I? :P I'll figure it out and fix up my code. See docs/hooks.txt from your mediawiki folder. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On 11-08-09 03:37 PM, John Elliot wrote: On 10/08/2011 6:53 AM, Daniel Friesen wrote: I can't comprehend the obsession with killing de-facto standardized patterns just to shove a button on a site to a picky validator that only takes into account a single relevant standard. One reason would be to help avoid embarrassments like this: http://validator.w3.org/check?uri=http://en.wikipedia.org Embarrassing? You do realize that the validator is complaining that it sees `ul/ul`, right? I can't even find the spot in the HTML4 or XHTML1 spec where it says that a perfectly fine marked up list is invalid if it doesn't contain any items. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
* Daniel Friesen wrote: Embarrassing? You do realize that the validator is complaining that it sees `ul/ul`, right? I can't even find the spot in the HTML4 or XHTML1 spec where it says that a perfectly fine marked up list is invalid if it doesn't contain any items. http://www.w3.org/TR/html4/struct/lists.html#edef-UL defines it as taking `(LI)+` as content, where `+` means one or more. -- Björn Höhrmann · mailto:bjo...@hoehrmann.de · http://bjoern.hoehrmann.de Am Badedeich 7 · Telefon: +49(0)160/4415681 · http://www.bjoernsworld.de 25899 Dagebüll · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 9:08 AM, Daniel Friesen wrote: On 11-08-09 03:37 PM, John Elliot wrote: http://validator.w3.org/check?uri=http://en.wikipedia.org Embarrassing? You do realize that the validator is complaining that it sees `ul/ul`, right? I hadn't realised that. I can't even find the spot in the HTML4 or XHTML1 spec where it says that a perfectly fine marked up list is invalid if it doesn't contain any items. Well you could save yourself some trouble and let validator.w3.org guide you in that matter. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] W3C validation links, and extended edit links
On 10/08/2011 9:13 AM, Platonides wrote: John Elliot wrote: Ah, but I don't know how to use the hook (yet), do I? :P I'll figure it out and fix up my code. See docs/hooks.txt from your mediawiki folder. Will do. Thanks! ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
