[MediaWiki-CodeReview] [MediaWiki r95284]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95284. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95284 Commit summary: Remove support for deprecated WikimediaMobile Disable voctrain group description. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95178]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95178. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95178 Commit summary: (follow-up r91812) change to wfMessage per Roan's suggestion. I did do some testing, and this appears to work in the edge case of message in user lang but not content. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95197]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95197. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95197#c21367 Commit summary: Followup r95185, added all the messaged used by the extension Comment: Did you change the code to use these messages instead? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95197]: New comment added
User Akshay.agarwal posted a comment on MediaWiki.r95197. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95197#c21368 Commit summary: Followup r95185, added all the messaged used by the extension Comment: Yes, I did! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95197]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95197. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95197#c21369 Commit summary: Followup r95185, added all the messaged used by the extension Comment: And which revision is that? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94995]: New comment added
User Catrope posted a comment on MediaWiki.r94995.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94995#c21370
Commit summary:
Per CR on r44412 and my promise in the commit summary of r94990, stop abusing
$wgInternalServer (intended for Squid URLs) for IRC/e-mail URLs and introduce
$wgCanonicalServer for these purposes instead. This revision introduces two new
hooks for WMF hacks, in exchange for making the core code saner.
* Introduce $wgCanonicalServer, which should typically be a fully qualified
version of $wgServer but in practice can be anything that you'd like to be used
in IRC/e-mail notifs
** Default value is $wgServer, expanded to http:// if protocol-relative
** This means you can easily set HTTPS as the 'default' protocol to use in IRC
and e-mail notifs by setting $wgCanonicalServer to https://example.com
* Introduce Title::getCanonicalURL(). Similar to getInternalURL(), including a
hook for WMF usage (which will be needed as long as secure.wikimedia.org is
used)
** Also add escapeCanonicalURL(). Due to some ridiculous accident of history,
the other escapeFooURL() functions don't have a $variant parameter; I decided
not to follow that bad example
* Reinstate the spirit of r44406 and r44412: instead of calling
getInternalURL() (or getCanonicalURL()) and regexing the title parameter out,
obtain the path to index.php using $wgCanonicalServer . $wgScript and append
params to that. Sadly, we need to add a hook here to support the secure server
hack for WMF, but that's the price of saner code in this case
* Introduce the {{canonicalurl:}} and {{canonicalurle:}} parser functions,
which work just like {{fullurl:}} and {{fullurle:}} except that they use
getCanonicalURL() instead of getFullURL()
* Use {{canonicalurl:}} in the enotif_body message, fixing bug 29993
(protocol-relative URLs appear in e-mail notifications)
Comment:
* Doc comments: sure, will tweak
* secure.php: I know, that's why there's a big fat scaptrap on this :)
* CanonicalServer: maybe I didn't document this well enough, but
$wgCanonicalServer must '''always''' be the same, regardless of which protocol
the user comes in on. This ensures consistency in e-mails, but also prevents
cache pollution. We can choose to set it to http (which we will start out with)
and we can switch it to https when we feel comfortable to, but the important
thing is that it's set to a preferred protocol which is fixed. Setting
wgCanonicalServer to https won't reintroduce the notification e-mail problems,
it'll simply make all links in notification e-mails show https for everyone, so
things don't depend on what someone else did, but on what we decide should be
the site-wide default
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95339]: New comment added
User Catrope posted a comment on MediaWiki.r95339. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95339#c21371 Commit summary: up rel notes Comment: That's pretty much right, yes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95332]: New comment added
User Hashar posted a comment on MediaWiki.r95332. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95332#c21372 Commit summary: * (bug 30441) getParamValue must understand + encoding of space $.param() produces query string form encoding using the traditional '+' encoding for space; mediawiki.util.getParamValue() was using only decodeURIComponent() to do unescaping, which is not required by spec to handle '+'. Explicitly replacing '+' with '%20' before the decode nicely resolves this. Added a test case to qunit tests for mediawiki.util module. Comment: jQuery.param() internally uses encodeURIComponent() and then replace any '%20' occurrences with '+' : // global jQuery definition: var r20 = /%20/g; // jQuery.param() returns: return s.join( ).replace( r20, + ); Comparisons of escape() encodeURI() and encodeURIComponent() can be found with examples at: http://xkr.us/articles/javascript/encode-compare/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95359]: New comment added, and revision status changed
User Johnduhart changed the status of MediaWiki.r95359. Old Status: fixme New Status: new User Johnduhart also posted a comment on MediaWiki.r95359. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95359#c21373 Commit summary: (bug 30292) Replace \n with #32; to work around parser bug Comment: Sorry, that should be bug 20262 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95332]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r95332.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r95332.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95332#c21374
Commit summary:
* (bug 30441) getParamValue must understand + encoding of space
$.param() produces query string form encoding using the traditional '+'
encoding for space; mediawiki.util.getParamValue() was using only
decodeURIComponent() to do unescaping, which is not required by spec to handle
'+'. Explicitly replacing '+' with '%20' before the decode nicely resolves this.
Added a test case to qunit tests for mediawiki.util module.
Comment:
pre
+ return decodeURIComponent( m[1].replace( '+',
'%20' ) );
/pre
This doesn't work the way you expect. In JavaScript, code.replace()/code
only replaces the first occurrence, so:
pre
url3 = 'example.com?' + $.param({ 'TEST': 'a b+c d+e' });
example.com?TEST=a+b%2Bc+d%2Be
mw.util.getParamValue( 'TEST', url3 )
a b+c+d+e
/pre
You'll need to use a regex with the g (global) modifier.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95333]: Revision status changed
User Catrope changed the status of MediaWiki.r95333. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95333 Commit summary: (bug 29957) Special:CentralAuth should show time in user's local timezone ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95397]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r95397. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95397 Commit summary: Followup r95396, add missing comma ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21375 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Obviously this really needs RELEASE-NOTES writing up, as wgScaryTransclusion is dead etc... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] AbuseFilter to be enabled on all Wikimedia wikis by default today
Greetings, The AbuseFilter extension for MediaWiki, which helps prevent vandalism on wikis, will be globally enabled on all Wikimedia projects later today. More information is available at http://blog.wikimedia.org/2011/08/24/filter-preventing-abusive-edits-all-wikis/ -- Guillaume Paumier Technical Communications Manager — Wikimedia Foundation http://donate.wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [Wikitech-ambassadors] AbuseFilter to be enabled on all Wikimedia wikis by default today
Guillaume Paumier, 24/08/2011 16:36: The AbuseFilter extension for MediaWiki, which helps prevent vandalism on wikis, will be globally enabled on all Wikimedia projects later today. More information is available at http://blog.wikimedia.org/2011/08/24/filter-preventing-abusive-edits-all-wikis/ I know I can look at noc.wikimedia.org, but could you please add some info about the default configuration so that at least sysops know what to expect. Or is it supposed to be used only by [global sysops and] stewards (as it happened on some small wikis recently)? Thank you, Nemo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [Wikitech-ambassadors] AbuseFilter to be enabled on all Wikimedia wikis by default today
On 24 August 2011 15:55, Federico Leva (Nemo) nemow...@gmail.com wrote: Guillaume Paumier, 24/08/2011 16:36: The AbuseFilter extension for MediaWiki, which helps prevent vandalism on wikis, will be globally enabled on all Wikimedia projects later today. More information is available at http://blog.wikimedia.org/2011/08/24/filter-preventing-abusive-edits-all-wikis/ I know I can look at noc.wikimedia.org, but could you please add some info about the default configuration so that at least sysops know what to expect. Or is it supposed to be used only by [global sysops and] stewards (as it happened on some small wikis recently)? It says in the blog post to which Guillaume linked that the default set up is blank, and that any sysop can set one up as they see fit, with a link to the documentation on how we've used in on enwiki (given that it's been active there for two years). Hope this helps. Yours, -- James D. Forrester jdforres...@wikimedia.org | jdforres...@gmail.com [[Wikipedia:User:Jdforrester|James F.]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [Wikitech-ambassadors] AbuseFilter to be enabled on all Wikimedia wikis by default today
On Wed, Aug 24, 2011 at 4:57 PM, James Forrester ja...@jdforrester.org wrote: On 24 August 2011 15:55, Federico Leva (Nemo) nemow...@gmail.com wrote: I know I can look at noc.wikimedia.org, but could you please add some info about the default configuration so that at least sysops know what to expect. Or is it supposed to be used only by [global sysops and] stewards (as it happened on some small wikis recently)? It says in the blog post to which Guillaume linked that the default set up is blank, and that any sysop can set one up as they see fit, with a link to the documentation on how we've used in on enwiki (given that it's been active there for two years). This is correct. Admins will be the ones able to create and manage filters, and there will be no default filters. The full configuration file is at http://noc.wikimedia.org/conf/highlight.php?file=abusefilter.php -- Guillaume Paumier Technical Communications Manager — Wikimedia Foundation http://donate.wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r95396. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21376 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: PHP Notice: Found alias defined for Globaltemplateusage when searching for special page aliases for GlobalTemplateUsage. Case mismatch? [Called from SpecialPage::getTitleFor in /www/w/includes/SpecialPage.php at line 259] in /www/w/includes/GlobalFunctions.php on line 3396 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: Revision status changed
User Reedy changed the status of MediaWiki.r95396. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95402]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r95402. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95402#c21377 Commit summary: Followup r95396 Lowercase names passed as the name to the SpecialPage constructor Comment: Not using CamelCase is so 2001. Why not to fix MessagesEn.php instead to use CamelCase? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] 1.18 code review status
Hi everyone, Thank you everyone involved for getting the review queue down as low as it is. As it stands, we have 82 new revisions to review, and 57 fixmes: http://www.mediawiki.org/wiki/MediaWiki_roadmap/1.18/Revision_report Back on August 18, we had 171 new revisions to review and 59 fixmes. If you start there an plot linearly to release, that means reviewing 7-8 new revisions per day, and fixing an average of 2 fixmes per day to just barely be done on September 16. Needless to say, we're doing great on the new revisions, but the fixmes are a bit of a problem. Even accounting for the fact that fixmes are being added as a result of the rapid rate of new revision fixing, we're still not fixing the fixmes fast enough. Between August 18 and now, we've netted 2 revisions, by fixing 9 fixmes, and adding 7 more. That's only fixing the fixmes at a rate of 1.5 a day, which won't get us there even if we don't add any more fixmes. Given the fact that reviewing 89 revisions yielded 7 new fixmes, it's reasonable to expect that 5-10% of the remaining new revisions will become new fixmes, which will add 4-8 new fixmes before we're done. So, please take a look at the fixme list (especially if you are one of the committers involved) and do what you can to reduce our load. Thanks! Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New localization extension: jQueryMsg
Fixed on mw.org 2011/8/18 Jeroen De Dauw jeroended...@gmail.com Svn links in article are broken. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Removing * {{msg}} support from MediaWiki:Sidebar
2011/8/20 Ashar Voultoiz hashar+...@free.fr The sidebar code is a hack and it is far from being user friendly. User currently has to edit: - [[MediaWiki:Sidebar]] - a message for link - a message for link name Afaik that's not true. Those 3 steps are only needed if you need internationalization, in which case it makes sense to have multiple pages. If you just want a simple link and link name you can just use: *Some article|Click here! In which case the magic sidebar code will indeed look if there's a message by that name, but if there is not it will output that text raw. So there is no requirement to create two separate messages. 2011/8/20 Ashar Voultoiz hashar+...@free.fr We should just rewrite it from scratch, using some Special page to easily add / remove links. Save them to the database and the cache system. Yes, definitely! This has been brought up a few times before and I think it's an obvious thing to do. It was brought up as a project for GSoC: Sidebar/toolbar customization GUI Regarding the maintainability and automation from one wiki to another, I a shared table solves that easily if it needs to be synchronized across a wiki farm. And if only needed once or twice (export / import) one can use database table export/import from phpMyAdmin even. That's no different from any other database (ie. interwiki). The Sidebar feature could have an API module or SpecialPage-action that allows exporting to, for example, JSON. Which an then be imported on another wiki through the API or a SpecialPage-action. (eg. api.php?action=sidebarop=export or Special:Sidebar/export). -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95016]: Revision status changed
User Reedy changed the status of MediaWiki.r95016. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95016 Commit summary: Expand some more URLs: for feeds, referers and the proxy script ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94995]: Revision status changed
User Reedy changed the status of MediaWiki.r94995.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94995
Commit summary:
Per CR on r44412 and my promise in the commit summary of r94990, stop abusing
$wgInternalServer (intended for Squid URLs) for IRC/e-mail URLs and introduce
$wgCanonicalServer for these purposes instead. This revision introduces two new
hooks for WMF hacks, in exchange for making the core code saner.
* Introduce $wgCanonicalServer, which should typically be a fully qualified
version of $wgServer but in practice can be anything that you'd like to be used
in IRC/e-mail notifs
** Default value is $wgServer, expanded to http:// if protocol-relative
** This means you can easily set HTTPS as the 'default' protocol to use in IRC
and e-mail notifs by setting $wgCanonicalServer to https://example.com
* Introduce Title::getCanonicalURL(). Similar to getInternalURL(), including a
hook for WMF usage (which will be needed as long as secure.wikimedia.org is
used)
** Also add escapeCanonicalURL(). Due to some ridiculous accident of history,
the other escapeFooURL() functions don't have a $variant parameter; I decided
not to follow that bad example
* Reinstate the spirit of r44406 and r44412: instead of calling
getInternalURL() (or getCanonicalURL()) and regexing the title parameter out,
obtain the path to index.php using $wgCanonicalServer . $wgScript and append
params to that. Sadly, we need to add a hook here to support the secure server
hack for WMF, but that's the price of saner code in this case
* Introduce the {{canonicalurl:}} and {{canonicalurle:}} parser functions,
which work just like {{fullurl:}} and {{fullurle:}} except that they use
getCanonicalURL() instead of getFullURL()
* Use {{canonicalurl:}} in the enotif_body message, fixing bug 29993
(protocol-relative URLs appear in e-mail notifications)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88006]: Revision status changed
User ^demon changed the status of MediaWiki.r88006. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88006 Commit summary: bug 28868 removed page number in longdesc in pagedtiffhandler and put in total count of pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95006]: Revision status changed
User Reedy changed the status of MediaWiki.r95006. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95006 Commit summary: Add a PROTO_CANONICAL mode to wfExpandUrl(), which uses $wgCanonicalServer ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21378 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Other minor thing is getCanonicalUrl() needs fixing in trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94990]: Revision status changed
User ^demon changed the status of MediaWiki.r94990. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94990 Commit summary: Followup r94754: move protocol expansion from getIRCLine() to inside getInternalUrl(); these internal URLs should always be fully qualified. Effectively this means that if $wgServer is protocol-relative and $wgInternalServer either isn't set or is also protocol relative (but it really shouldn't be the latter!), we'll add http:// to URLs used for Squid purging and in IRC lines. If people want those to be https:// instead, they can set $wgInternalServer accordingly. We should really, really break the connection between internal URLs used for Squid purges and URLs used for IRC, and use the latter in e-mails as well. This was briefly discussed in the CR comments on r44412 and I'll be working on that today. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95010]: Revision status changed
User ^demon changed the status of MediaWiki.r95010. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95010 Commit summary: Make the PROTO_ parameter to wfExpandUrl() explicit in all calls. There are now no calls to wfExpandUrl() in core that rely on PROTO_CURRENT being the default. Also switch to using getCanonicalUrl() for rel=canonical :D (I picked the right name, I KNEW IT) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95386]: Revision status changed
User Reedy changed the status of MediaWiki.r95386. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95386 Commit summary: Fix some description urls ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95404]: Revision status changed
User ^demon changed the status of MediaWiki.r95404. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95404 Commit summary: actually check user's y/n in a fashion that works; write dumpruninfo file in place, no need for temp file first ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95403]: Revision status changed
User ^demon changed the status of MediaWiki.r95403. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95403 Commit summary: Add documentation Remove unused variables, and unload globals ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95395]: Revision status changed
User ^demon changed the status of MediaWiki.r95395. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95395 Commit summary: Fix documentation (clearing w/c) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95392]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95392. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95392#c21379 Commit summary: added compat method to special pages to fix incompat w/ 1.17 Comment: These would be so nice in core 1.18 :o ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94495]: Revision status changed
User ^demon changed the status of MediaWiki.r94495. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94495 Commit summary: * Remove a comment about a memory leak. I fixed it before I finished writing the comment. * Add a comment about a possible timeout strategy. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95392]: New comment added
User ^demon posted a comment on MediaWiki.r95392. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95392#c21380 Commit summary: added compat method to special pages to fix incompat w/ 1.17 Comment: Doesn't core already have getOutput() and such? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95404]: Revision status changed
User ^demon changed the status of MediaWiki.r95404. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95404 Commit summary: actually check user's y/n in a fashion that works; write dumpruninfo file in place, no need for temp file first ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95405]: Revision status changed
User ^demon changed the status of MediaWiki.r95405. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95405 Commit summary: Followup r93706: add @embed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r66491]: Revision status changed
User ^demon changed the status of MediaWiki.r66491. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66491 Commit summary: Following up on r66057, r66106 r66107. I really, really need to wrap my head around this issue completely. But I think this is a better solution for now, i18n wise. Where is that damn Ashlee\!? S/he needs to write some test code for this extension\! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r66107]: Revision status changed
User ^demon changed the status of MediaWiki.r66107. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66107 Commit summary: Fix to r66106; maybe I should test my code before I commit. _ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r66106]: Revision status changed
User ^demon changed the status of MediaWiki.r66106. Old Status: deferred New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66106 Commit summary: Follow up/fix to r66057, hopefully this suffice greatly regarding the spaces between strings and such. No beginning or trailing spaces. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r66057]: Revision status changed
User ^demon changed the status of MediaWiki.r66057. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66057 Commit summary: Far more render logic added. Still not added so much to parse input data. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r71601]: Revision status changed
User ^demon changed the status of MediaWiki.r71601. Old Status: fixme New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71601 Commit summary: reflect compatible with IE8 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93261]: Revision status changed
User Reedy changed the status of MediaWiki.r93261. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93261 Commit summary: Save css optimizations for modern css ( margin: 0 0 0 0 to margin: 0 etc.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92155]: Revision status changed
User Reedy changed the status of MediaWiki.r92155. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92155 Commit summary: Restructure tab code of mediawiki.special.preferences.js . * 10 levels of indent, really? * Follow up r91869: Instead of setting the title, and later parsing it out and setting id from it, just set the id directly. * Hashes are now in the form #prefsection-personal. This means that they now work in browser with deactivated JS as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95392]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95392. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95392#c21381 Commit summary: added compat method to special pages to fix incompat w/ 1.17 Comment: In trunk yes, but having these as forward-compatibility in older versions would lessen the pain in the extensions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95407]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r95407. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r95407. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95407#c21382 Commit summary: Revert most of r93261 Leave change from named color 'gainsboro' to hex #DCDCDC Comment: we could have kept the optimizations such as: - padding: 0 0em 0 0em; + padding:0; Marking ok anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mediawiki and a standard template library
Note that things like {{Cite}} and {{trim}} should probably
be an extension that adds a parser function, not a template.
Although the overlap between extensions adding parser
functions and and templates getting tighter with WikiScripts,
in general templates are for re-used wikitext and formatting.
Parser functions / magic words are for computing and logic.
So to share such logic from one wiki to another, one doesn't.
One simply installs the same extension.
--
Krinkle
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95407]: New comment added
User Hashar posted a comment on MediaWiki.r95407. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95407#c21383 Commit summary: Revert most of r93261 Leave change from named color 'gainsboro' to hex #DCDCDC Comment: Meanwhile, does it really need 1.18? r93261 was never merged afaik ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95407]: New comment added
User Reedy posted a comment on MediaWiki.r95407. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95407#c21384 Commit summary: Revert most of r93261 Leave change from named color 'gainsboro' to hex #DCDCDC Comment: Duh! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95408]: Revision status changed
User ^demon changed the status of MediaWiki.r95408. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95408 Commit summary: Revert changes to HTMLForm from r92155 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90668]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r90668. Old Status: ok New Status: fixme User Raymond also posted a comment on MediaWiki.r90668. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90668#c21385 Commit summary: Fix for r86722: pass the message 'dberrortext' unescaped to the output since it contains. I really don't like to pass unescaped messages to the output *sigh* Comment: This can produce a PHP warning: Warning: htmlspecialchars() expects parameter 1 to be string, array given in D:\F_Programmierung\xampp\htdocs\wiki2\includes\db\DatabaseError.php on line 271 [[File:R90668 warning Screenshot.png|thumb|left|300px|Screenshot]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95392]: New comment added
User ^demon posted a comment on MediaWiki.r95392. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95392#c21386 Commit summary: added compat method to special pages to fix incompat w/ 1.17 Comment: REL1_18 has it too, see around lines 645-650 of SpecialPage.php. It might not have had it from the original branch point, but the new branch point contains it for sure :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95392]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r95392. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95392#c21387 Commit summary: added compat method to special pages to fix incompat w/ 1.17 Comment: Don't you mean 1.17.x? It's already in 1.18 AFAIK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91728]: Revision status changed
User Reedy changed the status of MediaWiki.r91728. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91728 Commit summary: Rewrite mwsuggest.js using j.ui.autocomplete. This gets rid of a lot of the little kinks of the previously implemenation: The suggestion list now contains regular anchors which can be openened in new indows or separate tabs. The carret doesn't jump around anymore when using the arrow keys to select an item. This should make it much easier to eventually merge Vectors simple search mwsuggest. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93382]: Revision status changed
User Reedy changed the status of MediaWiki.r93382. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93382 Commit summary: r91728 : Fix whitespace and two vars per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94236]: Revision status changed
User Reedy changed the status of MediaWiki.r94236. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94236 Commit summary: Follow-up r93383: api param is 'namespace', not 'namespaces'. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] upcoming conferences - help tell people about MediaWiki, get volunteers?
On 21/08/11 15:58, Sumana Harihareswara wrote: If you're going to a conference, here's a leaflet you can print and give out to encourage people to contribute to MediaWiki: http://www.mediawiki.org/wiki/File:MediaWiki_flyer_20110725-1.pdf People willing to translate it can use the .svg source file at: http://www.mediawiki.org/wiki/File:MediaWiki_flyer_20110725-1.svg french Guillom: nous avons besoin d'une verison française :-) /french -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85876]: Revision status changed
User Reedy changed the status of MediaWiki.r85876. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85876 Commit summary: (bug 13879) Special:Emailuser now asks for suitable target user if called without. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94995]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r94995.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94995#c21389
Commit summary:
Per CR on r44412 and my promise in the commit summary of r94990, stop abusing
$wgInternalServer (intended for Squid URLs) for IRC/e-mail URLs and introduce
$wgCanonicalServer for these purposes instead. This revision introduces two new
hooks for WMF hacks, in exchange for making the core code saner.
* Introduce $wgCanonicalServer, which should typically be a fully qualified
version of $wgServer but in practice can be anything that you'd like to be used
in IRC/e-mail notifs
** Default value is $wgServer, expanded to http:// if protocol-relative
** This means you can easily set HTTPS as the 'default' protocol to use in IRC
and e-mail notifs by setting $wgCanonicalServer to https://example.com
* Introduce Title::getCanonicalURL(). Similar to getInternalURL(), including a
hook for WMF usage (which will be needed as long as secure.wikimedia.org is
used)
** Also add escapeCanonicalURL(). Due to some ridiculous accident of history,
the other escapeFooURL() functions don't have a $variant parameter; I decided
not to follow that bad example
* Reinstate the spirit of r44406 and r44412: instead of calling
getInternalURL() (or getCanonicalURL()) and regexing the title parameter out,
obtain the path to index.php using $wgCanonicalServer . $wgScript and append
params to that. Sadly, we need to add a hook here to support the secure server
hack for WMF, but that's the price of saner code in this case
* Introduce the {{canonicalurl:}} and {{canonicalurle:}} parser functions,
which work just like {{fullurl:}} and {{fullurle:}} except that they use
getCanonicalURL() instead of getFullURL()
* Use {{canonicalurl:}} in the enotif_body message, fixing bug 29993
(protocol-relative URLs appear in e-mail notifications)
Comment:
Right -- having $wgCanonicalServer ''differ'' between http and https is what
would be problematic. Just writing these things down explicitly so we don't
forget when the scaptrap comes due. ;)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87984]: Revision status changed
User Reedy changed the status of MediaWiki.r87984. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87984 Commit summary: Bug 26090 : Ignore unlikely EXIF dates in UploadWizard ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86072]: New comment added
User Reedy posted a comment on MediaWiki.r86072. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86072#c21390 Commit summary: Followup to r86064 (List with double line-breaks inside tables). Also contains patch for Bug 16700 by Mormegil (Additional linebreak though nested templates). Parsertests for both Comment: Bawolff, can you verify the patch in https://bugzilla.wikimedia.org/attachment.cgi?id=8931action=diff As if it doesn't fix it, I'm going to revert this revision and then merge out of 1.18 Cheers! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81945]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r81945. Old Status: fixme New Status: resolved User Reedy also posted a comment on MediaWiki.r81945. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81945#c21391 Commit summary: If someone asks for a non-existent group, show an empty list, not a list of all users. This is less surprising. Comment: Looks to have been fixed between then and now. Marking resolved ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91402]: Revision status changed
User Reedy changed the status of MediaWiki.r91402. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91402 Commit summary: Allow SqlBagOStuff data to be split over many tables, to avoid lock contention performance issues on servers with a high write load. See http://bugs.mysql.com/bug.php?id=61735 and http://bugs.mysql.com/bug.php?id=61736 . ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87984]: New comment added
User NeilK posted a comment on MediaWiki.r87984. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87984#c21392 Commit summary: Bug 26090 : Ignore unlikely EXIF dates in UploadWizard Comment: reedy -- thanks for doing that, I was just about to ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Reedy posted a comment on MediaWiki.r87482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87482#c21393 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: Is this still broken? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added
User Catrope posted a comment on MediaWiki.r87482. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87482#c21394 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release notes formatting tweak. Comment: I believe this is fixed now, but someone should break out an IE6 VM and check. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] older revision view statistics
I suppose that most readers read the current versions of pages and not the previous revisions. Are there precise statistics about it? What percentage of readers bother to look at the histories and the previous revisions? -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95413]: Revision status changed
User SPQRobin changed the status of MediaWiki.r95413. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95413 Commit summary: Fix fixme on r92059 per SPQRobin ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94404]: Revision status changed
User Reedy changed the status of MediaWiki.r94404. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94404 Commit summary: Hopefully prevent race conditions in ArticleFeedback by reading from the master rather than the slave and using LOCK IN SHARE MODE. These race conditions probably caused bug 30227. Hopefully this will prevent that from happening again. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94511]: Revision status changed
User Reedy changed the status of MediaWiki.r94511. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94511 Commit summary: Followup r94502: per CR, use two caching variables instead of an array indexed with true or false ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87948]: Revision status changed
User Reedy changed the status of MediaWiki.r87948. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87948 Commit summary: fix backtrace on SQL error Setting $wgShowDBErrorBacktrace did not have any effect when throwing a DBQueryError exception. Code was missing to actually append the backtrace to the output :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95415]: Revision status changed
User SPQRobin changed the status of MediaWiki.r95415. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95415 Commit summary: Fix one caller to analyzePrefix() that was passing a Title object instead of a string. Apparently explode( '/', $title ) can segfault PHP if $title is a Title object, but only in certain cases (i.e. only for certain titles, and not on the CLI). Not filing a bug against PHP because it's not reproducible and only been observed in an old version (5.2.4), just working around it instead ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95416]: Revision status changed
User SPQRobin changed the status of MediaWiki.r95416. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95416 Commit summary: 1.17wmf1: MFT r95415 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95419]: Revision status changed
User Krinkle changed the status of MediaWiki.r95419. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95419 Commit summary: * (bug 30540) fix for path lookup from GlobalUsage extension's refreshGlobalImageLinks.php Was using ../.. which seemed to assume that your current working directory is in a particular dir instead of going relative to the file's actual location. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r86305. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c21396 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Marking fixme. tableSorterCollation isn't set anywhere (other than in the unit test). A grep search didn't return any call to mw.config.set and/or an array property in PHP's config vars for tableSorterCollation. Where is it coming from or should the function using code tableSorterCollation/code be refactored ? The rest of the revision is either fine or has been fixed in the mean time. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95423]: Revision status changed
User Krinkle changed the status of MediaWiki.r95423. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95423 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94251]: Revision status changed
User Krinkle changed the status of MediaWiki.r94251. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94251 Commit summary: Add internationalization of the ToolserverStatus library ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94253]: Revision status changed
User Krinkle changed the status of MediaWiki.r94253. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94253 Commit summary: Fix comment, document $fail parameter. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94255]: Revision status changed
User Krinkle changed the status of MediaWiki.r94255. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94255 Commit summary: Bad filename in r94251 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94308]: Revision status changed
User Krinkle changed the status of MediaWiki.r94308. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94308 Commit summary: Follow up r94305. But still, things don't seem to be right... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94904]: Revision status changed
User Krinkle changed the status of MediaWiki.r94904. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94904 Commit summary: Update messages for CommonsHelper2 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94308]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r94308. Old Status: ok New Status: fixme User Krinkle also posted a comment on MediaWiki.r94308. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94308#c21397 Commit summary: Follow up r94305. But still, things don't seem to be right... Comment: Please explain what would be not alright ? This revision is blocking deployment right now. Note that it looks good to me, but waiting for your reply. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94305]: Revision status changed
User Krinkle changed the status of MediaWiki.r94305.
Old Status: deferred
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94305
Commit summary:
Change getAvailableLangs (added in r84981) to return by default the languages
available
in the main domain, which is what I think most tools would need.
'Helper' domains such as General will have much more translations than the tool
itself,
but showing all those language as available would be deceiving (OTOH, if they
happen to
have such enable from the Intuition board, or if they manually hack the url, it
still works).
The old $I18N-getAvailableLangs() behavior is now available with
$I18N-getAvailableLangs('any');
The only usage of getAvailableLangs was in searchPage.php of Monuments API,
which is well-filled.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93745]: Revision status changed
User Krinkle changed the status of MediaWiki.r93745. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93745 Commit summary: Tweak messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95079]: Revision status changed
User Krinkle changed the status of MediaWiki.r95079. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95079 Commit summary: Followup r82900: per CR, use .length instead of size(), strict comparison with zero, and re-select from the DOM after removal to guard against weird interaction between .remove() and .length ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93062]: New comment added
User Krinkle posted a comment on MediaWiki.r93062.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93062#c21398
Commit summary:
r92054: Some IE fixes
Comment:
Why was the selector changed from code#catlinks ul, #catlinks li {/code to
code#catlinks ul {/code ?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93062]: New comment added
User Krinkle posted a comment on MediaWiki.r93062. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93062#c21399 Commit summary: r92054: Some IE fixes Comment: Okay. Makes sense. Looks good. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95408]: Revision status changed
User Reedy changed the status of MediaWiki.r95408. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95408 Commit summary: Revert changes to HTMLForm from r92155 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92155]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r92155. Old Status: resolved New Status: fixme User Reedy also posted a comment on MediaWiki.r92155. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92155#c21400 Commit summary: Restructure tab code of mediawiki.special.preferences.js . * 10 levels of indent, really? * Follow up r91869: Instead of setting the title, and later parsing it out and setting id from it, just set the id directly. * Hashes are now in the form #prefsection-personal. This means that they now work in browser with deactivated JS as well. Comment: r95408 broke preferences tabs Could someone more JS familiar look at fixing this up? Thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92347]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92347. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r92347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92347#c21401 Commit summary: essage=Only selector that seems to work on text input elements is jQuery's proprietary :text selector with (from: http://api.jquery.com/text-selector/). With no performance boost. Comment: See also [https://github.com/jquery/sizzle/blob/93cc46709e03173288111f8b60d4192fea2ec8d0/sizzle.js#L624 source code of :text] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95434]: Revision status changed
User Reedy changed the status of MediaWiki.r95434. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95434 Commit summary: new accessor for CodeRevision repository ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95433]: Revision status changed
User Reedy changed the status of MediaWiki.r95433. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95433 Commit summary: makes CodeRevisionView::formatComment() public That method should really be moved out of the view object. For example, we could use a generic helping class that each view can reuse. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82577]: New comment added
User Reedy posted a comment on MediaWiki.r82577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82577#c21402 Commit summary: improve namespace related methods MWNamespace::getTalk() could give erroneus results when using it on specials namespaces (NS_MEDIA, NS_SPECIAL). It now use MWNamespace::isMethodValidFor() which will throw an exception if a special namespace was given. MWNamespace::getSubject() is now returning identity for specials namespaces. New MWNamespace::getAssociated() used to find out the subject page of a talk page and vice versa. Special namespaces will results in an exception. TESTS: Added tests for almost complete code coverage. Functions relying on global $wgCanonicalNamespaces are still incomplete though. MWNamespace::isMovable() needs more assertions. Tests results (ignoring incomplete tests output): $ php phpunit.php --filter MWNamespace PHPUnit 3.5.10 by Sebastian Bergmann. .I.. Time: 1 second, Memory: 31.75Mb OK, but incomplete or skipped tests! Tests: 24, Assertions: 99, Incomplete: 5. Comment: The first 3 items have been dealt with. The last 2 still need dealing with... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95422]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r95422. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r95422. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95422#c21403 Commit summary: Followup r82577 Remove $this-object Swap assertEquals parameters Comment: Thanks a lot Reedy for dealing with it. I owe you another beer. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95426]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r95426. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r95426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95426#c21404 Commit summary: Fix testGetTalkExceptions from r82577 Comment: thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92245]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92245. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r92245. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92245#c21405 Commit summary: r92054 : Fix wordwrap by using inline-block. This has the nice sideeffect of fixing an Opera background image bug as well. Remove categories from print, they're not especially useful on paper. (Also give footer some space) Comment: Reverted the commonPrint.css change in r95436. It was discussed a little bit in r92054 CR, but I'm not (yet) convinced they are irrelevant for print. Please open a ticket if you think they should be hidden (including motivation). Marking OK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r92054. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c21406 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: This revision introduces an issue. The codenowikidiv id=catlinks/nowiki/code are outputted form within the skin-implementations (ie. ColongneBlue.php), but that ID is styled from codecommon.css/code, please centralize that output so that the ID-naming is the same acros skins (or move the styling to skin's stylesheet). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added
User Krinkle posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c21407 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: Hm.. seems it is already centralized. codeSkin.php/code defines a method codeSkin-getCategories()/code which wraps codenowikidiv id=catlinks/nowiki/code around codegetCategoryLinks()/code , perhaps use that instead ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
