[MediaWiki-CodeReview] [MediaWiki r96736]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96736. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96736 Commit summary: Fix comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96750]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96750. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96750 Commit summary: Simplify some contexts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96752]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r96752. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r96752. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96752#c22328 Commit summary: Kill unused globals/variables Add to documentation Comment: The changes in MessageGroupBaseTest are wrong. You are hiding few bugs and the last test excepts an exception from the line you removed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added
User DieBuche posted a comment on MediaWiki.r86305.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c22329
Commit summary:
Followup r86088 per CR: Move month array builder into language; use
mw.config.get(); Fix rowspans and some cleanup
Comment:
Brion is right it's an site specific thing. Why would it be hard to use? You
just put something like mw.config.set('tableSorterCollation', {'ä' : 'ae'})
into common.js
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92054]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r92054. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r92054. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c22330 Commit summary: Render category links as an HTML list. Bug 12261. Based on patch by Thana Bergi. It's removing the textual pipe separator, wrapping the links inside li elements and adding a left 1px border as separator. This makes it much easier to manipulate the list via JS or CSS and is also semantically correct Comment: r96775 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96773]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96773. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96773 Commit summary: * Follow-up r96420: don't show e-mail links to anon users * Fix for r24612 (!) spotted while fixing the above: parenthesis arround the bitwise check are needed since ! operator has higher precedence than ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96752]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96752. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96752 Commit summary: Kill unused globals/variables Add to documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96755]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96755. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96755 Commit summary: Fix E_NOTICE about undefined variable. * $lang was probably defined earlier, before the code was rearranged. Follows-up r95992 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96756]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96756. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96756#c22331 Commit summary: work on special:surveystats Comment: pre + 'survey-question-type-number' = 'Number', /pre Please provide documentation whether this means a digit (8) or any number (88). + 'surveys-surveystats-question-answercount' = 'Amount of answers', Shouldn't that be number of answers, since answers are countable? pre + 'surveys-surveystats-question-answers' = 'Most provided answers', /pre Would be nice to document the context where this message is used (why not for the rest of messages too). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96757]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r96757. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r96757. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96757#c22332 Commit summary: do not list special:surveystats Comment: To make the code more readable you could instead call $this-setListed( false ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96758]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r96758. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r96758. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96758#c22333 Commit summary: docs++ Comment: Has code change too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96760]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96760. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96760#c22334 Commit summary: * Per Aaron on r96261, use string 'flip' instead of boolean * Apparently @noflip should only be set once, otherwise it behaves differently Comment: The default could be 'noflip' instead of false to keep it always a string. The rest looks very nice. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96763]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r96763.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r96763.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96763#c22335
Commit summary:
work on special:surveystats
Comment:
At least 'surveys-surveystats-question-answer' needs documentation. And you
don't need to provide the number twice, nowiki{{PLURAL}}/nowiki handles
formatted numbers very well (it might even cause bugs with unformatted numbers).
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96765]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96765. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96765#c22336 Commit summary: (bug 30722) Add an identity collation that sorts things based on what the unicode code point is (aka pre-1.17 behaviour). I'm tagging this 1.18 because the original bug was for iswiktionary wanting it, so it'd be nice to get it in 1.18. Comment: I'd replace the RELEASE-NOTES bug description with the one in your commit message. The one in release-notes makes no sense :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96767]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96767.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96767#c22337
Commit summary:
(bug 16755) Add syntax to DEFAULTSORT - {{DEFAULTSORT:Foo|noerror}} and
{{DEFAULTSORT:Bar|noreplace}}
to in both cases prevent the A sortkey already was specified earlier in the
page, yadda yadda message and in the second case, also do not replace the
sortkey
if one was already specified.
Comment:
shouldn't noreplace and noerror be i18ned?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96771]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96771. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96771 Commit summary: Some small changes to English-language values ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96772]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96772#c22338 Commit summary: Minor formatting and documentation revisions. Comment: pre+/** + * Set up parser hooks. + */ +$wgHooks[ 'ParserFirstCallInit' ][] = 'WikiCitation::onParserFirstCallInit'; +$wgHooks[ 'ParserClearState' ][] = 'WikiCitation::onParserClearState'; +$wgHooks[ 'ParserBeforeTidy' ][] = 'WikiCitation::onParserBeforeTidy'; /pre If you do it like that, doxygen will display the comment only for the first line. Looks for includes/DefaultSettings.php how to document blocks of configuration code. Usually this kind of code is just hidden behind @cond file_level_code, with normal comments inside. Was the removal of wc_dissertation intended? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96774]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96774. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96774 Commit summary: * Use local context instead of global variables * Call Linker methods statically * Added missing call to outputHeader() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92279]: Revision status changed
User Reedy changed the status of MediaWiki.r92279. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92279 Commit summary: (bug 28762) Resizing to specified height broken for very thin images Restructure and comment of ImageHandler::normaliseParams(). ImageHandler::normaliseParams() will now output both width/height as physicalWidth/Height, where width/height are the dimensions used by the browser, and physicalWidth/Height are the dimensions of the thumbnail that will be created. This allows keeping the use of unique dimensions for a specified thumbnail width, by forcing client side resizing of 1px-wide images with non corresponding height. Also fixed a bug where the check for mustRender() was in an if statement where it should not have been. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96777]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96777. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96777 Commit summary: Drop support for Potlatch, as Potlatch 2 is now the standard editor at OpenStreetMap. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Re quests about log system
On Sat, Sep 10, 2011 at 8:28 PM, Niklas Laxström niklas.laxst...@gmail.com wrote: Another point came up in IRC discussions: JSON converts UTF-8 characters to unicode escape sequences. serialize() does not. This effectively negates any size advantages JSON might have. I noticed JSON is used extensively in resource loader. Roan: did you consider this point when choosing JSON format for storing message resources? No, I didn't know this and didn't think about it. The reason I chose JSON is because the primary use case of the message blobs was to be sent to JavaScript and used for i18n there, so it was convenient to keep it as JSON the whole time and not have to do any decoding or encoding for the primary use case. The only case in which PHP needs to read the JSON data is when a single message is changed in the MediaWiki: namespace, in which case the blob is decoded, the message contents are swapped out, and the blob is re-encoded. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96763]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r96763. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96763#c22339 Commit summary: work on special:surveystats Comment: Oh, neat. Fixed by r96780 :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96756]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r96756. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96756#c22340 Commit summary: work on special:surveystats Comment: Points 0 and 2 fixed by r96781. Not sure about the second one. Is amount not valid for some countable stuff?! Seems ok to me, but then again I'm not a native English speaker so could very well be wrong. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96712]: New comment added
User SPQRobin posted a comment on MediaWiki.r96712. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96712#c22341 Commit summary: Conversion script between Tifinagh and Latin for the Tachelhit language Preferences: made getLanguageNames include those that don't have a Messages file Comment: To be clear (I explained it to Nikerabbit on IRC): the change in Preferences is *only* for the variants dropdown and not for the interface language dropdown. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96783]: New comment added
User Huji posted a comment on MediaWiki.r96783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96783#c22342 Commit summary: Adding Persian (Farsi) web-fonts. Please see my comment on the MediaWiki/Special:Version on this commit Comment: This revision adds the free font DeJaVuSans as well as the EOT version of it to be used on Persian wikis. Conversion to EOT needs to be done with special tools, because the majority of convertors break the Persian fonts. I have not yet been able to create a WOFF version of the same font. The DeJaVuSans comes with many Linux distros (including Ubuntu which I'm using). It is a rather large font (~600KB) but all convertors that compress this font break it (in terms of showing RTL Persian text correctly). Nevertheless, it is currently used in major Persian wikis as the default font for non-Windows machines. For Windows machines, Tahoma is used as default; regarding the looks and feel of Persian letters, DeJaVuSans and Tahoma are very close. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system
Geez, I didn't mean to squash the discussion! TRAC isn't *that* weird a language, is it? From: wikitech-l-boun...@lists.wikimedia.org [wikitech-l-boun...@lists.wikimedia.org] on behalf of Russell N. Nelson - rnnelson [rnnel...@clarkson.edu] Sent: Thursday, September 08, 2011 2:18 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system How about http://en.wikipedia.org/wiki/TRAC_%28programming_language%29 ? It has the benefit that simple things are simple, but you can create complicated things because it's a full programming language. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system
It's over complicated for our needs, and we really don't need another full featured language to learn and parse. It's like saying everyone should learn ruby so we can do skins in it. On Sun, Sep 11, 2011 at 12:05 PM, Russell N. Nelson - rnnelson rnnel...@clarkson.edu wrote: Geez, I didn't mean to squash the discussion! TRAC isn't *that* weird a language, is it? From: wikitech-l-boun...@lists.wikimedia.org [ wikitech-l-boun...@lists.wikimedia.org] on behalf of Russell N. Nelson - rnnelson [rnnel...@clarkson.edu] Sent: Thursday, September 08, 2011 2:18 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system How about http://en.wikipedia.org/wiki/TRAC_%28programming_language%29 ? It has the benefit that simple things are simple, but you can create complicated things because it's a full programming language. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- John ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96783]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r96783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96783#c22343 Commit summary: Adding Persian (Farsi) web-fonts. Please see my comment on the MediaWiki/Special:Version on this commit Comment: Using a generic , multi scripts font like DejavuSans does not look an appropriate way. The TTF and EOT has 670KB size , and most of the glyphs will be unnecessary for the page. Is there any free licensed fonts with only glyphs required for fa.wikipedia? What do you think about Nastaleeq fonts like this http://www.crulp.org/software/localization/Fonts/nafeesNastaleeq.html ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96783]: New comment added
User Huji posted a comment on MediaWiki.r96783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96783#c22344 Commit summary: Adding Persian (Farsi) web-fonts. Please see my comment on the MediaWiki/Special:Version on this commit Comment: There are a number of free fonts available but their readability is a big issue. Many of them use a lot of vertical space or are too artistic (such as Nastaleeq) and not appropriate for the web. The majority of Persian website are currently using Tahoma, but because Tahoma is not a free font, there are issues with non-Windows machines. I'm aware that this is not the optimal solution; however, it at least allows a single look and feel for the wikis using WebFonts extension on all platforms (regardless of OS). One workaround can be to prune DejaVuSans and create another font which only contains ASCII characters and Persian glyphs. However, this is beyond my expertise at the moment. The solution is to create and use free fonts for Persian, something that has to be done by graphic artists. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96783]: New comment added
User Huji posted a comment on MediaWiki.r96783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96783#c22345 Commit summary: Adding Persian (Farsi) web-fonts. Please see my comment on the MediaWiki/Special:Version on this commit Comment: Btw, Nafees Nastaleeq fonts are almost exclusively used for Urdu, which is different from Persian. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96783]: New comment added
User Huji posted a comment on MediaWiki.r96783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96783#c22346 Commit summary: Adding Persian (Farsi) web-fonts. Please see my comment on the MediaWiki/Special:Version on this commit Comment: Actually, I just found another font which is much smaller (around 60KB), and is free (although not GPL). Therefore, I reverted my previous changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] sep11.wikipedia.org
Sorry, what is sep11.wikipedia.org? Is it project Wikipedia Org? Why not domain jan01.wikipedia.org, mar08.wikipedia.org, etc? 2011/9/10 MZMcBride z...@mzmcbride.com: Benjamin Lees wrote: On Fri, Sep 9, 2011 at 1:44 PM, Platonides platoni...@gmail.com wrote: Looks fixed to me (redirects to archive.org) sep11.wikipedia.org redirects to archive.org, but sep11.wikipedia.org/wiki/ still redirects to sep11memories.org. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96797]: New comment added
User Huji posted a comment on MediaWiki.r96797. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96797#c22347 Commit summary: Reverting r96783 r96787 and r96788; adding IranianSans font, which is not GPL based but is a free font; including IranianSans's license Comment: Here is a demo for those interested to see how IranianSans looks like: http://toolserver.org/~huji/webfont/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] sep11.wikipedia.org
http://en.wikipedia.org/wiki/September_11_attacks 2011/9/11 Краснов Кирилл krasnovfo...@gmail.com Sorry, what is sep11.wikipedia.org? Is it project Wikipedia Org? Why not domain jan01.wikipedia.org, mar08.wikipedia.org, etc? 2011/9/10 MZMcBride z...@mzmcbride.com: Benjamin Lees wrote: On Fri, Sep 9, 2011 at 1:44 PM, Platonides platoni...@gmail.com wrote: Looks fixed to me (redirects to archive.org) sep11.wikipedia.org redirects to archive.org, but sep11.wikipedia.org/wiki/ still redirects to sep11memories.org. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- John ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96780]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96780. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96780 Commit summary: Follow up to r96763; fixed i18n issues ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96763]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96763. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96763 Commit summary: work on special:surveystats ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96781]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96781. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96781 Commit summary: Follow up to r96756; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87147]: New comment added
User Duplicatebug posted a comment on MediaWiki.r87147. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87147#c22348 Commit summary: * (bug 27179) API: List of extension tags * Get a list of function hooks through meta=siteinfo Comment: flags of functionHooks are missing. codeappendFunctionHooks/code does not add information about SFH_NO_HASH, which makes it hard to use, because is is very important to know, if the function hook has a leading # or not. Maybe add the # to the hookname. Adding the information about SFH_OBJECT_ARGS is a nice to have (not used often). A objectargs= can do the job. Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system
The *syntax* is simple. You can eliminate unnecessary primitives. From: wikitech-l-boun...@lists.wikimedia.org [wikitech-l-boun...@lists.wikimedia.org] on behalf of John Du Hart [compwhi...@gmail.com] Sent: Sunday, September 11, 2011 12:12 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system It's over complicated for our needs, and we really don't need another full featured language to learn and parse. It's like saying everyone should learn ruby so we can do skins in it. On Sun, Sep 11, 2011 at 12:05 PM, Russell N. Nelson - rnnelson rnnel...@clarkson.edu wrote: Geez, I didn't mean to squash the discussion! TRAC isn't *that* weird a language, is it? From: wikitech-l-boun...@lists.wikimedia.org [ wikitech-l-boun...@lists.wikimedia.org] on behalf of Russell N. Nelson - rnnelson [rnnel...@clarkson.edu] Sent: Thursday, September 08, 2011 2:18 PM To: Wikimedia developers Subject: Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system How about http://en.wikipedia.org/wiki/TRAC_%28programming_language%29 ? It has the benefit that simple things are simple, but you can create complicated things because it's a full programming language. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- John ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96798]: New comment added
User Siebrand posted a comment on MediaWiki.r96798.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96798#c22349
Commit summary:
(Bug 30364) LanguageConverter should depend on the page content language
instead of the wiki content language. Remains largely the same, except for
extensions using the PageContentLanguage hook like Translate and
WikimediaIncubator.
* Made variant tabs hidden on special pages (has no or sometimes
wrong/inconsistent effect there; plus it's mainly in the user language)
* Made redirects be in content language again (remove from
Title-getPageLanguage())
Comment:
code- if ( $req ) {
+ if ( $req = $this-validateVariant( $req ) ) {
/code
Afaik assignments inside ifs should be avoided.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96793]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96793. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96793 Commit summary: i18n tweak ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96733]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r96733. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96733 Commit summary: Revert r96732 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] sep11.wikipedia.org
After the sep 11 attacks a lot of articles where added to Wikipedia about people who died in the attack etc. These articles weren't considered encyclopedic but we didn't want to delete the articles either so they were moved to it's own dedicated wiki, sep11. regards, Finne 2011/9/11 Краснов Кирилл krasnovfo...@gmail.com: Sorry, what is sep11.wikipedia.org? Is it project Wikipedia Org? Why not domain jan01.wikipedia.org, mar08.wikipedia.org, etc? 2011/9/10 MZMcBride z...@mzmcbride.com: Benjamin Lees wrote: On Fri, Sep 9, 2011 at 1:44 PM, Platonides platoni...@gmail.com wrote: Looks fixed to me (redirects to archive.org) sep11.wikipedia.org redirects to archive.org, but sep11.wikipedia.org/wiki/ still redirects to sep11memories.org. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Maybe you knew early on that your track went from point A to B, but unlike you I wasn't given a map at birth! Alyssa, Chasing Amy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96585]: New comment added
User DaSch posted a comment on MediaWiki.r96585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96585#c22350 Commit summary: Switch JSON to (un)serialize Comment: this changes seams to cause the following bug https://bugzilla.wikimedia.org/show_bug.cgi?id=30854 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96783]: Revision status changed
User Reedy changed the status of MediaWiki.r96783. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96783 Commit summary: Adding Persian (Farsi) web-fonts. Please see my comment on the MediaWiki/Special:Version on this commit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96787]: Revision status changed
User Reedy changed the status of MediaWiki.r96787. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96787 Commit summary: Adding WOFF version of DeJaVuSans font, follow up to r96783 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96788]: Revision status changed
User Reedy changed the status of MediaWiki.r96788. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96788 Commit summary: Removing the executable bit from font files, follow up r96783 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Duplicatebug posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c22351 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: An unused tt$forceRawInterwiki/tt is leaved in Parser.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Duplicatebug posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c22352 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: This commit makes Title.php mutable (with Title::setInterwiki), it is called at one place, maybe it is possible to create a new title with one of the factory methods and remove Title::setInterwiki. The change of Preprocessor_Hash.php should also added to Preprocessor_HipHop. A comment is also nice, to say why the interwiki of the frame/context, and not the interwiki from the templatename, is used. (My understanding: It is used to load the inner templates of a distant template also from the distant wiki). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96805]: New comment added, and revision status changed
User SPQRobin changed the status of MediaWiki.r96805. Old Status: new New Status: ok User SPQRobin also posted a comment on MediaWiki.r96805. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96805#c22353 Commit summary: Per r96723: register new message key to maintenance script Comment: Thanks, forgot to add it.. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] sep11.wikipedia.org
Hi, John. You wrote Sunday, September 11, 2011, 8:38:07 PM: http://en.wikipedia.org/wiki/September_11_attacks 2011/9/11 Краснов Кирилл krasnovfo...@gmail.com Sorry, what is sep11.wikipedia.org? Is it project Wikipedia Org? Why not domain jan01.wikipedia.org, mar08.wikipedia.org, etc? Why not http://en.wikipedia.org/wiki/Beslan_school_hostage_crisis ? Sorry for my badly english. I translate with google next text: I honor the memory of all victims of this tragic day. I express my condolences to all relatives and friends who lost loved ones. But Wikipedia is an international project, which should equally take into account all the rights and freedoms of people around the world. What a tragedy of September 11 terrorist attack other notable terrorist attacks? Why for that date, there is a subdomain Wikipedia, and for other important dates, no? Why not make a date on every terrorist attack? For example, in Norway http://en.wikipedia.org/wiki/2011_Norway_attacks ? -- Best regards, Kirill http://www.kraeg.ru/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96807]: Revision status changed
User Meno25 changed the status of MediaWiki.r96807. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96807 Commit summary: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96767]: New comment added
User Bawolff posted a comment on MediaWiki.r96767.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96767#c22354
Commit summary:
(bug 16755) Add syntax to DEFAULTSORT - {{DEFAULTSORT:Foo|noerror}} and
{{DEFAULTSORT:Bar|noreplace}}
to in both cases prevent the A sortkey already was specified earlier in the
page, yadda yadda message and in the second case, also do not replace the
sortkey
if one was already specified.
Comment:
yep it should. Done in r96809
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] sep11.wikipedia.org
- Original Message - From: Краснов Кирилл krasnovfo...@gmail.com Sorry, what is sep11.wikipedia.org? Is it project Wikipedia Org? Why not domain jan01.wikipedia.org, mar08.wikipedia.org, etc? Please Don't Feed The Trolls, folks. Cheers, -- jra -- Jay R. Ashworth Baylink j...@baylink.com Designer The Things I Think RFC 2100 Ashworth Associates http://baylink.pitas.com 2000 Land Rover DII St Petersburg FL USA http://photo.imageinc.us +1 727 647 1274 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96760]: New comment added
User SPQRobin posted a comment on MediaWiki.r96760. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96760#c22355 Commit summary: * Per Aaron on r96261, use string 'flip' instead of boolean * Apparently @noflip should only be set once, otherwise it behaves differently Comment: Done in r96812 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] sep11.wikipedia.org
I'm sorry for all. I did not want to offend anyone. I only told IMHO for this MONTH topic. One more sorry. I'm end. Good luck and peaceful sky over head. 2011/9/11 Jay Ashworth : Please Don't Feed The Trolls, folks. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] sep11.wikipedia.org
2011/9/11 Kirill Krasnov krasnovfo...@gmail.com: Hi, John. You wrote Sunday, September 11, 2011, 8:38:07 PM: http://en.wikipedia.org/wiki/September_11_attacks 2011/9/11 Краснов Кирилл krasnovfo...@gmail.com Sorry, what is sep11.wikipedia.org? Is it project Wikipedia Org? Why not domain jan01.wikipedia.org, mar08.wikipedia.org, etc? Why not http://en.wikipedia.org/wiki/Beslan_school_hostage_crisis ? Sorry for my badly english. I translate with google next text: I honor the memory of all victims of this tragic day. I express my condolences to all relatives and friends who lost loved ones. But Wikipedia is an international project, which should equally take into account all the rights and freedoms of people around the world. What a tragedy of September 11 terrorist attack other notable terrorist attacks? Why for that date, there is a subdomain Wikipedia, and for other important dates, no? Why not make a date on every terrorist attack? For example, in Norway http://en.wikipedia.org/wiki/2011_Norway_attacks ? -- Best regards, Kirill http://www.kraeg.ru/ Kirill, The Sept. 11 wiki is closed now. But it was set up very early in Wikipedia's history, before we had really figured out how huge and international Wikipedia would be (and before we started using the Wikimedia name). First, as Finne says, there were lots of entries created on the English Wikipedia that weren't strictly encyclopedic, so a separate subdomain was created for them. Then, a few years later after discussion about whether such a project was really appropriate for Wikimedia, the wiki was closed, and later the content was moved over to the Internet Archive and elsewhere. We kept the link as a redirect simply for historical preservation purposes :) You can read more on meta: http://meta.wikimedia.org/wiki/Sep11wiki As a historical note, I believe the 9/11 attacks were one of the first times that the Wikipedia community really responded by writing articles in real-time, a phenomena that has become one of our extraordinary hallmarks as a project in the last ten years. best, -- phoebe ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96815]: New comment added
User Krinkle posted a comment on MediaWiki.r96815.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96815#c22356
Commit summary:
navigation++
Comment:
pre
+ protected function displayNavigation( array $links ) {
+ $this-getOutput()-addHTML( Html::rawElement( 'p', array(),
implode( ' - ', $links ) ) );
+ }
/pre
Perhaps use Language-pipeList() instead ? Using dash as separator in
navigation is uncommon in MediaWiki.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96815]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r96815. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96815#c22357 Commit summary: navigation++ Comment: Cool, applied in follow up :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96818]: New comment added
User Krinkle posted a comment on MediaWiki.r96818. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96818#c22358 Commit summary: Follow up to r96815; Comment: SpecialPages are connected to the wiki context as of MediaWiki 1.18. Use SpecialPage-getLang() instead of the globals. code$this-getLang()/code in this case. This ensures that the right context is used. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96815]: Revision status changed
User Krinkle changed the status of MediaWiki.r96815. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96815 Commit summary: navigation++ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Taking suggestions for a template language syntax for our skin system
On Thu, Sep 8, 2011 at 11:04 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: Aye, there's absolutely no way HAML is going to fly with the majority of people building skins. Instead of Why the hell do I have to insert all this junk just to make my skin work right? I'm going back to WordPress. kind of issue we had before I cleaned up the skin system we'll end up with a What the hell is this syntax? I'm going back to Drupal. kind of issue. I'm curious what problem you're trying to solve. It sounds like you're trying to get people who are currently working on Wordpress skins or Drupal skins to work on MediaWiki skins instead, but to what end? Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96818]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r96818. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96818#c22359 Commit summary: Follow up to r96815; Comment: Neat; made use of that in follow up :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96824]: New comment added
User SPQRobin posted a comment on MediaWiki.r96824. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96824#c22360 Commit summary: SpecialSearch: add two hooks, one to modify the power search box, one to change the message pointing to the page title searched for WikimediaIncubator: * use these hooks and SpecialSearchSetupEngine to improve search usability * use a different message for the language code in preferences, per suggestion of Amir Comment: It would be ''very nice'' if the changes in SpecialSearch may be backported to either REL1_18 or the soon-to-be 1.18wmf1 branch, so that I wouldn't have to wait for 1.19 deployment :-S ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Bugzilla Weekly Report
MediaWiki Bugzilla Report for September 05, 2011 - September 12, 2011 Status changes this week Bugs NEW : 237 Bugs ASSIGNED : 20 Bugs REOPENED : 37 Bugs RESOLVED : 124 Total bugs still open: 6055 Resolutions for the week: Bugs marked FIXED : 80 Bugs marked REMIND : 0 Bugs marked INVALID: 12 Bugs marked DUPLICATE : 13 Bugs marked WONTFIX: 14 Bugs marked WORKSFORME : 2 Bugs marked LATER : 4 Bugs marked MOVED : 0 Specific Product/Component Resolutions User Metrics New Bugs Per Component MobileFrontend 6 Site requests 5 Semantic MediaWiki 4 UploadWizard3 Internationalization3 New Bugs Per Product MediaWiki 20 Wikimedia 11 MediaWiki extensions29 Wikimedia Mobile1 Top 5 Bug Resolvers sam [AT] reedyboy.net 17 bawolff+wn [AT] gmail.com 12 arichards [AT] wikimedia.org11 niklas.laxstrom [AT] gmail.com 10 roan.kattouw [AT] gmail.com 9 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
