[MediaWiki-CodeReview] [MediaWiki r76344]: New comment added
User Tim Starling posted a comment on MediaWiki.r76344. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76344#c22985 Commit summary: Title blacklist: * (bug 22141) Introduce a separate user right for overriding title blacklist on account creations only * Some minor refactorings Comment: Was the $user parameter to TitleBlacklist::userCannot() meant to be used for something? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Stage 1 of the 1.18 deployment done
Hi everyone, Stage 1 of the MediaWiki 1.18 deployment is complete. We've deployed to the following wikis: * he.wikisource.org * mediawiki.org * simple.wikipedia.org * simple.wiktionary.org * strategy.wikimedia.org * usability.wikimedia.org The deployment had a few bumps (mainly problems with LiquidThreads, which we reverted to 1.17), but mostly went well. We started late due to getting a last-minute adjustment to the Resource Loader/Het Deploy compatibility fix in. You can see some of the last minute changes we made here: http://www.mediawiki.org/w/index.php?path=branches%2Fwmf%2F1.18wmf1title=Special%3ACode%2FMediaWiki ...as well as logs of major changes to the cluster last night here: http://wikitech.wikimedia.org/view/Server_admin_log Thanks to all involved! Next step is Stage 2 on Monday. More details about the 1.18 deployment generally are here: http://blog.wikimedia.org/2011/09/16/mediawiki118iscomin/ Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97795]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97795. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97795 Commit summary: Fixed User::getGroups(), apparently broken since r3. User::load() doesn't load groups anymore, so calling $this-getGroups() was the same as just accessing $this-mGroups. Usually it doesn't matter, since most factory functions are funnelled into loadFromId() which calls loadGroups() or loads the groups from the cache, but loadFromRow() was potentially broken. It's necessary for User::loadFromRow() to set $this-mGroups to null, same as the calling code in User::loadFromDatabase(), so that they will be loaded dynamically when User::newFromRow() is called. No bugs found that are caused by this but it couldn't hurt to have working accessors. Tested from eval.php. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97796]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97796. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97796 Commit summary: Add another hook parameter and extensive documentation to CentralAuthAutoCreate in an attempt to avoid a repeat of the half-initialised User issues as fixed by r97794. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97797]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97797. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97797 Commit summary: Remove unused global added during testing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97794]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97794. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97794 Commit summary: Fix for r76344: you can't access $wgUser during the CentralAuthAutoCreate hook, because it's the same object that invoked CentralAuth via UserLoadFromSession, after mLoadedItems is set to true but before any data is initialised. The calling code in CentralAuth does permissions checks correctly, by creating a new User object for the anonymous user who is logging in. That's what I've implemented here too. Most of the changes here are just propagating the anonymous user object through the call stack. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94951]: New comment added
User Krinkle posted a comment on MediaWiki.r94951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#c22986 Commit summary: new method to parse chunk delimiters Their format is a one liner: @@ -l,s +l,s @@ See http://en.wikipedia.org/wiki/Diff#Unified_format Comment: The server in question is indeed running Windows. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97798]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97798. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97798 Commit summary: MFT r97794, r97797: Fixed TitleBlacklist which was causing Invalid argument supplied for foreach() when automatic account creation was attempted on a 1.18 wiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97578]: New comment added, and revision status changed
User Wikinaut changed the status of MediaWiki.r97578.
Old Status: fixme
New Status: new
User Wikinaut also posted a comment on MediaWiki.r97578.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97578#c22987
Commit summary:
follow up to r97566 - adding message documentation for new message texts
(identical to two prefs- texts)
Comment:
fixed in r97799 !
* 'openidoptional' = '{{Identical|Optional}}',
* 'openidrequired' = '{{Identical|Required}}',
* 'openidemail' = '{{Identical|E-mail address}}',
* 'openidlanguage' = '{{Identical|Language}}',
* 'openidtimezone' = '{{Identical|Time zone}}',
* 'openidchoosepassword' = '{{Identical|Password}}',
* 'openiddelete-button' = '{{Identical|Confirm}}',
* 'openid-urls-action' = '{{Identical|Action}}',
* openid-urls-registration' = '{{Identical|prefs-registration}}',
* openid-urls-registration-date-time' =
'{{Identical|prefs-registration-date-time}}',
I changed s/Indentical/msg-mw/ in _all_ messages of OpenID extension see r97799
.
Please can you (Nikerabbit) document the differences in use between
* nowiki{{Identical|this}}/nowiki and
* nowikimsg-mw/nowiki
on the MediaWiki page
* http://www.mediawiki.org/wiki/Translatewiki.net and
* http://www.mediawiki.org/wiki/Localisation
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97578]: New comment added
User Wikinaut posted a comment on MediaWiki.r97578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97578#c22988 Commit summary: follow up to r97566 - adding message documentation for new message texts (identical to two prefs- texts) Comment: See here http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/OpenID/OpenID.i18n.php?pathrev=97799r1=97798r2=97799 all changes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97799]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97799.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97799#c22989
Commit summary:
fixes and follow up to r97578 . fixes message texts which are used in in same
way as some other message This message is used in the same way as
\{\{msg-mw\|some message key\}\}
Comment:
Now you did too much, the Identical template should stay on messages which it
existed before. If you want you can add additional note to them.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97799]: New comment added
User Wikinaut posted a comment on MediaWiki.r97799.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97799#c22990
Commit summary:
fixes and follow up to r97578 . fixes message texts which are used in in same
way as some other message This message is used in the same way as
\{\{msg-mw\|some message key\}\}
Comment:
Can _you_ please change it like you would have expected me to change it? Then I
know exactly how it should look like. Please.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95260]: New comment added, and revision status changed
User ArielGlenn changed the status of MediaWiki.r95260. Old Status: fixme New Status: new User ArielGlenn also posted a comment on MediaWiki.r95260. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95260#c22991 Commit summary: add functions that support close and rename of output files as they are being written, used to write out checkpoint files at regular intervals during XML dump production Comment: Ugh, I meant that to get removed, not committed. Fixed in r97800. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97799]: Revision status changed
User Raymond changed the status of MediaWiki.r97799.
Old Status: new
New Status: reverted
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97799
Commit summary:
fixes and follow up to r97578 . fixes message texts which are used in in same
way as some other message This message is used in the same way as
\{\{msg-mw\|some message key\}\}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97791]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r97791. Old Status: deferred New Status: fixme User Raymond also posted a comment on MediaWiki.r97791. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97791#c22992 Commit summary: Added check of Page Schemas form declaration to getDefaultFormsForPage() Comment: PHP Fatal error: Class 'PSSchema' not found in /www/w/extensions/SemanticForms/includes/SF_FormLinker.php on line 315 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97799]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97799.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97799#c22993
Commit summary:
fixes and follow up to r97578 . fixes message texts which are used in in same
way as some other message This message is used in the same way as
\{\{msg-mw\|some message key\}\}
Comment:
In a moment.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97744]: Revision status changed
User Reedy changed the status of MediaWiki.r97744. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97744 Commit summary: Comment out unreachable code Remove unreachable return false; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97799]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97799.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97799#c22994
Commit summary:
fixes and follow up to r97578 . fixes message texts which are used in in same
way as some other message This message is used in the same way as
\{\{msg-mw\|some message key\}\}
Comment:
Done in twn. See next language commit.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97578]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97578. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97578 Commit summary: follow up to r97566 - adding message documentation for new message texts (identical to two prefs- texts) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94627]: New comment added
User BotInc posted a comment on MediaWiki.r94627. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94627#c22995 Commit summary: Add FormData upload transport. If enabled this is used in Browsers that support FormData. Larger files are uploaded in chunks. Comment: * using $j.parseJSON might be better, but are there Browsers where FromData works but JSON does not? * geckoFormData was written by me before for another site. To make the code simpler and better maintainable in the future, geckoFormData can also be taken out since Firefox 7 will be released next week and its only required for older versions of Firefox. * wait could be renamed, not sure chunksRemaining is a better name right now, it is needed since FileReader is async in appendBlob and the xhr can only be send once all FileReaders are done. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97791]: New comment added
User Yaron Koren posted a comment on MediaWiki.r97791. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97791#c22996 Commit summary: Added check of Page Schemas form declaration to getDefaultFormsForPage() Comment: Oops! Thanks for testing that, and pointing out the bug. This is now fixed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97791]: Revision status changed
User Raymond changed the status of MediaWiki.r97791. Old Status: fixme New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97791 Commit summary: Added check of Page Schemas form declaration to getDefaultFormsForPage() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Conflict with extension developers in reservation of custom namespaces
On 11-09-22 01:13 AM, Michael Allan wrote: Hello to all, I'm posting to request help with a conflict in namespace registration: http://www.mediawiki.org/wiki/Extension_default_namespaces?oldid=430890 Wiki admins are looking for a safe range of namespaces to use for custom, site-specific purposes. A little over a year ago, we floated the range 500-599 on the registration talk page. There were no objections, so, a couple of months ago we reserved the range and amended the manual. You can see the discussion in section 4: http://www.mediawiki.org/wiki/Talk:Extension_namespace_registration?oldid=436566 It turns out that an extension had already been using that range. Apparently the developer forgot to register it (see section 5, above). I guess he spoke to someone else, because just yesterday: * The namespace registration system was replaced with a default system and the page was moved: http://www.mediawiki.org/wiki/Extension_default_namespaces * The range 500-599 is no longer marked as reserved in the same manner as the extensions are marked. * A Liquid Threads extension was enabled on the talk page. (I mention this because it fails on my Firefox 3.6, so I can't use the talk page anymore.) I guess the issue isn't open for discussion there, anyway. Please someone else take a thought for the needs of the admins, and: 1. Pick a range to reserve for site-specific use. A whole block of 100 would be ideal, if that's possible. 2. Clearly mark the range as reserved, in the same manner as the extension ranges are marked. For example: http://www.mediawiki.org/wiki/Extension_default_namespaces?oldid=430890#Site-specific 3. Update the manual to reflect these changes: http://www.mediawiki.org/wiki/Manual:Using_custom_namespaces The extension developer (the one who forgot to register his namespace) says this is a silly request, but I think it's quite reasonable. PS - Could someone also add a link to this thread from the talk page? I am no longer able to post there. http://www.mediawiki.org/wiki/Talk:Extension_default_namespaces Please include wikitech-l in this discussion. Not every developer watches mediawiki-l because it's more of a help list, wikitech-l is our mailing list for development discussion. Jack is not the author of the BlogPage extension. BlogPage is an extension developed for ArmchairGM, Jack has kindly been porting ArmchairGM and Wikia built extensions to be installable in normal MediaWiki. Naturally as he recently ported the BlogPage code that was in an external code repo and put it in our code repo for everyone to use, he went and responsibly added the namespaces that the extension has been using since it was developed (presumably sometime back in 2007) to that page so people would know. There were no 'objections' because practically no-one even knew that discussion existed. That's like walking into a forest, shouting out I am now king of North America, then walking back into a city and asserting that because no-one objected you're now king. ArmchairGM was founded in 2005, bought by Wikia in 2006, and their code was released in early-mid 2008. That page on MW.org however never existed before mid-2008. So not only is the concept of forcing 3rd party companies to abide by and add information to a wiki page we have on MW.org ridiculous, that page never even existed when BlogPage was developed. The sentiment that the site-specific reservation added is silly seams to be shared by Jack, ^demon, and me at the least. For the record, all three of us are core developers. That page does NOT list reservations or registrations. It is nothing but a helpful informational page that lists default namespaces currently used by existing extensions and other known practices. The only purpose being so that developers of new extensions who want to try and avoid conflicting with namespaces other people may already be using can do so by avoiding any area of namespace numbers that people are already using. The page itself even lists two extensions using 600-601. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97784]: New comment added
User Peachey88 posted a comment on MediaWiki.r97784. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97784#c22997 Commit summary: Added back xml::hidden wrapper, used by LQT Comment: Just a note for those looking later: This was so the 1.17wmf branch of LQT could work on 1.18 (since the DB schema changes for it weren't done) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97778]: New comment added
User SPQRobin posted a comment on MediaWiki.r97778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97778#c22998 Commit summary: * Changing static page to dynamic result according to the given URL. ** Non-existing language subdomains of Wikipedia, Wiktionary, Wikiquote, Wikibooks and Wikinews now redirect to the appropriate page on Wikimedia Incubator. ** Non-existing language subdomains of Wikisource and Wikiversity return customized 404 page. Comment: Yay! I hope this can be deployed soon :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97328]: New comment added
User Reedy posted a comment on MediaWiki.r97328.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97328#c22999
Commit summary:
Noticed in apache error logs (see below). If the length of the message is
longer than the maximum length, only send what will fit
Sep 16 20:07:28 10.0.2.193 apache2[28441]: PHP Warning: socket_sendto() [a
href='function.socket-sendto'function.socket-sendto/a]: unable to write to
socket [90]: Message too long in
/home/wikipedia/common/php-1.17-test/includes/GlobalFunctions.php on line 464
Sep 16 20:07:29 10.0.2.193 apache2[26511]: PHP Warning: socket_sendto() [a
href='function.socket-sendto'function.socket-sendto/a]: unable to write to
socket [90]: Message too long in
/home/wikipedia/common/php-1.17-test/includes/GlobalFunctions.php on line 464
Comment:
Looking at the PHP documentation for this [1]
SO_SNDBUF is Reports the size of the send buffer., which seemingly is what we
want.
Reading it and the documentation would lead you to believe SOL_UDP is valid,
but does a poor job of listing other correct values
The constants [2] show SOL_DUP along with a huge host of other values.
SOCK_DGRAM would be correct for UDP, but pushing that as the middle parameter
to socket_get_option() gives unable to retrieve socket option [95]
It could be hardcoded at 64KB (65,536) using the length in bytes per Krinkle
above (rather thant he string length)... It just seems like there should be a
better way to do it
Having said that, I've just noticed above
pre
// Clean it up for the multiplexer
if ( strval( $prefix ) !== '' ) {
$text = preg_replace( '/^/m', $prefix . ' ', $text );
// Limit to 64KB
if ( strlen( $text ) 65534 ) {
$text = substr( $text, 0, 65534 );
}
if ( substr( $text, -1 ) != \n ) {
$text .= \n;
}
} elseif ( strlen( $text ) 65535 ) {
$text = substr( $text, 0, 65535 );
}
/pre
In theory, the larger packet condition shouldn't occur, bar, that is using
strlen also, not string byte length..
Removing the code I added, and then just changing both to do the length by the
byte length..
[1] http://php.net/manual/en/function.socket-get-option.php
[2] http://www.php.net/manual/en/sockets.constants.php
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97781]: New comment added
User Reedy posted a comment on MediaWiki.r97781. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97781#c23000 Commit summary: Removing LQT, will copy new one from unbroken 1.17wmf1 branch Comment: What was broken about it? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97781]: New comment added
User Peachey88 posted a comment on MediaWiki.r97781. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97781#c23001 Commit summary: Removing LQT, will copy new one from unbroken 1.17wmf1 branch Comment: Needs a schema change ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92528]: Revision status changed
User Reedy changed the status of MediaWiki.r92528. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92528 Commit summary: (bug 19838) API does not use interwiki cache. Patch by Beau; modified to work with current code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97804]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97804. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97804 Commit summary: Add number grouping pattern. Ref Bug 29495. Ml and Hi added in r97793 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97807]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97807.
Old Status: new
New Status: ok
User Nikerabbit also posted a comment on MediaWiki.r97807.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97807#c23002
Commit summary:
Fix mixed tabs and spaces from r97793
Couple of minor style tweaks also
Comment:
Thanks, I was going to do this too. One space could still be added between ){.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97807]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r97807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97807#c23003 Commit summary: Fix mixed tabs and spaces from r97793 Couple of minor style tweaks also Comment: Whitespaces corrected in r97809 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97782]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r97782. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97782#c23004 Commit summary: Copied in working 1.17wmf1 version of LQT Comment: please tag this an other LQT fixes for 1.18 as well, thanks! 1.18 (non-wmf) needs a working LQT, going back to unbroken 1.17wmf is ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97784]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r97784. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97784#c23005 Commit summary: Added back xml::hidden wrapper, used by LQT Comment: please tag for 1.18 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97784]: New comment added
User Peachey88 posted a comment on MediaWiki.r97784. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97784#c23006 Commit summary: Added back xml::hidden wrapper, used by LQT Comment: This isn't need for 1.18, They can run the 1.18 branch of LQT, the reason its not on the wmf cluster is the db schema hasn't been updated yet. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97810]: New comment added
User Reedy posted a comment on MediaWiki.r97810. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97810#c23007 Commit summary: * (bug 31081) $wgEnotifUseJobQ causes many unnecessary jobs to be queued Do some of the cheap checks before spawning attempting to send emails via any method Comment: Makes sense to push this into 1.18wmf1, might be useful to push into 1.18 anyway... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97726]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r97726. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97726#c23008 Commit summary: If babel-portal is empty, don't make a link. Made it empty by default. Comment: please tag for 1.18, thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r72707]: Revision status changed
User Reedy changed the status of MediaWiki.r72707. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72707 Commit summary: More or less rewrote Special:NewMessages. Only user-visible change is that it is now paged. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97686]: New comment added
User Bawolff posted a comment on MediaWiki.r97686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97686#c23009 Commit summary: Make per page edit notices work in namespaces without subpages enabled. Comment: Whoops didn't realize it's been previously implemented and reverted. Personally I think it is really weird that this is ok for non-subpaged namespaces, but not for subpage namespaces. Is this ok, or should it be reverted? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97809]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97809. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97809 Commit summary: stylize.php - minor whitespace fixes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97726]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97726. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97726#c23010 Commit summary: If babel-portal is empty, don't make a link. Made it empty by default. Comment: Why? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97606]: Revision status changed
User Reedy changed the status of MediaWiki.r97606. Old Status: deferred New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97606 Commit summary: Narayam: Blank keybuffer was matching against rules that require keybuffer match. Fixed now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92279]: New comment added
User Bawolff posted a comment on MediaWiki.r92279. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92279#c23011 Commit summary: (bug 28762) Resizing to specified height broken for very thin images Restructure and comment of ImageHandler::normaliseParams(). ImageHandler::normaliseParams() will now output both width/height as physicalWidth/Height, where width/height are the dimensions used by the browser, and physicalWidth/Height are the dimensions of the thumbnail that will be created. This allows keeping the use of unique dimensions for a specified thumbnail width, by forcing client side resizing of 1px-wide images with non corresponding height. Also fixed a bug where the check for mustRender() was in an if statement where it should not have been. Comment: If you're marking this fixme on account of the mustRender check move, that has already been fixed by a follow-up. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92279]: New comment added
User Bryan posted a comment on MediaWiki.r92279. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92279#c23012 Commit summary: (bug 28762) Resizing to specified height broken for very thin images Restructure and comment of ImageHandler::normaliseParams(). ImageHandler::normaliseParams() will now output both width/height as physicalWidth/Height, where width/height are the dimensions used by the browser, and physicalWidth/Height are the dimensions of the thumbnail that will be created. This allows keeping the use of unique dimensions for a specified thumbnail width, by forcing client side resizing of 1px-wide images with non corresponding height. Also fixed a bug where the check for mustRender() was in an if statement where it should not have been. Comment: Oops ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97784]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r97784. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97784#c23013 Commit summary: Added back xml::hidden wrapper, used by LQT Comment: If WMF plans to revert these changes and also upgrade to LQT 1.18, thus truly testing it, that is fine. Else I believe most users would prefer to have a tested, working version. We would like to start using LQT, which was impossible in the 1.17 release, and I have doubts how well tested the 1.18 version is. I fear the WMF version may be the only truly tested version of LQT. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97726]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r97726. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97726#c23014 Commit summary: If babel-portal is empty, don't make a link. Made it empty by default. Comment: I suggest it to provide a working version for 1.18 users outside WMF as well. If it is a bug to WMF, then it also affects other wiki farms. Leave it if I am wrong and don't understand it enough. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97784]: New comment added
User Reedy posted a comment on MediaWiki.r97784. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97784#c23015 Commit summary: Added back xml::hidden wrapper, used by LQT Comment: This is because for 1.17wmf1 we were still using the version of LQT from 1.16wmf4 For 1.18wmf1, I had it branch from REL1_18, but as now transpired, that was missing some schema updates from September 2010 (months before 1.17wmf1), so hence REL1_18 LQT breaking on the site. This was then reverted back to the old version (ie from 1.16wmf4), which also doesn't work due to edit.js being missing, per bug 31087 I've fixed the schema patch in r97811 and tagged that for 1.18 backport When the appropriate operations staff are available later today, I shall speak about getting the necessary index updates done, and the newer version of LQT to be pushed out to WMF sites ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93758]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r93758.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93758#c23016
Commit summary:
* (bug 15558) Allow includable special pages to be parameterized using wiki
syntax
* Changed SpecialPageFactory::capturePath() to take the same parameters as
SpecialPageFactory::executePath() (except the last one) and made it always
return a bool instead of bool-or-string. The result HTML can be fetched from
the OutputPage object of the context.
* Added module styles, scritps and messages members to ParserOutput in addition
to modules. The first one is needed to display Special:RecentChanges correctly
when transcluded since EnhancedChangesList::beginRecentChangesList() calls
addModuleStyles( 'mediawiki.special.changeslist' )
Yes, this means that you can use {{Special:Recentchanges|enhanced=0}} to use
the old changes list. For the ones that wonder,
{{Special:Recentchanges|uselang=something}} will not work since the Language
object is forced to the one used by the parser.
Comment:
Should the partial changes made to 1.18wmf also be applied to 1.18? Tag for
1.18?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97726]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97726. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97726#c23017 Commit summary: If babel-portal is empty, don't make a link. Made it empty by default. Comment: Babel in 1.18 might be so different it might not be worth it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97682]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r97682. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97682#c23018 Commit summary: fix for bug 31049 - Disable mobile site link Comment: Should this also be tagged for 1.18? Is in trunk and has been applied by preilly to 1.18wmf. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97556]: New comment added
User G.Hagedorn posted a comment on MediaWiki.r97556. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97556#c23019 Commit summary: fix for Bug 30985 - Mobile header expanding and menu do not work until page loads Comment: Can/should this be tagged for 1.18 as well? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97403]: New comment added
User Bawolff posted a comment on MediaWiki.r97403. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97403#c23020 Commit summary: (bug 18424) Clean up paging links on Special:allpages and special:prefixindex. *Make them normal font size (my eyes! my eyes! with the tiny writing) *Special:prefindex needs a paging link on the bottom like special:allpages (added a class name here, because I couldn't use the existing id on both) *special:prefindex was doing $wgLang-pipeList( full html table here, next link here ) which was giving bad output for the obvious reason. Comment: I'm tagging this 1.18 and 1.18wmf1 on the basis of the extra | by the paging links in things like [http://www.mediawiki.org/w/index.php?title=Special%3APrefixIndexprefix=%24namespace=100] (regression in 1.18) which this fixes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97606]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97606. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97606#c23021 Commit summary: Narayam: Blank keybuffer was matching against rules that require keybuffer match. Fixed now. Comment: Test cases would be nice. As it is I can't understand what the code is doing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97786]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97786. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97786 Commit summary: stylize.php changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86255]: New comment added, and revision status changed
User Bawolff changed the status of MediaWiki.r86255. Old Status: resolved New Status: fixme User Bawolff also posted a comment on MediaWiki.r86255. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86255#c23022 Commit summary: Refactor the factory/i18n/list/etc static methods from SpecialPage into their own class; there's no reason we need to be parsing them in every single SpecialPage subclass. Leave all the methods as stubs in SpecialPage.php; if we required PHP 5.3 they could be replaced by a a __callStatic() magic method, but that doesn't work on PHP 5.2. Also make a few changes to the functions available. SpecialPageFactory::resolveAlias() now takes an optional subpage and returns array(name,subpage). Similarly merge getPage() and getPageByAlias(). There were many examples of (extensions particularly) making dubious assumptions about the presence or absence of subpages or canonical-ness. I didn't deprecate SpecialPage::getTitleFor() as it's got over six hundred calls. I'm rather undecided on the best position of getPage()/executePath(). Although the latter needs cleanup anyway. Comment: This causes a very minor regression in 1.18 (noticed by Jack Phoenix on irc). If you have a link a line in mediawiki:sidebar like: pre Special:Code/MediaWiki|Look at MediaWiki codebase /pre before it would link to [[Special:Code/MediaWiki]] where now it links to [[Special:Code]]. (Same for all special pages, however subpages are preserved for normal links) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97822]: New comment added
User Raymond posted a comment on MediaWiki.r97822. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97822#c23023 Commit summary: FU r97819: Move commented out message to the end of the 'en' section. It seems sync-groups.php of Tranlate is confused about it and ignores further messages until a new language section begins Comment: Wrong try. sync-groups.php still ignores message. Must be another error in the i18n file :-( ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97819]: New comment added
User Nicmavr posted a comment on MediaWiki.r97819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97819#c23024 Commit summary: Some message tweaks, Add extension per r97061 to translatewiki.net Comment: pre + 'linkfilter-home-title' = '$1 links', + 'linkfilter-home-title-all' = 'All kinks', /pre Kinks? Looks like a typo to me. pre - 'linkfilter-new-links-title' = 'New Links', + 'linkfilter-popular-articles' = 'Do not miss', + 'linkfilter-new-links-title' = 'New links', /pre I think Don't miss would be more appropriate for this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97817]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97817. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97817 Commit summary: Guard against PHP fatal error in /home/wikipedia/common/php-1.18/includes/Linker.php line 831: Argument 1 passed to Linker::makeMediaLinkObj() must be an instance of Title, null given, called in /home/wikipedia/common/php-1.18/includes/Linker.php on line 1221 and defined ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97818]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97818. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97818 Commit summary: 1.18wmf1 MFT r97817 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97810]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r97810. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97810#c23025 Commit summary: * (bug 31081) $wgEnotifUseJobQ causes many unnecessary jobs to be queued Do some of the cheap checks before spawning attempting to send emails via any method Comment: Why are you checking $editor-isAllowed( 'nominornewtalk' ) but not whether it it a talk page edit? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97823]: New comment added
User Siebrand posted a comment on MediaWiki.r97823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97823#c23026 Commit summary: Fix hook location Comment: Looks like you accidentally reverted the versiOn date. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97823]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97823#c23027 Commit summary: Fix hook location Comment: Yes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97776]: New comment added, and revision status changed
User Awjrichards changed the status of MediaWiki.r97776. Old Status: new New Status: fixme User Awjrichards also posted a comment on MediaWiki.r97776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97776#c23028 Commit summary: Adding webitects form for this week as well as a few changes to RapidHTML Comment: The field name 'currency' gets used in multiple places throughout here - it should be 'currency_code'. This is what is expected by DonationInterface. In the form, I see you are creating hidden fields for both 'currency' and 'currency_code', but only 'currency' is getting posted at form submission, likely due to the Javascript magic at the end of the form file. Also, with RapidHtml forms, the PayPal redirect needs to be handled differently than with the landing pages: pre +// set the action to go to PayPal + /** +** TODO: FIX ME ** (Broken on return to form from PP and then choose CC) +**/ + $(input[name=gateway]).val(paypal); + document.paypalcontribution.action = https://wikimediafoundation.org/wiki/Special:ContributionTracking/en;; + $(#loading).html(img src='../images/loading.gif' / Redirecting to PayPal…); + document.paypalcontribution.submit(); + } + }); /pre iirc, the PayPal redirect should happen via DonationInterface to ensure tracking data is properly set. the 'PaypalRedirect' should get set to true and posted back to DonationInterface, which should take care of the rest. Also, you seem to have changed from tabs - spaces in RapidHtml.php, which I believe is why the diff is showing that the entire file changed. Besides being counter to MediaWiki convention (http://www.mediawiki.org/wiki/Coding_conventions#File_formatting), this means I cannot easily code review this file. Please fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97829]: New comment added
User SPQRobin posted a comment on MediaWiki.r97829. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97829#c23029 Commit summary: * + XHTML necessities accidentally lost in r97778 Comment: Maybe we can do just codenowiki!DOCTYPE html/nowiki/code like it is in HTML5? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97830]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r97830. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97830#c23030 Commit summary: Copy SideBarTest from trunk for bug 3110 Comment: Wrong bug number? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97830]: New comment added
User Reedy posted a comment on MediaWiki.r97830. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97830#c23031 Commit summary: Copy SideBarTest from trunk for bug 3110 Comment: Yup, bug 31100 pre reedy@ubuntu64-esxi:~/mediawiki/branches/REL1_18/phase3/tests/phpunit$ php phpunit.php skins/SideBarTest.php PHPUnit 3.5.15 by Sebastian Bergmann. .. Time: 0 seconds, Memory: 29.50Mb OK (6 tests, 11 assertions) /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97810]: New comment added
User Reedy posted a comment on MediaWiki.r97810. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97810#c23032 Commit summary: * (bug 31081) $wgEnotifUseJobQ causes many unnecessary jobs to be queued Do some of the cheap checks before spawning attempting to send emails via any method Comment: Seems I've eaten an option in the top version pre - } elseif ( $targetUser-getOption( 'enotifusertalkpages' ) /pre Also, that's how it was in the original code... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97658]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r97658. Old Status: new New Status: fixme User Aaron Schulz also posted a comment on MediaWiki.r97658. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97658#c23033 Commit summary: * Made IndexPager extend ContextSource * Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables * Call Linker methods statically * Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser() Comment: Notice: Undefined property: UsersPager::$creationSort in D:\www\MW_trunk\phase3\includes\specials\SpecialListusers.php on line i70/i Parent constructor is also called twice. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97776]: Revision status changed
User Awjrichards changed the status of MediaWiki.r97776. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97776 Commit summary: Adding webitects form for this week as well as a few changes to RapidHTML ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97819]: New comment added, and revision status changed
User Jack Phoenix changed the status of MediaWiki.r97819. Old Status: new New Status: fixme User Jack Phoenix also posted a comment on MediaWiki.r97819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97819#c23034 Commit summary: Some message tweaks, Add extension per r97061 to translatewiki.net Comment: Marking as FIXME as per Nicmavr's comment above. +1 for Don't miss, too — it's not grammatically incorrect and looks better IMO. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97820]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r97820. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97820#c23035 Commit summary: FU r97819/r97061: Add missing messaga 'grouppage-linkadmin' Comment: I actually left that message out on purpose back then; I figured that if someone wants to create such a page, they most likely will know about the MediaWiki:Grouppage-* messages, but adding it by default just creates yet another redlink on Special:ListGroupRights, Special:ListUsers and Special:Preferences. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97831]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r97831. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97831#c23036 Commit summary: Fix some i18n and L10n issues. Comment: I'm not seeing the point of this. It seems that this change adds complexity to the code without actually being useful. [[MediaWiki|What's wrong with ordinary links?]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97821]: Revision status changed
User MarkAHershberger changed the status of MediaWiki.r97821. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97821 Commit summary: Parser test for bug 31098, disabled of course ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97820]: New comment added
User Raymond posted a comment on MediaWiki.r97820. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97820#c23037 Commit summary: FU r97819/r97061: Add missing messaga 'grouppage-linkadmin' Comment: Yes, but consistency is important, IMO. We have this message for all groups, IIRC, why not for this? Does not make sense. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97810]: New comment added
User Reedy posted a comment on MediaWiki.r97810. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97810#c23038 Commit summary: * (bug 31081) $wgEnotifUseJobQ causes many unnecessary jobs to be queued Do some of the cheap checks before spawning attempting to send emails via any method Comment: Ignore my first comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97831]: New comment added
User Siebrand posted a comment on MediaWiki.r97831. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97831#c23039 Commit summary: Fix some i18n and L10n issues. Comment: This ensures that users on a wiki are sent to a single page unrelated to their user language. Translators will (and should) be able to localise page names, which would lead to red links even though there might not be a need to display red links. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97765]: Revision status changed
User ^demon changed the status of MediaWiki.r97765. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97765 Commit summary: Made trimCache() protected ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97527]: Revision status changed
User ^demon changed the status of MediaWiki.r97527. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97527 Commit summary: Put notes in host help about PostgreSQL via unix socket, as IP is not always enabled. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97658]: New comment added, and revision status changed
User IAlex changed the status of MediaWiki.r97658. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r97658. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97658#c23040 Commit summary: * Made IndexPager extend ContextSource * Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables * Call Linker methods statically * Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser() Comment: Fixed in r97839. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97327]: Revision status changed
User ^demon changed the status of MediaWiki.r97327. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97327 Commit summary: Removed useless check since the variable always exists and null would be catched by the second part ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97839]: Revision status changed
User ^demon changed the status of MediaWiki.r97839. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97839 Commit summary: Per Aaron, fix for r97658: removed double call to parent constructor that will also fix the E_NOTICE ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97800]: Revision status changed
User ^demon changed the status of MediaWiki.r97800. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97800 Commit summary: remove cruft that didn't all get cleaned up before commit in r95260, addressing fixme. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97762]: Revision status changed
User ^demon changed the status of MediaWiki.r97762. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97762 Commit summary: Added lock/unlock function stubs. Fixes: PHP fatal error in /usr/local/apache/common-local/php-1.18/includes/objectcache/MemcachedPhpBagOStuff.php line 91: Call to undefined method MemCachedClientforWiki::lock() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97601]: Revision status changed
User ^demon changed the status of MediaWiki.r97601. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97601 Commit summary: Fixing a bug in r97495 that Aaron catched. I misinterpreted the documentation for what 'valid' means. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97816]: Revision status changed
User ^demon changed the status of MediaWiki.r97816. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97816 Commit summary: Fix single character access ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97777]: Revision status changed
User ^demon changed the status of MediaWiki.r9. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/9 Commit summary: * (bug 29154) Allow upload-by-URL to follow HTTP redirects ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97774]: Revision status changed
User ^demon changed the status of MediaWiki.r97774. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97774 Commit summary: * (bug 30041) Fix installer cache selection field to keep the selected radio button, initialize the memcached server fold-out correctly when coming back to the page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97772]: Revision status changed
User ^demon changed the status of MediaWiki.r97772. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97772 Commit summary: * (bug 30041) Fix memcached validation in installer to accept resolvable hostnames 'localhost:11211' was rejected because 'localhost' isn't an IP address... however it's a perfectly legit host to connect to. :) Followup to r82687 which introduced the IP address check. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97103]: Revision status changed
User ^demon changed the status of MediaWiki.r97103. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97103 Commit summary: * (bug 30894) Add --output option to mwdocgen.php to override output directory Note that files go into the 'html' subdir of wherever you point. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97841]: Revision status changed
User Reedy changed the status of MediaWiki.r97841. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97841 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97837]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97837. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97837#c23041 Commit summary: Fix from within function CodeRevision::getComments. Database returned error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '! IS NULL ORDER BY cc_sortkey' at line 1 (localhost). Comment: Does '!= null' really work? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85131]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85131. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85131#c23042 Commit summary: Translate: check for bug 28152 (Special:Preferences explode if some messages are the same) Comment: We will definitely need something like this. However the check system is not really good for this. Besides, messages can also be customised in Mediawiki-namespace, and this will not prevent that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97844]: Revision status changed
User Siebrand changed the status of MediaWiki.r97844. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97844 Commit summary: Backing out r85131 for now. See CR for the reasons. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97819]: New comment added
User Siebrand posted a comment on MediaWiki.r97819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97819#c23044 Commit summary: Some message tweaks, Add extension per r97061 to translatewiki.net Comment: No message documentation present. This increases chances of incorrect translations, which is something we hope to avoid. Please add. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94951]: New comment added
User Hashar posted a comment on MediaWiki.r94951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#c23046 Commit summary: new method to parse chunk delimiters Their format is a one liner: @@ -l,s +l,s @@ See http://en.wikipedia.org/wiki/Diff#Unified_format Comment: I do not have a Windows install to reproduce the issue. Looks like the issue is caused by \n vs \r\n under Windows: explode( \n, $text ) which eans each line will probably still have a \r at the end. We need a wfIsWindows() call to handle the issue or we can call rtrim() on each line to sanitize it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97819]: New comment added
User SPQRobin posted a comment on MediaWiki.r97819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97819#c23045 Commit summary: Some message tweaks, Add extension per r97061 to translatewiki.net Comment: Typo fixed in r97845 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94951]: New comment added
User Hashar posted a comment on MediaWiki.r94951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94951#c23047 Commit summary: new method to parse chunk delimiters Their format is a one liner: @@ -l,s +l,s @@ See http://en.wikipedia.org/wiki/Diff#Unified_format Comment: Oh, and if that is the case, the issue comes from r41212 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95640]: Revision status changed
User Happy-melon changed the status of MediaWiki.r95640.
Old Status: fixme
New Status: new
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95640
Commit summary:
As suggested to me by email: very active members of a wiki community can end up
receiving hundreds of emails via Special:EmailUser, the majority of which will
end up with the boilerplate {{SITENAME}} email subject, making them hard to
distinguish. Pass the name of the user sending the email to the message, so
that it can be at least a little bit more unique.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97852]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97852. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97852 Commit summary: FU r95640: documentation for message change. Also replace a deprecated font element that my IDE complained about. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95640]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95640.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95640
Commit summary:
As suggested to me by email: very active members of a wiki community can end up
receiving hundreds of emails via Special:EmailUser, the majority of which will
end up with the boilerplate {{SITENAME}} email subject, making them hard to
distinguish. Pass the name of the user sending the email to the message, so
that it can be at least a little bit more unique.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
