User "BotInc" posted a comment on MediaWiki.r94627.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94627#c22995
Commit summary:

Add FormData upload transport.
If enabled this is used in Browsers that support FormData.
Larger files are uploaded in chunks.

Comment:

* using $j.parseJSON might be better, but are there Browsers where FromData 
works but JSON does not?
* geckoFormData was written by me before for another site. To make the code 
simpler and better maintainable in the future, geckoFormData can also be taken 
out since Firefox 7 will be released next week and its only required for older 
versions of Firefox.
* wait could be renamed, not sure chunksRemaining is a better name right now, 
it is needed since FileReader is async in appendBlob and the xhr can only be 
send once all FileReaders are done.


_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to