[MediaWiki-CodeReview] [MediaWiki r112065]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112065 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112065 Old status: new New status: ok Commit summary for MediaWiki.r112065: r112062: updated LogEntry publish() function too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112066]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112066 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112066 Old status: new New status: ok Commit summary for MediaWiki.r112066: Move parameters were backwards Ping r112061 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112070]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112070 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112070 Old status: new New status: ok Commit summary for MediaWiki.r112070: Made use of new getIRCActionComment() function so that comments are back in IRC lines. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112074]: New comment added
Nikerabbit posted a comment on MediaWiki.r112074. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112074#c31332 Commit summary for MediaWiki.r112074: Falling through to the floor is going to end in tears Ping r104236 Nikerabbit's comment: Classical. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112079]: New comment added
Nikerabbit posted a comment on MediaWiki.r112079. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112079#c31333 Commit summary for MediaWiki.r112079: * General log formatting fixes, like using the content language, for IRC feeds (works similar to LogPage::actionText). Use getPrefixedText() for the log title, not just the non-namespace part. * Made patrol log IRC code behave as it did pre-r97495. Nikerabbit's comment: wfMessage is the new thing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112082]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112082 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112082 Old status: new New status: ok Commit summary for MediaWiki.r112082: Minor fixes in Telugu transliteration based on the patch by Veeven in Bug 33480 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111991]: New comment added
Aaron Schulz posted a comment on MediaWiki.r111991. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111991#c31334 Commit summary for MediaWiki.r111991: Displaying the language name in the current user's language. Should work with cldr installed. Ping r111614. Aaron Schulz's comment: Needs a code comment or something. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112083]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r112083 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112083#c31335 Old Status: new New Status: ok Commit summary for MediaWiki.r112083: This script uses about 550MB of RAM on 1.19wmf1. Increase memory limit appropriately. Nikerabbit's comment: Wow. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111991]: New comment added
Nikerabbit posted a comment on MediaWiki.r111991. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111991#c31336 Commit summary for MediaWiki.r111991: Displaying the language name in the current user's language. Should work with cldr installed. Ping r111614. Nikerabbit's comment: Why? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111991]: New comment added
Aaron Schulz posted a comment on MediaWiki.r111991. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111991#c31337 Commit summary for MediaWiki.r111991: Displaying the language name in the current user's language. Should work with cldr installed. Ping r111614. Aaron Schulz's comment: Otherwise someone might have it go back to the way it was before, thinking it's better. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111991]: New comment added
Nikerabbit posted a comment on MediaWiki.r111991. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111991#c31338 Commit summary for MediaWiki.r111991: Displaying the language name in the current user's language. Should work with cldr installed. Ping r111614. Nikerabbit's comment: I don't think anybody would do that that way. Language::getLanguageNames is more likely and doesn't have that problem. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112059]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r112059 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112059#c31339 Old Status: deferred New Status: ok Commit summary for MediaWiki.r112059: activate sep parameter for result printers ul, ol Nikerabbit's comment: It works, thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Question: Hook:LinkEnd and Title::getNamespace method for internal page ( such as User or User_talk page ) where the target page does not exist
On 22 February 2012 08:28, Thomas Gries m...@tgries.de wrote:
Am 21.02.2012 23:57, schrieb Roan Kattouw:
I don't think so. Even non-existent Title object must have their
namespace set.
Yes, they have.
I have found the problem. It is not the Linker per se and come with a
modified question.
It has to do with i18n and localisation of the (in this case) names for
USER and USER_TALK Namespace.
Basically:
a link on a page like [[Benutzer:Alice]] is not necessarily the same as
[[User:Alice]] (even when the latter exists).
It depends on the current setting of
$wgLanguageCode = en ;
$wgLanguageCode = de ;
(during testing my extension I played with this setting)
whether [[Benutzer:Alice]] it is in the Namespace or not.
So I was trapped by thinking that _any_ localised Namespace (like
Benutzer) is necessarily the same as USER or USER_TALK,
which was incorrect.
Question:
===
Has anyone an idea, how to detect language-independently whether a link
on page is in Namespace USER or USER_TALK, or in a localised version of
these (when $wgLanguageCode has been modified)?
The goal is to detect and to mark USER or USER_TALK page links
language-independently in
function wfWikiArticleFeedsAddSignatureMarker in E:WikiArticleFeeds line
262 .
Tom
Well if this were an on-wiki template I would suggest you normalise the
namespace name to the localised canonical name using {{NAMESPACE:page}},
then compare it with a switch to the various similarly-normalised namespace
names: {{#switch: {{NAMESPACE:page}} | {{ns:2}} = it's a user page |
{{ns:3}} = it's a user talk page }}. Programatically you'd be able to
cut out a lot of circularity in that process, just have a look at what code
is used in the NAMESPACE: parser function and see what you can reuse.
Or, and I can't quite tell which you want from your comment, are you
looking to detect when a link uses a prefix which is a User: namespace
alias in *any* language, even when that prefix is not in use on the wiki?
Why would you want to do that?
--HM
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112097]: New comment added
Santhosh.thottingal posted a comment on MediaWiki.r112097. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112097#c31340 Commit summary for MediaWiki.r112097: EOT fonts with Microtype Express compression. Recreated using Google sfntly tool Santhosh.thottingal's comment: More info about this compression format: https://code.google.com/p/sfntly/wiki/MicroTypeExpress ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112091]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112091 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112091 Old status: new New status: ok Commit summary for MediaWiki.r112091: tests not throwing an exception are successes Ping r106113 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Git migration - instructions for Sysops
C == Chad innocentkil...@gmail.com writes: C Yes, we do plan to leave SVN up in read-only form for quite some C time after the changeover. Be aware that once we switch, changes C won't be merged back into the SVN. OK, my plan then is to do my weekly 'svn update's until I notice one day they don't update anything anymore. Whereupon I will look back at the notes in this thread and the latest official documentation on how to maintain a mediawiki site's updates via git. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New committer
Great Thanks! On Wed, Feb 22, 2012 at 8:16 AM, Alolita Sharma alolita.sha...@gmail.comwrote: Welcome Ashish! Look forward to some great work on Tweetiki and Visual Editor from you (w Trevor as mentor)! Best, Alolita On Tue, Feb 21, 2012 at 6:03 PM, Sumana Harihareswara suma...@wikimedia.org wrote: Ashish Dubey (ashishd, User:Dash1291) is author of Extension:Tweetiki and is working on bringing real-time collaborative editing to the visual editor. I just gave him extensions commit access. Welcome, Ashish! (Commit access queue review will be slower this week due to the deployments; my apologies.) -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Ashish Dubey ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New committer
On 02/22/2012 01:01 PM, Ashish Dubey wrote: Great Thanks! On Wed, Feb 22, 2012 at 8:16 AM, Alolita Sharmaalolita.sha...@gmail.comwrote: Welcome Ashish! Look forward to some great work on Tweetiki and Visual Editor from you (w Trevor as mentor)! Welcome from me too! Looking forward to work together on the node server running both the parser and collaboration stuff. Gabriel ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Patch submitted: authentication on Wikipedia via user_name OR user_email
Le 17 févr. 2012 à 14:28, Bergi a écrit :
Bináris schrieb:
An alternative solution to the original problem could be an extension that
displays possible characters from several alphabets and helps to generate
the username with mouse and put it back to the login name/password field.
I don't think that would be a good idea.
* It sounds as it would need JavaScript (or would be difficult to implement)
* clicking is much slower than typing
* possible characters from several alphabets? You know, we support the full
set of Unicode. Displaying all unicode blocks would need the user to remember
from which block his characters are
* One version of the problem is that you try to login from a system that
doesn't support your characters with any font. displaying characters is the
heavy task. If we don't want to show pictures, the user needs to remember the
individual character codes.
(or is there a usable all-unicode web font?)
Therefore, it is a great idea to login with your email address, which usually
consists of latin characters. I have that problem myself, beeing User:✓ (a
great challenge for toolserver tools ;-). Usually I have:
* My browsers autologin function which fills in the username at known wikis
* My browsers notice function which allows me to insert various texts with
the contextmenu
* Once logged in, I have a extraeditbutton above the edit form
* or can cp the sign from the #p-personal portlet (user page, user disk,
prefs...)
But when I try to login no at my home system, I'm challenged how to insert
the 0x2713 char code with the keyboard. At windows Alt + num pad usually
works, but... So I often end up googling for unicode checkmark, and cp the
character from wikipedias List of Unicode characters :-(
Thank you for your support. I just submitted a complete patch entitled Can't
authenticate using my mother language username (UNICODE) when I only have (a
public) access to Wikipedia with an ASCII (english) keyboard in about 20
languages on
https://bugzilla.wikimedia.org/show_bug.cgi?id=34590
People supporting this idea, please for it.
Here is the text:
This is a real issue for people who have registered with a username having
UNICODE and non ASCII (7 bits) characters and who want to login to Wikipedia
when they are abroad with a simple English keyboard and want to edit some pages
(usually English pages).
The fact that Wikipedia and Mediawikis do not offer the possibility to
authenticate with an e-mail is now considered, at least for me, as a bug.
I recently discussed this fact on Wikitech-l (Great idea
http://lists.wikimedia.org/pipermail/wikitech-l/2012-February/058183.html) and
some tests have been made trying to answer legitimate questions (see
http://lists.wikimedia.org/pipermail/wikitech-l/2012-February/058253.html) to a
simple patch that I proposed.
This small patch in User.php (function idFromName) is enough in most cases:
$dbr = wfGetDB( DB_SLAVE );
$s = $dbr-selectRow( 'user', array( 'user_id' ), array( 'user_name' =
$nt-getText() ), __METHOD__ );
if ( $s === false ) {
//Start Patch $result = null;
$stwo = $dbr-selectRow( 'user', array( 'user_id' ), array(
'user_email' = $nt-getText() ), __METHOD__ );
if ( $stwo === false ) {
$result = null;
}else {
$result = $stwo-user_id;
}
//End Patch
} else {
$result = $s-user_id;
}
The modified Login form is:
Username (or e-mail): |___|
Password: |___|
The full attached patch is rendering this new form in about 20 languages (that
is what we need in our wikis). The patch is simply adding two new msg:
- 'yournameoremail' instead of 'yourname' in Userlogin.php and
- 'passwordreset-usernameoremail' instead of 'passwordreset-username' in
SpecialPasswordReset.php .
In order to explain this new experimental feature, we added a Hook in
LocalSettings.php :
function efLoginFormMessage( $template ) {
$template-set( 'header', NEW (experimental): if you are a registered user
with an authenticated e-mail, you can also log in with your e-mail address in
place of your username. Your e-mail is used only during the authentication
phase; if successful you will be logged with your standard username. br
/Please notice that for people owning different accounts with the same e-mail,
you will be logged in with your first registered username (lowest ID). If the
password entered doesn't match the password of your lowest registered ID, you
can't authenticate this way and should enter your desired username.);
return true;
}
$wgHooks['UserLoginForm'][]='efLoginFormMessage';
I hope that this patch will be visited and accept. It is changing our live
here. People having been registered with accented characters or in Cyrillic can
use their e-mail to get their temporary password by e-mail while still being
able to sign authorship in
[MediaWiki-CodeReview] [MediaWiki r112100]: New comment added
Siebrand posted a comment on MediaWiki.r112100. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112100#c31341 Commit summary for MediaWiki.r112100: r112061: Add new message keys to maintenance files otherwise the next run of the translatewiki.net export script would kick them. But ignore them for translation per Nikerabbit: I don't want these messages to be translated. https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112061#c31329 Siebrand's comment: Maybe set these to ignored, as they're solely used for irc and will be removed again (hopefully someday soon?). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112100]: New comment added
Siebrand posted a comment on MediaWiki.r112100. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112100#c31342 Commit summary for MediaWiki.r112100: r112061: Add new message keys to maintenance files otherwise the next run of the translatewiki.net export script would kick them. But ignore them for translation per Nikerabbit: I don't want these messages to be translated. https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112061#c31329 Siebrand's comment: Oops. Should have read the complete commit message :). Excellent work. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Patch submitted: authentication on Wikipedia via user_name OR user_email
Great, thanks! What will this do if I have multiple user names on the same e-mail? What will this do if I have multiple user names on the same e-mail AND the same password? (For me it would be a good solution to choose the user with the smallest id.) -- Bináris ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112087]: Revision status changed
^demon changed the status of MediaWiki.r112087 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112087 Old status: new New status: resolved Commit summary for MediaWiki.r112087: * Add my USERINFO ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112084]: Revision status changed
^demon changed the status of MediaWiki.r112084 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112084 Old status: new New status: ok Commit summary for MediaWiki.r112084: MFT r112083: more memory ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112085]: Revision status changed
^demon changed the status of MediaWiki.r112085 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112085 Old status: new New status: ok Commit summary for MediaWiki.r112085: MFT r112083: more memory ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112089]: Revision status changed
^demon changed the status of MediaWiki.r112089 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112089 Old status: new New status: ok Commit summary for MediaWiki.r112089: Fix localisation file discovery (maintenance/mergeMessageFileList.php) broken by Contest ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112090]: Revision status changed
^demon changed the status of MediaWiki.r112090 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112090 Old status: new New status: ok Commit summary for MediaWiki.r112090: MFT r112089: fix mergeMessagesFileList.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112092]: Revision status changed
^demon changed the status of MediaWiki.r112092 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112092 Old status: new New status: ok Commit summary for MediaWiki.r112092: More fixes for mergeMessageFileList.php: * In CustomUserSignup, wrap the ClickTracking reference in a class_exists() block * In FlaggedRevs, include FlaggedRevsUI.setup.php manually instead of relying on $wgAutoloadClasses, and remove array type hinting from various setup functions, since the lack of any configuration globals causes them to give a fatal error otherwise * In ZeroRatedMobileAccess, use a static function for the hook instead of a nonstatic class member, both to fix mergeMessageFileList.php and for startup performance. Apparently the author does not know why we have *.body.php files. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112093]: Revision status changed
^demon changed the status of MediaWiki.r112093 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112093 Old status: new New status: ok Commit summary for MediaWiki.r112093: MFT r112092: mergeMessageFileList.php fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Patch submitted: authentication on Wikipedia via user_name OR user_email
On Wed, Feb 22, 2012 at 10:35 PM, Bináris wikipo...@gmail.com wrote: Great, thanks! What will this do if I have multiple user names on the same e-mail? What will this do if I have multiple user names on the same e-mail AND the same password? (For me it would be a good solution to choose the user with the smallest id.) It should reject it then request the username be entered, Not everyone would like it (if they were in that situation) to randomly log into their oldest account. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111933]: Revision status changed
Krinkle changed the status of MediaWiki.r111933 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111933 Old status: new New status: ok Commit summary for MediaWiki.r111933: MFT to 1.19wmf1 r111580 Bug 34397: align footer so that it doesn't overlap with sidebar in Simple skin ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111996]: Revision status changed
Preilly changed the status of MediaWiki.r111996 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111996 Old status: new New status: ok Commit summary for MediaWiki.r111996: move common table and .mwm-notice definitions into common stylesheets there are many definitions across all the stylesheets - these should just be in the common files beta_common and common ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111998]: Revision status changed
Preilly changed the status of MediaWiki.r111998 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111998 Old status: new New status: ok Commit summary for MediaWiki.r111998: move common css definitions into common files warning: several of these rules were not present in kindle.css or wii.css they looked pretty harmless but these could be checked in the rare case they produce any side effects ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112006]: Revision status changed
Preilly changed the status of MediaWiki.r112006 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112006 Old status: new New status: ok Commit summary for MediaWiki.r112006: Fix extra nested parse ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112013]: Revision status changed
Preilly changed the status of MediaWiki.r112013 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112013 Old status: new New status: ok Commit summary for MediaWiki.r112013: clean up css duplicate definitions warning: again many of these rules do not appear in wii.css and kindle.css ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112056]: New comment added
Preilly posted a comment on MediaWiki.r112056. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112056#c31343 Commit summary for MediaWiki.r112056: Added forward-compatibility with potential new wfIsConfiguredProxy function (introduced r111788) - this checks an IP against the list of configured squid proxies. This is preferred over wfIsTrustedProxy since wfIsTrustedProxy also runs a hook that gets used by an extension on the WMF cluster to check the IP against trusted open proxies as well as the configured squid proxies, which is not our desired behavior. Preilly's comment: You are missing a space around )) after 'wfIsConfiguredProxy'. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112056]: Revision status changed
Preilly changed the status of MediaWiki.r112056 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112056 Old status: new New status: fixme Commit summary for MediaWiki.r112056: Added forward-compatibility with potential new wfIsConfiguredProxy function (introduced r111788) - this checks an IP against the list of configured squid proxies. This is preferred over wfIsTrustedProxy since wfIsTrustedProxy also runs a hook that gets used by an extension on the WMF cluster to check the IP against trusted open proxies as well as the configured squid proxies, which is not our desired behavior. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112088]: Revision status changed
Preilly changed the status of MediaWiki.r112088 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112088 Old status: new New status: ok Commit summary for MediaWiki.r112088: Committing work in progress: prop=excerpt module. Ideally, it should be independent from MobileFrontend, but right now I'm just taking advantage of MobileFormatter. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112101]: Revision status changed
Preilly changed the status of MediaWiki.r112101 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112101 Old status: new New status: ok Commit summary for MediaWiki.r112101: jslint application and beta_application code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112102]: Revision status changed
Preilly changed the status of MediaWiki.r112102 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112102 Old status: new New status: ok Commit summary for MediaWiki.r112102: use utils to add class to body see r111651#c31083 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112103]: Revision status changed
Preilly changed the status of MediaWiki.r112103 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112103 Old status: new New status: ok Commit summary for MediaWiki.r112103: address bug r19935 applied slightly modified version of a9984 from ashwini use click handler rather than focus for this patch to work in Chrome ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112106]: Revision status changed
Preilly changed the status of MediaWiki.r112106 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112106 Old status: new New status: ok Commit summary for MediaWiki.r112106: remove redundant line for sizing results the results in beta mode are 100% width by default see #32175 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112107]: Revision status changed
Preilly changed the status of MediaWiki.r112107 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112107 Old status: new New status: ok Commit summary for MediaWiki.r112107: add test for highlighting potentially unsafe search input ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112108]: Revision status changed
Preilly changed the status of MediaWiki.r112108 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112108 Old status: new New status: ok Commit summary for MediaWiki.r112108: cleanup remove unused variable correct whitespace for function arguments ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112109]: Revision status changed
Preilly changed the status of MediaWiki.r112109 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112109 Old status: new New status: ok Commit summary for MediaWiki.r112109: Fix Catchable fatal error: Argument 2 passed to ApiParseExtender::onAPIGetParamDescription() must be an array, boolean given in /usr/local/apache/common-local/live-hom/extensions/MobileFrontend/ApiParseExtender.php on line 31 $desc can be an array ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112111]: Revision status changed
Preilly changed the status of MediaWiki.r112111 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112111 Old status: new New status: ok Commit summary for MediaWiki.r112111: Avoid undefined index notices ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112118]: Revision status changed
Preilly changed the status of MediaWiki.r112118 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112118 Old status: new New status: ok Commit summary for MediaWiki.r112118: abstract addEventListener IE 9 doesn't support addEventListener so it is useful to have a utility function to attach events going forward. Note discussion here: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112019 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112109]: New comment added
Reedy posted a comment on MediaWiki.r112109. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112109#c31344 Commit summary for MediaWiki.r112109: Fix Catchable fatal error: Argument 2 passed to ApiParseExtender::onAPIGetParamDescription() must be an array, boolean given in /usr/local/apache/common-local/live-hom/extensions/MobileFrontend/ApiParseExtender.php on line 31 $desc can be an array Reedy's comment: Rather, desc can be a bool or an array... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r98045]: New comment added, and revision status changed
MarkAHershberger changed the status of MediaWiki.r98045 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98045#c31345 Old Status: fixme New Status: new Commit summary for MediaWiki.r98045: Improve the accessibility of our jump-to functionality - Stop hiding with display: none;, this hides our jump links from modern screen readers and users with motor disabilities (ie: nowadays, pratically everyone they are intended to help). - Instead hide with an overflow that will make the links viable tab targets. This alone is enough to help screen reader users. - Add in a script that will show the jump-links area on-focus for motor-impared users who can still see who have js enabled (this can't be done with css unfortunately) MarkAHershberger's comment: I'm assuming r112034 is the fix for this. Change back to FIXME if I'm wrong. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] MediaWiki RC2UDP feature/bugfix frozen (aka irc recent changes feed)
Hi, Following recent events that unexpectatly broke many wiki bots monitoring wikis in real-time via the irc recent changes feed (powered by routing localized strings emitted by MediaWiki's rc2udp output to an IRC server), The feed is mostly used by bots which have hardcoded most enviromental variables, and had to do so since MediaWiki never offered a way to get this parse information dynamically from an API (i.e. to the i18n messages used and the meaning of the numbered replacement variables). To avoid future breakages or mass migration while a replacement[1] is already on the horizon, I think it's a good time as any to declare this feature as legacy and therefor feature and bugfix froozen until deprecated/superseeded by a more modern system[1]. Pretty much the only aspect that is still free to change (and always has) is the content of the i18n messages (e.g. it's totally fine if translatewiki commits a patch that changes [[MediaWiki:1movedto2/de]] from `verschob „[[$1]]“ nach „[[$2]]“` to `verschieb [[$1]] auf [[$2]]` (which would affect log comments of German content-langauge wikis such as in irc.wikimedia.org/#de.wikipedia).. as long as the message is still stored at message-key 1movedto2 and $1 is origin and $2 is target. Same goes for messages like MediaWiki:Revertpage, MediaWiki:Autosumm-blank and MediaWiki:Autosumm-replace. Which aren't log messages, but are used the same way (edit summary is parsed and action is determined). I hope we can soon start focussing on the new system [1], start elaborating on what the needs are, use cases, requirements and come up with a design specification and implementation. Related events: bug 34508[2], bug 30245[3]. -- Krinkle [1] https://www.mediawiki.org/wiki/Requests_for_comment/Structured_data_push_notification_support_for_recent_changes [2] https://bugzilla.wikimedia.org/show_bug.cgi?id=34508#c16 [3] https://bugzilla.wikimedia.org/show_bug.cgi?id=30245 [3] http://etherpad.wikimedia.org/IRCBot-Messages ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r98045]: New comment added, and revision status changed
Brion VIBBER changed the status of MediaWiki.r98045 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98045#c31346 Old Status: new New Status: resolved Commit summary for MediaWiki.r98045: Improve the accessibility of our jump-to functionality - Stop hiding with display: none;, this hides our jump links from modern screen readers and users with motor disabilities (ie: nowadays, pratically everyone they are intended to help). - Instead hide with an overflow that will make the links viable tab targets. This alone is enough to help screen reader users. - Add in a script that will show the jump-links area on-focus for motor-impared users who can still see who have js enabled (this can't be done with css unfortunately) Brion VIBBER's comment: Yep it's resolved. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112126]: Revision status changed
Jeroen De Dauw changed the status of MediaWiki.r112126 to fixme URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112126 Old status: new New status: fixme Commit summary for MediaWiki.r112126: quick fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112105]: Revision status changed
Nikerabbit changed the status of MediaWiki.r112105 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112105 Old status: new New status: ok Commit summary for MediaWiki.r112105: eol-style, ping r112087 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111556]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r111556 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111556#c31348 Old Status: fixme New Status: new Commit summary for MediaWiki.r111556: Committing my work in embedded translation editor. * Only exposed when translate-beta=1 is provided in the URL, or when double clicking messages * Please test functionally, feedback on the UI also welcome * The dialog editor should not be affected, other than translation suggestions are now loaded synchronously Nikerabbit's comment: All have been fixed in follow ups. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111997]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r111997 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111997#c31349 Old Status: fixme New Status: new Commit summary for MediaWiki.r111997: Committing this from git so that Siebrand can review it using CR tool. Nikerabbit's comment: Fixed in followups. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111556]: Revision status changed
Siebrand changed the status of MediaWiki.r111556 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111556 Old status: new New status: ok Commit summary for MediaWiki.r111556: Committing my work in embedded translation editor. * Only exposed when translate-beta=1 is provided in the URL, or when double clicking messages * Please test functionally, feedback on the UI also welcome * The dialog editor should not be affected, other than translation suggestions are now loaded synchronously ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111800]: New comment added
Werdna posted a comment on MediaWiki.r111800. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111800#c31350 Commit summary for MediaWiki.r111800: Add both size *and* size difference on history page per bug 34449 Werdna's comment: See the conversation on the bug. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112141]: Revision status changed
Siebrand changed the status of MediaWiki.r112141 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112141 Old status: new New status: ok Commit summary for MediaWiki.r112141: r112128: Add new message keys to maintenance files otherwise the next run of the translatewiki.net export script would kick them. But ignore them for translation per Nikerabbit: I don't want these messages to be translated. https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112061#c31329 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112143]: Revision status changed
Awjrichards changed the status of MediaWiki.r112143 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112143 Old status: new New status: ok Commit summary for MediaWiki.r112143: Quick change to update for minfraud's new server names. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111989]: New comment added
Krinkle posted a comment on MediaWiki.r111989.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111989#c31351
Commit summary for MediaWiki.r111989:
* (bug 34538) Fixed compatibility with
$wgResourceLoaderExperimentalAsyncLoading in some extensions.
* Tested AbuseFilter.
* Did not test ArticleCreationWorkflow, Configure, ContributionTracking,
FlaggedRevs, FundraiserPortal, InlineCategorizer, MarkAsHelpful, Math/Mathjax.
* Fixed a typo in a comment in LiveTranslate.
* Did not review extensions alphabetically after MoodBar.
Krinkle's comment:
I haven't tested any of this, but I see a few pieces of concern that you may
not have been aware of. Nothing critical, just small bits and pieces.
pre
- var $filterBox = $( '#' + mw.config.get( 'abuseFilterBoxName' ) );
+ var $filterBox = [];
..
- var $syntaxResult = $( '#mw-abusefilter-syntaxresult' );
+ var $syntaxResult = [];
/pre
This file contains several references to $filterBox outside the document-ready
callback. I don't know if those methods are called directly but it feels wrong.
But initializing it to an empty array doesn't make sense either way. Things
like code$filterBox.val()/code will fail if it's not a jQuery object.
Either leave it undefined (codevar $filterBox;/code) or initialize it to an
empty jQuery object (codevar $filterBox = $( [] );/code) to keep it
compatible in a lazy way.
pre
- (function($,mw) {
-$(div.searchresults)
- })( jQuery, window.mediaWiki );
+ jQuery( document ).ready( function() {
+ jQuery(div.searchresults)
+ } );
/pre
code$/code can be aliased locally without an additional closure via the
first argument of the document-ready callback.
pre
+ jQuery( document ).ready( function() {
var wgDonateButton = getDonateButton();
..
+ } );
/pre
Again, I don't know this extension. But this can potentially break stuff if
anything else outside this file was referring to wgDonateButton, which is now
in a lower context, and no longer exposed. It wasn't a global since
ResourceLoader uses closures per module, but it was exposed to other files
within the same module (if the module has multiple files). Probably not an
issue here thoguh (unless this file is not loaded with ResourceLoader in which
case the breakage much more likely).
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111983]: New comment added, and revision status changed
Krinkle changed the status of MediaWiki.r111983 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111983#c31352 Old Status: new New Status: ok Commit summary for MediaWiki.r111983: * Fixed failure of the edit toolbar to load when $wgResourceLoaderExperimentalAsyncLoading is enabled and module execution occurs before the edit box appears in the DOM. Similar to bug 34538. * Also fixed breakage of byteLimit on edit in the same scenario. * For 1.19 backport so no release notes. Krinkle's comment: Same as in r111989 cr, code$toolbar : [],/code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112151]: New comment added, and revision status changed
Aaron Schulz changed the status of MediaWiki.r112151 to ok and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112151#c31353
Old Status: new
New Status: ok
Commit summary for MediaWiki.r112151:
1.19wmf1: Fix the UploadStash hack in thumb.php so it works with the FileRepo
refactoring. This is already live.
* FSRepo constructor needs real file paths, but getZonePath() returns mwstore
paths. Pass in data from $wgLocalFileRepo instead. This is a hack but whatever
* FSRepo constructor requires a 'name' key, pass one. This caused a notice in
1.18wmf1 but causes an exception in 1.19wmf1
* For building $path, use the 'public' zone of the fake repo rather than the
'temp' zone of the real repo. They have the same FS paths, so they were
identical in 1.18wmf1 but the mwstore URLs returned in 1.19wmf1 are different
* Pass a Title object with $strippedName into the UnregisteredLocalFile
constructor so $this-name is set to $strippedName rather than $fileName, which
is needed for hash paths to be computed correctly (the hash path for
20120222132345!foo.png should be based on md5('foo.png'), not on
md5('20120222132345!foo.png') )
Aaron Schulz's comment:
The change to $repo-getZonePath( 'public' ) makes sense since the backend name
portion of the path needs to match up with the repo's backend (e.g.
$repo-getBackend()). If you give a path like mwstore://Y/cont/stuff.jpg to a
backend named Y it will work, but it will be seen as invalid for a backend
named X.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112151]: New comment added
Catrope posted a comment on MediaWiki.r112151.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112151#c31354
Commit summary for MediaWiki.r112151:
1.19wmf1: Fix the UploadStash hack in thumb.php so it works with the FileRepo
refactoring. This is already live.
* FSRepo constructor needs real file paths, but getZonePath() returns mwstore
paths. Pass in data from $wgLocalFileRepo instead. This is a hack but whatever
* FSRepo constructor requires a 'name' key, pass one. This caused a notice in
1.18wmf1 but causes an exception in 1.19wmf1
* For building $path, use the 'public' zone of the fake repo rather than the
'temp' zone of the real repo. They have the same FS paths, so they were
identical in 1.18wmf1 but the mwstore URLs returned in 1.19wmf1 are different
* Pass a Title object with $strippedName into the UnregisteredLocalFile
constructor so $this-name is set to $strippedName rather than $fileName, which
is needed for hash paths to be computed correctly (the hash path for
20120222132345!foo.png should be based on md5('foo.png'), not on
md5('20120222132345!foo.png') )
Catrope's comment:
Yeah. It didn't matter before because it was all just FS paths anyway, so
code$repo-getZonePath( 'public' )/code and code$localRepo-getZonePath(
'temp' )/code were the same string.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Question: Hook:LinkEnd and Title::getNamespace method for internal page ( such as User or User_talk page ) where the target page does not exist
On Wed, Feb 22, 2012 at 12:28 AM, Thomas Gries m...@tgries.de wrote: Basically: a link on a page like [[Benutzer:Alice]] is not necessarily the same as [[User:Alice]] (even when the latter exists). It depends on the current setting of $wgLanguageCode = en ; $wgLanguageCode = de ; (during testing my extension I played with this setting) whether [[Benutzer:Alice]] it is in the Namespace or not. So I was trapped by thinking that _any_ localised Namespace (like Benutzer) is necessarily the same as USER or USER_TALK, which was incorrect. Question: === Has anyone an idea, how to detect language-independently whether a link on page is in Namespace USER or USER_TALK, or in a localised version of these (when $wgLanguageCode has been modified)? The goal is to detect and to mark USER or USER_TALK page links language-independently in function wfWikiArticleFeedsAddSignatureMarker in E:WikiArticleFeeds line 262 . This sounds like it should be a non-issue. If the wiki language is set to English, then [[Benutzer:Alice]] simply is not a user page, it's in the main namespace. If the language is set to German, [[Benutzerin:Alice]] will be a user page, and [[Benutzer:Alice]] and [[User:Alice]] will be aliases pointing to that page. Trying to detect German namespace prefixes while the wiki language is in English simply is not going to work, and *should not* work. If you have been changing the lanugage code settings around a lot, then maybe something got stuck in parser cache and that made it look like the detection failed? Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki RC2UDP feature/bugfix frozen (aka irc recent changes feed)
On 23/02/12 05:42, Krinkle wrote: To avoid future breakages or mass migration while a replacement[1] is already on the horizon, I think it's a good time as any to declare this feature as legacy and therefor feature and bugfix froozen until deprecated/superseeded by a more modern system[1]. I don't think it has to be frozen, as I have repeatedly said on Bugzilla and IRC. Like HTML screen scrapers, if you maintain one of these bots, you have to expect the input format to change from time to time. The bots provide an important service, which is why I asked that the bot authors be notified of any changes well in advance of deployment, so that there would be no disruption. That didn't happen, so we had to revert the format changes. Note that the changes to the IRC format were unintentional and were detrimental for both humans and bots reading the feed. There's no guarantee that the bot authors will want to switch to XMPP even if it is more modern and more stable. When I spoke to some of them previously, they indicated that familiarity with IRC client libraries and scripting languages like the one provided by mIRC was very important. Declaring the IRC interface deprecated would be unpopular among the many human users of this feature, inside and outside Wikimedia. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111604]: New comment added, and revision status changed
Brion VIBBER changed the status of MediaWiki.r111604 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111604#c31355 Old Status: new New Status: ok Commit summary for MediaWiki.r111604: Fixes Bug 34333 - multi file selection with FF10 fails Patch from Rainer Brion VIBBER's comment: I don't like the version checking particularly, this should probably be replaced with checks for exact interfaces unless there's a very specific undetectable bug that it's meant to find. But this should fix the FF 10 issue for the moment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9647]: Revision status changed
Bináris changed the status of pywikipedia.r9647 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9647 Old status: new New status: resolved Commit summary for pywikipedia.r9647: get version from sqlite table while using TortoiseSVN 1.7 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111604]: New comment added, and revision status changed
Krinkle changed the status of MediaWiki.r111604 to new and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111604#c31356
Old Status: ok
New Status: new
Commit summary for MediaWiki.r111604:
Fixes Bug 34333 - multi file selection with FF10 fails
Patch from Rainer
Krinkle's comment:
$.browser is deprecated by jQuery.
Use $.client.profile() instead:
source lang=javascript
$.browser
{
webkit: true,
version: 535.11,
safari: true
}
/source
source lang=javascript
$.client.profile()
{
name: chrome,
layout: webkit,
layoutVersion: 535,
platform: mac,
version: 17.0.963.56,
versionBase: 17,
versionNumber: 17
}
/source
Where versionNumber is a ready to use integer that should help in the 5
comparison as well.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9884]: Revision status changed
Bináris changed the status of pywikipedia.r9884 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9884 Old status: new New status: ok Commit summary for pywikipedia.r9884: bugfix for missing withHistory parameter at r9876 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112132]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112132 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112132 Old status: new New status: resolved Commit summary for MediaWiki.r112132: Uglier than ugly hack to fix block log any many others by not having the username prepended on the messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112133]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112133 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112133 Old status: new New status: ok Commit summary for MediaWiki.r112133: Followup, restore the irctext variable just in vase, ping r112132 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9894]: Revision status changed
Bináris changed the status of pywikipedia.r9894 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9894 Old status: new New status: ok Commit summary for pywikipedia.r9894: bugfix for string assignment(r9893) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9892]: New comment added
Bináris posted a comment on pywikipedia.r9892. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9892#c31357 Commit summary for pywikipedia.r9892: docstring from wikipedia.family() from rewrite Bináris's comment: In line 4724 @param fatal: bool does not want to be @type fatal? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9649]: Revision status changed
Bináris changed the status of pywikipedia.r9649 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9649 Old status: new New status: ok Commit summary for pywikipedia.r9649: remove debugging stuff ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9644]: Revision status changed
Bináris changed the status of pywikipedia.r9644 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9644 Old status: new New status: ok Commit summary for pywikipedia.r9644: utf-8 encoding ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112079]: Revision status changed
Hashar changed the status of MediaWiki.r112079 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112079 Old status: new New status: ok Commit summary for MediaWiki.r112079: * General log formatting fixes, like using the content language, for IRC feeds (works similar to LogPage::actionText). Use getPrefixedText() for the log title, not just the non-namespace part. * Made patrol log IRC code behave as it did pre-r97495. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r110931]: New comment added
Krinkle posted a comment on MediaWiki.r110931. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110931#c31358 Commit summary for MediaWiki.r110931: Javascript improvements Krinkle's comment: pre 97 + // We need to remove dependencies from mw.util that will don't use and 98 + // aren't compatible with zepto.js 99 + // Krinkle will hate me 100 + // TODO: This only saves about 4KB, reevaluate later 101 + $wgResourceModules['mediawiki.util.lite'] = array( 102 +'scripts' = 'resources/mediawiki/mediawiki.util.js', 103 +/*'dependencies' = array( 104 +'jquery.client', 105 +'jquery.cookie', 106 +'jquery.messageBox', 107 + 'jquery.mwExtension', 108 +),*/ 109 + //'messages' = array( 'showtoc', 'hidetoc' ), 110 + 'position' = 'top', // For $wgPreloadJavaScriptMwUtil 111 +); 112 + $wgResourceModules['mediawiki.api.lite'] = array( 113 +'scripts' = 'resources/mediawiki/mediawiki.api.js', 114 +'dependencies' = 'mediawiki.util.lite', /pre Rrrarr ;-) bug 26799 wil set these free as codemediawiki.page/code (assuming you're loading it for things like ttmw.util.addPortletLink/tt). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111643]: New comment added
Tim Starling posted a comment on MediaWiki.r111643. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111643#c31359 Commit summary for MediaWiki.r111643: (bug 34420) - Special:Version should use git You can test it using git init in our $IP and do a dummy commit with: git commit -a RELEASE-NOTES-1.19 Then head to Special:Version and look at the magic version number. This need a backport in REL1_19 / 1.19wmf1 since WMF is going to use git soon (tm). Tim Starling's comment: It only needs a 1.19wmf1 backport if we're going to use that exact branch with git and not make a new one from trunk. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111604]: New comment added, and revision status changed
RobLa-WMF changed the status of MediaWiki.r111604 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111604#c31360 Old Status: new New Status: ok Commit summary for MediaWiki.r111604: Fixes Bug 34333 - multi file selection with FF10 fails Patch from Rainer RobLa-WMF's comment: Per Brion's comment, we need a capability check here, but not for now. That's probably not going to be up to mah to write a new capability-checking version anyway, so let's get this cleared out of our review queue. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111796]: Revision status changed
Tim Starling changed the status of MediaWiki.r111796 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111796 Old status: new New status: ok Commit summary for MediaWiki.r111796: fix for bug34431 - Disable the old toolbar if the new toolbar is enabled ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111643]: New comment added
Krinkle posted a comment on MediaWiki.r111643. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111643#c31361 Commit summary for MediaWiki.r111643: (bug 34420) - Special:Version should use git You can test it using git init in our $IP and do a dummy commit with: git commit -a RELEASE-NOTES-1.19 Then head to Special:Version and look at the magic version number. This need a backport in REL1_19 / 1.19wmf1 since WMF is going to use git soon (tm). Krinkle's comment: Hm.. yeah, git only has one tt.git/tt directory in the repo root. Not in every subdirectory. But on the other hand, Git doesn't support sparse checkouts, so we're safe since phase3 will be a repo, right ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112160]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112160 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112160 Old status: new New status: ok Commit summary for MediaWiki.r112160: Followup r111796, always return true ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111643]: New comment added
RobLa-WMF posted a comment on MediaWiki.r111643. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111643#c31362 Commit summary for MediaWiki.r111643: (bug 34420) - Special:Version should use git You can test it using git init in our $IP and do a dummy commit with: git commit -a RELEASE-NOTES-1.19 Then head to Special:Version and look at the magic version number. This need a backport in REL1_19 / 1.19wmf1 since WMF is going to use git soon (tm). RobLa-WMF's comment: Good point ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112128]: Revision status changed
Tim Starling changed the status of MediaWiki.r112128 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112128 Old status: new New status: ok Commit summary for MediaWiki.r112128: r112045/bug 34508: Make upload/upload and overwrite match old IRC format ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112152]: Revision status changed
Tim Starling changed the status of MediaWiki.r112152 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112152 Old status: new New status: ok Commit summary for MediaWiki.r112152: (bug 34600) Older skins using useHeadElement=false were broken in 1.18 . Modified patch by Vitaliy Flippov ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112153]: Revision status changed
Tim Starling changed the status of MediaWiki.r112153 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112153 Old status: new New status: ok Commit summary for MediaWiki.r112153: * (bug 34598) Double search dropdowns sometimes appearing Forces mwsuggest to load before vector simple search, so we can guarantee that we disable it. (If it were loaded second and ready already called, then it could load simplesearch first and fail to disable mwsuggest.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112112]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112112 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112112 Old status: new New status: ok Commit summary for MediaWiki.r112112: Use local context to get messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111809]: Revision status changed
Catrope changed the status of MediaWiki.r111809 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111809 Old status: new New status: ok Commit summary for MediaWiki.r111809: Add missing dependency of mediawiki.user to mediawiki.api.watch. May resolve some of bug 34450 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112165]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112165 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112165 Old status: new New status: ok Commit summary for MediaWiki.r112165: Fix spacing in r111809 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111810]: Revision status changed
Catrope changed the status of MediaWiki.r111810 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111810 Old status: new New status: ok Commit summary for MediaWiki.r111810: MFT r111809 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105123]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r105123 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105123 Old status: new New status: resolved Commit summary for MediaWiki.r105123: svn:eol-style native on all phase3 stuff, since I messed that up in r105122 Also adding the MWDebug class I missed there as well ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112050]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r112050 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112050 Old status: new New status: ok Commit summary for MediaWiki.r112050: Refactors the check if a particular IP is in the list of configured squid servers into its own function. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] 1.19 deploy to commons rescheduled for Wednesday, Feb 22 18:00-22:00 UTC
Hi everyone, This deployment of 1.19 to commons finally happened about an hour or so ago. We're keeping an eye on possible issues. We haven't seen anything that would cause us to roll back, but we are seeing a few issues. Please report bugs in Bugzilla, or if you're feeling too lazy for that, at least drop a note on this talk page: https://meta.wikimedia.org/wiki/Talk:Wikimedia_maintenance_notice Thanks! Rob On Tue, Feb 21, 2012 at 8:49 PM, Rob Lanphier ro...@wikimedia.org wrote: Hi all, The 1.19 deploy to commons didn't go the way we hoped. We're planning to try again tomorrow, after we have some time to debug some of the problems we hit. Roan and Aaron are discussing some thumb generation issues now, and there are also some Javascript issues that we'll need to resolve tomorrow. A new deployment window is planned for Wednesday, Feb 22 18:00-22:00 UTC Rob ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111989]: New comment added, and revision status changed
Tim Starling changed the status of MediaWiki.r111989 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111989#c31363 Old Status: new New Status: fixme Commit summary for MediaWiki.r111989: * (bug 34538) Fixed compatibility with $wgResourceLoaderExperimentalAsyncLoading in some extensions. * Tested AbuseFilter. * Did not test ArticleCreationWorkflow, Configure, ContributionTracking, FlaggedRevs, FundraiserPortal, InlineCategorizer, MarkAsHelpful, Math/Mathjax. * Fixed a typo in a comment in LiveTranslate. * Did not review extensions alphabetically after MoodBar. Tim Starling's comment: Initialising to an empty array was Roan's idea, he told me to do it when I wrote r111983. There were some instances in the core already of the same pattern. You're right that it seems a bit wrong. I don't see the point in creating a $ alias for a single-line function. Yes there are references $filterBox, but only in functions called from callbacks registered in the document ready hook. Note that the object is anonymous and does not provide any global variables which would allow it to be called from an external module or from HTML, so the ready callback is the only entry point. The wgDonateButton thing does appear to be a bug. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111975]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r111975 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111975 Old status: new New status: ok Commit summary for MediaWiki.r111975: Revert RDFa and Microdata improvements to addMeta in r111439 till after the git migration. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112169]: New comment added
Krinkle posted a comment on MediaWiki.r112169. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112169#c31364 Commit summary for MediaWiki.r112169: bug 34599: special:uploadwizard loading insecure content from commons This is in mediawiki.feedback module which is hosted in core. A quick fix to load this spinner image protocol-relative. Should be replaced with CSS and a locally-hosted image. Krinkle's comment: There's also bug 33045. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112170]: New comment added
Krinkle posted a comment on MediaWiki.r112170. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112170#c31365 Commit summary for MediaWiki.r112170: [mw.util] bug fix and minor clean up * Fixes bug 34603 (Patch by Rainer rai...@rillke.eu) and other instances of the same bug -- Use 'util' instead of 'this' to allow re-usage of the method in a different context * Use ternary operator instead of the default operator in mw.util.wikiGetlink to check it for type instead of thruthy-ness (so that falsy-values such as '' work, and thruthy non-string values such as objects fail). Krinkle's comment: Also fixes bug 33347 :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111085]: New comment added
Aaron Schulz posted a comment on MediaWiki.r111085.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111085#c31366
Commit summary for MediaWiki.r111085:
(bug 28936, bug 5280) Broken or invalid titles can't be removed from watchlist.
Now titles are fixed or deleted, if unfixable, upon loading
Special:EditWatchlist.
Aaron Schulz's comment:
pre
- if ( $namespace 0 ) {
- $haveInvalidNamespaces = true;
- continue;
/pre
You replaced this with an if, but it no longer breaks out before the inner
loop on $pages.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112169]: Revision status changed
Reedy changed the status of MediaWiki.r112169 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112169 Old status: new New status: ok Commit summary for MediaWiki.r112169: bug 34599: special:uploadwizard loading insecure content from commons This is in mediawiki.feedback module which is hosted in core. A quick fix to load this spinner image protocol-relative. Should be replaced with CSS and a locally-hosted image. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112172]: New comment added, and revision status changed
Krinkle changed the status of MediaWiki.r112172 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112172#c31367 Old Status: new New Status: ok Commit summary for MediaWiki.r112172: * (bug 33045) Use locally-sourced spinner image for mediawiki.feedback module instead of Commons image Switched from an img with a hardcoded Commons link to a span, a stylesheet, and a locally-hosted copy of the image. Krinkle's comment: May wanna code@embed/code it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
