Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()
On 10.05.2013 17:58, Chad wrote: On Fri, May 10, 2013 at 8:05 AM, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, I can see why SPL might require extra work in HipHop to support. At the same time I find it somewhat unfortunate this means one cannot use the Standard PHP Library. Yeah, but I think it's a workable issue. And the HH team seems very amenable to feature requests (and patches!), so implementing parts of the SPL are certainly possible over the long term. As Tim points out, for ArrayObject and filter_var() it's non trivial to implement (even Zend's implementation of the former is 2000+ LOC). System and development software, such as OS, compilers, language libraries, different kinds of VM's and so on are really huge and 2000+ lines of code actually is a *little* amount. It's not a framework or wiki. It's development software written in low-level language. Dmitriy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()
On 10.05.2013 23:51, Antoine Musso wrote: Le 10/05/13 03:10, Tim Starling a écrit : There's a few other SPL features that we don't use at the moment and we should avoid introducing if possible due to lack of support in HipHop: snip: various SPL classes I wish we actually used Spl :-] They are nice classes providing all kind of useful features: http://php.net/manual/en/book.spl.php Yes it is strange that Facebook does not need SPL. Especially because since PHP 5.3 SPL is not optional anymore. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()
On Sat, May 11, 2013 at 3:31 AM, Dmitriy Sintsov ques...@rambler.ru wrote: On 10.05.2013 17:58, Chad wrote: On Fri, May 10, 2013 at 8:05 AM, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, I can see why SPL might require extra work in HipHop to support. At the same time I find it somewhat unfortunate this means one cannot use the Standard PHP Library. Yeah, but I think it's a workable issue. And the HH team seems very amenable to feature requests (and patches!), so implementing parts of the SPL are certainly possible over the long term. As Tim points out, for ArrayObject and filter_var() it's non trivial to implement (even Zend's implementation of the former is 2000+ LOC). System and development software, such as OS, compilers, language libraries, different kinds of VM's and so on are really huge and 2000+ lines of code actually is a *little* amount. It's not a framework or wiki. It's development software written in low-level language. Indeed, 2000 isn't really a lot, I was just trying to give an order of magnitude so people wouldn't think it was like 50 LOC or something. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Object.keys called on non-object
Hi everyone,
I've just installed VisualEditor + parsoid for mediawiki. This is the my
configurator:
--- localsettings.js
exports.setup = function( parsoidConfig ) {
// The URL here is supposed to be your MediaWiki installation root
parsoidConfig.setInterwiki( 'localhost', '
http://www.startupperday.com/api.php' );
// Use the PHP preprocessor to expand templates via the MW API
(default true)
//parsoidConfig.usePHPPreProcessor = false;
// Use selective serialization (default false)
//parsoidConfig.useSelser = true;
// allow cross-domain requests to the API (default disallowed)
parsoidConfig.allowCORS = '*';
};
--- LocalSettings.php
require_once($IP/extensions/VisualEditor/VisualEditor.php);
// Create VisualEditor namespace
define( 'NS_VISUALEDITOR', 2500 );
define( 'NS_VISUALEDITOR_TALK', 2501 );
$wgExtraNamespaces[NS_VISUALEDITOR] = 'VisualEditor';
$wgExtraNamespaces[NS_VISUALEDITOR_TALK] = 'VisualEditor_talk';
// Allow using VisualEditor in the main namespace only (default)
$wgVisualEditorNamespaces = array( NS_MAIN );
// Restrict VisualEditor to the VisualEditor namespace
#$wgVisualEditorNamespaces = array();
#$wgVisualEditorNamespaces[] = NS_VISUALEDITOR;
// Enable by default for everybody
$wgDefaultUserOptions['visualeditor-enable'] = 1;
// Don't allow users to disable it
$wgHiddenPrefs[] = 'visualeditor-enable';
$wgVisualEditorParsoidURL = 'http://www.startupperday.com:8000/';
--- but when I try to save everything in mediawiki I get:
TypeError: Object.keys called on non-object
at Function.keys (native)
at Object.WikiConfig (/srv/
www.startupperday.com/Parsoid/js/lib/mediawiki.WikiConfig.js:41:20)
at null.anonymous (/srv/
www.startupperday.com/Parsoid/js/lib/mediawiki.parser.environment.js:300:22)
at processSome (/srv/
www.startupperday.com/Parsoid/js/lib/mediawiki.ApiRequest.js:98:17)
at process._tickCallback (node.js:415:13)
Can you help me? :(((
--
*Marco De Nadai*
http://www.marcodena.it/http://www.marcodena.it/?utm_source=emailutm_medium=emailutm_campaign=Email%2Bpersonali
--
*Marco De Nadai*
http://www.marcodena.it/http://www.marcodena.it/?utm_source=emailutm_medium=emailutm_campaign=Email%2Bpersonali
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Object.keys called on non-object
On Sat, May 11, 2013 at 04:46:37PM +0200, Marco De Nadai wrote: TypeError: Object.keys called on non-object at Function.keys (native) at Object.WikiConfig (/srv/ www.startupperday.com/Parsoid/js/lib/mediawiki.WikiConfig.js:41:20) at null.anonymous (/srv/ www.startupperday.com/Parsoid/js/lib/mediawiki.parser.environment.js:300:22) at processSome (/srv/ www.startupperday.com/Parsoid/js/lib/mediawiki.ApiRequest.js:98:17) at process._tickCallback (node.js:415:13) Can you help me? :((( Is this wiki readable by anonymous users? If not, the Parsoid service won't be able to get the necessary configuration from your wiki via the API. There's a bug for this - https://bugzilla.wikimedia.org/show_bug.cgi?id=44483 You could try to fix the bug, but it's a tough one. You could also work around the issue by creating a cached JSON response in js/lib/baseconfig, where we have a bunch of default configs laying around. After doing that you may need to change some configuration or even code to get Parsoid's API to use that file instead of an API response, but it's possible. If your wiki *isn't* read-only, then I'm sorry I rambled at you here :) we can help much more easily on IRC at #mediawiki-parsoid on Freenode, because of the relative speed of the communication with IRC. Thanks for trying out the system! Hopefully we can help you get it working on your wiki. Ta, -- Mark Holmquist Software Engineer Wikimedia Foundation mtrac...@member.fsf.org https://wikimediafoundation.org/wiki/User:MHolmquist signature.asc Description: Digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Not much usage of the Visual Editor?
Well, that's disconcerting - is this actually all the edits with the Visual Editor? https://en.wikipedia.org/w/index.php?title=Special:RecentChangestagfilter=visualeditor I'll have to make a point of hammering on it more ;-) - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
On Sat, May 11, 2013 at 12:29 PM, David Gerard dger...@gmail.com wrote: Well, that's disconcerting - is this actually all the edits with the Visual Editor? https://en.wikipedia.org/w/index.php?title=Special:RecentChangestagfilter=visualeditor I'll have to make a point of hammering on it more ;-) Yes the RecentChanges tag should be comprehensive. I think part of this is due to the opt in nature of the tool, and the rest is due to some well-known limitations. It doesn't yet handle templates, images, or references very well, and it's pretty slow on English Wikipedia still. I think the VisualEditor and Parsoid team are aware of all these, and have work in progress or on the near-term roadmap. One thing we could experiment with is turning on VisualEditor as the default for new people who've just signed up. We'd need to do this carefully with guidance from James/Trevor et. al., and with a close eye on the conversion rate. At the very least we could run a few remote usability tests to see if it made a positive difference or just totally confused people. My team could perhaps tackle this as part of our work on the Getting Started workflow we're presenting to newly-registered folks on English Wikipedia. Steven ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Is it possible to set revision tags from the API?
I've looked into this and my conclusion is that it isn't possible, but I would really like to do this so I figured I would ask. I have a bot making edits via the API and I would like to use revision tags with the bots edits. Is this possible from the API? I see where I can retrieve them in revisions, and get them as properties for a number of things. But I can't seem to see anyway that I can associate a tag with a given revision or edit. Jamie Thingelstad ja...@thingelstad.com mobile: 612-810-3699 find me on AIM Twitter Facebook LinkedIn ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
On Sat, May 11, 2013 at 01:01:05PM -0700, Steven Walling wrote: One thing we could experiment with is turning on VisualEditor as the default for new people who've just signed up. We'd need to do this carefully with guidance from James/Trevor et. al., and with a close eye on the conversion rate. At the very least we could run a few remote usability tests to see if it made a positive difference or just totally confused people. My team could perhaps tackle this as part of our work on the Getting Started workflow we're presenting to newly-registered folks on English Wikipedia. Actually, if you wanted to really streamline the copyediting tasks, you could just link to the veaction=edit version of the edit form rather than the page itself, maybe with a special token that VE could use to notify the user that they were editing the page, instead of the default notification that just says hey, you're using VisualEditor, which is probably not the most helpful text for a totally-brand-new user. -- Mark Holmquist Software Engineer Wikimedia Foundation mtrac...@member.fsf.org https://wikimediafoundation.org/wiki/User:MHolmquist signature.asc Description: Digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
On Sat, 11 May 2013 22:01:05 +0200, Steven Walling steven.wall...@gmail.com wrote: One thing we could experiment with is turning on VisualEditor as the default for new people who've just signed up. We'd need to do this carefully with guidance from James/Trevor et. al., and with a close eye on the conversion rate. At the very least we could run a few remote usability tests to see if it made a positive difference or just totally confused people. My team could perhaps tackle this as part of our work on the Getting Started workflow we're presenting to newly-registered folks on English Wikipedia. As much as I love VE myself, this seems like an extremely bad idea given its current state. -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
On Sat, May 11, 2013 at 1:01 PM, Steven Walling steven.wall...@gmail.comwrote: On Sat, May 11, 2013 at 12:29 PM, David Gerard dger...@gmail.com wrote: Well, that's disconcerting - is this actually all the edits with the Visual Editor? https://en.wikipedia.org/w/index.php?title=Special:RecentChangestagfilter=visualeditor I'll have to make a point of hammering on it more ;-) Yes the RecentChanges tag should be comprehensive. I think part of this is due to the opt in nature of the tool, and the rest is due to some well-known limitations. It doesn't yet handle templates, images, or references very well, and it's pretty slow on English Wikipedia still. I think the VisualEditor and Parsoid team are aware of all these, and have work in progress or on the near-term roadmap. Yeah, I expect the overlap between people who follow wikimedia news enough to know they can opt-in and people who do fairly complex formatting work is pretty high. E.G. I have it installed, but rarely use it because most of my on-wiki work is fixing references, which the VE can't cope with yet (or, it's simply faster for me to do it by hand, as I can write markup in my sleep). Would it be helpful for the dev team to have more people using it on a regular basis? -- phoebe -- * I use this address for lists; send personal messages to phoebe.ayers at gmail.com * ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
On 11 May 2013 21:01, Steven Walling steven.wall...@gmail.com wrote: One thing we could experiment with is turning on VisualEditor as the default for new people who've just signed up. Oh my goodness, this thing is so not ready for newbies yet. It would confuse them utterly. (But *why* can't I edit the infobox? What's these changes mean? etc.) I suggest propagandising it with current editors. I'll pitch in ;-) - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Is it possible to set revision tags from the API?
On 2013-05-11 5:06 PM, Jamie Thingelstad ja...@thingelstad.com wrote: I've looked into this and my conclusion is that it isn't possible, but I would really like to do this so I figured I would ask. I have a bot making edits via the API and I would like to use revision tags with the bots edits. Is this possible from the API? I see where I can retrieve them in revisions, and get them as properties for a number of things. But I can't seem to see anyway that I can associate a tag with a given revision or edit. Jamie Thingelstad ja...@thingelstad.com mobile: 612-810-3699 find me on AIM Twitter Facebook LinkedIn ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l No that is not possible. Tags can currently only be set by extensions. (Arguably having some interface for users to manipulate tags might be a good thing) -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Is it possible to set revision tags from the API?
On Sat, May 11, 2013 at 4:43 PM, Brian Wolff bawo...@gmail.com wrote: (Arguably having some interface for users to manipulate tags might be a good thing) If there is a significant interest in this, I might be able to pull something together. Should something like this be a core feature or an extension? *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
On Sat, May 11, 2013 at 1:41 PM, David Gerard dger...@gmail.com wrote: Oh my goodness, this thing is so not ready for newbies yet. It would confuse them utterly. (But *why* can't I edit the infobox? What's these changes mean? etc.) People who think that not editing the images and infobox would be more confusing than wikitext need to go watch some of the many usability tests we've run, including all the way back to 2009-10. We run usability tests with every iteration of the Getting Started experiment we launch these days, and every time new people who click Edit for the first time are quite literally shocked by the crazy mess that is wikitext. In this workflow, we're specifically asking newbies to do something that doesn't involve anything other than simple text changes (the most advanced markup we ask them to work with is links), so VisualEditor may actually be quite appropriate to A/B test. It may have extreme limitations, but at least it is roughly what new editors expect to see after hitting edit, instead of a garbled mass of incomprehensible code. Steven ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
On 11 May 2013 21:59, Steven Walling steven.wall...@gmail.com wrote: We run usability tests with every iteration of the Getting Started experiment we launch these days, and every time new people who click Edit for the first time are quite literally shocked by the crazy mess that is wikitext. This is true. I am a Level 20 Wizard or whatever in computery stuff and I *still* find it incomprehensible computer guacamole, so I suppose this may well not actually be worse. It may have extreme limitations, but at least it is roughly what new editors expect to see after hitting edit, instead of a garbled mass of incomprehensible code. Well, yes :-) Perhaps big banners (big orange banners?) for THIS IS ALPHA, WHICH IS THE STAGE BEFORE BETA ... - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
2013/5/11 David Gerard dger...@gmail.com: Well, that's disconcerting - is this actually all the edits with the Visual Editor? https://en.wikipedia.org/w/index.php?title=Special:RecentChangestagfilter=visualeditor In German Wikipedia there seem to be slightly more users who give the VE a try: https://de.wikipedia.org/w/index.php?title=Spezial:Letzte_%C3%84nderungentagfilter=visualeditor Regards, Jürgen. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] HipHop VM support: ArrayObject and filter_var()
FWIW, here is what I have so far: http://pastebin.com/hUQ92DfB I haven't tested it yet because my PHP environment is not behaving, and the only class I haven't implemented fully is SplHeap. *-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com On Sat, May 11, 2013 at 8:57 AM, Chad innocentkil...@gmail.com wrote: On Sat, May 11, 2013 at 3:31 AM, Dmitriy Sintsov ques...@rambler.ru wrote: On 10.05.2013 17:58, Chad wrote: On Fri, May 10, 2013 at 8:05 AM, Jeroen De Dauw jeroended...@gmail.com wrote: Hey, I can see why SPL might require extra work in HipHop to support. At the same time I find it somewhat unfortunate this means one cannot use the Standard PHP Library. Yeah, but I think it's a workable issue. And the HH team seems very amenable to feature requests (and patches!), so implementing parts of the SPL are certainly possible over the long term. As Tim points out, for ArrayObject and filter_var() it's non trivial to implement (even Zend's implementation of the former is 2000+ LOC). System and development software, such as OS, compilers, language libraries, different kinds of VM's and so on are really huge and 2000+ lines of code actually is a *little* amount. It's not a framework or wiki. It's development software written in low-level language. Indeed, 2000 isn't really a lot, I was just trying to give an order of magnitude so people wouldn't think it was like 50 LOC or something. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Not much usage of the Visual Editor?
Steven Walling wrote: One thing we could experiment with is turning on VisualEditor as the default for new people who've just signed up. I won't call it wikitext corruption, but the current (live) version of VisualEditor is actively harming articles by inserting pawns into them: * https://bugzilla.wikimedia.org/48346 * https://en.wikipedia.org/w/index.php?diff=553360286oldid=540708795 Until issues like this are completely resolved, VisualEditor use should be decreased, not increased, in my opinion. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Object.keys called on non-object
Thank you very much. I have all the permissions, so I will contact you via IRC :( 2013/5/11 Mark Holmquist mtrac...@member.fsf.org On Sat, May 11, 2013 at 04:46:37PM +0200, Marco De Nadai wrote: TypeError: Object.keys called on non-object at Function.keys (native) at Object.WikiConfig (/srv/ www.startupperday.com/Parsoid/js/lib/mediawiki.WikiConfig.js:41:20) at null.anonymous (/srv/ www.startupperday.com/Parsoid/js/lib/mediawiki.parser.environment.js:300:22 ) at processSome (/srv/ www.startupperday.com/Parsoid/js/lib/mediawiki.ApiRequest.js:98:17) at process._tickCallback (node.js:415:13) Can you help me? :((( Is this wiki readable by anonymous users? If not, the Parsoid service won't be able to get the necessary configuration from your wiki via the API. There's a bug for this - https://bugzilla.wikimedia.org/show_bug.cgi?id=44483 You could try to fix the bug, but it's a tough one. You could also work around the issue by creating a cached JSON response in js/lib/baseconfig, where we have a bunch of default configs laying around. After doing that you may need to change some configuration or even code to get Parsoid's API to use that file instead of an API response, but it's possible. If your wiki *isn't* read-only, then I'm sorry I rambled at you here :) we can help much more easily on IRC at #mediawiki-parsoid on Freenode, because of the relative speed of the communication with IRC. Thanks for trying out the system! Hopefully we can help you get it working on your wiki. Ta, -- Mark Holmquist Software Engineer Wikimedia Foundation mtrac...@member.fsf.org https://wikimediafoundation.org/wiki/User:MHolmquist ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- *Marco De Nadai* http://www.marcodena.it/http://www.marcodena.it/?utm_source=emailutm_medium=emailutm_campaign=Email%2Bpersonali ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
