[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16665 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: -1. It's harder to change constant than variable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User "Happy-melon" posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c1 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: When would you ever want to dynamically change the variable describing the MW version?!? The fact that it's immutable is a strength, not a weakness, less chance of it getting accidentally overwritten. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16667 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: People who run modified version of MediaWiki? People who want to fake the version for unknown reasons? Why is everyone breaking threading when responding to first comment? Bad ui I guess. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User "^demon" posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16670 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: +1 on reverting $wgVersion as a constant. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87635]: New comment added
User "Happy-melon" posted a comment on MediaWiki.r87635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87635#c16676 Commit summary: * Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded. * Move the declaration of $wgFeedClasses from Defines.php to WebStart.php Comment: Anyone running a modified version of MW can and should hack the version number along with whatever else they've changed, precisely ''so that'' it gets reverted along with any other changes if they do an upgrade without repatching. Updating the version via LocalSettings, which won't get overwritten by an upgrade, and the code via core hacks which will, is asking for (more than the usual amount of) trouble. I can see merit in a wfGetVersionText() function which can be hooked to change the display on things like Special:Version and the tag, but being able to fudge version_compare() calls is neither big nor clever. MW_VERSION summarises the state of the other 714,000 lines of code in MW core, version comparisons exist to stop Bad Things™ happening when those structures don't match up with what external code expects to see. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
