[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User MaxSem posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17710 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: To elaborate on Brion's revert of this revision: LoadExtensionSchemaUpdates hook works both for installation and upgrades. If it does not work, fix the extension and/or the core updater, but not introduce an alternative update infrastructure. As of adding stuff to LocalSettings, just use sane defaults. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User Freakolowsky posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17711 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: No need for elaboration i totally understand your (and Brion's) logic. If it works why change it. What i fail to understand is your resistance to a simple let's make this ugly thing nicer idea. It doesn't break anything ... But hey ... i'll let it be ... got other things to do :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17567 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: Can't extensions already add themselves to the DatabaseUpdater list through a hook? Why do we need a subclass? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User Freakolowsky posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17577 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: Currently it only works for the installer part (net even sure if that works correctly). You can specify a updater function trough the hook but DatabaseUpdater passes itself to that function as a parameter. That class has all the addXXX and applyPatch functions as protected, so you actually can't do nothing useful with it other that using the DB directly and doing DDL stuff. So instead of opening up the updater functions i think it would be better to have an updater specific to the extension inside. This way you can besides taking care of the installation process also handle the potential DB upgrade of extension specific parts. You can also use this updater to pass some defaults to LocalSettingsGenerator. The current code works, but it's very limited. Generally i think this would be a useful feature. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User ^demon posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17420 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: Should probably make doUpdates() abstract in the base class. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89263]: New comment added
User Freakolowsky posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17422 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: but the general idea seem sound? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
