Re: [Wikitech-l] How to speed up the review in gerrit?
On Wed, 2012-12-19 at 13:30 -0500, Sumana Harihareswara wrote: Try these tips: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews Does Gerrit support setting default CCs for certain code areas (projects, subfolders etc)? Letting new contributors search manually for a patch reviewer feels as wrong as letting new bug reporters search for an assignee or somebody to comment on their report. andre -- Andre Klapper | Wikimedia Bugwrangler http://blogs.gnome.org/aklapper/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On Thu, Dec 20, 2012 at 7:35 AM, Andre Klapper aklap...@wikimedia.org wrote: On Wed, 2012-12-19 at 13:30 -0500, Sumana Harihareswara wrote: Try these tips: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews Does Gerrit support setting default CCs for certain code areas (projects, subfolders etc)? Letting new contributors search manually for a patch reviewer feels as wrong as letting new bug reporters search for an assignee or somebody to comment on their report. No. I remember hearing some mutterings about a plugin to do this, but I haven't seen anything done. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On 20 December 2012 13:35, Andre Klapper aklap...@wikimedia.org wrote: Does Gerrit support setting default CCs for certain code areas (projects, subfolders etc)? Letting new contributors search manually for a patch reviewer feels as wrong as letting new bug reporters search for an assignee or somebody to comment on their report. It's possible to do it the other way around - people can /subscribe/ to a project via https://gerrit.wikimedia.org/r/#/settings/projects and receive e-mails when new patchsets are uploaded. I don't think this adds people to the reviewers list, but at least people get notified. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On Thu, 20 Dec 2012 14:20:07 +0100, Merlijn van Deen valhall...@arctus.nl wrote: It's possible to do it the other way around - people can /subscribe/ to a project via https://gerrit.wikimedia.org/r/#/settings/projects and receive e-mails when new patchsets are uploaded. I don't think this adds people to the reviewers list, but at least people get notified. It sends you a mail and adds the change to the Watched Changes tab on your dashboard. -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On 12/19/2012 05:57 AM, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a month of inactivity, and it will come tomorrow... The changes are really simple. How to ask someone to really do the review? Does Gerrit have such function? I've received all of them; I just have +1/-1 on that. Matt Flaschen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
You could add people as reviewers, or personally ask someone to review, prefereably someone who worked on the extension in the past. -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
Le 19/12/12 11:57, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a month of inactivity, and it will come tomorrow... The changes are really simple. How to ask someone to really do the review? Does Gerrit have such function? And the changes are: https://gerrit.wikimedia.org/r/#/c/39369/ add a dependency on mediawiki.legacy.wikibits. https://gerrit.wikimedia.org/r/#/c/25629/ Fix a bug: drafts didn't show up when creating new pages https://gerrit.wikimedia.org/r/#/c/25628/ Always display user's drafts on the edit form https://gerrit.wikimedia.org/r/#/c/25627/ Fix for PHP 5.4: add to function prototype -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
Matma Rex писал 2012-12-19 15:01: You could add people as reviewers, or personally ask someone to review, prefereably someone who worked on the extension in the past. Okay, I've just done it... So, do you mean all committers just add random reviewers when they see no reaction? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
Antoine Musso писал 2012-12-19 16:19: Le 19/12/12 11:57, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a month of inactivity, and it will come tomorrow... The changes are really simple. How to ask someone to really do the review? Does Gerrit have such function? And the changes are: https://gerrit.wikimedia.org/r/#/c/39369/ add a dependency on mediawiki.legacy.wikibits. https://gerrit.wikimedia.org/r/#/c/25629/ Fix a bug: drafts didn't show up when creating new pages https://gerrit.wikimedia.org/r/#/c/25628/ Always display user's drafts on the edit form https://gerrit.wikimedia.org/r/#/c/25627/ Fix for PHP 5.4: add to function prototype Yes, exactly! I've just added the first one (added dependency..). Others are older.. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On 12/19/2012 07:24 AM, vita...@yourcmc.ru wrote: Antoine Musso писал 2012-12-19 16:19: Le 19/12/12 11:57, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a month of inactivity, and it will come tomorrow... The changes are really simple. How to ask someone to really do the review? Does Gerrit have such function? And the changes are: https://gerrit.wikimedia.org/r/#/c/39369/ add a dependency on mediawiki.legacy.wikibits. https://gerrit.wikimedia.org/r/#/c/25629/ Fix a bug: drafts didn't show up when creating new pages https://gerrit.wikimedia.org/r/#/c/25628/ Always display user's drafts on the edit form https://gerrit.wikimedia.org/r/#/c/25627/ Fix for PHP 5.4: add to function prototype Yes, exactly! I've just added the first one (added dependency..). Others are older.. Try these tips: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews -- Sumana Harihareswara Engineering Community Manager Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
I've had patchsets that I submitted in August and they still haven't been merged. For example, the account creation API, which has actually been approved, but never merged. *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com On Wed, Dec 19, 2012 at 1:30 PM, Sumana Harihareswara suma...@wikimedia.org wrote: On 12/19/2012 07:24 AM, vita...@yourcmc.ru wrote: Antoine Musso писал 2012-12-19 16:19: Le 19/12/12 11:57, vita...@yourcmc.ru wrote: Hello! 28 SEPTEMBER I've pushed minor changes to the gerrit, to the Drafts extensions. Since then I've corrected two of them (uploaded patch set 2), but after that, nobody did the review. As I understand, Gerrit will abandon changes after a month of inactivity, and it will come tomorrow... The changes are really simple. How to ask someone to really do the review? Does Gerrit have such function? And the changes are: https://gerrit.wikimedia.org/r/#/c/39369/ add a dependency on mediawiki.legacy.wikibits. https://gerrit.wikimedia.org/r/#/c/25629/ Fix a bug: drafts didn't show up when creating new pages https://gerrit.wikimedia.org/r/#/c/25628/ Always display user's drafts on the edit form https://gerrit.wikimedia.org/r/#/c/25627/ Fix for PHP 5.4: add to function prototype Yes, exactly! I've just added the first one (added dependency..). Others are older.. Try these tips: https://www.mediawiki.org/wiki/Git/Code_review/Getting_reviews -- Sumana Harihareswara Engineering Community Manager Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On 12/19/2012 02:41 PM, Tyler Romeo wrote: I've had patchsets that I submitted in August and they still haven't been merged. For example, the account creation API, which has actually been approved, but never merged. Which one are you referring to, https://gerrit.wikimedia.org/r/#/c/18127/ ? On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? Matt Flaschen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen mflasc...@wikimedia.org wrote: On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? There's a bug for that: https://bugzilla.wikimedia.org/show_bug.cgi?id=40061 I've been wanting to fix my name for ages as well... -- Matma Rex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
Yep, that patch. If you notice, patches 8, 16, 18, 20, and 21 have all been approved, i.e., +2 on CR. But it's yet to have been merged. At the very least, its dependency has been merged. I'm not in a humongous rush or anything, I'm just pointing out that sometimes you really just have to wait it out. ;) *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com On Wed, Dec 19, 2012 at 4:58 PM, Matma Rex matma@gmail.com wrote: On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen mflasc...@wikimedia.org wrote: On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/**r/#/dashboard/278https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? There's a bug for that: https://bugzilla.wikimedia.** org/show_bug.cgi?id=40061https://bugzilla.wikimedia.org/show_bug.cgi?id=40061 I've been wanting to fix my name for ages as well... -- Matma Rex __**_ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On 12/19/2012 05:06 PM, Tyler Romeo wrote: Yep, that patch. If you notice, patches 8, 16, 18, 20, and 21 have all been approved, i.e., +2 on CR. But it's yet to have been merged. At the very least, its dependency has been merged. I'm not in a humongous rush or anything, I'm just pointing out that sometimes you really just have to wait it out. ;) Yeah, I don't have any clever suggestion, just ping people on IRC or email if some time elapses. Matt Flaschen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
On 12/19/2012 04:58 PM, Matma Rex wrote: On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen mflasc...@wikimedia.org wrote: On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? There's a bug for that: https://bugzilla.wikimedia.org/show_bug.cgi?id=40061 I've been wanting to fix my name for ages as well... It turns out Parent5446 is his actual username. But if I didn't know better, it looks like some auto-generated gerrit ID. :) Matt Flaschen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to speed up the review in gerrit?
Lol yes. Parent5446 is my actual username, although it is not my name in real life. :P *--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerro...@gmail.com On Wed, Dec 19, 2012 at 5:15 PM, Matthew Flaschen mflasc...@wikimedia.orgwrote: On 12/19/2012 04:58 PM, Matma Rex wrote: On Wed, 19 Dec 2012 22:55:24 +0100, Matthew Flaschen mflasc...@wikimedia.org wrote: On a simpler note, why does it have your name as Parent5446? https://gerrit.wikimedia.org/r/#/dashboard/278 Can someone fix this? There's a bug for that: https://bugzilla.wikimedia.org/show_bug.cgi?id=40061 I've been wanting to fix my name for ages as well... It turns out Parent5446 is his actual username. But if I didn't know better, it looks like some auto-generated gerrit ID. :) Matt Flaschen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
