Re: PATCH: no tls space
At 12:37 PM 10/23/00 +0200, you wrote: >Well, is the situation "pressing ESC in the file open dialog" >indicated by WinXX with COMDLG32_SetExtendedError(0) or does it have >some special error? No, but if you call a common dialog box and you get an error, if you calls another dialog box after, under Windows you get 0 if this call has not caused an extended error; under Wine you get the same error code because it's saved in the thread local storage. I admit it's not often a real world problem since most extended errors result from programming errors and as such should cause the user to terminate the program; but to be completely correct, each common dialog should reset the extended error - and so allocate implicitly the Tls. Gerard
Re: PATCH: no tls space
gerard patel writes: > At 10:53 PM 10/22/00 +0200, you wrote: > > >I don't think this is a fix. It only hides the real problem: > >Some builtin-commdlg function failed without setting > >COMDLG32_SetCommDlgExtendedError. The application sees the failed > >function and wants to know the reason. > > > >So the failing function is better fixed and the check left in to see > >where and when those problems appear. > > > > Seems pure wisdom to me. > I just tried to add a COMDLG32_SetExtendedError(0) to > Filedlg_Init (it seems logical to initialize the error code no...) > and it removes the messages for Notepad 16 bits as well. > Well, is the situation "pressing ESC in the file open dialog" indicated by WinXX with COMDLG32_SetExtendedError(0) or does it have some special error? Bye Uwe Bonnes[EMAIL PROTECTED] Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt - Tel. 06151 162516 Fax. 06151 164321 --
Re: PATCH: no tls space
At 10:53 PM 10/22/00 +0200, you wrote: >I don't think this is a fix. It only hides the real problem: >Some builtin-commdlg function failed without setting >COMDLG32_SetCommDlgExtendedError. The application sees the failed >function and wants to know the reason. > >So the failing function is better fixed and the check left in to see >where and when those problems appear. > Seems pure wisdom to me. I just tried to add a COMDLG32_SetExtendedError(0) to Filedlg_Init (it seems logical to initialize the error code no...) and it removes the messages for Notepad 16 bits as well. Gerard
Re: PATCH: no tls space
Marcus Meissner writes: > Hi, > > This gets rid of the misleading "No Tls Space" error message. > (It appeared by closing a file open dialog with .) > Hallo, I don't think this is a fix. It only hides the real problem: Some builtin-commdlg function failed without setting COMDLG32_SetCommDlgExtendedError. The application sees the failed function and wants to know the reason. So the failing function is better fixed and the check left in to see where and when those problems appear. Bye Uwe Bonnes[EMAIL PROTECTED] Free Software: If you contribute nothing, expect nothing --
