Remove LATER and REMIND bug resolutions
Hi, It's been a week and nobody has responded to Dmitry's bug report [1] yet, so I'm going to bring it up here. I am all for it, does anyone have objections? - Lei [1] http://bugs.winehq.org/show_bug.cgi?id=13794
winetrick, dotnet2 and vc80
I just had the misfortune of needing a new wineprefix to try out something - and found that dotnet20 (through winetrick at least) doesn't check for vc80 runtime, but once it gets into wineprefix, things go rather bad with any wine commands - including winetricks itself - which makes it painful to install vc80 runtime afterwards. Please make some vc80 check in winetrick, or make vc80 a dependency automatic install if dotnet20 is asked for? BTW, well done everybody for wine 1.0 - still on rc5 but upgrading in the next hour or two! Cheers... Hin-Tak __ Sent from Yahoo! Mail. A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html
Re: Website down
Just for "geek value", is it possible to have a graph of how the slashdot effect look like? I mean a graph of the hourly web hit statistics or something. Be very glad that a lot of people are finding wine interesting... __ Sent from Yahoo! Mail. A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html
Re: [PATCH] shell32: SHFileOperation can move several files into one directory
2008/6/17 Vitaly Perov <[EMAIL PROTECTED]>:
> The test was sent 2 hours ago
> If FOF_MULTIDESTFILES flag is set it's not olny mean that pTo contains
> multiple destination files, it also can contain one folder.
>
> Changelog:
> - shell32: SHFileOperation can move several files into one directory
>
--- a/dlls/shell32/shlfileop.c
+++ b/dlls/shell32/shlfileop.c
@@ -1426,7 +1426,8 @@ static HRESULT move_files(LPSHFILEOPSTRUCTW
lpFileOp, const FILE_LIST *flFrom, c
return ERROR_CANCELLED;
if ((lpFileOp->fFlags & FOF_MULTIDESTFILES) &&
-flFrom->dwNumFiles != flTo->dwNumFiles)
+flFrom->dwNumFiles != flTo->dwNumFiles &&
+!IsAttribDir(fileDest->attributes))
{
return ERROR_CANCELLED;
}
There is a glaring error right here. For one, you should heed
compiler warnings:
wine/dlls/shell32/shlfileop.c: In function 'SHFileOperationW':
wine/dlls/shell32/shlfileop.c:1428: warning: 'fileDest' is used
uninitialized in this function
wine/dlls/shell32/shlfileop.c:1407: note: 'fileDest' was declared here
You're using fileDest when it hasn't been initialized (as the warning
says). Second, the tests fail:
shlfileop.c:1132: Test failed: The file is not moved - many files are
specified as a target
shlfileop.c:1206: Test failed: Expected d.txt to not exist
make: *** [shlfileop.ok] Error 2
--
James Hawkins
Re: Wine release 1.0
Congratulations! On Tue, Jun 17, 2008 at 4:20 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > The Wine team is proud to announce that Wine 1.0 is now available. > This is the first stable release of Wine after 15 years of development > and beta testing. Many thanks to everybody who helped us along that > long road! > > While compatibility is not perfect yet, thousands of applications have > been reported to work very well. Check http://appdb.winehq.org to see > the details for your favorite applications. > > The source is available from the following locations: > > http://ibiblio.org/pub/linux/system/emulators/wine/wine-1.0.tar.bz2 > http://prdownloads.sourceforge.net/wine/wine-1.0.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/site/download > > You will find documentation on http://www.winehq.org/site/documentation > > You can also get the current source directly from the git > repository. Check http://www.winehq.org/site/git for details. > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > > > Bugs fixed in 1.0: > > 3838 The Punisher demo crashes after the introduction movies > 3898 Counter-Strike 1.6 performance issue > 4755 X Error of failed request: BadDrawable (X_PolyFillRectangle) when > switching to Virtual Desktop > 6315 Starlancer draws ships as white when direct3d is enabled > 7268 Oni not opening after install > 8185 can't login in Skype 3.1 on wine/kubuntu 7 > 8634 antialiasing disabled in gtasa menu > 9555 Wine crash when I click help in Stata 10 > 9589 Static / Scratchy Sound with OSS in Call of Duty > 9903 WinRAR with NXServer - black icons > 10009 QIP: window z-order is still wrong > 10268 Robot Wars: Arena of Destruction crashes while quitting (causing > resolution to stay 640 x 480) > 10322 Eve-online (video memory misaddressed?) > 10700 Dragon Naturally Speaking 9 needs gdiplus.GdipDrawArcI, > gdiplus.GdipCreatePen2, ... > 11011 Call of Duty 1.0 doesn't run after install. > 11104 Dance Praise 2: Does not respond to input > 12415 Can not leave fullscreen Warcraft 3x (Regression) > 12963 Moto Racer 2 works with wine 0.9.60 and crashes with wine 0.9.61 > 13271 The demo of the punisher fails to install > 13740 winebrowser gets wrong URL, problem with unicode > > > > Changes since 1.0-rc5: > > Alexandre Julliard (1): > Updated the authors list. > > Francois Gouget (3): > Remove spaces before '...' in the Danish resources. > regedit: Remove spaces before '...'. > winecfg: Remove spaces before '...'. > > Jaime Rave (1): > wineconsole: Update Spanish translation. > > Matthias Kupfer (1): > wordpad: Small typo fix for German translation. > > -- > Alexandre Julliard > [EMAIL PROTECTED] > >
Re: Celebrating Wine 1.0
The site was slashdotted a few hours ago, but it seems to be stable now. /dev/null took my words of praise in the WineHQ outage though: On Tue, Jun 17, 2008 at 7:23 PM, Remco <[EMAIL PROTECTED]> wrote: > And it's DOWN! The web server couldn't handle the excitement I guess. > > As a user, I want to thank all the developers for all their hard work > in the past 15 years. I was 5 years old when you guys started, and > because of you I could switch to Linux, about 10 years later. I like > to play a video game now and then, and Wine makes it possible. I just > take a look at the AppDB before I decide to buy a game, and usually I > can. Thanks again! > > Remco > > On Tue, Jun 17, 2008 at 6:26 PM, Dimi Paun <[EMAIL PROTECTED]> wrote: >> >> On Tue, 2008-06-17 at 09:55 -0500, Jeremy White wrote: >>> Woohoo >>> >>> Alexandre just posted the Wine 1.0 commit! I eagerly did my git >>> update and enjoyed running 'wine --version'. Ooo. I'm going to do it >>> again... >> >> Wow, this is the moment we've all been waiting for! >> >> Congratulations everybody, this is way cool indeed. >> >> And I must say, this would not have been possible >> without Alexandre's amazing contribution. Kudos! >> >> -- >> Dimi Paun <[EMAIL PROTECTED]> >> Lattica, Inc. >> >> >> >> >
Re: Website down
Yep, front page of Digg can be a website killer. We seem to be coming out of it now. At least the server didn't completely melt. *knock on wood* -Newan Austin English wrote: > Did we get slashdotted/dugg to death? > > -Austin > >
Re: About code freeze...
Alex Villacís Lasso wrote: > Wine 1.0 is out! Great! > > Does this mean we are now out of code freeze? I have a bunch of richedit > patches I submitted previously but were held up because of the code > freeze. Is it time to submit them again? > AJ said earlier in IRC that the Code Freeze is now over so I would assume everyone is ok to continue sending as usual. Ben H.
re: Fix DirectSound's primary buffer Volume and Pan handling
On Jul 23, 2004, Francois Gouget wrote:
> The patch removes the primary buffer's 'volpan' variable and instead
> uses waveOutGetVolume() on dsound->hwo to get the current volume.
This seems to be failing for me here on three different machines
during the primary part of test_secondary() in dsound/tests/ds3d.c.
You can see evidence of this in valgrind logs, e.g.
http://kegel.com/wine/valgrind/logs-2007-12-06/vg-dsound_ds3d.txt
or
http://kegel.com/wine/valgrind/logs-2008-06-16/vg-dsound_ds3d.txt
you can see valgrind getting annoyed that waveOutGetVolume
didn't actually retrieve anything:
Conditional jump or move depends on uninitialised value(s)
at DSOUND_AmpFactorToVolPan (mixer.c:66)
by PrimaryBufferImpl_GetVolume (primary.c:646)
by test_secondary (ds3d.c:864)
by dsenum_callback (ds3d.c:1303)
by DirectSoundEnumerateA (dsound_main.c:315)
by ds3d_tests (ds3d.c:1324)
by func_ds3d (ds3d.c:1344)
by run_test (test.h:449)
by main (test.h:498)
Uninitialised value was created by a stack allocation
at PrimaryBufferImpl_GetVolume (primary.c:627)
The test nevertheless happens to succeed on some machines,
but not others. One machine it fails on (even without valgrind) says
ds3d.c:896: Test failed: The primary pan changed from 673 to 656
because, I think, it's calculating the pan based on random
values on the stack.
A +dsound,+alsa,+wave log (and a few extra trace statements) shows
trace:dsound:PrimaryBufferImpl_GetPan (0x132258,0x32fa48)
trace:wave:ALSA_wodMessage (0, WODM_GETVOLUME, , 0032F8E4, );
trace:wave:wodGetVolume (0, 0x32f8e4);
trace:wave:wodGetVolume wDevId 0, hctl (nil)
trace:alsa:ALSA_CheckSetVolume line 470; hctl (nil)
trace:wave:wodGetVolume CheckSetVolume failed; rc 8
trace:dsound:DSOUND_AmpFactorToVolPan (0x32f8c8)
trace:dsound:DSOUND_AmpFactorToVolPan left=3b34, right=7e59
trace:dsound:DSOUND_AmpFactorToVolPan Vol=-611 Pan=656
ds3d.c:896: Test failed: The primary pan changed from 673 to 656
ALSA_CheckSetVolume returns right early because hctl is NULL.
I threw together a small test illustrating the problem;
see the attached patch and log from problem machine.
(Note that sound works on this machine, and running the main
ds3d tests with WINETEST_INTERACTIVE=1 yields many tones
in the headphones.)
Could somebody who knows this code have a look? Thanks!
- Dan
diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c
index 112bb39..10ea7be 100644
--- a/dlls/dsound/primary.c
+++ b/dlls/dsound/primary.c
@@ -628,6 +628,7 @@ static HRESULT WINAPI PrimaryBufferImpl_
DirectSoundDevice *device = ((PrimaryBufferImpl *)iface)->device;
DWORD ampfactors;
DSVOLUMEPAN volpan;
+MMRESULT mmres;
TRACE("(%p,%p)\n", iface, vol);
if (!(device->dsbd.dwFlags & DSBCAPS_CTRLVOLUME)) {
@@ -640,7 +641,12 @@ static HRESULT WINAPI PrimaryBufferImpl_
return DSERR_INVALIDPARAM;
}
- waveOutGetVolume(device->hwo, &factors);
+ mmres = waveOutGetVolume(device->hwo, &factors);
+if (mmres != MMSYSERR_NOERROR) {
+WARN("can't get volume\n");
+return DSERR_GENERIC;
+}
+
volpan.dwTotalLeftAmpFactor=ampfactors & 0x;
volpan.dwTotalRightAmpFactor=ampfactors >> 16;
DSOUND_AmpFactorToVolPan(&volpan);
diff --git a/dlls/dsound/tests/ds3d.c b/dlls/dsound/tests/ds3d.c
index e20dc21..084dfb4 100644
--- a/dlls/dsound/tests/ds3d.c
+++ b/dlls/dsound/tests/ds3d.c
@@ -1318,6 +1318,92 @@ static BOOL WINAPI dsenum_callback(LPGUI
return 1;
}
+static HRESULT test_volume(LPGUID lpGuid)
+{
+HRESULT rc;
+LPDIRECTSOUND dso=NULL;
+LPDIRECTSOUNDBUFFER primary=NULL;
+DSBUFFERDESC bufdesc;
+int ref;
+
+/* Create the DirectSound object */
+rc=pDirectSoundCreate(lpGuid,&dso,NULL);
+ok(rc==DS_OK||rc==DSERR_NODRIVER,"DirectSoundCreate() failed: %s\n",
+ DXGetErrorString8(rc));
+if (rc!=DS_OK)
+return rc;
+
+/* We must call SetCooperativeLevel before creating primary buffer */
+/* DSOUND: Setting DirectSound cooperative level to DSSCL_PRIORITY */
+rc=IDirectSound_SetCooperativeLevel(dso,get_hwnd(),DSSCL_PRIORITY);
+ok(rc==DS_OK,"IDirectSound_SetCooperativeLevel(DSSCL_PRIORITY) failed: "
+ "%s\n",DXGetErrorString8(rc));
+if (rc!=DS_OK)
+goto EXIT;
+
+ZeroMemory(&bufdesc, sizeof(bufdesc));
+bufdesc.dwSize=sizeof(bufdesc);
+bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER;
+bufdesc.dwFlags|=(DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN);
+rc=IDirectSound_CreateSoundBuffer(dso,&bufdesc,&primary,NULL);
+ok((rc==DS_OK && primary!=NULL) || (rc==DSERR_CONTROLUNAVAIL),
+ "IDirectSound_CreateSoundBuffer() failed to create a primary buffer: "
+ "%s\n", DXGetErrorString8(rc));
+if (rc==DSERR_CONTROLUNAVAIL)
+trace(" No Primary\n");
+else if (rc==DS_OK && primary!=NULL) {
+LONG tvol;
+rc=IDirectSoundBuffer_GetVolume(primary,&tvol);
+ok(rc == 0, "Hey! Couldn't get volume!\n");
+}
Re: Celebrating Wine 1.0
And it's DOWN! The web server couldn't handle the excitement I guess. As a user, I want to thank all the developers for all their hard work in the past 15 years. I was 5 years old when you guys started, and because of you I could switch to Linux, about 10 years later. I like to play a video game now and then, and Wine makes it possible. I just take a look at the AppDB before I decide to buy a game, and usually I can. Thanks again! Remco On Tue, Jun 17, 2008 at 6:26 PM, Dimi Paun <[EMAIL PROTECTED]> wrote: > > On Tue, 2008-06-17 at 09:55 -0500, Jeremy White wrote: >> Woohoo >> >> Alexandre just posted the Wine 1.0 commit! I eagerly did my git >> update and enjoyed running 'wine --version'. Ooo. I'm going to do it >> again... > > Wow, this is the moment we've all been waiting for! > > Congratulations everybody, this is way cool indeed. > > And I must say, this would not have been possible > without Alexandre's amazing contribution. Kudos! > > -- > Dimi Paun <[EMAIL PROTECTED]> > Lattica, Inc. > > > >
Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.
On Sat, Dec 22, 2007 at 11:12 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > You could paste it all over winehq.org and the docs and it'll still happen. I think this argument is totally bogus. Whats viewed as illegal reverse engineering in Canada is not the same as in the United States. Having this unwritten standard just means people end up wasting more time. Lets just codify the standard practices and be done with it, then when someone violates it, send them the URL so we don't have to keep having this discussion every three months. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo
Re: Website down
Austin English wrote: > Did we get slashdotted/dugg to death? Not quite death, but it's pretty tough sailing right now. I think we could have handled one or the other, but both together are apparently more than our current systems can handle. We've stopped mysqld for the moment to try to ride through this; still trying to figure out if there is a simple way to get it through this hump. (Both Digg and /. have really short curves; the demand will be down within hours, and we can go back to business as usual). Cheers, Jeremy
Website down
Did we get slashdotted/dugg to death? -Austin
About code freeze...
Wine 1.0 is out! Great!
Does this mean we are now out of code freeze? I have a bunch of richedit
patches I submitted previously but were held up because of the code
freeze. Is it time to submit them again?
--
perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'
Re: Celebrating Wine 1.0
On Tue, 2008-06-17 at 09:55 -0500, Jeremy White wrote: > Woohoo > > Alexandre just posted the Wine 1.0 commit! I eagerly did my git > update and enjoyed running 'wine --version'. Ooo. I'm going to do it > again... Wow, this is the moment we've all been waiting for! Congratulations everybody, this is way cool indeed. And I must say, this would not have been possible without Alexandre's amazing contribution. Kudos! -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.
Celebrating Wine 1.0
Woohoo Alexandre just posted the Wine 1.0 commit! I eagerly did my git update and enjoyed running 'wine --version'. Ooo. I'm going to do it again... Let us all have a moment of silence to mourn the passing of the Wine 1.0 jokes . Seriously, this is a major milestone for the Wine project. It is no small undertaking to create a complex Free Software project, and to bring it to a state of general usefulness. There are literally millions - if not more - people using this software we have built. This is a great accomplishment, and we all should be deeply proud of what we've accomplished. I think it's particularly important to thank each and every one of the 1076 AUTHORS and to recognize the support and work of the many people that have contributed to Wine without having their name in that file. I also think we should particularly take a moment to recognize the incredible work of our fearless leader - Alexandre Julliard - without whom none of this would have been possible. And then we should celebrate! I realize that any real large communal celebration will have to wait until we can gather for Wineconf. But I intend to gather up a gang of folks and go out for a meal to celebrate. I will lift a glass of Wine in toast to Alexandre and the many people that have worked on Wine, and I encourage everyone else to do the same. Ideally, people will become sufficiently happy to wax maudlin and we can capture all kinds of embarrassing stories on #winehackers . Cheers, Jeremy
Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.
Hi,
> ole32: get_moniker_for_progid_display_name should fallback to using
> IClassFactory to get IParseDisplayName if getting it directly fails.
This fix looks OK, but still gets lots of error messages:
err:ole:apartment_getclassobject DllGetClassObject returned error 0x80004002
err:ole:create_server class {228d9a81-c302-11cf-9aa4-00aa004a5691} not
registered
fixme:ole:CoGetClassObject CLSCTX_REMOTE_SERVER not supported
err:ole:CoGetClassObject no class object
{228d9a81-c302-11cf-9aa4-00aa004a5691} could be created for context
0x15
2008/1/7 Robert Shearman <[EMAIL PROTECTED]>:
>> Then run the test:
>> $ ../../../wine ole32_test.exe.so moniker
>> err:ole:apartment_getclassobject DllGetClassObject returned error
>> 0x80004002
>> err:ole:create_server class {228d9a81-c302-11cf-9aa4-00aa004a5691} not
>> registered
>> fixme:ole:CoGetClassObject CLSCTX_REMOTE_SERVER not supported
>> err:ole:CoGetClassObject no class object
>> {228d9a81-c302-11cf-9aa4-00aa004a5691} could be created for context
>> 0x15
>> moniker.c:783: Test failed: LDAP**
>> moniker: 2 tests executed (0 marked as todo, 1 failure), 0 skipped.
>>
>> after my patch:
>> $ ../../../wine ole32_test.exe.so moniker
>> moniker.c:783: Test failed: LDAP**
>> moniker: 2 tests executed (0 marked as todo, 1 failure), 0 skipped.
>>
>> Although the test failed, but loading class
>> {228d9a81-c302-11cf-9aa4-00aa004a5691} success.
>>
>
> I've just sent a patch for this. Thanks for reporting it and going to the
> trouble of describing how to reproduce it and proposing a patch.
>
> --
> Rob Shearman
>
>
--
$ apt-get moo
(__)
(oo)
/--\/
/ | ||
* /\---/\
~~ ~~
"Have you mooed today?"...
Only 205 nonleak valgrind errors left!
Changes since yesterday: - added suppression for glibc bug in if_nameindex - added two patches by Huw, one by Rob, one by Jon, one by Roy - fixed split script; broken out error files now more complete This gets us down from 218 to 205 or so. (Please join the party! We can use all the help we can get getting rid of these bugs; though many are innocuous to users, a few aren't, and they're all annoying to anyone using valgrind. It remains to be seen how many of these patches Alexandre will accept after 1.0 is out, but I'm hopeful we can get most of them up to his standards.) Report showing unique nonleak errors: http://kegel.com/wine/valgrind/logs-2008-06-16.counts.txt Logs: http://kegel.com/wine/valgrind/logs-2008-06-16.log.gz http://kegel.com/wine/valgrind/logs-2008-06-16/ Pending wine patches: http://kegel.com/wine/valgrind/logs-2008-06-16-patches/ http://kegel.com/wine/valgrind/logs-2008-06-16-patches.tgz http://kegel.com/wine/valgrind/logs-2008-06-16-patch.txt Suppression file: http://kegel.com/wine/valgrind/valgrind-suppressions
