Re: spoolss: [2] Add a stub for IsLocalCall
2008/6/29 Detlef Riekenberg [EMAIL PROTECTED]:
/**
+ * IsLocalCall[EMAIL PROTECTED]
+ */
+BOOL WINAPI IsLocalCall()
+{
+FIXME(() stub\n);
+return TRUE;
+}
The function definition is incomplete. You should change it to BOOL
WINAPI IsLocalCall(void).
--
Rob Shearman
Re: [06/12] gdi32: Perform the world transform separately from font scaling
Am Dienstag, den 24.06.2008, 16:11 +0900 schrieb Dmitry Timoshkov:
+/* World transform */
+if (!is_identity_FMAT2(font-font_desc.matrix))
+{
+FT_Matrix worldMat;
+worldMat.xx = FT_FixedFromFloat(font-font_desc.matrix.eM11);
+worldMat.xy = FT_FixedFromFloat(font-font_desc.matrix.eM21);
+worldMat.yx = FT_FixedFromFloat(font-font_desc.matrix.eM12);
+worldMat.yy = FT_FixedFromFloat(font-font_desc.matrix.eM22);
+pFT_Matrix_Multiply(worldMat, transMat);
+needsTransform = TRUE;
+}
+
This causes a regression in the German computer-aided tax form printing
program Elster-Formular. Previously, font scaling worked like in the
GM_COMPATIBLE graphics mode (set via SetGraphicsMode on the DC), that
is, mainly abs(yy) is used as scaling factor, and that's it. This change
introduces something like the GM_ADVANCED graphics mode, but does it
wrong (for example, the origin for reflections should be the point
specified in TextOut, currently, reflections are done relative to the
base line of the character; also the background is not reflected at
all). I have attached a simple test program to show what happens in wine
with a scaling that inverts the y axis (as the German tax program uses).
Its expected output would be to characters looking the same at the same
Y position, which is what I get in windows, and also with Wine 1.0.
If the GM_ADVANCED line is activated, expected output would be the first
F as is, and the second F upside down above the line, with the
lowest part of the white box touching the black line. No Wine version
does handle this case correctly.
Regards,
Michael Karcher
#include windows.h
LRESULT CALLBACK wndproc(HWND wnd, UINT msg, WPARAM wp, LPARAM lp)
{
if(msg == WM_PAINT)
{
HDC dc;
PAINTSTRUCT ps;
HFONT fnt, oldfont;
dc = BeginPaint(wnd, ps);
SetMapMode(dc, MM_ANISOTROPIC);
/* SetGraphicsMode(dc, GM_ADVANCED);*/
fnt = CreateFont(-20, 0, 0, 0, FW_MEDIUM,
FALSE, FALSE, FALSE, ANSI_CHARSET,
OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS,
DEFAULT_QUALITY, DEFAULT_PITCH, Arial);
oldfont = SelectObject(dc, fnt);
MoveToEx(dc,0,50, NULL);
LineTo(dc,100, 50);
TextOut(dc, 20, 50, F, 1);
SetWindowExtEx(dc, 800, 800, NULL);
SetViewportExtEx(dc, 800, -800, NULL);
SelectObject(dc, oldfont);
SelectObject(dc, fnt);
TextOut(dc, 50, -50, F, 1);
DeleteObject(SelectObject(dc, oldfont));
EndPaint(wnd, ps);
}
else if(msg == WM_DESTROY)
PostQuitMessage(0);
else
DefWindowProc(wnd, msg, wp, lp);
}
int main(void)
{
static WNDCLASS wc = {0};
MSG msg;
HWND mainwnd;
wc.lpfnWndProc = wndproc;
wc.hCursor = LoadCursor(NULL, MAKEINTRESOURCE(IDC_ARROW));
wc.hbrBackground = (HBRUSH)(COLOR_APPWORKSPACE+1);
wc.lpszClassName = sclfont;
RegisterClass(wc);
mainwnd = CreateWindow(sclfont, Font scaling test, WS_OVERLAPPEDWINDOW | WS_VISIBLE,
CW_USEDEFAULT, CW_USEDEFAULT, 200, 200, 0, 0, 0, 0);
while(GetMessage(msg, NULL, 0, 0))
{
TranslateMessage(msg);
DispatchMessage(msg);
}
return 0;
}
Re: cryptui(2/3): Document definitions missing from public header
Juan Lang [EMAIL PROTECTED] writes: +/* These definitions probably belong in cryptuiapi.h, but the PSDK doesn't have + * them, so define them here. + */ The latest version of the PSDK does have them AFAICS. -- Alexandre Julliard [EMAIL PROTECTED]
UUID lookup utility
To be able to check quickly what a UUID in Bugzilla means, I wrote a script to show some information about them. It uses data retrieved from Windows and Wine include files and registries (it finds information about more than 32000 different UUIDs). If someone is interested in it, I have put to on http://pf128.krakow.sdi.tpnet.pl/uuid.tgz . It's written in JavaScript and works under Firefox 1.5+ (it would require some small modifications to work on IE). Mikołaj Zalewski
Re: Bugzilla search
Try it now. Vitaliy Margolen wrote: Any time I'm trying to search for bugs with anything more then just a simple string in the subject I'm getting a blank page. This didn't happen before. This makes searching for bugs impossible. Can some one look into this? Vitaliy.
Re: Bugzilla search
Jeremy Newman wrote: Try it now. Much better, thanks. Vitaliy.
Re: programs: add rudimentary dxdiag
Hi, any comments on this one? btw, is there a reason i never ever receive any comments on my patches when they are rejected? If so, please tell me, that'll save me a lot of time of sending them in... I'll bite. One comment for both questions: it's too big. No comment from AJ usually means either, this is too big, I'll look at it later, or I think there's something wrong with it, but I don't know what yet, I'll look at it later. Of course new patches come along, and you eventually get dropped from the queue. You can split this up. Try adding a stub program with one patch then adding a bit at a time. --Juan
Re: programs: add rudimentary dxdiag
On Mon, Jun 30, 2008 at 9:50 AM, Louis. Lenders [EMAIL PROTECTED] wrote: Hi, any comments on this one? btw, is there a reason i never ever receive any comments on my patches when they are rejected? If so, please tell me, that'll save me a lot of time of sending them in... - Forwarded Message From: Louis. Lenders [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, 26 June, 2008 3:20:04 AM Subject: Re: programs: add rudimentary dxdiag Hi, some apps like Gameshadow (http://www.gameshadow.com/) check for dxdiag.exe, and give an error if it's not found, so wine needs its own. Instead of simple stub, this patch also adds the (simplified) d3d test like seen in native dxdiag, so users can test if their d3d is setup correctly. Screenshot can be seen here: http://bugs.winehq.org/attachment.cgi?id=14342 A few remarks: -patch contains binary code for a bitmap, so to apply again i had to do git apply dx.patch git add programs/dxdiag/ tools/make_makefiles autoconf maybe there's a simpler way, but i dunno - code for spinning cube was partially based on spinning cube code scattered all over the internet -rest was ripped of winecfg - There' s a problem while minizing the d3d-window, but running it in wine-0.9.22 it all goes fine, so this must be a regression somewhere, and not a bug in the attached code. I'll go after that later. - Hopefully you're not to picky on this patch, it 's quite some line's of code,and i'm sure things need to be improved, but this does not affect wine's core code but os rather an enhancement, and it 's not really possible to send it in in small chuncks. Not happy with your email address? Get the one you really want - millions of new email addresses available now at Yahoo! Not happy with your email address? Get the one you really want - millions of new email addresses available now at Yahoo! Like I said in the bug, you should add dxdiag to configure.ac/Makefile.in/etc. -Austin
Re: Some conformance tests a bit slow under Valgrind
On Fri, Jun 27, 2008 at 12:43 PM, Dylan Smith [EMAIL PROTECTED] wrote: Rather than using one URL for all the messages, you could also cycle through URL after testing them initially. It would have the same performance of using the same valid URL, but keeps the variety in the test. I ended up looking at the test more to fix a valgrind error, and noticed that my patch should probably only cycle over valid urls instead of all of them. The valid urls could be moved to the front of the urls array, and then index can be use the number of valid urls to mod by, rather than the total number of urls. I am attaching a rough patch to show what I mean, and so I can give everyone an idea of the impact this type of change makes. The following are times from calling runtest for the editor tests of riched20.dll before and after the patch. Before: real1m6.924s user0m42.067s sys0m7.148s After: real0m11.539s user0m3.876s sys0m0.956s Dan, was this enough of a difference for the time the tests take to run?
Re: advapi32: Fix a test failure on a non-admin XP system
James Hawkins wrote: Hi, Changelog: * Fix a test failure on a non-admin XP system. dlls/advapi32/tests/registry.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) This one has puzzled me for some time. Every now and then we find an XP box that receives this ERROR_ACCESS_DENIED error. Non of the other tests for such a system indicate however that there are rights issues. We have several tests that skip tests if there are not enough rights and they would show on test.winehq.org. So maybe that patch is correct but the circumstances? -- Cheers, Paul.
[ANNOUNCE] ciopfs-0.2
Hi, Just in case someone is interested in a fuse based case insensitive overlay file system. I have just released ciopfs 0.2 which implements unicode support based on glib and has better error handling in out of memory situations. http://www.brain-dump.org/projects/ciopfs/ Have fun, Marc -- Marc Andre Tanner http://www.brain-dump.org/ GPG key: CF7D56C0
Re: mshtml.dll:Add IPersistPropertyBag interface to HTMLDocument
Ivan Sinitsin wrote: Changelog Add IPersistPropertyBag interface to HTMLDocument HTMLDocument shouldn't implement IPersistPropertyBag interface, which is proved by patch I've just sent. The fact that app queries for interface doesn't mean we should implement it. Please test such thing in the future. Jacek
user32: Add additional tests for scroll state, make them pass under Wine
This patch adds a few tests for scrollbar behavior in Windows. It shows
that if the window was created with at least WS_VSCROLL or WS_HSCROLL
styles, WinXP returns default information for scrollbar range, but Win98
returns an error, until first initialized. This error does not change if
styles are set or cleared before initializing ranges. On both versions,
setting either scrollbar range automatically initializes both if
required (Wine still returned error for the other scrollbar - fix
included). I have tried to test this on Win98 and WinXP-SP2, but maybe
other versions are different. Could you please test this patch? Also, is
it OK to tell apart Win9x vs. WinXP behavior in the way it is done in
this patch? Once either behavior is identified, it is consistent on all
future tests, as shown by the tests. Wine fixed to implement Win98 behavior.
Changelog:
* Document and test differences between WinXP and Win98 scrollbar behavior
* Make tests pass under Wine (Win98 behavior)
--
perl -e '$x=2.4;print sprintf(%.0f + %.0f = %.0f\n,$x,$x,$x+$x);'
From b76e90dbc6905daf76ec0df957bc93965f22464a Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Alex=20Villac=C3=ADs=20Lasso?= [EMAIL PROTECTED]
Date: Sun, 29 Jun 2008 12:40:10 -0500
Subject: [PATCH] user32: Add additional tests for scroll state, make them pass under Wine.
---
dlls/user32/scroll.c | 36 +--
dlls/user32/tests/scroll.c | 273
2 files changed, 300 insertions(+), 9 deletions(-)
diff --git a/dlls/user32/scroll.c b/dlls/user32/scroll.c
index ddfacd6..e116357 100644
--- a/dlls/user32/scroll.c
+++ b/dlls/user32/scroll.c
@@ -140,6 +140,22 @@ static inline BOOL SCROLL_ScrollInfoValid( LPCSCROLLINFO info )
info-cbSize != sizeof(*info) - sizeof(info-nTrackPos)));
}
+static SCROLLBAR_INFO *SCROLL_AllocateInternalInfo(void)
+{
+SCROLLBAR_INFO *infoPtr;
+
+infoPtr = HeapAlloc( GetProcessHeap(), 0, sizeof(SCROLLBAR_INFO) );
+if (infoPtr)
+{
+/* Set default values */
+infoPtr-minVal = infoPtr-curVal = infoPtr-page = 0;
+/* From MSDN: max for a standard scroll bar is 100 by default. */
+infoPtr-maxVal = 100;
+/* Scroll bar is enabled by default after create */
+infoPtr-flags = ESB_ENABLE_BOTH;
+}
+return infoPtr;
+}
/***
* SCROLL_GetInternalInfo
@@ -166,16 +182,18 @@ static SCROLLBAR_INFO *SCROLL_GetInternalInfo( HWND hwnd, INT nBar, BOOL alloc )
{
if (nBar != SB_HORZ nBar != SB_VERT)
WARN(Cannot initialize nBar=%d\n,nBar);
-else if ((infoPtr = HeapAlloc( GetProcessHeap(), 0, sizeof(SCROLLBAR_INFO) )))
+else if ((infoPtr = SCROLL_AllocateInternalInfo()) != NULL)
{
-/* Set default values */
-infoPtr-minVal = infoPtr-curVal = infoPtr-page = 0;
-/* From MSDN: max for a standard scroll bar is 100 by default. */
-infoPtr-maxVal = 100;
-/* Scroll bar is enabled by default after create */
-infoPtr-flags = ESB_ENABLE_BOTH;
-if (nBar == SB_HORZ) wndPtr-pHScroll = infoPtr;
-else wndPtr-pVScroll = infoPtr;
+if (nBar == SB_HORZ)
+{
+wndPtr-pHScroll = infoPtr;
+if (!wndPtr-pVScroll) wndPtr-pVScroll = SCROLL_AllocateInternalInfo();
+}
+else
+{
+wndPtr-pVScroll = infoPtr;
+if (!wndPtr-pHScroll) wndPtr-pHScroll = SCROLL_AllocateInternalInfo();
+}
}
}
WIN_ReleasePtr( wndPtr );
diff --git a/dlls/user32/tests/scroll.c b/dlls/user32/tests/scroll.c
index 3bc407a..7b388ca 100644
--- a/dlls/user32/tests/scroll.c
+++ b/dlls/user32/tests/scroll.c
@@ -127,6 +127,219 @@ static void scrollbar_test3(void)
}
+static void scrollbar_test4(int fnBar, BOOL hBarEnabled, BOOL vBarEnabled)
+{
+SCROLLINFO si;
+LRESULT r;
+BOOL r2;
+BOOL behavior_winxp = FALSE;
+BOOL behavior_win98 = FALSE;
+
+r = GetWindowLongA(hMainWnd, GWL_STYLE);
+ok(((r WS_HSCROLL) != 0) == hBarEnabled,
+Unexpected WS_HSCROLL style, found %d expected %d\n,
+((r WS_HSCROLL) != 0), hBarEnabled);
+ok(((r WS_VSCROLL) != 0) == vBarEnabled,
+Unexpected WS_VSCROLL style, found %d expected %d\n,
+((r WS_VSCROLL) != 0), vBarEnabled);
+
+trace(Testing bar type %d with initial style (%d,%d)\n, fnBar, hBarEnabled, vBarEnabled);
+
+si.cbSize = sizeof(si);
+si.fMask = SIF_RANGE | SIF_PAGE | SIF_POS;
+si.nMin = si.nMax = si.nPos = si.nPage = 0xdeadbeef;
+SetLastError(0xdeadbeef);
+r2 = GetScrollInfo(hMainWnd, fnBar, si);
+r = GetLastError();
+if (!(hBarEnabled || vBarEnabled)) {
+ok(!r2, GetScrollInfo incorrectly succeeded\n);
+ok(( r == ERROR_NO_SCROLLBARS /* WinXP */
+|| r ==
Re: user32: Add additional tests for scroll state, make them pass under Wine
On Mon, Jun 30, 2008 at 3:34 PM, Alex Villacís Lasso
[EMAIL PROTECTED] wrote:
This patch adds a few tests for scrollbar behavior in Windows. It shows that
if the window was created with at least WS_VSCROLL or WS_HSCROLL styles,
WinXP returns default information for scrollbar range, but Win98 returns an
error, until first initialized. This error does not change if styles are set
or cleared before initializing ranges. On both versions, setting either
scrollbar range automatically initializes both if required (Wine still
returned error for the other scrollbar - fix included). I have tried to test
this on Win98 and WinXP-SP2, but maybe other versions are different. Could
you please test this patch? Also, is it OK to tell apart Win9x vs. WinXP
behavior in the way it is done in this patch? Once either behavior is
identified, it is consistent on all future tests, as shown by the tests.
Wine fixed to implement Win98 behavior.
Why in the world would you implement Win98 behavior over WinXP,
especially since the WinXP behavior is more logical and (probably,
haven't looked) stated on msdn?
+if (!(hBarEnabled || vBarEnabled)) {
+ok(!r2, GetScrollInfo incorrectly succeeded\n);
+ok(( r == ERROR_NO_SCROLLBARS /* WinXP */
+|| r == 0xdeadbeef /* Win98 */ ),
+GetLastError returned 0x%08lx expected 0x%08x
(ERROR_NO_SCROLLBARS or 0xdeadbeef)\n,
+r, ERROR_NO_SCROLLBARS);
That's hideous spacing just for the sake of lining up some error codes.
+ok(si.nMin == 0xdeadbeef, si.nMin == 0x%x, expected
0xdeadbeef\n, si.nMin);
+ok(si.nMax == 0xdeadbeef, si.nMax == 0x%x, expected
0xdeadbeef\n, si.nMax);
+ok(si.nPos == 0xdeadbeef, si.nPos == 0x%x, expected
0xdeadbeef\n, si.nPos);
+ok(si.nPage == 0xdeadbeef, si.nPage == 0x%x, expected
0xdeadbeef\n, si.nPage);
+
+if (r == ERROR_NO_SCROLLBARS) behavior_winxp = TRUE;
+if (r == 0xdeadbeef) behavior_win98 = TRUE;
+} else {
+if (r2) {
+ok(si.nMin == 0, si.nMin == %d, expected 0\n, si.nMin);
+ok(si.nMax == 100, si.nMax == %d, expected 100\n, si.nMax);
+ok(si.nPos == 0, si.nPos == %d, expected 0\n, si.nPos);
+ok(si.nPage == 0, si.nPage == %d, expected 0\n, si.nPage);
+
+behavior_winxp = TRUE;
+} else {
+ok(r == 0xdeadbeef, GetScrollInfo failed, error is %ld
(0x%08lx) expected 0xdeadbeef\n, r, r);
+
+behavior_win98 = TRUE;
+}
+}
This is seriously complex (in a bad way). I think you've tried to
factor too much into one function. You don't need to set and check
the version, just test for both cases that are expected, like all the
other tests:
ok(si.nMin == 0 ||
si.nMin == 0xdeadbeef, si.nMin == 0x%x, expected 0 or
0xdeadbeef\n, si.nMin);
--
James Hawkins
Re: user32: Add additional tests for scroll state, make them pass under Wine
Why in the world would you implement Win98 behavior over WinXP,
especially since the WinXP behavior is more logical and (probably,
haven't looked) stated on msdn?
I did not implement Win98 behavior - it was already implemented that way
in Wine, except for one difference that was found and changed to be
consistent. Having said that, I agree that it is better to implement the
WinXP behavior. I will do that in a future patch.
Reece Dunn escribió:
2008/6/30 James Hawkins [EMAIL PROTECTED]:
On Mon, Jun 30, 2008 at 3:34 PM, Alex Villacís Lasso
[EMAIL PROTECTED] wrote:
...
+ok(si.nMin == 0xdeadbeef, si.nMin == 0x%x, expected
0xdeadbeef\n, si.nMin);
+ok(si.nMax == 0xdeadbeef, si.nMax == 0x%x, expected
0xdeadbeef\n, si.nMax);
+ok(si.nPos == 0xdeadbeef, si.nPos == 0x%x, expected
0xdeadbeef\n, si.nPos);
+ok(si.nPage == 0xdeadbeef, si.nPage == 0x%x, expected
0xdeadbeef\n, si.nPage);
+
+if (r == ERROR_NO_SCROLLBARS) behavior_winxp = TRUE;
+if (r == 0xdeadbeef) behavior_win98 = TRUE;
+} else {
+if (r2) {
+ok(si.nMin == 0, si.nMin == %d, expected 0\n, si.nMin);
+ok(si.nMax == 100, si.nMax == %d, expected 100\n, si.nMax);
+ok(si.nPos == 0, si.nPos == %d, expected 0\n, si.nPos);
+ok(si.nPage == 0, si.nPage == %d, expected 0\n, si.nPage);
+
+behavior_winxp = TRUE;
+} else {
+ok(r == 0xdeadbeef, GetScrollInfo failed, error is %ld
(0x%08lx) expected 0xdeadbeef\n, r, r);
+
+behavior_win98 = TRUE;
+}
+}
This is seriously complex (in a bad way). I think you've tried to
factor too much into one function. You don't need to set and check
the version, just test for both cases that are expected, like all the
other tests:
ok(si.nMin == 0 ||
si.nMin == 0xdeadbeef, si.nMin == 0x%x, expected 0 or
0xdeadbeef\n, si.nMin);
Francois Gouget also implemented a broken() method so you can get Wine
to do the right thing, something like:
ok(si.nMin == 0 /* XP */ ||
broken(si.nMin == 0xdeadbeef) /* 98 */ ,
si.nMin == 0x%x, expected 0 or 0xdeadbeef\n, si.nMin);
- Reece
Thanks for the reminder. I will use it.
--
perl -e '$x=2.4;print sprintf(%.0f + %.0f = %.0f\n,$x,$x,$x+$x);'
source.google.com/git author search broken?
I've been reduced to running 'git log --author=foo' locally because the author search on source.winehq.org isn't returning any results. For instance, http://source.winehq.org/git/wine.git/?a=searchh=HEADst=authors=Julliard returns zero hits. Not really a huge problem, but it'd be nice if that worked again.
Re: source.google.com/git author search broken?
On Mon, Jun 30, 2008 at 6:02 PM, Dan Kegel [EMAIL PROTECTED] wrote: I've been reduced to running 'git log --author=foo' locally because the author search on source.winehq.org isn't returning any results. For instance, http://source.winehq.org/git/wine.git/?a=searchh=HEADst=authors=Julliard returns zero hits. Not really a huge problem, but it'd be nice if that worked again. I've found that checking the re box next to the text input makes it work again for whatever reason. Yields this link: http://source.winehq.org/git/wine.git/?a=searchh=HEADst=authors=Julliardsr=1 --John Klehm P.S. source.google.com?? ;-)
new valgrind errors in gdiplus
Why this code, committed on the 21st, should only be showing valgrind errors today, I don't know. For a full and gory list of the new errors, see http://kegel.com/wine/valgrind/logs-2008-06-30/vg-gdiplus_font-diff.txt Here's a small excerpt: + Conditional jump or move depends on uninitialised value(s) +at CreateFontIndirectW (font.c:364) +by GdipCreateFontFamilyFromName (font.c:373) +by GdipGetGenericFontFamilySansSerif (font.c:516) +by test_getgenerics (font.c:206) +by func_font (font.c:253) +by run_test (test.h:449) +by main (test.h:498) + Uninitialised value was created by a stack allocation +at GdipCreateFontFamilyFromName (font.c:353) ... + Conditional jump or move depends on uninitialised value(s) +at fontcmp (freetype.c:3038) +by find_in_cache (freetype.c:3085) +by WineEngCreateFontInstance (freetype.c:3281) +by FONT_SelectObject (font.c:492) +by SelectObject (gdiobj.c:1129) +by GdipCreateFontFamilyFromName (font.c:374) +by GdipGetGenericFontFamilySansSerif (font.c:516) +by test_getgenerics (font.c:206) +by func_font (font.c:253) +by run_test (test.h:449) +by main (test.h:498) + Uninitialised value was created by a stack allocation +at GdipCreateFontFamilyFromName (font.c:353) ... + Conditional jump or move depends on uninitialised value(s) +at TranslateCharsetInfo (font.c:2577) +by WineEngCreateFontInstance (freetype.c:3319) +by FONT_SelectObject (font.c:492) +by SelectObject (gdiobj.c:1129) +by GdipCreateFontFamilyFromName (font.c:374) +by GdipGetGenericFontFamilySansSerif (font.c:516) +by test_getgenerics (font.c:206) +by func_font (font.c:253) +by run_test (test.h:449) +by main (test.h:498) + Uninitialised value was created by a stack allocation +at GdipCreateFontFamilyFromName (font.c:353) ... + Invalid free() / delete / delete[] +at notify_free (heap.c:199) +by RtlFreeHeap (heap.c:1284) +by GdipFree (gdiplus.c:122) +by GdipDeleteFontFamily (font.c:448) +by test_getgenerics (font.c:223) +by func_font (font.c:253) +by run_test (test.h:449) +by main (test.h:498) + Address 0x7f0162f0 is 0 bytes after a block of size 4,608 alloc'd +at notify_alloc (heap.c:191) +by RtlAllocateHeap (heap.c:1231) +by alloc_font (freetype.c:2840) +by WineEngCreateFontInstance (freetype.c:3301) +by FONT_SelectObject (font.c:492) +by SelectObject (gdiobj.c:1129) +by GdipCreateFontFromLogfontW (font.c:183) +by test_logfont (font.c:124) +by func_font (font.c:251) +by run_test (test.h:449) +by main (test.h:498)
new gdi32:font test failure
Hey Dmitry, A test you added in the following commit introduces ~1 failure per platform: commit 6f7457d8adaf67b457154a45deef21d5b5a87c8f Author: Dmitry Timoshkov [EMAIL PROTECTED] Date: Tue Jun 24 16:13:31 2008 +0900 gdi32: Add a test for outline text metrics. Looking at the test code, it looks like a rounding difference: font.c:302: found bitmap font System, height 16 font.c:443: gm.gmCellIncX 1366, width_orig 1366 font.c:451: gm.gmCellIncX 683, width_orig 1366 font.c:483: gm.gmCellIncX 27320, width_orig 1366 font.c:494: gm.gmCellIncX 13660, width_orig 1366 font.c:514: gm.gmCellIncX 10758, width_orig 1366 font.c:517: Test failed: incX 10758 != 10757 Thanks, James Hawkins
new inetmib1 test failures
Hi Juan, Tests you added in the following commit are failing for most systems: commit c531c117340a43dbe8668189a32e6dd27f091ce4 Author: Juan Lang [EMAIL PROTECTED] Date: Tue May 20 20:54:34 2008 -0700 inetmib1: Support the MIB2 interface table. It looks like these values aren't set on all systems (these are the results from the failing XP system): main.c:191: Test failed: expected 2, got 65539 main.c:197: Test failed: expected 2, got 65539 main.c:203: Test failed: expected 2, got 65539 These are the results from a win2k machine: main.c:191: Test failed: expected 4, got 16777221 main.c:197: Test failed: expected 4, got 16777221 main.c:203: Test failed: expected 4, got 16777221 Can you please have a look at these? Thanks, James Hawkins
Re: new inetmib1 test failures
Hi James, It looks like these values aren't set on all systems (these are the results from the failing XP system): main.c:191: Test failed: expected 2, got 65539 main.c:197: Test failed: expected 2, got 65539 main.c:203: Test failed: expected 2, got 65539 These are the results from a win2k machine: main.c:191: Test failed: expected 4, got 16777221 main.c:197: Test failed: expected 4, got 16777221 main.c:203: Test failed: expected 4, got 16777221 How odd. I was surprised by the number of test failures, since I wrote the tests on Windows XP (where they still pass for me.) Thanks for the reminder. I'll relax the test from an == to a =, which might be surprising but is at least allowed according to RFC 1157. --Juan
