Re: New Icons are very good, but not yet perfect
2009/4/25 Joel Holdsworth j...@airwebreathe.org.uk: Hi All, Great stuff with the new Tango icons for Wine - they're a definite improvement. One observation: it looks like the icons that I have installed do not have versions that have been tuned for small size: 16x16 and especially 22x22. If I understand correctly, the scaled icons were drawn for 48x48, which means that when the icon is drawn at size 22x22 in my gnome menu, there will be line width of 0.46px which looks too faint next to the other icons which have been tuned for small sizes, and have 1px lines. Does anyone know anything about this? Thanks Joel Holdsworth Are those new icons in Wine 1.1.20? Because i do not see that... :(
Re: [1/7] [wined3d] add ps_np2fixup_t ptr to shader_arb_priv (review)
James McKenzie wrote: Tobias Jakobi wrote: For review: This patchset implements np2 texcoord fixup in ARB mode. Constants used to store texture dimensions are already packed, using the same data structures like the GLSL packing code. The code is finished and works quite well. It has been tested with Max Payne 2, HL2 and FEAR. All games now work with post-processing effects and anything else that needs NP2 textures on the nvidia FX series. Greets, Tobias Tobias: Do you plan on rewriting this to work in the backend? James McKenzie Hi James, my plan is currently the following: (1) Wait until stefand has implemented backend_private_data (2) Adapt the GLSL constant packing patchset to this (trivial) (3) Adapt the ARB code (also trivial) and submit it - apart from the backend_private_data changes there isn't anything else needed (4) Write NP2 fixup code for the vertexshader-only case and implement it in GLSL (ARB is too difficult) (5) Resolve bug #14762 to fixed Greets, Tobias
Re: Reparse point unit tests patches
On So, 2009-04-26 at 13:18 +1000, Paul TBBle Hampson wrote: [PATCH 2/2] Add unit tests for junction points using reparse point interface http://www.winehq.org/pipermail/wine-patches/2009-January/067227.html I didn't test the patches, but from the quick lock: The test must compile with the Microsoft VC toolchain. That might break, when you define a struct in your source without a guard #ifndef. Much better is the use of the correct header for that. + /* Stuff that lives in ntifs.h, according to MSDN */ It's in ddk/ntifs.h in OpenWatcom. + buf[bytes] = '\0'; Your debugstrn_w is broken. Your Code writes to unallocated memory, when WideCharToMultiByte need more bytes as you provided. + (WCHAR*)(((char*) That looks really ugly. + static void InitFunctionPointers(void) A private function with mixed case can be mixed up with an Windows API function, when used. Please use lowcase here. Please avoid to use the current Directory. I suggest to use a temporary directory below GetTempPath and create your test directories there + skip(kernel32 does not export required functions.\n); Please use win_skip here -- By by ... Detlef
Re: Old regression in Autocad
The regression is completed by this one : -Second regression : Don't show second registration page and help contents 8d28f09d8a582ff499b5947a5a2d1cf2700fb259 is first bad commit commit 8d28f09d8a582ff499b5947a5a2d1cf2700fb259 Author: Jacek Caban ja...@codeweavers.com Date: Tue Dec 30 06:48:59 2008 +0100 mshtml: Wine Gecko 0.9.0 release. :04 04 40390dae8dde3dbef05e4f754437e7b8129703d9 a0ba652e905b5b7cf1e39566232dbcb9558e4993 M dlls This patch completed the regression and added a new problem : AutoCAD help content is no longer displayed. Now, I don't know if to open a couple of new bugs, just one or nothing. The first regression I spotted broke the first registration page, which worked anyways *only* with native shlwapi. The second one broke the whole autocad help system (which had indeed already some problems...) and also the second registration page, even if the first patch is withdrawn. Ciao Max
Re: kernel32/tests: Added last error tests for GetPrivateProfileString
On Thu, Apr 23, 2009 at 10:06 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: Dmitry Kislyuk wrote: I don't have a particular app for you, however, there can easily be apps that would behave differently from how they would on Windows due to these last errors not being set to what the app expects. Do you have a reason why Wine behavior should not match the Windows behavior in these test cases? By Windows behavior I am referring to the more recent Windows versions of course. My understanding is that the LastError messages vary a bit between windows versions. Wine tries to be compatible with multiple windows versions so deciding which would be the right lasterror message to give is the problem that occurs. --John Klehm
Re: user32/tests: show that vertical and horizontal window scroll bar info is not created independently.
Rein Klazes wrote:
test case for bug #18102
---
dlls/user32/tests/scroll.c | 131 +++-
1 files changed, 130 insertions(+), 1 deletions(-)
diff --git a/dlls/user32/tests/scroll.c b/dlls/user32/tests/scroll.c
index 4f602c2..5cf3fcd 100644
--- a/dlls/user32/tests/scroll.c
+++ b/dlls/user32/tests/scroll.c
@@ -220,6 +220,130 @@ static void scrollbar_test_track(void)
ok( IsWindow( hScroll), Scrollbar has gone!\n);
}
+/* some tests designed to show that Horizontal and Vertical
+ * window scroll bar info are not created independently */
+static void scrollbar_test_default( DWORD style)
+{
+INT min, max, ret;
+HWND hwnd;
+SCROLLINFO si = { sizeof( SCROLLINFO), SIF_TRACKPOS };
+
+hwnd = CreateWindowExA( 0, static, , WS_POPUP | style,
+0, 0, 10, 10, 0, 0, 0, NULL);
+assert( hwnd != 0);
+
+ret = GetScrollRange( hwnd, SB_VERT, min, max);
+ok( ret ||
+broken( !ret) /* Win 98/ME */
+, GetScrollRange failed.\n);
No comments on the patch as I don't know enough of this stuff. The comma
at the start of a new line looks strange though (couple of these in the
patch).
+scrollbar_test_default( 0);
+if( 0) { /* enable this when the todo's in scrollbar_test_default are fixed */
+scrollbar_test_default( WS_HSCROLL);
+scrollbar_test_default( WS_VSCROLL);
+scrollbar_test_default( WS_HSCROLL | WS_VSCROLL);
+}
Does Wine crash on these?
--
Cheers,
Paul.
Re: user32/tests: show that vertical and horizontal window scroll bar info is not created independently.
On Sun, 26 Apr 2009 19:46:24 +0200, you wrote:
+scrollbar_test_default( 0);
+if( 0) { /* enable this when the todo's in scrollbar_test_default are fixed
*/
+scrollbar_test_default( WS_HSCROLL);
+scrollbar_test_default( WS_VSCROLL);
+scrollbar_test_default( WS_HSCROLL | WS_VSCROLL);
+}
Does Wine crash on these?
No, but it would give a number of succeeded test in todo blocks.
The effort into putting temporary logic there to silence them seems
better spent on getting rid of the todo's in the first place. Which I
will try to do in the next couple of days.
Rein.
Re: Romanian translation
I'm pretty sure you should adapt Windows terminology. That's what's being done with other languages, AFAIK. 2009/4/26 Dimitriu Petru petrime...@gmail.com: Good day. I'm a Romanian ReactOS translator. (For those who don't know, ReactOS is an operating system which seeks to be 100% compatible and similar to Windows NT.) Many translations from Wine are passed to the ReactOS project when synchronizing the source code. That leads to the fact that I can't directly translate and/or update any translation of ReactOS files that are in sync with Wine. Some translations are already done here on the Wine project but some of them are wrong (For example Basic colours is translated incorrectly as Culori de basă when the correct translation is Culori de bază), others don't fit with the rest of the translations (The translations of ReactOS should retain the terminology used in Windows. In Windows, Cancel is translated to Revocare, in Wine the translation is Renunţă which is the imperative form of the verb a renunţa - to give up). I was told I should speak to you if I want to change these translations but the problem is that many Linux distributions are translated in Romanian using Renunţă as Cancel etc and if I try to change the translation in Wine, then the Romanian Linux-users will strongly disagree ... Now that's a problem! What do you suggest I should do? -- Adys
Re: winedbg: add a crash dialog for --auto mode
2009/4/16 Mikołaj Zalewski miko...@zalewski.pl: This version of the patch uses the now implemented GetProcessImageFileName. From 549bdead0736d63bc2c05557b6813a64b53aa2ec Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Miko=C5=82aj_Zalewski?= miko...@zalewski.pl Date: Sun, 21 Dec 2008 22:28:32 +0100 Subject: [PATCH] winedbg: add a crash dialog for --auto mode --- dlls/kernel32/tests/debugger.c | 96 ++- programs/winedbg/Makefile.in |5 +- programs/winedbg/crashdlg.c| 172 programs/winedbg/debugger.h|6 ++ programs/winedbg/intvar.h |3 + programs/winedbg/resource.h| 34 programs/winedbg/rsrc.rc | 26 ++ programs/winedbg/rsrc_En.rc| 53 programs/winedbg/tgt_active.c | 16 +++- programs/winedbg/winedbg.c | 36 +--- 10 files changed, 392 insertions(+), 55 deletions(-) Howdy Mikołaj, Looks like this patch caused a regression in http://bugs.winehq.org/show_bug.cgi?id=18216. Could you have a look? Before, it would crash, but the app continued on happily. After the crash dialog patch, the debugger is spawned infinitely, until the X client limit is reached. Seems to be hitting a loop somewhere... -- -Austin
