Re: DXTn textures in D3DX9
Ben Klein schrieb: 2009/5/23 Stefan Dösinger stefandoesin...@gmx.at: Am Freitag, 22. Mai 2009 19:15:22 schrieb Roderick Colenbrander: So what they are saying is that Nvidia has a license on the s3tc patent for use in those tools but if we would rip their code out we wouldn't be covered unless (but that is gray area) we put all their image code in wine (which would be impossible since it is C++). Perhaps if we want to be safe we could ask s3 for a license for use in Wine? Hmm. My idea would have been to link against this lib, but if it is C++ it makes troubles. Interestingly enough, nvidia-texture-tools is MIT license and provides no provision for patent protection. In theory, a fork of this project to C would be linkable with Wine without legal issues. Their FAQ states that [we] don't have to obtain a license of the S3TC patent to use any of NVIDIA's products but it also adds that certain uses of NVIDIA Texture Tools source code cannot be considered NVIDIA products anymore. Thus, forking the project and integrating it into Wine would probably have the same legal status as writing an own S3TC (de)compressor within Wine. Seems like asking for a license or directly using the binaries of this lib are the only options we have then. Forking NVIDIA TT and disable it by default would probably not be accepted by AJ I guess...
Re: Mac OS X Joystick problem
On Fri, May 22, 2009 at 4:54 AM, Mike Kronenberg mike.kronenb...@kronenberg.org wrote: On 22.05.2009, at 05:05, Nathan Gray wrote: On Thu, May 21, 2009 at 10:45 AM, Aric Stewart a...@codeweavers.com wrote: Well the Mac OS X Joystick code will only work on Leopard. So you will have to build and run it on Leopard box using xcode3. I'm certainly running on Leopard, but I can't say how Mike built it. If you are good there then try building the winetests for dinput and run them with your joystick plugged in. You should get some status traces about your joystick (finding the name and status of the various axes and buttons) I guess I'll see if I can find time to set up a build environment. The last time I tried I could never build a fully-functional wine despite hours of effort. Thanks, -n8 -- http://n8gray.org Hi Natahn, I have a focus on simple enduser products :) Thats why my downloadable builds are all made on Tiger (XCode 2.x) to have a single app running on both systems. But the script from my building environment is made to build on Leopard (XCode 3.x) , too. I guess that explains it -- thanks for clarifying. You may want to add a note somewhere that joysticks won't work with your builds to save some frustration. Thanks, -n8 -- http://n8gray.org
Re: Mac OS X Joystick problem
On Thu, May 21, 2009 at 10:45 AM, Aric Stewart a...@codeweavers.com wrote: If you are good there then try building the winetests for dinput and run them with your joystick plugged in. You should get some status traces about your joystick (finding the name and status of the various axes and buttons) Ok, I built everything with Mike's build environment (after a bit of updating URLs and such). From within the build directory I can run dinput_test.exe and I get output like this (moving the stick and pushing some buttons): [n8g...@golux]% wine programs/winetest/dinput_test.exe joystick joystick.c:616: -- Testing Direct Input Version 0x0700 -- fixme:dinput:get_osx_device_elements Unhandled type 513 fixme:dinput:get_osx_device_elements Unhandled type 513 joystick.c:206: Microsoft SideWinder Precision Pro (USB) joystick.c:572: joystick.c:591: X 1976 Y-1061 Z0 Rx0 Ry0 Rz -323 S0-1056 S10 POV0 9000 POV1 -1 POV2 -1 POV3 -1 B 0 0 0 1 1 0 0 1 0 0 0 0 joystick.c:596: joystick.c:616: -- Testing Direct Input Version 0x0500 -- fixme:dinput:get_osx_device_elements Unhandled type 513 fixme:dinput:get_osx_device_elements Unhandled type 513 joystick.c:206: Microsoft SideWinder Precision Pro (USB) joystick.c:572: joystick.c:591: X 2000 Y-1101 Z0 Rx0 Ry0 Rz -323 S0-1088 S10 POV0 9000 POV1 -1 POV2 -1 POV3 -1 B 0 0 0 1 1 0 0 1 0 0 0 0 joystick.c:596: joystick.c:616: -- Testing Direct Input Version 0x0300 -- joystick: 251 tests executed (0 marked as todo, 0 failures), 0 skipped. If that is working then it may be how the games interact with dinput so it become not a mac specific issue. However, I still don't get any axes detected in the IL2 demo. During launch it produces this output: DirectX Joystick NOT created: DirectX joystick driver: device not attached (Yes, the joystick is attached when I launch it.) I also don't get any joysticks listed in the Descent Freespace demo's setup app. Is there some other demo you can recommend that works for you? Thanks, -n8 -- http://n8gray.org
Static-ify rsaenh/mpi?
So dlls/rsaenh/mpi.c defines 13 functions that are only used there. So they could be made static by tweaking mpi.c and tomcrypt.h. However my understanding is that this files has been imported in Wine from another project so maybe it's not a good idea to diverge much from them. What do you think? Should we just leave them as is? -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner
Re: Static-ify rsaenh/mpi?
Francois Gouget wrote: So dlls/rsaenh/mpi.c defines 13 functions that are only used there. So they could be made static by tweaking mpi.c and tomcrypt.h. However my understanding is that this files has been imported in Wine from another project so maybe it's not a good idea to diverge much from them. What do you think? Should we just leave them as is? Hi Francois, I made a few of the functions in mpi.c static a while back, but stopped when there was a bug report (http://bugs.winehq.org/show_bug.cgi?id=17406) that seemed consequential but turned out to be apparently due to a bug gcc. Also one of my patches to this file was rejected, which I didn't follow up, but it may have been due to the fact that there are comments to each function in both tomcrypt.h and mpi.c, and I tried to form combined versions in the latter. -- Andy.
[patch] segv on use-after-free in dsound/buffer.c
Hello!
One of games rarely crashed with segv in line 86 of dsound/buffer.c:
85: IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This-dsb);
86: This-dsb-notify = NULL;
(sorry, I failed to save actual backtrace at the time). This looks
like typical assign-after-free bug. I've applied attached patch
(wine-1.1.7, now on 1.1.19), no crashes so far (btw, similar
*Secodary*Release method down in code uses proper order -
assign-NULL-then-release).
--- wine-1.1.7/dlls/dsound/buffer.c.orig 2009-03-14 15:28:10.0 +0300
+++ wine-1.1.7/dlls/dsound/buffer.c 2009-04-23 19:50:42.0 +0400
@@ -82,8 +82,8 @@ static ULONG WINAPI IDirectSoundNotifyImpl_Release(
TRACE((%p) ref was %d\n, This, ref + 1);
if (!ref) {
-IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This-dsb);
This-dsb-notify = NULL;
+IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This-dsb);
HeapFree(GetProcessHeap(), 0, This);
TRACE((%p) released\n, This);
}
Updating bugs in Bugzilla
Hi all, Is there any way I can have access to update bugs that I did not open in Bugzilla? I update a lot of bugs and some of them are not set correctly (incorrect component or incorrect URL). Wrong URLs are a real pain because it can lead to testing the wrong version of an app (see Bug 13371). At the moment I have to ask someone with access to make these changes for me, and they're not always done. I don't want to ask them repeatedly because they have better things to do, I'm sure, and it would be easier if I could do it myself. I have admin access on the AppDB for this reason. Is there any way I could have a similar access on Bugzilla? I had no idea where to send this email to... Thanks, Ken.
Re: DIB Engine : passing all tests
On Fri, May 22, 2009 at 6:31 PM, Massimo Del Fedele m...@veneto.com wrote: I posted on bug 421 page (as usual) latest update of my engine. It suld pass all tests in wine suite also all bitmap's todo_wines, so expect some false positive signaled by tests. Austin, could you please re-run it on your test machines ? Sorry for the delay. New residence has crappy wireless internet, need to find a better solution. Anywho, I've still got a failure: palette.c:105: Test failed: getColor=00302010 http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/gdi32:palette.html Yep, several todo's are passing now: http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/gdi32:bitmap.html Full report: http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/report.html (The user32 failure can be ignored, I get that spuriously without DIB engine). -- -Austin
Re: DIB Engine : passing all tests
Austin English ha scritto: On Fri, May 22, 2009 at 6:31 PM, Massimo Del Fedele m...@veneto.com wrote: I posted on bug 421 page (as usual) latest update of my engine. It suld pass all tests in wine suite also all bitmap's todo_wines, so expect some false positive signaled by tests. Austin, could you please re-run it on your test machines ? Sorry for the delay. New residence has crappy wireless internet, need to find a better solution. Anywho, I've still got a failure: palette.c:105: Test failed: getColor=00302010 http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/gdi32:palette.html Yep, I've seen it sorry, I checked out just the bitmap suite. It's trivial to fix, will do on next release Yep, several todo's are passing now: http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/gdi32:bitmap.html too bad that the suite marks them as failures :-) Full report: http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/report.html (The user32 failure can be ignored, I get that spuriously without DIB engine). Thank you for report. I still have to do a couple of optimizations, some font cleanups and then it'll be finished. I guess I'll setup a build machine for debian/ubuntu packages shortly. Ciao Max
Re: [patch] segv on use-after-free in dsound/buffer.c
2009/5/23 Yuriy Kaminskiy yum...@mail.ru: Hello! One of games rarely crashed with segv in line 86 of dsound/buffer.c: 85: IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This-dsb); 86: This-dsb-notify = NULL; (sorry, I failed to save actual backtrace at the time). This looks like typical assign-after-free bug. I've applied attached patch (wine-1.1.7, now on 1.1.19), no crashes so far (btw, similar *Secodary*Release method down in code uses proper order - assign-NULL-then-release). Please send patches to wine-patc...@winehq.org Thanks for helping Wine! -- -Austin
Re: DXTn textures in D3DX9
2009/5/22 Tony Wasserka tony.wasse...@freenet.de: Hi everyone, I'm working on implementing D3DXLoadSurfaceFromFileInMemory right now, but I've got a problem. The function most convert a loaded surface's data to a user specified surface format (I did not yet find a way to do it elsehow, UpdateTexture and StretchRect are to limited for that task, suggestions welcome if I missed anything). Now, if the user specifies that D3DX9 needs to convert e.g. an R8G8B8 surface to DXT1 (or to save a surface to a DXTn compressed DDS file), I'm not sure wether I can implement that behavior; on #winehackers I was told that the (de)compression part is coverered by S3's patents, but the Gimp DDS plugin and this (http://mollyrocket.com/forums/viewtopic.php?t=392) seem to provide OSS solutions for it anways. So... Can anybody tell me for sure wether I may implement this code or not? What it comes down to is that I don't think we want to take that risk, so essentially No.
re: Updating bugs in Bugzilla
Ken Sharp asked: [Can I have bugzilla privs?] OK, you have them now. Please them wisely.
Re: Static-ify rsaenh/mpi?
On Sat, 23 May 2009, Andrew Talbot wrote: [...] I made a few of the functions in mpi.c static a while back, but stopped when there was a bug report (http://bugs.winehq.org/show_bug.cgi?id=17406) that seemed consequential but turned out to be apparently due to a bug gcc. The bug is with -O3 which is not the default and which I would not personally care about. I'd be more open about maintenance issues. -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service
Re: Static-ify rsaenh/mpi?
Francois Gouget wrote: The bug is with -O3 which is not the default and which I would not personally care about. I'd be more open about maintenance issues. My inclination would be to make the functions static. However, how to handle the comments is an issue to consider. Also, I probably made a mistake in moving functions around at the same time in order to avoid unnecessary forward references: perhaps that is best treated as a separate exercise. -- Andy.
Re: Updating bugs in Bugzilla
Done without reply. :-p Thanks. Ken Sharp wrote: Hi all, Is there any way I can have access to update bugs that I did not open in Bugzilla? I update a lot of bugs and some of them are not set correctly (incorrect component or incorrect URL). Wrong URLs are a real pain because it can lead to testing the wrong version of an app (see Bug 13371). At the moment I have to ask someone with access to make these changes for me, and they're not always done. I don't want to ask them repeatedly because they have better things to do, I'm sure, and it would be easier if I could do it myself. I have admin access on the AppDB for this reason. Is there any way I could have a similar access on Bugzilla? I had no idea where to send this email to... Thanks, Ken.
Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3
Roderick Colenbrander wrote: Thanks, I used this to compile wine 1.1.21 for testing purposes this week. I had to update the scripts a bit (e.g. use newere versions of some libraries and tools because the old ones are offline). I can post a patch against the old script. Further don't ship the opengl hack anymore for new wine packages as you are aware it isn't needed for xquartz 2.3.3 anymore. Everyone should move to the latest xquartz. This might prevent some opengl bug reports which I have to close on bugzilla as well ;) Can you provide the updates to the scripts? Since I am using Leopard, the opengl fix is not needed anymore, but it may have to stay until XQuartz 2.3.3 is backported for Tiger. James McKenzie
Re: DIB Engine : passing all tests
2009/5/24 Massimo Del Fedele m...@veneto.com: Austin English ha scritto: On Fri, May 22, 2009 at 6:31 PM, Massimo Del Fedele m...@veneto.com wrote: I posted on bug 421 page (as usual) latest update of my engine. It suld pass all tests in wine suite also all bitmap's todo_wines, so expect some false positive signaled by tests. Austin, could you please re-run it on your test machines ? Sorry for the delay. New residence has crappy wireless internet, need to find a better solution. Anywho, I've still got a failure: palette.c:105: Test failed: getColor=00302010 http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/gdi32:palette.html Yep, I've seen it sorry, I checked out just the bitmap suite. It's trivial to fix, will do on next release Yep, several todo's are passing now: http://test.winehq.org/data/b175a43fb8439a33a686512935597d4c43c19733/wine_ae-ub904-dib/gdi32:bitmap.html too bad that the suite marks them as failures :-) Does that mean it's time to remove these todos (and make them full tests) or are they still wanted for the case where Max's DIB engine is not installed? I'm looking forward to this hitting upstream :) Have the architectural issues been solved yet?
Re: annoying pkg-config problem on 64 bit Ubuntu 8.10
2009/5/23 Austin English austinengl...@gmail.com: On Thu, May 21, 2009 at 5:24 PM, Joel Holdsworth j...@airwebreathe.org.uk wrote: On Thu, 2009-05-21 at 22:18 +0200, Tijnema wrote: Haven't checked Jaunty yet to see if it's still busted. We may need to postprocess pkg-config's output to add the missing 32 in some cases. Not sure if it's worth it. On Jaunty I get $ pkg-config --libs dbus-1 -L//lib -ldbus-1 I do as well, but './configure' and './configure --enable-win64' both work fine. Does it tell you you're missing dbus or HAL stuff when you're not?
