Re: Simplify code in dlls/imm32/tests/imm32.c
Gerald Pfeifer wrote:
Not sure how to else handle this; possibly remove this whole subtest?
Gerald
ChangeLog:
Simplify code in dlls/imm32/tests/imm32.c (and avoid false warning).
diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c
index 1951242..3e35ac1 100644
--- a/dlls/imm32/tests/imm32.c
+++ b/dlls/imm32/tests/imm32.c
@@ -210,7 +210,7 @@ static void test_ImmNotifyIME(void) {
/* behavior differs between win9x and NT */
ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr));
-ok(ret || !ret, You'll never read this.\n);
+ok(TRUE, You'll never read this.\n);
We could use broken() to make sure we follow the wanted behaviour for
Wine. From the patch that changed that item it should be:
ok(!ret || broken(ret), .)
If you look however at test.winehq.org it looks like hardly any box
meets the proper requirements to run these tests at all.
So I'd say:
ok(!ret, After being cancelled the composition string is empty.\n);
(Tested on my W2K3 and Vista boxes).
--
Cheers,
Paul.
Re: Fix error checking in dlls/ddraw/executebuffer.c
Gerald Pfeifer wrote: I believe, after looking at the ranges of D3DLIGHTSTATETYPE, that the below is the actual intention of this code (to ensure we are in range). Gerald ChangeLog: Fix error checking in IDirect3DExecuteBufferImpl_Execute(). diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c index 73e0657..6d6d304 100644 --- a/dlls/ddraw/executebuffer.c +++ b/dlls/ddraw/executebuffer.c @@ -249,7 +249,7 @@ IDirect3DExecuteBufferImpl_Execute(IDirect3DExecuteBufferImpl *This, TRACE((%08x,%08x)\n, ci-u1.dlstLightStateType, ci-u2.dwArg[0]); - if (!ci-u1.dlstLightStateType (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) + if (!ci-u1.dlstLightStateType || (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) ERR(Unexpected Light State Type\n); Would: if ((ci-u1.dlstLightStateType D3DLIGHTSTATE_MATERIAL) || (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) be easier to read? (Matter of taste I guess). -- Cheers, Paul.
Re: Wine translation statistics sources
Mikołaj Zalewski miko...@zalewski.pl writes: It's online again. Having it on WineHQ would probably give a better uptime (and a much better latency, but this should also improve on my side, when I won't need a temporary SSH tunnel anymore and will move the HTTP server from my good old Pentium 100MHz to a new Atom machine). I've been in contact with Jeremy Newman about it some time ago, but, after a few exchanges, my e-mails got unanswered, so I assumed he is too busy to help with it (and, alone, I don't know how to do it). It's now online at http://source.winehq.org/transl/ and will be updated every time there's a git push. Please let me know if you find any problems. The source is also available now in the tools.git repository. -- Alexandre Julliard julli...@winehq.org
Re: Wine translation statistics sources
It's now online at http://source.winehq.org/transl/ and will be updated every time there's a git push. Please let me know if you find any problems. The source is also available now in the tools.git repository. It looks like there is a problem with CSS - some formatting is gone and I get a 403 forbidden on http://source.winehq.org/transl/style.css . Mikołaj
Re: Fix error checking in dlls/ddraw/executebuffer.c
On Sat, 20 Jun 2009, Paul Vriens wrote: - if (!ci-u1.dlstLightStateType (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) +if (!ci-u1.dlstLightStateType || (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) Would: if ((ci-u1.dlstLightStateType D3DLIGHTSTATE_MATERIAL) || (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) be easier to read? (Matter of taste I guess). I found the existing check (with the bug fixed ;-) easier to understand, but as you say it's a matter of taste and I do not feel strongly about it. Gerald
Simplify code in dlls/imm32/tests/imm32.c
Hello Gerald Pfeifer, You did, /* behavior differs between win9x and NT */ ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr)); -ok(ret || !ret, You'll never read this.\n); +ok(TRUE, You'll never read this.\n); Wouldn't it be better to do something like: ok(ret || broken(!ret), You'll never read this.\n); or marking the other case broken()? Note that broken() should be interpreted as, unwanted functionality for Wine HTH, Joris
Re: Wine translation statistics sources
Mikołaj Zalewski miko...@zalewski.pl writes: It's now online at http://source.winehq.org/transl/ and will be updated every time there's a git push. Please let me know if you find any problems. The source is also available now in the tools.git repository. It looks like there is a problem with CSS - some formatting is gone and I get a 403 forbidden on http://source.winehq.org/transl/style.css Yep, should be fixed now. BTW it would be nice to give it a more WineHQ-ish look, if someone feels like hacking up that CSS... -- Alexandre Julliard julli...@winehq.org
Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
On Saturday 20 June 2009 17:17:53 Gerald Pfeifer wrote: Hi Gerald, not really about this patch in specific, but would you mind sticking to the established practice of prefixing your patches with the area of wine you're affecting? That makes it easier to skim the wine-patches list for the dlls I know and care about. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton. signature.asc Description: This is a digitally signed message part.
Strange issue with recv in Launchpad Enhanced
I'm trying to track down an issue with Launchpad Enhanced were it fails to download its updates (Bug #17443). It appears that the issue stems from recv being called with a buffer from a different process, so as a result the call fails. I put together a hack that gets around the problem ( http://bugs.winehq.org/show_bug.cgi?id=17443#c2), but I'm having difficulty figuring out exactly why this is happening in the first place. Does anyone know if this is a known difference between Windows and Linux or if there is something else strange going on? Erich Hoover ehoo...@mines.edu
Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
2009/6/20 Gerald Pfeifer ger...@pfeifer.com: This makes it more clear that ! applies to the overall condition, not just to the first part which is then and-ed. I happened to have the same patch. Note that this does fix a real bug, ! has higher precedence than .
