Re: configure.ac: add -Werror to default compiler options
On Thu, Sep 1, 2011 at 4:27 AM, Dan Kegel d...@kegel.com wrote: At which point it would probably be a fine idea to add -Werror by default; buildbot will help keep everyone in sync, even if they're using a compiler that doesn't catch as many warnings as the one buildbot uses. Have you tried compiling on 64-bit? There are still a handful of compile warnings there (most in oleaut32/tmarshal.c; then setupapi/devinst.c; dsound+winmm). Octavian
Re: buildbot status
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 01.09.2011 um 01:12 schrieb Dan Kegel: it'd probably be a better use of time to bring up a modern ati system? If I had one I could use as-is, yes. My computer with a modern AMD GPU is in my working and sleeping room, where I'd like to keep it for coding, but I can't keep it on all the time. The iMac would be an idea, but there's still a rather nasty issue with the lack of xrandr and xvidmode support on Apple's X server, and a wine hack that is needed with CrossOver's X server. If I read your scripts correctly you run the tests in a virtual desktop, in which case this wouldn't be an issue. If on the other hand you have an system with a AMD GPU(using fglrx or the open source driver doesn't matter) and have some issues setting it up(e.g. the d3d tests crashing the X server) I can look into those issues and help you get it running on your side. -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJOXzIBAAoJEN0/YqbEcdMwmC4P/AwxunC+lpXf84G6VnRkoIUA SuoZV79t10WFpfI4JJLlmJdB3BPsbQIQoXb22iWc6wQqOtUC9luKIyzZCLEOxQ1l +C+lA8IYvlFDb5A0Cjf92B0LBIWDOHc4EzrizANVIrdiWPzY0kW+/OhqcNWbC59f IxbiARtoum7gFSwXJToe2OWG9DRuBwhPlaoXkPq4sbLFR//SnoYab8agmbP6sd5n 5Umi0RdAeSVIXVNUv2QZsBIrMWdcg9k4Dg3epauExKyE7P+G26awSmpVfqgCNQMU DrekgeICoGTTPYIgDJAsTQ6hyyD2vsoXuQNcoWRoAJv06+pwMvXvzknX2X2batiP nEkZoQj13QMJKyT6cby3GKKC4xdRhUzfmilAbLWoGwX8QWq7c2oLqTUgo1pJ2Iku Stgqef2J6Sj+9y/6xAMtwOuDNWx7bb0m0R/ReLWs5uu+4oB683hiGLVofvC+d5tw TgOa3zpo74a/rZIopY/6kA5rITmiwC2kYx3WKxaGrI/jfUfvaLFmbU45ShwJvQDu lkDb6Rs6hz4pyBXBkeC8DHkL+phogEB5ZGZQryoA1bWUdB7mvS9SnfiT8vgyMx/g 7KPlHJ3rlfC8sRkwdCGDt8gv1BhM6TPoKqN04vKACYeaB0uFJOmo3p+kJ2F+lXUn zCy6QZ0cpFKwFlkXm2HK =a472 -END PGP SIGNATURE-
Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 31.08.2011 um 12:29 schrieb Henri Verbeet: On 31 August 2011 10:58, Stefan Dösinger stefandoesin...@gmx.at wrote: This will break 2D-only apps in situations where OpenGL is not available. It Well, DirectDraw 2D-only applications, but yes. All three people in that situation should either install a software GL renderer or explicitly set the DirectDrawRenderer registry key to gdi. My mail is a bit late, but the programs I'm mainly concerned about are Internet Explorer and Windows Media Player. If someone wants to play a game in a VNC X server that's a crazy enough setup that setting an extra registry key doesn't matter, but running IE in VNC isn't that unusual. It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with I'm not sure how this will make it more impossible to fix that bug. Well, without opengl we can still render to the NULL hwnd, even if it has issues like not working with a compositing Window manager(Windows disables aero when a ddraw app doesn't specify a clipping window). OpenGL refuses to do that. -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJOXzPPAAoJEN0/YqbEcdMwp0wP/31DLijd+24l30IT0Apk0Gru FyOzYdGynHuZ0AyO0tNa7EH+bAxrrBqNxJw2yuBrcgB5iLoqwE8xehuEVpQ26oA4 JCbd820uPtf8ijnIeTD2wc6UEq8noZfyM+DUo8419w08RrLD5LdB3feHUeWTXZZA iT1UiRmIornAU9HgHpCMBlwmDvSG3EGhtgcRPwo4ABgnvkvn7yiAIH0s8ZUkUgVH I0WtL2Wx7pFWhqbRblsrqTrdUZI0nzkvDuZHoFyU9mVKSX+AMLO/r/1TeC6HynaJ RS11ngFRgogLQFLhxUSocfQk5lccqeb+jw9HtHvKPjWMKHwZLSOJArvGTeMQoujG DDim4tst/7dPKVlU9m29rNijX2iVpGCcwFeeR94XXFj6L9Am6HkapxOJTap+Knl0 gVzYJSRnAITVIa2E9UMicMjU3SifC2+sSgY/J9FGs4yOLqCV0cwRrGmUzcbwYhAu crLPDcnbIzy0H05kKbRTDzA329jH0T4dAFveoyRAIEHTYpI9tWoLVP8yKgJ5edlG wTA+HkU3IhVyQmOVlIWL4pJ6qe5oVQ2aT58WCpxGcWQoZBsJh6mltq6i/zTJcjk8 ZA5hR6SjJOSiY+xVXdjE/zSBUp49rZhhBUzr0CQGQdEiFQvlKIwDiY8TwRrcY3HO encWQArhsqvqeyGyIWzz =YifS -END PGP SIGNATURE-
Re: [3/7] dinput: Added enumerated devices to ConfigureDevices dialog
On Tue, Aug 30, 2011 at 09:11:33PM -0300, Lucas Zawacki wrote: It doesn't make sense to pass the info as WM_INITDIALG parameter if it's going to be stored in global variables anyway. A better way would be to store this in the window info. Any pointers on what's the set of winapi functions used to store and retrieve data in windows? I've searched MSDN for almost 30 minutes and no luck. SetPropA/W Also offset 0 of the window longs are usually used, like e.g. in comctl32/tooltips.c: SetWindowLongPtrW (hwnd, 0, (LONG_PTR)infoPtr); Ciao, Marcus
winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol.
Hi, I've one idea left about what may have caused the 2 apply failures. The patches are in my git queue just above wine-1.3.27 and the unrelated Valgrind hacks, so in theory, they should work. However the patches depend on each other, but since I reused the subject line of patches originally submitted with several days spacing between them, I forgot to add [PATCH 1/N] this week. The order is: 0001-winecoreaudio: Fix AudioRenderClient Get/ReleaseBuffer protocol. 0002-mmdevapi: Do not mix frames and bytes. (in git now, but should not interfere) 0003-mmdevapi: Use UINT32 for a number of frames and UINT64 to sum them. Perhaps you tried out UINT32 first? Please try Get/Release first. My apology for the trouble, Jörg Höhle
Daily builds of latest Git now available as Ubuntu packages
For an easier user testing experience, you can now install the latest git as a convenient Ubuntu package. The instructions are very similar to using the standard Ubuntu packages, however the PPA name is different. Instead of ppa:ubuntu-wine/ppa, you add ppa:ubuntu-wine/daily. From a terminal: sudo add-apt-repository ppa:ubuntu-wine/daily sudo apt-get update sudo apt-get install wine1.3 The packages are versioned like wine1.3-1.3.27+daily-20110901. Limitations: The major version number is based on the latest released version of the Ubuntu packages, so on release days you might see something like 1.3.27+daily-20110909 which would actually be equivalent 1.3.28. If I get especially behind and don't update the official packages after Monday, you might even see a 1.3.27+daily that's actually ahead of 1.3.28. In all cases wine --version should return what it normally does, however - this is just the package revision that is being wonky. Possible future: These packages are a convenient way to run some tests that may be much too slow for testbot to run against every patch, such as autohotkey-based application automation. Thanks, Scott Ritchie
Re: configure.ac: add -Werror to default compiler options
Dan Kegel wrote: (Reviving http://www.winehq.org/pipermail/wine-devel/2008-September/069266.html ) After http://www.winehq.org/pipermail/wine-patches/2011-August/106150.html and http://www.winehq.org/pipermail/wine-patches/2011-August/106151.html, configuring with -Wall -Werror gives the right results, judging by a quick diff of config.h and config.status. (sys/asoundlib.h is not detected, but that's ok, it's marked as obsolete, and wine uses alsa/asoundlib.h instead.) This takes care of Maarten's concerns from the earlier thread. Then building yields only a tiny handful of errors: dllfunc.c: In function ‘AMovieDllRegisterServer2’: dllfunc.c:180: warning: dereferencing type-punned pointer will break strict-aliasing rules qualitycontrol.c: In function ‘QualityControlImpl_Notify’: qualitycontrol.c:70: warning: dereferencing type-punned pointer will break strict-aliasing rules transform.c: In function ‘TransformFilterImpl_QueryInterface’: transform.c:248: warning: dereferencing type-punned pointer will break strict-aliasing rules ../../include/winternl.h: In function ‘get_vm86_teb_info’: ../../include/winternl.h:2660: warning: dereferencing type-punned pointer will break strict-aliasing rules ... register.c: In function ‘create_registrar’: register.c:66: warning: dereferencing type-punned pointer will break strict-aliasing rules Those are potential, if unlikely, bugs; we ought to either fix them or add -fno-strict-aliasing to CFLAGS for the seven or so affected .c files. At which point it would probably be a fine idea to add -Werror by default; buildbot will help keep everyone in sync, even if they're using a compiler that doesn't catch as many warnings as the one buildbot uses. You can try submitting a patch to add -Werror by default but I already know the patch status that it will get: REJECTED!!11!! You might get away with enabling it for the buildbot as you can enforce a controlled environment. But enabling it in general is such a bad idea that it isn't funny. No clue why people insist to still do it. Ask packagers what they think about upstreams that do that, disabling that is one of the first actions they do. bye michael
Re: configure.ac: add -Werror to default compiler options
(resent with correct from-address, please ignore the previous one) 1 sep 2011 kl. 03:27 skrev Dan Kegel: At which point it would probably be a fine idea to add -Werror by default; buildbot will help keep everyone in sync, even if they're using a compiler that doesn't catch as many warnings as the one buildbot uses. We use -Werror at my company, but I think you should really think twice before enabling it for a distributed package. New compiler versions add new warnings. Usually correctly so, but there's no way to know what warnings will be produced by what compiler, and keeping up with new compilers requires a bit of effort. We make sure to always test new compilers separately before upgrading on the developing machines. I think most users will probably just see that the package fails to build, and assume it's broken. Ps. I know there's also a few warnings while building on OS X. I don't have access to it now, or I'd send the list. -- Per Johansson
Re: [PATCH 1/5] ddraw: Make the OpenGL renderer the default one.
On 1 September 2011 09:27, Stefan Dösinger stefandoesin...@gmx.at wrote: Am 31.08.2011 um 12:29 schrieb Henri Verbeet: Well, DirectDraw 2D-only applications, but yes. All three people in that situation should either install a software GL renderer or explicitly set the DirectDrawRenderer registry key to gdi. My mail is a bit late, but the programs I'm mainly concerned about are Internet Explorer and Windows Media Player. If someone wants to play a game in a VNC X server that's a crazy enough setup that setting an extra registry key doesn't matter, but running IE in VNC isn't that unusual. So you install a software GL renderer, use something that actually works with indirect GL, or set DirectDrawRenderer to gdi. Plenty of reasonable options to make it work I'd say. If you really want to go out of your way to make this work you can even make the fallback to gdi automatic, but it would have to be before any surfaces or swapchains are created, I'm not putting the surface type switching code back in. Preferably this would work by making the surface type just go away on the wined3d side, and just not exposing any GL based blitters or 3D rendering. It will make it impossible to run some apps out of the box(e.g. the ones currently affected by bug 2082, and old QuickTime versions). That's fine with I'm not sure how this will make it more impossible to fix that bug. Well, without opengl we can still render to the NULL hwnd, even if it has issues like not working with a compositing Window manager(Windows disables aero when a ddraw app doesn't specify a clipping window). OpenGL refuses to do that. So you don't use GL to render to that. For simple blits, it should be fairly trivial to only use CPU blits when blitting to the root window. For actual 3D rendering you'd have to create an intermediate offscreen target to render to, which is probably somewhat harder. But then, with the GDI renderer this doesn't work at all.
Re: buildbot status
On 1 September 2011 09:19, Stefan Dösinger stefandoesin...@gmx.at wrote: The iMac would be an idea, but there's still a rather nasty issue with the lack of xrandr and xvidmode support on Apple's X server, and a wine hack that is needed with CrossOver's X server. If I read your scripts correctly you run the tests in a virtual desktop, in which case this wouldn't be an issue. Note that virtual desktop breaks some (iirc user32) tests, unless that's something that was fixed recently. If on the other hand you have an system with a AMD GPU(using fglrx or the open source driver doesn't matter) Did the tests start passing on fglrx then?
Re: [1/5] ddraw: Simplify Z format parsing a bit, remove ERRs
On 1 September 2011 11:01, Stefan Dösinger ste...@codeweavers.com wrote: case 32: if(DDPixelFormat-u2.dwStencilBitDepth == 8) return WINED3DFMT_D24_UNORM_S8_UINT; -else +else if (DDPixelFormat-u2.dwStencilBitDepth == 4) return WINED3DFMT_S4X4_UINT_D24_UNORM; I'm not sure if this is intentional or not, but you fallthrough to the default case here. If that's intentional, a /* Fallthrough */ or similar comment wouldn't hurt. On the other hand, you do explicitly handle it in the no-stencil case.
Re: Daily builds of latest Git now available as Ubuntu packages
On 1 September 2011 10:50, Scott Ritchie sc...@open-vote.org wrote: For an easier user testing experience, you can now install the latest git as a convenient Ubuntu package. This seems very handy, thank you. As this seems like as good a place as any for Ubuntu packaging of wine - do you see any fix in the future for gstreamer support on Wine when compiling on 64-bit Ubuntu? The current Wine configure script (quite correctly) disables support because the installed glibconfig.h includes type definitions correct for 64-bit compilation for incorrect for 32-bit compilation. ia32-libs doesn't contain header files and there is no other package that can provide the 32-bit header. Perhaps proper multilib support in the upcoming 11.10 provides a solution? Alex
Re: Daily builds of latest Git now available as Ubuntu packages
On 1 September 2011 11:50, Scott Ritchie sc...@open-vote.org wrote: The packages are versioned like wine1.3-1.3.27+daily-20110901. Limitations: The major version number is based on the latest released version of the Ubuntu packages, so on release days you might see something like 1.3.27+daily-20110909 which would actually be equivalent 1.3.28. If I get especially behind and don't update the official packages after Monday, you might even see a 1.3.27+daily that's actually ahead of 1.3.28. I don't use Ubuntu, so this doesn't really affect me, but can't you use the output from git describe for the version?
Re: Daily builds of latest Git now available as Ubuntu packages
On Thu, Sep 1, 2011 at 3:05 PM, Alex Bradbury a...@asbradbury.org wrote: As this seems like as good a place as any for Ubuntu packaging of wine - do you see any fix in the future for gstreamer support on Wine when compiling on 64-bit Ubuntu? The current Wine configure script (quite correctly) disables support because the installed glibconfig.h includes type definitions correct for 64-bit compilation for incorrect for 32-bit compilation. ia32-libs doesn't contain header files and there is no other package that can provide the 32-bit header. Perhaps proper multilib support in the upcoming 11.10 provides a solution? One way to do this is setup an i386 chroot (using debootstrap + schroot) and use that to build 32-bit wine. I used this setup to test the gstreamer patch and it works without a glitch. See [1] for more info. Multiarch support already kind of works in current Ubuntu (11.04), though not that excellent and it's not yet enabled by default. Haven't tried installing glib-dev using that, but I'm guessing that even if it did work pkgconfig most likely won't know about it, so we would have the wrong -I flags output from the configure script (because there is no way for us to specifically ask pkgconfig for a certain architecture). Anyway, what do you use gstreamer for or what applications use it? I'm the one that broke it, but to be honest I based my assessment that it was already broken just by reading the code, not by actually testing it with an application. Octavian [1] https://help.ubuntu.com/community/DebootstrapChroot
Re: Daily builds of latest Git now available as Ubuntu packages
On 09/01/2011 05:21 AM, Henri Verbeet wrote: On 1 September 2011 11:50, Scott Ritchie sc...@open-vote.org wrote: The packages are versioned like wine1.3-1.3.27+daily-20110901. Limitations: The major version number is based on the latest released version of the Ubuntu packages, so on release days you might see something like 1.3.27+daily-20110909 which would actually be equivalent 1.3.28. If I get especially behind and don't update the official packages after Monday, you might even see a 1.3.27+daily that's actually ahead of 1.3.28. I don't use Ubuntu, so this doesn't really affect me, but can't you use the output from git describe for the version? Unfortunately I have to use Launchpad Recipe's supported substitution variables here, and while they do have one for the latest git-tag if I build locally this doesn't work on launchpad itself. The reason for this is that the launchpad recipe builders don't have git proper, but instead rely on bzr-git imports (the package is actually building off the launchpad bzr import of the Wine git tree merged with my packaging bzr branch). Yeah it's a bit lame, and I'll raise the issue with the launchpad folks when I see them next, but it's a pretty minor problem atm. Thanks, Scott Ritchie
Re: Daily builds of latest Git now available as Ubuntu packages
On 09/01/2011 05:05 AM, Alex Bradbury wrote: On 1 September 2011 10:50, Scott Ritchie sc...@open-vote.org wrote: For an easier user testing experience, you can now install the latest git as a convenient Ubuntu package. This seems very handy, thank you. As this seems like as good a place as any for Ubuntu packaging of wine - do you see any fix in the future for gstreamer support on Wine when compiling on 64-bit Ubuntu? The current Wine configure script (quite correctly) disables support because the installed glibconfig.h includes type definitions correct for 64-bit compilation for incorrect for 32-bit compilation. ia32-libs doesn't contain header files and there is no other package that can provide the 32-bit header. Perhaps proper multilib support in the upcoming 11.10 provides a solution? Alex I'll work on this for Oneiric beta, after I'm done with that it's possible I can backport it to Natty but no guarantees. Thanks, Scott Ritchie
Re: file
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/194 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot
Re: services: Issue a fixme when a service fails to start.
On Thu, Sep 1, 2011 at 4:02 PM, Francois Gouget fgou...@codeweavers.com wrote: @@ -295,7 +295,8 @@ static void scmdatabase_autostart_services(struct scmdatabase *db) argv[0] = service-name; argv[1] = NULL; err = service_start(service, 1, argv); - /* FIXME: do something if the service failed to start */ + if (err != ERROR_SUCCESS) + WINE_FIXME(do something if the service failed to start %d\n, err); Why not print something more informative? This looks nice and also tells you which service did not start: WINE_FIXME(Auto-start service %s failed to start: %d\n, wine_dbgstr_w(service-name), err); Octavian
Re: 78217: Subject: [PATCH 3/3] winecfg: Remove driver selection from Audio tab
On Wed, Aug 31, 2011 at 01:25:41PM -0700, Dan Kegel wrote: Ah, I see you resent a fixed version, sorry for the noise. Thanks just the same. Because of your bot's email, I was able to know to resend the patch before I ran out the door. Andrew (FWIW, the bot won't test your retry, since it was an incomplete patch series.) On Wed, Aug 31, 2011 at 1:22 PM, Dan Kegel d...@kegel.com wrote: On Wed, Aug 31, 2011 at 1:10 PM, build...@buildbot.kegel.com wrote: The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/161 BUILD FAILED: failed git Something's fishy; looking at http://marc.info/?l=wine-patchesm=131134541100364w=2 I see that the July 22nd version seems to have interesting strings, but the August 31st version has all question marks when it comes to non-ascii text. What happened between the two? http://source.winehq.org/patches/data/78217, which is where I pulled the patch from, also has the question marks.
re: po: Fix some typography issues in the Czech translation.
This patch found a bug in my scripts - it failed to grep the patch for sender and subject - but it looks like there might be something wrong with the patch itself, it doesn't apply here. Buildbot said: Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/194 BUILD FAILED: failed git and here's what I get when I do it by hand: $ wget http://source.winehq.org/patches/data/78249 $ git apply 78249 typocz.patch:31: trailing whitespace. msgstr Ověřte prosím, že název souboru byl zadán správně typocz.patch:40: trailing whitespace. Chcete ho vytvořit? typocz.patch:49: trailing whitespace. Chcete ho přepsat novým? typocz.patch:54: trailing whitespace. msgstr Nedovolený(é) znak(y) v cestě k souboru typocz.patch:63: trailing whitespace. Chcete ho přepsat novým? error: patch failed: po/cs.po:210 error: po/cs.po: patch does not apply
Re: buildbot status
On Thu, Sep 1, 2011 at 4:04 AM, Henri Verbeet hverb...@gmail.com wrote: Note that virtual desktop breaks some (iirc user32) tests, unless that's something that was fixed recently. I work around it. There were only a couple. - Dan
Re: kernel32: Fix writing to a pipe in WriteConsoleW().
On Wed, 24 Aug 2011, Eric Pouech wrote:
[...]
you can safely provide the patches with protecting WriteConsole and friends
with a if (!is_console_handle(???)) return FALSE; line
Would something like the attached patch be ok?
As far as I can see all the other APIs pretty much immediately pass the
handle to wineserver which I expect will complain if it's not a console
handle.
Further notes:
* Performing the 'console handle check' locally would likely be faster
but, except for WriteConsole maybe, this should usually be the case
and is probably not performance critical anyway.
* There are a few cases where we check for invalid parameters and
return an error before the handle is checked by wineserver. It's
possible that in such cases Windows checks the handle first. But
unless we know of applications that need the right error code in
these corner cases it does not justify adding an explicit check.
--
Francois Gouget fgou...@free.fr http://fgouget.free.fr/
I haven't lost my mind, it's backed up on tape around here somewhere...commit b351266059e566afe7838cef18d7ea9de15d65f2
Author: Francois Gouget fgou...@free.fr
Date: Thu Sep 1 14:54:10 2011 +0200
kernel32: Make sure the console functions fail if not given a console handle.
FlushConsoleInputBuffer(), ReadConsoleInputW(), WriteConsoleW() and SetConsoleDisplayMode() need and were missing an explicit check.
diff --git a/dlls/kernel32/console.c b/dlls/kernel32/console.c
index bab2322..ddb152b 100644
--- a/dlls/kernel32/console.c
+++ b/dlls/kernel32/console.c
@@ -1236,6 +1236,11 @@ BOOL WINAPI FlushConsoleInputBuffer( HANDLE handle )
enum read_console_input_return last;
INPUT_RECORDir;
+if (!is_console_handle(handle))
+{
+SetLastError(ERROR_INVALID_HANDLE);
+return FALSE;
+}
while ((last = read_console_input(handle, ir, 0)) == rci_gotone);
return last == rci_timeout;
@@ -1699,6 +1704,11 @@ BOOL WINAPI ReadConsoleInputW(HANDLE hConsoleInput, PINPUT_RECORD lpBuffer,
DWORD idx = 0;
DWORD timeout = INFINITE;
+if (!is_console_handle(hConsoleInput))
+{
+SetLastError(ERROR_INVALID_HANDLE);
+return FALSE;
+}
if (!nLength)
{
if (lpNumberOfEventsRead) *lpNumberOfEventsRead = 0;
@@ -2356,6 +2366,11 @@ BOOL WINAPI WriteConsoleW(HANDLE hConsoleOutput, LPCVOID lpBuffer, DWORD nNumber
hConsoleOutput, debugstr_wn(lpBuffer, nNumberOfCharsToWrite),
nNumberOfCharsToWrite, lpNumberOfCharsWritten, lpReserved);
+if (!is_console_handle(hConsoleOutput))
+{
+SetLastError(ERROR_INVALID_HANDLE);
+return FALSE;
+}
if (lpNumberOfCharsWritten) *lpNumberOfCharsWritten = 0;
if ((fd = get_console_bare_fd(hConsoleOutput)) != -1)
@@ -2911,6 +2926,11 @@ BOOL WINAPI SetConsoleDisplayMode(HANDLE hConsoleOutput, DWORD dwFlags,
{
TRACE((%p, %x, (%d, %d))\n, hConsoleOutput, dwFlags,
lpNewScreenBufferDimensions-X, lpNewScreenBufferDimensions-Y);
+if (!is_console_handle(hConsoleOutput))
+{
+SetLastError(ERROR_INVALID_HANDLE);
+return FALSE;
+}
if (dwFlags == 1)
{
/* We cannot switch to fullscreen */
Re: setupapi: Fix a few pointer cast warnings.
Jerome Leclanche adys...@gmail.com writes: From c8a7535beebb152641330d3d1410d17345522867 Mon Sep 17 00:00:00 2001 From: Jerome Leclanche adys@azura Date: Thu, 1 Sep 2011 12:51:26 +0100 Subject: [PATCH] setupapi: Fix a few pointer cast warnings. That's just hiding the pointer truncation bug. -- Alexandre Julliard julli...@winehq.org
Re: setupapi: Fix a few pointer cast warnings.
If anyone wants to have a shot at a proper fix, by all means -- I don't have the C skills to figure this one out properly ;) On Thu, Sep 1, 2011 at 3:24 PM, Alexandre Julliard julli...@winehq.org wrote: Jerome Leclanche adys...@gmail.com writes: From c8a7535beebb152641330d3d1410d17345522867 Mon Sep 17 00:00:00 2001 From: Jerome Leclanche adys@azura Date: Thu, 1 Sep 2011 12:51:26 +0100 Subject: [PATCH] setupapi: Fix a few pointer cast warnings. That's just hiding the pointer truncation bug. -- Alexandre Julliard julli...@winehq.org
Re: po: Fix some typography issues in the Czech translation.
2011/9/1 Dan Kegel d...@kegel.com: This patch found a bug in my scripts - it failed to grep the patch for sender and subject - but it looks like there might be something wrong with the patch itself, it doesn't apply here. The patch uses dos line endings, that's why it doesn't apply. Octavian
Re: [1/7] cmd: Add support for LSS comparison operator in if statements
Frédéric Delanoy frederic.dela...@gmail.com writes:
+ else if ((s = StrStrIW (p, lssW))) {
+s += 3;
+a = StrToIntW(condition);
+b = StrToIntW(WCMD_parameter (s, 0, NULL));
I don't think you want to use strstr for that sort of thing.
--
Alexandre Julliard
julli...@winehq.org
Re: [1/5] ddraw: Simplify Z format parsing a bit, remove ERRs
On Thursday 01 September 2011 13:27:28 Henri Verbeet wrote: On 1 September 2011 11:01, Stefan Dösinger ste...@codeweavers.com wrote: case 32: if(DDPixelFormat-u2.dwStencilBitDepth == 8) return WINED3DFMT_D24_UNORM_S8_UINT; -else +else if (DDPixelFormat-u2.dwStencilBitDepth == 4) return WINED3DFMT_S4X4_UINT_D24_UNORM; I'm not sure if this is intentional or not, but you fallthrough to the default case here. It was intentional, but you're right that it is inconsistent. signature.asc Description: This is a digitally signed message part.
Re: buildbot status
On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: Did the tests start passing on fglrx then? As far as I know they don't. But do they have to? If I remember correctly Dan's previous patchwatcher scripts kept track of tests that were failing, so they didn't require a fully successful test run. The important thing was that the tests succeeded or failed reliably. The new setup looks much less sophisticated in that regard, at very least it can't check single ok() lines(or I haven't found the code that does this) signature.asc Description: This is a digitally signed message part.
Re: configure.ac: add -Werror to default compiler options
On Thu, Sep 1, 2011 at 1:35 AM, Jerome Leclanche adys...@gmail.com wrote: Here is a warning report from a 64bit system. I get a lot of warnings on both 32 and 64bit wines. Many of them are variable set but not used (unused error returns, ...). http://bugs.winehq.org/show_bug.cgi?id=26768 was filed a while ago for the oleaut32 spam. Wow. Guess we have a ways to go. - Dan
Re: buildbot status
On Thu, Sep 1, 2011 at 8:38 AM, Stefan Dösinger stefandoesin...@gmx.at wrote: On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: Did the tests start passing on fglrx then? As far as I know they don't. But do they have to? If I remember correctly Dan's previous patchwatcher scripts kept track of tests that were failing, so they didn't require a fully successful test run. The important thing was that the tests succeeded or failed reliably. The new setup looks much less sophisticated in that regard Right - I have not yet forward ported the code that tracks known failures. It hasn't been needed so far -- I've gotten away with a simple blacklist -- but once I start doing things like valgrinding, checking compiler warnings, or running on ATI I'll probably need to bring it back. - Dan
Re: buildbot status
On 1 September 2011 17:38, Stefan Dösinger stefandoesin...@gmx.at wrote: On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: Did the tests start passing on fglrx then? As far as I know they don't. But do they have to? If running those tests is the point of that machine, I'd say so. With a known broken configuration, you risk just running into the same known bugs every time you change something or add a new test, wasting everyone's time. An important consideration here is that apparently upstream isn't interested in fixing this kind of bug, and there's no way for us to fix them ourselves.
Re: po: Fix some typography issues in the Czech translation.
On Thu, Sep 1, 2011 at 7:52 AM, Octavian Voicu octavian.vo...@gmail.com wrote: 2011/9/1 Dan Kegel d...@kegel.com: This patch found a bug in my scripts - it failed to grep the patch for sender and subject - but it looks like there might be something wrong with the patch itself, it doesn't apply here. The patch uses dos line endings, that's why it doesn't apply. That's it, thanks. (I had seen them, but thought patch tools were smart enough to ignore 'em; I guess patch does if the whole patch is in CRLF format, but in this case, the preamble wasn't.) I just checked, and none of our .c, .h, or .po files have embedded CR's. I guess it would be ok to strip trailing CR's on incoming patches, I'll do that. But there's something even fishier about http://source.winehq.org/patches/data/78249 -- it ends in a block of NUL characters. What's up with that? hexdump -C shows ... 1560 20 0d 0a 20 23 3a 20 77 69 6e 68 6c 70 33 32 2e | .. #: winhlp32.| 1570 72 63 3a 36 34 0d 0a 20 23 2c 20 66 75 7a 7a 79 |rc:64.. #, fuzzy| 1580 0d 0a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 || 1590 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 || * 1d80 00 00 0a 0a || - Dan
Re: buildbot status
Fwiw, the d3d8 and d3d9 device tests fail, no idea why, the d3d9 query test fails(this is something we can fix). The ddraw, d3d8 and d3d9 visual tests can't read back the backbuffer, so they refuse to run. On Thursday 01 September 2011 18:18:11 Henri Verbeet wrote: On 1 September 2011 17:38, Stefan Dösinger stefandoesin...@gmx.at wrote: On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: Did the tests start passing on fglrx then? As far as I know they don't. But do they have to? If running those tests is the point of that machine, I'd say so. With a known broken configuration, you risk just running into the same known bugs every time you change something or add a new test, wasting everyone's time. An important consideration here is that apparently upstream isn't interested in fixing this kind of bug, and there's no way for us to fix them ourselves. signature.asc Description: This is a digitally signed message part.
Re: configure.ac: add -Werror to default compiler options
Am 01.09.2011 17:52, schrieb Dan Kegel: On Thu, Sep 1, 2011 at 1:35 AM, Jerome Leclanche adys...@gmail.com wrote: Here is a warning report from a 64bit system. I get a lot of warnings on both 32 and 64bit wines. Many of them are variable set but not used (unused error returns, ...). http://bugs.winehq.org/show_bug.cgi?id=26768 was filed a while ago for the oleaut32 spam. Wow. Guess we have a ways to go. - Dan Also beside Micheal's comment -Werror is a bad idea for crosscompiling, compiling with other compilers, compiling on new/uncommon systems, compiling on other architectures and so on... -- Best Regards, André Hentschel
Re: buildbot status
On Thursday 01 September 2011 18:46:58 Stefan Dösinger wrote: Fwiw, the d3d8 and d3d9 device tests fail, no idea why, the d3d9 query test fails(this is something we can fix). The ddraw, d3d8 and d3d9 visual tests can't read back the backbuffer, so they refuse to run. This crash happens in the CreateDevice call that uses the D3DCREATE_FPU_PRESERVE flag. The exception is a division by zero exception in the driver. I had a quick look at the D3DCREATE_FPU_PRESERVE code: shouldn't we do something like ddraw where we set the FPU control word in every method and restore it afterwards? I think we can't blame the driver for crashing if we hand it over the FPU in a messed up state. It probably needs some more test, e.g. what do methods other than CreateDevice do when FPU_PRESERVE is not set and the FPU is in some non-standard mode. No idea yet why the visual tests don't work. signature.asc Description: This is a digitally signed message part.
Re: po: Fix some typography issues in the Czech translation.
On Thu, Sep 1, 2011 at 7:21 PM, Dan Kegel d...@kegel.com wrote: I just checked, and none of our .c, .h, or .po files have embedded CR's. I guess it would be ok to strip trailing CR's on incoming patches, I'll do that. That's weird, did they blacklist the 0x0d character from the encoding of Unicode characters? Pasted all the Unicode characters from a Wikipedia page in a file and couldn't find any 0x0d in the file. In any case, is Alexandre also going to strip CRs? If not, there isn't much point in doing that, as patch wouldn't go in with the CRs. Octavian
Re: buildbot status
On 1 September 2011 19:00, Stefan Dösinger ste...@codeweavers.com wrote: I had a quick look at the D3DCREATE_FPU_PRESERVE code: shouldn't we do something like ddraw where we set the FPU control word in every method and restore it afterwards? I think we can't blame the driver for crashing if we hand it over the FPU in a messed up state. It probably needs some more test, e.g. what do methods other than CreateDevice do when FPU_PRESERVE is not set and the FPU is in some non-standard mode. No idea yet why the visual tests don't work. What it comes down to is this: Both Mesa and NVIDIA can manage to somehow make this work, fglrx isn't interested in making it work. That's their good right of course, but the consequence is that I from my side am not particularly interested in making things work with fglrx. I'd much rather spend that time working with the r300g and r600g people on making those drivers as good as possible. Now if you can justify working on this, either towards your employer or towards yourself in your own time, I'm certainly not going to stop you. All I care about in that regard is that any resulting patches are up to standards. However, what I want to avoid is the situation where I'm spending time debugging fglrx because the buildbot has test failures there. Looking at this from a slightly different angle, I think that if you expect people to take buildbot results seriously, you should run it on a configuration that's known to be solid, so that people can be confident any failures are actual issues with the patch, instead of e.g. fglrx or Ubuntu breaking something again.
Re: configure.ac: add -Werror to default compiler options
On Thu, Sep 1, 2011 at 8:52 AM, Dan Kegel d...@kegel.com wrote: On Thu, Sep 1, 2011 at 1:35 AM, Jerome Leclanche adys...@gmail.com wrote: Here is a warning report from a 64bit system. I get a lot of warnings on both 32 and 64bit wines. Many of them are variable set but not used (unused error returns, ...). http://bugs.winehq.org/show_bug.cgi?id=26768 was filed a while ago for the oleaut32 spam. Wow. Guess we have a ways to go. Finally dug up AJ's position on the question: http://www.winehq.org/pipermail/wine-devel/2008-September/069203.html So, no -Werror by default in git. Buildbot may at some point start complaining about patches that introduce new warnings, though. Dan
Re: 78256: Subject: [PATCH 1/5] wined3d: Print a FIXME for any flags passed to wined3d_surface_flip().
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/201 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Severe startup latencies for Windows applications run under wine
Hi Ben: Thanks for your further tests. On 2011-08-30 08:20+1000 Ben Peddell wrote (but then later forwarded to list so I am repeating my off-list reply to the list as well): Some things I have seen while investigating: I created a program which had a startup that immediately called ExitProcess to attempt to eliminate most of the initialization of the process being forked. On Windows 7 x64 SP1 on an AMD 5050e: bash.exe takes about 22.2ms to fork. make.exe takes about 8.8ms to fork. cmd.exe takes about 5.9ms to fork. Under wine 1.2.1 on linux 2.6.38 on an AMD 5050e: bash.exe takes about 236ms to fork nothing, and 182ms to fork /bin/true. make.exe takes about 77ms to fork nothing, and 25ms to fork /bin/true. wine-cmd takes about 9ms to fork nothing. Under wine-git on linux 2.6.38 on an AMD 5050e: bash.exe takes about 190ms to fork nothing, and 147ms to fork /bin/true make.exe takes about 71ms to fork nothing and 20ms to fork /bin/true. wine-cmd takes about 9ms to fork nothing. Just out of curiosity do you have any explanation of why /bin/true provided faster make.exe results than your quick-exiting programme both for wine-1.2.1 and wine-git? Even the native bash takes twice as long to fork as make - 1.1ms vs 0.5ms. It looks to me like the fork emulation in MSYS is encountering a bottleneck, and not actual process creation. I assume you meant encountering a _wine_ bottleneck since clearly above your MSYS tests of make.exe and bash.exe on Windows don't have the large startup latencies you encounter with wine-1.2 and wine-git. How does the MSYS version of make (make.exe that you tried above) compare in this regard with the MinGW version of make (MinGW/bin/mingw32-make.exe) that specifically excludes everything to do with MSYS? My guess is you will encounter a similar wine bottleneck for this case as well, but it is worth verifying that. And now you have done a clean comparison with the same software stack it is clear that wine-git somewhat reduces the bottleneck compared to wine-1.2. Thus, I expect my own planned clean comparisons to show the same. So I have changed the subject line appropriately. Now, if someone could just figure out what the wine bottleneck is that is causing these severe start-up latencies for Windows applications Alan __ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __ Linux-powered Science __
Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing
Hi Frédéric, Some of those tests are already present in the test_builtins.cmd* (e.g. the spacing tests) You should probably integrated your tests in there: that makes it easier to spot regressions and helps prevent tests duplication I can certainly do that if you prefer (and I will), but I don't agree that having all tests in a single big file is an advantage. Splitting the unit tests over multiple files would make it much easier to relate output lines to script lines and do focused work on certain areas. For anyone who doesn't work on it regularly, test_builtins.cmd is a nightmare. Also, see http://www.winehq.org/pipermail/wine-devel/2011-August/091817.html I'm not sure why you're telling me that. My patches aren't about performance but correctness. They won't affect performance negatively, either. Regards, Martin PS: any idea why my patches didn't make it to wine-patches?
Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing
IMHO we should probably split it only when it's reasonably complete, where we'd have a broader view. Well, it's up to you. I just made an attempt to merge my stuff into test_builtins and gave up after 2 hours :-( Also, test_parsing name is probably a bit too generic (not that test_builtins isn't ;) ) But you can still submit it in the meantime, maybe AJ will accept it. Just make sure there's no duplication AFAICT there is no real duplication. 4 TODOs in the current test_builtins are removed by the last of my patches, so there is some overlap, but I wouldn't call it a duplicate. Also, when you have to make tests work on NT4-2k8 *and* wine at *all* times, you sometimes have to make your hands dirty. I tested my stuff only on XP. Perhaps someone can help me out testing other native versions. Just ask if you don't understand the @keywords@. Doc is a bit lacking; I might add a quick wiki help page if desired. Yes, that'd be helpful (IMO just a README file in the tests/ directory would be even better). It took me a while to get started with the cmd testing code. Did you correctly register via http://www.winehq.org/mailman/listinfo/wine-patches? I was hoping this was an open ML (and last time tried it was). OK, I'll subscribe and re-submit. Nice job by the way. Thanks a lot, it seems that you took on a big task with cmd, good luck! Martin
Re: [PATCH] ntdll: provide a timestamp debug channel, which prints a millisecond resolution timestamp in front of debug output, very useful to debug deadlocks (resend)
On Wed, Aug 31, 2011 at 12:20 PM, Alexandre Julliard
julli...@winehq.org wrote:
Bernhard Loos bernhardl...@googlemail.com writes:
@@ -164,8 +165,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls,
struct __wine_debug_chan
/* only print header if we are at the beginning of the line */
if (info-out_pos == info-output || info-out_pos[-1] == '\n')
{
+ if (TRACE_ON(timestamp))
+ {
+ LARGE_INTEGER now;
+ extern timeout_t server_start_time;
Don't add extern statements all over the place, there are functions to
return tick counts.
Found NtGetTickCount, after some looking around which does what I need.
In my defence, I the kernel32 version of GetTickCount also calls
NtQuerySystemTime, so it never occured to me, that there might be one
in ntdll.
Also you probably want a more readable formatting.
I'm not exactly sure, how to make it more readable. I could add a .
after seconds and ms at the end, but this makes it more likely to
create line wraps, which also hurts readability and it's not that hard
to figure out.
--
Alexandre Julliard
julli...@winehq.org
Re: configure.ac: add -Werror to default compiler options
1 sep 2011 kl. 03:27 skrev Dan Kegel: At which point it would probably be a fine idea to add -Werror by default; buildbot will help keep everyone in sync, even if they're using a compiler that doesn't catch as many warnings as the one buildbot uses. We use -Werror at my company, but I think you should really think twice before enabling it for a distributed package. New compiler versions add new warnings. Usually correctly so, but there's no way to know what warnings will be produced by what compiler, and keeping up with new compilers requires a bit of effort. We make sure to always test new compilers separately before upgrading on the developing machines. I think most users will probably just see that the package fails to build, and assume it's broken. Ps. I know there's also a few warnings while building on OS X. I don't have access to it now, or I'd send the list. -- Pelle Johansson
Re: 78256: Subject: [PATCH 1/5] wined3d: Print a FIXME for any flags passed to wined3d_surface_flip().
On 1 September 2011 20:51, build...@kegel.com wrote: Backtrace: =0 0x7bc4772c HEAP_CreateFreeBlock+0xbb(subheap=0x110014, ptr=0x130910, size=0xdffe8) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/heap.c:583] in ntdll (0x0032f444) 1 0x7bc47a57 HEAP_ShrinkBlock+0x42(subheap=0x110014, pArena=0x1308e8, size=0x20) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/heap.c:685] in ntdll (0x0032f468) 2 0x7bc4abdd RtlAllocateHeap+0x2a8(heap=0x11, flags=0x2, size=0x1a) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/heap.c:1699] in ntdll (0x0032f4c8) 3 0x40063383 OpenDriverA+0x96(lpDriverName=winealsa.drv, lpSectionName=0x0(nil), lParam=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/driver.c:361] in winmm (0x0032f518) 4 0x400666ac MMDRV_Install+0x151(drvRegName=winealsa.drv, drvFileName=winealsa.drv, bIsMapper=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:456] in winmm (0x0032f5c8) 5 0x400670d1 MMDRV_Init+0x3b7() [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:571] in winmm (0x0032f658) 6 0x40064d4d MMDRV_InitSingleType+0x2a(type=0x5) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:80] in winmm (0x0032f668) 7 0x40065993 MMDRV_Get+0xc9(_hndl=0x0(nil), type=0x5, bCanBeID=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:261] in winmm (0x0032f768) 8 0x4007c537 WINMM_DRVMessage+0xac(dev=0, message=0x814, param1=0x13050c, param2=0, is_out=0x1) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/waveform.c:2774] in winmm (0x0032f7b8) 9 0x4007c839 waveOutMessage+0x111(hWaveOut=(nil), uMessage=0x814, dwParam1=0x13050c, dwParam2=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/waveform.c:2832] in winmm (0x0032f7f8) 10 0x4002ed0b DSOUND_ReopenDevice+0x153(device=0x1304f8, forcewave=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/primary.c:108] in dsound (0x0032f878) 11 0x400225de DirectSoundDevice_Initialize+0x47e(ppDevice=0x1222dc, lpcGUID=0x400428f0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/dsound.c:1412] in dsound (0x0032f9a8) 12 0x40020b4a IDirectSound8_IDirectSound8_Initialize+0x8e(iface=0x1222f8, lpcGuid=(nil)) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/dsound.c:920] in dsound (0x0032f9e8) 13 0x400214a6 DirectSoundCreate8+0x164(lpcGUID=(nil), ppDS=0x12d518, pUnkOuter=(nil)) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/dsound.c:1143] in dsound (0x0032fa38) 14 0x68f08e96 DSoundRender_create+0x20d(pUnkOuter=(nil), ppv=0x32fbfc) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/dsoundrender.c:519] in quartz (0x0032fbc8) 15 0x68f289fa DSCF_CreateInstance+0xa2(iface=0x122a60, pOuter=(nil), riid=0x6857404c, ppobj=0x685796d4) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/main.c:130] in quartz (0x0032fc18) 16 0x686cce9c CoCreateInstance+0x29a(rclsid=0x68575e9c, pUnkOuter=(nil), dwClsContext=0x1, iid=0x6857404c, ppv=0x685796d4) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ole32/compobj.c:2641] in ole32 (0x0032fc98) 17 0x68565c80 create_dsound_renderer+0x43() [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/dsoundrender.c:46] in quartz_test (0x0032fcd8) 18 0x68566e45 func_dsoundrender+0x25() [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/dsoundrender.c:225] in quartz_test (0x0032fcf8) 19 0x685727a2 run_test+0x9e(name=dsoundrender.c) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/../../../include/wine/test.h:556] in quartz_test (0x0032fd58) 20 0x68572bb9 main+0x23a(argc=couldn't compute location, argv=0x1103d8) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/../../../include/wine/test.h:624] in quartz_test (0x0032fe28) 21 0x68572c46 __wine_spec_exe_entry+0x69(peb=0x7ffdf000) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winecrt0/exe_entry.c:36] in quartz_test (0x0032fe60) 22 0x7b85fc74 call_process_entry+0xb() in kernel32 (0x0032fe78) 23 0x7b85fdbb start_process+0x144(peb=0x7ffdf000) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/kernel32/process.c:1087] in kernel32 (0x0032fec8) 24 0x7bc7dee8 call_thread_func+0xb() in ntdll (0x0032fed8) 25 0x7bc7df26 call_thread_entry_point+0x33(entry=0x7b85fc76, arg=0x7ffdf000) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffb8) 26 0x7bc53805 start_process+0x25(kernel_start=0x7b85fc76) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) 27 0x68028b4d wine_call_on_stack+0x1c() in
Re: 78258: Subject: [PATCH 3/5] wined3d: Get rid of some redundant else statements in IWineD3DSurfaceImpl_BltOverride().
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/203 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13889 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W2K8SE (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PRO (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (64 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead
Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13894 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '-- Testing invocation with CMD /C -') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '-- Testing invocation with CMD /C -', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '-- Testing CMD /C quoting -') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted 'hi') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '\\@space@\\') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '-- Testing CMD /C quoting -', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got 'hi', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '\\ \\', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '-- Testing CMD /C weirdness ---') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '-- Testing CMD /C weirdness ---', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '- Testing special characters --') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '- Testing special characters --', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30
Re: [PATCH 3/5] cmd: improve treatment of quotes in command line
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13896 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '-- Testing invocation with CMD /C -') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '-- Testing invocation with CMD /C -', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '-- Testing CMD /C quoting -') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted 'hi') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '\\@space@\\') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '-- Testing CMD /C quoting -', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got 'hi', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '\\ \\', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '-- Testing CMD /C weirdness ---') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '-- Testing CMD /C weirdness ---', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '- Testing special characters --') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '- Testing special characters --', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30
Re: 78259: Subject: [PATCH 4/5] wined3d: Make the device parameter to wined3d_device_get_light_enable() const.
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/204 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78256: Subject: [PATCH 1/5] wined3d: Print a FIXME for any flags passed to wined3d_surface_flip().
On 1 September 2011 21:02, Henri Verbeet hverb...@gmail.com wrote: I have some doubts about this being caused by this patch. That said, you may want to give 78289 a try.
Re: ws2_32: Avoid an unhandled read exception on WSAIoctl
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13899 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W2K8SE (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PRO (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (64 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead
Re: [PATCH 4/5] cmd: fix handling of special characters
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13897 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '-- Testing invocation with CMD /C -') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '-- Testing invocation with CMD /C -', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '-- Testing CMD /C quoting -') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted 'hi') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '\\@space@\\') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '-- Testing CMD /C quoting -', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got 'hi', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '\\ \\', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '-- Testing CMD /C weirdness ---') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '-- Testing CMD /C weirdness ---', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '- Testing special characters --') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '- Testing special characters --', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30
Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13898 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '-- Testing invocation with CMD /C -') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '-- Testing invocation with CMD /C -', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '-- Testing CMD /C quoting -') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted 'hi') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '\\@space@\\') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '-- Testing CMD /C quoting -', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got 'hi', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '\\ \\', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '-- Testing CMD /C weirdness ---') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '-- Testing CMD /C weirdness ---', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '- Testing special characters --') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '- Testing special characters --', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30
Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13895 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '-- Testing invocation with CMD /C -') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '-- Testing invocation with CMD /C -', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '-- Testing CMD /C quoting -') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted 'hi') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '\\@space@\\') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '-- Testing CMD /C quoting -', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got 'hi', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '\\ \\', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2@space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '-- Testing CMD /C weirdness ---') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1@space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '-- Testing CMD /C weirdness ---', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '- Testing special characters --') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '- Testing special characters --', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30
Re: 78260: Subject: [PATCH 5/5] wined3d: Make the device parameter to wined3d_device_get_clip_plane() const.
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/205 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78266: Subject: regedit: Remove the printing code
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/206 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78261: Subject: [1/6] dinput: Added ConfigureDevices dialog (try 3)
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/207 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78262: Subject: [2/6] dinput: Added enumerated devices to ConfigureDevices dialog (try 3)
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/208 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)
On Thu, Sep 1, 2011 at 16:27, Marvin test...@testbot.winehq.org wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13889 Your paranoid android. sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead I don't get the same results here, can anyone help me to understand why it failed? 10014 = WSAEFAULT and I could not find this return value anywhere near, maybe due to threading? Thanks, Bruno
Re: 78265: Subject: [3/6] dinput: Added object/action enumeration to ConfigureDevices dialog (try 3)
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/209 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78264: Subject: [5/6] dinput: Added possibility to change the action mapping in the ConfigureDevices dialog (try 3)
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/211 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: documentation: Remove ChangeLog.*.
On Wed, Aug 31, 2011 at 3:25 PM, Octavian Voicu wrote: They are not used anymore. Last change was with the release of wine 1.0. Sent as attachment because of the huge lines. Alexandre, This patch was sent before I got your reply on wine-devel, so you can ignore it. Probably was in the moderation queue because it is totally huge... Octavian
Re: 78267: Subject: [6/6] dinput: Working CANCEL and RESET buttons in ConfigureDevices dialog (try 3)
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/212 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: [1/6] dinput: Added ConfigureDevices dialog (try 3)
On Thu, Sep 1, 2011 at 9:34 PM, Lucas Fialho Zawacki lfzawa...@gmail.com wrote: +STRINGTABLE +BEGIN + IDS_ACTIONCOLUMN Action + IDS_OBJECTCOLUMN Object +END I think you should only keep the string table in dinput.rc. The dialog(s) should go in En.rc so they can be localized, like it's done in winecfg [1]. You probably should also add this to both .rc files: LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT Octavian [1] http://source.winehq.org/git/wine.git/tree/HEAD:/programs/winecfg
Re: 78268: Subject: view: Install it inside Wine
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/213 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)
On Thu, Sep 1, 2011 at 18:40, Bruno Jesus 00cp...@gmail.com wrote: I don't get the same results here, can anyone help me to understand why it failed? 10014 = WSAEFAULT and I could not find this return value anywhere near, maybe due to threading? Thanks, Bruno I see know that newer systems return a different value, should I add an OR to the ok() or is there a better way like checking which OS is running during the test? Bruno
Re: 78269: Subject: Polish translation for release 1.3.27
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/214 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Separate list for bots
wine-devel has been seeing more and more robot generated messages. Would it make sense to create wine-bots list for buildbot, testbot and friends? Automated messages could go to author, wine-bots with Reply-To: and Followup-To: pointing at wine-devel That way wine-devel could be returned to humans again. :-)
Re: 78270: Subject: widl: duplicate type in case of argument with range attribute
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/215 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78273: Subject: [PATCH 1/5] cmd/tests: add more tests for command line parsing
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/218 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78271: Subject: rpcrt4:properly unmarshall EMUM16 discriminant
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/216 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78276: Subject: [PATCH 2/5] cmd: use GetCommandline() rather than argv
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/219 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78278: Subject: [po]updated korean resource
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/223 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot
Re: Separate list for bots
I think buildbot might need a bit of tweaking, it's not normal for so many patches to fail. On Fri, Sep 2, 2011 at 1:06 AM, Peter Urbanec winehq@urbanec.net wrote: wine-devel has been seeing more and more robot generated messages. Would it make sense to create wine-bots list for buildbot, testbot and friends? Automated messages could go to author, wine-bots with Reply-To: and Followup-To: pointing at wine-devel That way wine-devel could be returned to humans again. :-)
Re: 78283: Subject: [PATCH] po: Update Japanese translation.
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/227 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78284: Subject: user32: Fix support for CB_SETDROPPEDWIDTH in combobox
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/228 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78285: Subject: [PATCH] po: Update Japanese translation.
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/229 BUILD FAILED: failed git For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78286: Subject: Polish translation for release 1.3.27
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/230 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78287: Subject: po: Update German translation
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/231 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: 78291: Subject: urlmon/tests: Print out the wrong mime
The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/235 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: Separate list for bots
Sorry for the mail storm, I've disabled mail again. (I out running errands all afternoon/evening, or I probably would have done that sooner.) As it happens, there is already a nearly unused mailing list for wine test results; I'll send results there from now on, at least until we work out more of the kinks. http://www.winehq.org/mailman/listinfo/wine-tests-results In this case, Henri had a proposed fix; maybe if Alexandre had committed it, the storm of error messages would have ceased. It's funny; I can't reproduce that crash manually, only through the buildbot. But I do see the tail overwrite clearly with warn+heap; perhaps it's time to add a bot that flags new warn+heap errors. - Dan
