Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?
Le 09/09/2011 13:02, Frédéric Delanoy a écrit : 2011/9/9 Eric Pouecheric.pou...@orange.fr: WineDbg set ! symbol_picker scoped will do what you want unfortunately, there's no way to store it as a default command (you can always use --command or --file on command line to help) Thanks for that quick response! Is there some doc on the internal commands, besides the code? http://www.winehq.org/docs/winedev-guide/dbg-config may be a bit out of date Frédéric not for that part... feel free to bring to the doc up to date set ! symbol_picker interactive being the other setting (which is the default : if several symbols found, ask the user for which one to pick) scoped meaning give precedence to local symbols over global symbols A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)
Re: Marking test cases as flaky?
A problem we have is that we have lots and lots of tests in dlls/d3d*/visual.c and device.c that are unrelated to each other. d3d9/visual has about 100 separate tests that could be in different files and work just the same way. Now I don't suggest moving them into different files, that would make the directory look pretty ugly. But maybe we could introduce a function that gives all following ok() calls a different name and makes it easier for external apps to separate tests. E.g. wine_begin_tests(depth_clamp); ok(...); ok(...); ok(...); wine_begin_tests(stretchrect) ok(...); ok(...); ok(...); and so on. signature.asc Description: This is a digitally signed message part.
urlmon:sec_mgr failure on XP
This test now fails on my Widnows XP VMs that have IE = 7 with 'All zones reset to default level': http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/xp_fg-winxp-latest/urlmon:sec_mgr.html sec_mgr.c:1695: Test failed: Expected zone 3, but got 1 for 'file/testing/test.test' The patch that introduces the failures is 98d5dfb8 which was committed on the 5th. I did some experiments and I can get this test to pass if I do: * Go to the Internet Properties control panel * Security tab * Select 'Local intranet' * Click on the 'Sites' button * Deselect 'Automatically detect intranet network' * Deselect 'Include all local (intranet) sites not listed in other zones' * Click on 'OK' I also checked on Windows 7 and by default it has the first checkbox checked but the second one unchecked. Disabling 'Automatically detect intranet network' and enabling 'Include all local sites...' to match Windows XP causes the test to fail on Windows 7 too. Finally, on XP even if I deselect all the 'Include XXX' checkboxes but select the 'Automatically detect intranet network' one the test fails while with the same configuration it passes on Windows 7. So I think this reflects a difference in the way the intranet detection works. So I'm hoping that you can fix the test. The easiest fix would be to remove the 'file/testing/test.test' check. An alternative would be to check what the settings are and adjust the expected result or skip the test. But it seems like this would be much more complex. -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0
The msctf:inputprocessor test is not reliable
This test is not reliable on my Debian desktop. http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/linux_fg-deb64-t32/msctf:inputprocessor.html inputprocessor.c:2117: Test failed: OnSetFocus expected current focus 0x12b070 got 0x12b0d0 inputprocessor.c:538: Test failed: Unexpected ThreadMgrEventSink_OnSetFocus sink inputprocessor.c:549: Test failed: Sink reports wrong previous focus If I run it in a loop it fails about once every twelve times: i=0;while ../../../tools/runtest inputprocessor.c [ $i -lt 100 ];do i=`expr $i + 1`; echo $i; done Introducing a single Sleep(50) as shown below makes it totally reliable here. ShowWindow(wnd3,SW_SHOWNORMAL); SetFocus(wnd3); +Sleep(50); processPendingMessages(); test_CurrentFocus = FOCUS_SAVE; test_PrevFocus = FOCUS_SAVE; test_OnSetFocus = SINK_SAVE; SetFocus(wnd1); processPendingMessages(); sink_check_saved(test_OnSetFocus,dm2,dm1,OnSetFocus); /* ^^^ Line that fails! */ That seems pretty hacky though. I suspect this is all because processPendingMessages() will exit if there's no pending message right after we call SetFocus() without giving enough time for the asynchronous X event to arrive. But I'm surprised that a single Sleep() fixes the issue, especially where it's placed. Also I don't know anything about msctf so I'm unsure how ThreadMgrEventSink_OnSetFocus() figures in all this. So should I just submit a patch to add that Sleep()? Or would it be better to change processPendingMessages() to look more like user32/tests/msg.c's flush_events() function although it looks like it's overkill for now? -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.
Re: The msctf:inputprocessor test is not reliable
Francois Gouget fgou...@free.fr writes: Or would it be better to change processPendingMessages() to look more like user32/tests/msg.c's flush_events() function although it looks like it's overkill for now? That's preferable, yes. -- Alexandre Julliard julli...@winehq.org
Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.
On Thu, Sep 8, 2011 at 8:11 PM, Francois Gouget fgou...@free.fr wrote: On Thu, 8 Sep 2011, Alexandre Julliard wrote: [...] I don't think the name of the family really matters here. By using Tahoma the Wine implementation is trying to make sure we always return something, and that's what we should check: that we get a family, and that it's valid for creating a font or something along those lines. We don't have a fallback for Monospace fonts so that if Courier New is not installed we return FontFamilyNotFound. What you're saying suggests that this is a bug. Does anyone have a font to recommend as the fallback? I think that the fallback for Courier New should be Liberation Mono [1] as they both are monospace. [1] http://en.wikipedia.org/wiki/Liberation_fonts
Re: [1/3] msxml3: Add xmlparser interfaces
On Wed, 7 Sep 2011, Alistair Leslie-Hughes wrote: Changelog: msxml3: Add xmlparser interfaces This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl which is a bit strange because I cannot find this type in the Windows SDK. But in the Windows 7 SDK there is an XmlError enumeration type in xmllite.h that looks similar but subtly different. These two enumaration types share some error codes, in particular XML_E_INVALID_HEXIDECIMAL (Microsoft can't spell apparently) but with different values. In this case 0xc00ce51e in Wine vs. 0xc00ce01e in the Windows 7 SDK. So what's going on? -- Francois Gouget fgou...@free.fr http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.
Re: Marking test cases as flaky?
On Sat, Sep 10, 2011 at 3:01 AM, Stefan Dösinger stefandoesin...@gmx.at wrote: A problem we have is that we have lots and lots of tests in dlls/d3d*/visual.c and device.c that are unrelated to each other. d3d9/visual has about 100 separate tests that could be in different files and work just the same way. Now I don't suggest moving them into different files, that would make the directory look pretty ugly. But maybe we could introduce a function that gives all following ok() calls a different name and makes it easier for external apps to separate tests. E.g. wine_begin_tests(depth_clamp); ok(...); ok(...); ok(...); wine_begin_tests(stretchrect) ok(...); ok(...); ok(...); Maybe instead of #define ok_(file, line) (winetest_set_location(file, line), 0) ? (void)0 : winetest_ok #define ok ok_(__FILE__, __LINE__) we could have #define ok_(file, func, line) (winetest_set_location(file, func, line), 0) ? (void)0 : winetest_ok #define ok ok_(__FILE__, __FUNCTION__, __LINE__) That would get you most of what you propose without any changes to the tests, I think.
Re: speeding up builds with ext4 and ccache tuning
Two more things: - ccache's cache size matters. If ccache -s shows the cache is full after two builds, try raising it. The default is 1 GB, and I think with gcc-2.95, I needed a slightly larger cache. - ccache might slow you down if you have less than 3GB of RAM.
Re: Marking test cases as flaky?
On Saturday 10 September 2011 19:43:08 Dan Kegel wrote: #define ok_(file, func, line) (winetest_set_location(file, func, line), 0) ? (void)0 : winetest_ok #define ok ok_(__FILE__, __FUNCTION__, __LINE__) That would get you most of what you propose without any changes to the tests, I think. I think that would work. Of course you have to change the tests that explicitly use ok_() signature.asc Description: This is a digitally signed message part.
Re: urlmon:sec_mgr failure on XP
Hi Francois, On Sat, Sep 10, 2011 at 6:33 AM, Francois Gouget fgou...@free.fr wrote: This test now fails on my Widnows XP VMs that have IE = 7 with 'All zones reset to default level': http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/xp_fg-winxp-latest/urlmon:sec_mgr.html sec_mgr.c:1695: Test failed: Expected zone 3, but got 1 for 'file/testing/test.test' I wasn't able to reproduce this problem on my Windows XP VM. I was, however, able to reproduce this problem using Windows 7. So I'm hoping that you can fix the test. The easiest fix would be to remove the 'file/testing/test.test' check. An alternative would be to check what the settings are and adjust the expected result or skip the test. But it seems like this would be much more complex. The test in question isn't really relevant with showing how the function itself should work, so removing it will be fine (I'll be sending a patch shortly removing it). Thanks for pointing this issue out. -- Thomas Mullaly thomas.mull...@gmail.com
Re: urlmon/tests: Removed a test that causes random failures on some machines
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14120 Your paranoid android. === WVISTAADM (32 bit sec_mgr) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation
re: msi: Properly check for a specified flag combination
Test failed here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c touch action.ok ... err:msi:env_parse_flags Invalid flags: 0007 err:msi:ITERATE_Actions Execution halted, action LRemoveEnvironmentStrings returned 1627 err:msi:env_parse_flags Invalid flags: 0007 action.c:5588: Test failed: Expected ERROR_SUCCESS, got 1627 action.c:5594: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5597: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5609: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 fixme:ntdll:NtQueryInformationToken QueryInformationToken( ..., TokenElevationType, ...) semi-stub action.c:5666: Test failed: key not created action.c:5670: Test failed: key not created action.c:5674: Test failed: key not created ... Command exited with non-zero status 7 4.04user 0.50system 0:05.03elapsed 90%CPU (0avgtext+0avgdata 51216maxresident)k 0inputs+7360outputs (0major+17117minor)pagefaults 0swaps make: *** [action.ok] Error 7 -- Forwarded message -- From: build...@kegel.com Date: Sat, Sep 10, 2011 at 12:33 PM Subject: Re: 78647: Subject: msi: Properly check for a specified flag combination To: d...@kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/15 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot
Re: Marking test cases as flaky?
On Sat, Sep 10, 2011 at 10:55 AM, Stefan Dösinger stefandoesin...@gmx.at wrote: On Saturday 10 September 2011 19:43:08 Dan Kegel wrote: #define ok_(file, func, line) (winetest_set_location(file, func, line), 0) ? (void)0 : winetest_ok #define ok ok_(__FILE__, __FUNCTION__, __LINE__) That would get you most of what you propose without any changes to the tests, I think. I think that would work. Of course you have to change the tests that explicitly use ok_() Might want to define the new form as ok2_ or something so we can defer changing the explicit uses of ok_().
Re: [1/3] msxml3: Add xmlparser interfaces
Hi Francois,
This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl
which is a bit strange because I cannot find this type in the Windows
SDK. But in the Windows 7 SDK there is an XmlError enumeration type in
xmllite.h that looks similar but subtly different.
These two enumaration types share some error codes, in particular
XML_E_INVALID_HEXIDECIMAL (Microsoft can't spell apparently) but with
different values. In this case 0xc00ce51e in Wine vs. 0xc00ce01e in the
Windows 7 SDK.
So what's going on?
I have taken my values from xmlparser.idl found in the the PocketPC SDK that
is included with VS 2008.
I've double check the values, and they are correct.
From the windows xmlparser.idl
typedef enum {
XML_E_PARSEERRORBASE = 0xC00CE500L,
XML_E_ENDOFINPUT= XML_E_PARSEERRORBASE,
...
XML_E_INVALID_HEXIDECIMAL, // 1E - WINE = 0xC00CE51E
} XML_ERROR_CODE;
Hope this clears things up.
Best Regards
Alistair Leslie-Hughes
