Re: [PATCH 1/2] amstream: Add stubbed implementation of DirectDrawStreamSample. (try 4)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18050 Your paranoid android. === WVISTAADM (32 bit amstream) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation
Re: [1/3] d3dx9: Define DDS structures.
Is there no header that should define these?
Re: [2/3] d3dx9: Add partial DDS support implementation for D3DXGetImageInfo functions.
On 26 April 2012 11:47, Józef Kucia joseph.ku...@gmail.com wrote: +static HRESULT get_image_info_from_dds(LPCVOID buffer, DWORD length, D3DXIMAGE_INFO *info) Please avoid types like LPCVOID.
Re: [1/3] d3dx9: Define DDS structures.
On Thu, Apr 26, 2012 at 12:04 PM, Henri Verbeet hverb...@gmail.com wrote: Is there no header that should define these? These structures and defines seem to be defined only in a D3D sample DDS without D3DX.
Re: [1/3] d3dx9: Define DDS structures.
On 26 April 2012 12:13, Józef Kucia joseph.ku...@gmail.com wrote: On Thu, Apr 26, 2012 at 12:04 PM, Henri Verbeet hverb...@gmail.com wrote: Is there no header that should define these? These structures and defines seem to be defined only in a D3D sample DDS without D3DX. I guess that's ok then.
Re: [3/3] d3dx9: Implement conversion from DDS pixel format to D3DFORMAT.
Il 26 aprile 2012 11:47, Józef Kucia joseph.ku...@gmail.com ha scritto:
static D3DFORMAT dds_pixel_format_to_d3dformat(const struct dds_pixel_format
*pixel_format)
{
- FIXME(Pixel format conversion not implemented.\n);
+ if (pixel_format-flags DDS_PF_FOURCC)
+ return dds_fourcc_to_d3dformat(pixel_format-fourcc);
+ else if (pixel_format-flags DDS_PF_RGB)
+ return dds_rgb_to_d3dformat(pixel_format);
+ else if (pixel_format-flags DDS_PF_LUMINANCE)
+ return dds_luminance_to_d3dformat(pixel_format);
+ else if (pixel_format-flags DDS_PF_ALPHA_ONLY)
+ return dds_alpha_to_d3dformat(pixel_format);
You don't need all those 'else's, the 'return's imply that you get
there only when the 'if' condition isn't true.
The same applies in other areas of this patch.
I don't mind much, but since you have to resend the series anyway...
Re: [1/3] d3dx9: Define DDS structures.
Am Donnerstag, 26. April 2012, 11:47:51 schrieb Józef Kucia: +DWORD pitch_or_linear_size; Are you aware that lPitch is a (signed) LONG in the original DDSURFACEDESC structure? Honestly I have no idea why, and I have never seen an app that passes a negative pitch, but it might lead to obscure bugs if it is not checked. signature.asc Description: This is a digitally signed message part.
Re: [1/3] d3dx9: Define DDS structures.
On Thu, Apr 26, 2012 at 9:50 PM, Stefan Dösinger stefandoesin...@gmx.at wrote: Am Donnerstag, 26. April 2012, 11:47:51 schrieb Józef Kucia: + DWORD pitch_or_linear_size; Are you aware that lPitch is a (signed) LONG in the original DDSURFACEDESC structure? Honestly I have no idea why, and I have never seen an app that passes a negative pitch, but it might lead to obscure bugs if it is not checked. MSDN says that dwPitchOrLinearSize is DWORD in the DDS_HEADER. Also, the same definition is used in a D3D sample. On the other hand, we can define it as LONG to be safe.
