Re: ntdll: Add a file access test.
On 9/13/2013 11:20, Dmitry Timoshkov wrote: This test passes under Wine and shows that ReadFile after CreateFile(GENERIC_WRITE) is really supposed to fail. --- dlls/ntdll/tests/file.c | 82 + 1 file changed, 82 insertions(+) It looks like it belongs to kernel32/tests.
Re: ntdll: Add a file access test.
Nikolay Sivov bungleh...@gmail.com wrote: It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. -- Dmitry.
Re: ntdll: Add a file access test.
On 9/13/2013 12:16, Dmitry Timoshkov wrote: Nikolay Sivov bungleh...@gmail.com wrote: It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. It doesn't matter what it uses internally. You're testing kernel32 calls.
Re: [1/2] ntdll: Properly handle 0-length reads. Resend.
Dmitry Timoshkov dmi...@baikal.ru writes: This matches what NtWriteFile does. I assume that this patch is in 'pending' state because of a test failure caused by 2/2, if the reason is different - please let me know. It would need some test cases for other file types. -- Alexandre Julliard julli...@winehq.org
Re: ntdll: Add a file access test.
Nikolay Sivov bungleh...@gmail.com wrote: It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. It doesn't matter what it uses internally. You're testing kernel32 calls. What are you trying to prove? Half of the calls in that file are using kernel32 APIs, that doesn't mean that they need to be moved to kernel32 or that they are doing something wrong. -- Dmitry.
Re: ntdll/tests: Fix compilation on systems that don't support nameless unions. (rediffed)
Francois Gouget fgou...@free.fr wrote: That tree was a bit out of date causing the patch to fail to apply. I updated it and rediffed. I'd appreciate if you could postpone sending this sort of patches when they could conflict with other pending patches in that area. Thanks. -- Dmitry.
Re: ntdll: Add a file access test.
Dmitry Timoshkov dmi...@baikal.ru writes: Nikolay Sivov bungleh...@gmail.com wrote: It looks like it belongs to kernel32/tests. Since actual access checks are done by ntdll APIs I believe that ntdll/tests is appropriate place, kernel32 file APIs are just wrappers around the tested functionality. It doesn't matter what it uses internally. You're testing kernel32 calls. What are you trying to prove? Half of the calls in that file are using kernel32 APIs, that doesn't mean that they need to be moved to kernel32 or that they are doing something wrong. Using kernel32 APIs in order to test the ntdll ones is fine. But a test that only calls kernel32 has no reason to be in ntdll. -- Alexandre Julliard julli...@winehq.org
Re: [PATCH 3/3] riched20: Add UTF8 support for EM_SETTEXTEX. (try 5)
Jactry Zeng jactr...@gmail.com writes:
@@ -3313,6 +3315,10 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT
msg, WPARAM wParam,
len = lParam ? strlen((char *)lParam) : 0;
}
} else {
+ if(bUTF8) {
+lParam = lParam + 3;
+pStruct-codepage = CP_UTF8;
+ }
That struct belongs to the caller, you can't change it.
--
Alexandre Julliard
julli...@winehq.org
Re: fonts: Add some box-type glyphs to wingdings.
On Fri, Sep 13, 2013 at 11:07:19AM +0100, Huw Davies wrote: --- fonts/wingding.sfd | 86 + Please ignore this one and use 'try 2'. I had the points of one glyph selected in the outline editor which apparently gets saved to the .sfd . Huw.
Re: [PATCH 3/3] riched20: Add UTF8 support for EM_SETTEXTEX. (try 5)
2013/9/13 Alexandre Julliard julli...@winehq.org
@@ -3313,6 +3315,10 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor,
UINT msg, WPARAM wParam,
len = lParam ? strlen((char *)lParam) : 0;
}
} else {
+ if(bUTF8) {
+lParam = lParam + 3;
+pStruct-codepage = CP_UTF8;
+ }
That struct belongs to the caller, you can't change it.
Thank you for the review!
I have sent another try.
--
Regards,
Jactry Zeng
Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 5)
On 9/13/2013 13:27, Jactry Zeng wrote: Re-based to latest git. Does it actually accept any other value besides CP_ACP or 1200? Documentation is unclear here, and makes impression that only two these values are valid.
Re: [PATCH 3/3] riched20: Add UTF8 support for EM_SETTEXTEX. (try 6)
On 9/13/2013 15:05, Jactry Zeng wrote: bUnicode = !bRtf pStruct-codepage == CP_UNICODE; +bUTF8 = (lParam (!strncmp((char *)lParam, utf8_bom, 3))); What will happen if both of these are true? This needs a test with BOM and 'codepage' set to 1200.
Re: [PATCH 3/3] riched20: Add UTF8 support for EM_SETTEXTEX. (try 6)
Hi Nikolay, 2013/9/13 Nikolay Sivov bungleh...@gmail.com On 9/13/2013 15:05, Jactry Zeng wrote: bUnicode = !bRtf pStruct-codepage == CP_UNICODE; +bUTF8 = (lParam (!strncmp((char *)lParam, utf8_bom, 3))); What will happen if both of these are true? This needs a test with BOM and 'codepage' set to 1200. Thanks for your review. The test showed that bUnicode have a higher priority that BOM. I will try it again. -- Regards, Jactry Zeng
Re: [PATCH 2/3] riched20/tests: Add UTF8 BOM tests for EM_SETTEXTEX. (try 5)
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2155 Your paranoid android. === w7pro64 (64 bit editor) === editor.c:5757: Test failed: wrong event mask (0x0) during WM_COMMAND
Re: [PATCH 1/3] iphlpapi/tests: Increase buffer size to prevent overflow.
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2158 Your paranoid android. === build (build) === Patch failed to apply
Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 2)
On 9/13/2013 22:26, André Hentschel wrote: Sorry, ignore my comment. I missed that we actually have this call already in wine.
Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 2)
On 9/13/2013 22:26, André Hentschel wrote:
+if (!pCreateFile2)
+{
+win_skip(CreateFile2 is missing\n);
+return;
+}
Should be skip() so it'll show up when running with wine. Not sure how
important it is though.
