Re: [1/2] wined3d: Support clipplanes with GLSL shaders

2008-08-23 Thread Henri Verbeet 
 @@ -248,11 +248,12 @@ typedef struct {
  void (*shader_generate_vshader)(IWineD3DVertexShader *iface, 
 SHADER_BUFFER *buffer);
  void (*shader_get_caps)(WINED3DDEVTYPE devtype, WineD3D_GL_Info 
 *gl_info, struct shader_caps *caps);
  BOOL (*shader_conv_supported)(WINED3DFORMAT conv);
 +DWORD shader_supported_clipplanes; /* bitmask of supported clipplanes */
  } shader_backend_t;
You shouldn't abuse the call table like that, you should store that
flag in the private data instead.

Re: [1/2] WineD3D: Support clipplanes with GLSL shaders

2008-03-31 Thread Alexandre Julliard 
Stefan Dösinger [EMAIL PROTECTED] writes:

 From 1cb24469eb0f53f7e67dea2c7659ad070b86f21d Mon Sep 17 00:00:00 2001
 From: Stefan Doesinger [EMAIL PROTECTED]
 Date: Fri, 28 Mar 2008 16:11:06 +0100
 Subject: [PATCH] WineD3D: Support clipplanes with GLSL shaders

 This patch removes the shader clipplane disabling code from the
 common/fixed function state table and enables GLSL shaders to write to
 the clipcoord output attribute. The ARB specific clipplane disabling is
 handled in the ARB shader backend.

It doesn't work for me:

../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so 
visual.c  touch visual.ok
visual.c:4738: Test failed: vs_3_0 returned color 0x0011, expected 
0x00203366
visual.c:4743: Test failed: vs_1_1 returned color 0x0011, expected 
0x00808080
visual.c:4748: Test failed: vs_2_0 returned color 0x0011, expected 
0x
visual.c:4929: Test failed: ps_3_0 returned color 0x00193300, expected 
0x0080ffe5
make[2]: *** [visual.ok] Error 4

-- 
Alexandre Julliard
[EMAIL PROTECTED]