Re: ddraw: Remove a test that fails in VMs

[James Hawkins]

On Sat, Apr 26, 2008 at 1:11 AM, Reece Dunn [EMAIL PROTECTED] wrote:
 2008/4/26 James Hawkins [EMAIL PROTECTED]:

  Hi,
  
The tests aren't run anyway in this case.
  
Changelog:
* Remove a test that fails in VMs.
  ...
hr = IDirect3D7_CreateDevice(Direct3D, 
 IID_IDirect3DRefDevice, Surface, Direct3DDevice);
}
}
   -ok(hr == D3D_OK, IDirect3D7_CreateDevice failed with %08x\n, hr);

  Wouldn't it be better to move the ok line to directly after the
  IDirect3D7_CreateDevice call? That way, on VM machines the test will
  not get run and on non-VM machines it will, as it is a valid test in
  that case.


No, the test will still be run in all cases, VM or not, and will fail
in VMs.  The function just sets up the direct3d device object for
other tests; there's no point in an ok test in this function,
especially when it doesn't pass for all systems.

-- 
James Hawkins

Re: ddraw: Remove a test that fails in VMs

[Reece Dunn]

2008/4/26 James Hawkins [EMAIL PROTECTED]:
 Hi,

  The tests aren't run anyway in this case.

  Changelog:
  * Remove a test that fails in VMs.
...
  hr = IDirect3D7_CreateDevice(Direct3D, IID_IDirect3DRefDevice, 
 Surface, Direct3DDevice);
  }
  }
 -ok(hr == D3D_OK, IDirect3D7_CreateDevice failed with %08x\n, hr);

Wouldn't it be better to move the ok line to directly after the
IDirect3D7_CreateDevice call? That way, on VM machines the test will
not get run and on non-VM machines it will, as it is a valid test in
that case.

- Reece

Re: ddraw: Remove a test that fails in VMs

[Reece Dunn]

2008/4/26 James Hawkins [EMAIL PROTECTED]:

 On Sat, Apr 26, 2008 at 1:11 AM, Reece Dunn [EMAIL PROTECTED] wrote:
Wouldn't it be better to move the ok line to directly after the
IDirect3D7_CreateDevice call? That way, on VM machines the test will
not get run and on non-VM machines it will, as it is a valid test in
that case.

  No, the test will still be run in all cases, VM or not, and will fail
  in VMs.  The function just sets up the direct3d device object for
  other tests; there's no point in an ok test in this function,
  especially when it doesn't pass for all systems.

Ok.

- Reece