Re: [Wireshark-dev] [PATCH] wireshark:decode GETDEVINFO error when using pnfs-block
Hi, I think this has a good chance of getting merged, but it's preferred to have patches submitted as enhancement bugs through bugs.wireshark.org. In this way discussion on the bug stays grouped, won't get lost in the backlog of a mailing list, sample captures (do you have one?) can be harvested for tests, etc. Thanks, Jaap On 03/13/2013 03:37 AM, fanchaoting wrote: > now when using pnfs block, if recieve a GETDEVINFO packet, the wireshark > decode this packect error, because GETDEVINFO(block-layout) is Different from > GETDEVINFO(file-layout). the wireshark now only can decode > GETDEVINFO(file-layout). > but when recieve GETDEVINFO(block-layout), it decode error. > > Signed-off-by: fanchaoting > > --- > > diff --git a/epan/dissectors/packet-nfs.c b/epan/dissectors/packet-nfs.c > index 77b6db5..35b5926 100644 > --- a/epan/dissectors/packet-nfs.c > +++ b/epan/dissectors/packet-nfs.c > @@ -407,6 +407,15 @@ static int hf_nfs_op_mask = -1; ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] -Wmissing-prototypes ??
The C++ standard requires prototypes for all functions, so g++ replaces gcc's -Wmissing-prototypes with a mandatory compiler error. I assume that this was part of the C++ compatibility work that Anders has been doing recently. Evan On Tue, Mar 12, 2013 at 10:55 PM, Bill Meier wrote: > Anders: > > Just out of curiosity, why are the prototypes in the following change needed > ? > > > Or: maybe the real question is: why is -Wmissing_prototypes needed ? > > We already catch any .h files which are missing prototypes of global > functions because we use -Wimplicit-function-declaration (part of -Wall). > > So: what am i missing ? > > Bill > > > >> >> User: etxrab >> Date: 2013/03/12 04:09 PM >> >> Log: >> - [-Wmissing-prototypes] > > --- packet-aodv.c (revision 48273) > +++ packet-aodv.c (revision 48274) > @@ -50,6 +50,8 @@ > * (both of the above two are draft-perkins-manet-aodv6-01.txt, which > * is from November 2000) > */ > +void proto_register_aodv(void); > +void proto_reg_handoff_aodv(void); > > #define INET6_ADDRLEN 16 > #define UDP_PORT_AODV 654 > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] qtshark -> wireshark-qt ?
2013/3/13 Evan Huus : > I believe when building with autotools and passing --with-qt to > configure that the resulting binary is still just called 'wireshark'? > I don't know what happens when you try and build both together, but I > don't have a problem with that producing wireshark-gtk2, > wireshark-gtk3 or wireshark-qt as appropriate. With CMake we can build both together and the qt version is called qtshark. I plan converting the Debian package to use CMake to ship both and simplify the build process. Cheers, Balint > > Evan > > On Tue, Mar 12, 2013 at 10:45 PM, Bálint Réczey > wrote: >> Hi, >> >> I would like to suggest renaming the relatively new qtshark binary to >> wireshark-qt. >> I believe wireshark-qt would align better with the practice of >> providing the very same software >> for different UI toolkits with the same name postfixed by the UI toolkit >> name. >> >> Cheers, >> Balint >> ___ >> Sent via:Wireshark-dev mailing list >> Archives:http://www.wireshark.org/lists/wireshark-dev >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev >> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] -Wmissing-prototypes ??
Anders: Just out of curiosity, why are the prototypes in the following change needed ? Or: maybe the real question is: why is -Wmissing_prototypes needed ? We already catch any .h files which are missing prototypes of global functions because we use -Wimplicit-function-declaration (part of -Wall). So: what am i missing ? Bill > > User: etxrab > Date: 2013/03/12 04:09 PM > > Log: > - [-Wmissing-prototypes] --- packet-aodv.c (revision 48273) +++ packet-aodv.c (revision 48274) @@ -50,6 +50,8 @@ * (both of the above two are draft-perkins-manet-aodv6-01.txt, which * is from November 2000) */ +void proto_register_aodv(void); +void proto_reg_handoff_aodv(void); #define INET6_ADDRLEN 16 #define UDP_PORT_AODV 654 ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] qtshark -> wireshark-qt ?
I believe when building with autotools and passing --with-qt to configure that the resulting binary is still just called 'wireshark'? I don't know what happens when you try and build both together, but I don't have a problem with that producing wireshark-gtk2, wireshark-gtk3 or wireshark-qt as appropriate. Evan On Tue, Mar 12, 2013 at 10:45 PM, Bálint Réczey wrote: > Hi, > > I would like to suggest renaming the relatively new qtshark binary to > wireshark-qt. > I believe wireshark-qt would align better with the practice of > providing the very same software > for different UI toolkits with the same name postfixed by the UI toolkit name. > > Cheers, > Balint > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] qtshark -> wireshark-qt ?
Hi, I would like to suggest renaming the relatively new qtshark binary to wireshark-qt. I believe wireshark-qt would align better with the practice of providing the very same software for different UI toolkits with the same name postfixed by the UI toolkit name. Cheers, Balint ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Wireshark 1.9.1 is now available
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark 1.9.1. This is an experimental release intended to test features that will go into Wireshark 1.10. What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis, development and education. What's New New and Updated Features The following features are new (or have been significantly updated) since version 1.8: o Wireshark on 32- and 64-bit Windows supports automatic updates. o The packet bytes view is faster. o You can now display a list of resolved host names in "hosts" format within Wireshark. o The wireless toolbar has been updated. o Wireshark on Linux does a better job of detecting interface addition and removal. o It is now possible to compare two fields in a display filter (for example: udp.srcport != udp.dstport). The two fields must be of the same type for this to work. o The main welcome screen and status bar now display file sizes using strict SI prefixes instead of old-style binary prefixes. o Capinfos now prints human-readable statistics with SI suffixes by default. Updated Protocol Support Too many protocols have been updated to list here. Getting Wireshark Wireshark source code and installation packages are available from [1]http://www.wireshark.org/download.html. Vendor-supplied Packages Most Linux and Unix vendors supply their own Wireshark packages. You can usually install or upgrade Wireshark using the package management system specific to that platform. A list of third-party packages can be found on the [2]download page on the Wireshark web site. File Locations Wireshark and TShark look in several different locations for preference files, plugins, SNMP MIBS, and RADIUS dictionaries. These locations vary from platform to platform. You can use About→Folders to find the default locations on your system. Known Problems Dumpcap might not quit if Wireshark or TShark crashes. ([3]Bug 1419) The BER dissector might infinitely loop. ([4]Bug 1516) Capture filters aren't applied when capturing from named pipes. ([5]Bug 1814) Filtering tshark captures with display filters (-R) no longer works. ([6]Bug 2234) The 64-bit Windows installer does not support Kerberos decryption. ([7]Win64 development page) Application crash when changing real-time option. ([8]Bug 4035) Hex pane display issue after startup. ([9]Bug 4056) Packet list rows are oversized. ([10]Bug 4357) Summary pane selected frame highlighting not maintained. ([11]Bug 4445) Wireshark and TShark will display incorrect delta times in some cases. ([12]Bug 4985) Getting Help Community support is available on [13]Wireshark's Q&A site and on the wireshark-users mailing list. Subscription information and archives for all of Wireshark's mailing lists can be found on [14]the web site. Official Wireshark training and certification are available from [15]Wireshark University. Frequently Asked Questions A complete FAQ is available on the [16]Wireshark web site. Digests wireshark-1.9.1.tar.bz2: 24670028 bytes MD5(wireshark-1.9.1.tar.bz2)=19190fef6d836a8436b943e1a70d8c74 SHA1(wireshark-1.9.1.tar.bz2)=6015e53de3e12703e6324d46af55da58567415ea RIPEMD160(wireshark-1.9.1.tar.bz2)=cd796a19abb7839d7aa233b740401640af9140e8 Wireshark-win64-1.9.1.exe: 32793880 bytes MD5(Wireshark-win64-1.9.1.exe)=f729580552358eb61ce0ece82bc6ddda SHA1(Wireshark-win64-1.9.1.exe)=73c8cd269200052df74234b92238720b9064ac8c RIPEMD160(Wireshark-win64-1.9.1.exe)=609ae6e76d6a57830899cefdd8b3aeaee25d054e Wireshark-win32-1.9.1.exe: 26373400 bytes MD5(Wireshark-win32-1.9.1.exe)=fe73b122839df6e40d001207d7fecfac SHA1(Wireshark-win32-1.9.1.exe)=06a3add8324bbb2f704044584dbbaa1d4b45a16e RIPEMD160(Wireshark-win32-1.9.1.exe)=3c1677bc7c2725b05fcc2d969d7a94ad837058bd Wireshark-1.9.1.u3p: 30560994 bytes MD5(Wireshark-1.9.1.u3p)=95b3b03a72503e5b302f56ab5b74c744 SHA1(Wireshark-1.9.1.u3p)=5807112289221dea9ed70afc08b54d204d4c481c RIPEMD160(Wireshark-1.9.1.u3p)=f2a118ad4bf71a6213469f2364c64fb7525b5d0a WiresharkPortable-1.9.1.paf.exe: 27644240 bytes MD5(WiresharkPortable-1.9.1.paf.exe)=fb46154090a242031897227eda93f357 SHA1(WiresharkPortable-1.9.1.paf.exe)=dedfbfdeccf018f4f65f9b0b78aa048ee216eb51 RIPEMD160(WiresharkPortable-1.9.1.paf.exe)=34353cab8d70512b80368156e7fc010e3429bb92 Wireshark 1.9.1 PPC 32.dmg: 23848369 bytes MD5(Wireshark 1.9.1 PPC 32.dmg)=ed41e7a663c47ebc19dd155d9e85eb36 SHA1(Wireshark 1.9.1 PPC 32.dmg)=51c4dfb7d7a8f2381805dd47b2d1289a6739c0bc RIPEMD160(Wireshark 1.9.1 PPC 32.dmg)=bf428443735ab4db0a048b4774875f3431207bd5 Wireshark 1.9.1 Intel 64.dmg: 22877616 bytes MD5(Wireshark 1.9.1 Intel 64.dmg)=0f1e7aa0145741f48f02720e6799790b SHA1(Wireshark 1.9.1 Intel 64.dmg)=c71dca40950a72054618309
Re: [Wireshark-dev] Old ethereal.com list archives back online
Hi Gerald, Cool, thanks! It's nice to look back and see how far we've come. And we're still not there yet! Thanks, Jaap On 03/12/2013 10:54 PM, Gerald Combs wrote: > Since www.ethereal.com is no longer serving up pages I added the old > mailing list archives to http://www.wireshark.org/lists/ . ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] wireshark-win32-libs rev 423: /tags/2013-03-09/
Hi, Check this: https://www.winpcap.org/devel.htm It says there's none. The 4.1.2 pack will do. Thanks, Jaap On 03/12/2013 04:23 PM, Maynard, Chris wrote: > Is there an updated WpdPack? I don't see one at > https://www.winpcap.org/archive/, but then again I don't see a > 4.1.2-WpdPack.zip there either. > > -Original Message- > From: wireshark-commits-boun...@wireshark.org > [mailto:wireshark-commits-boun...@wireshark.org] On Behalf Of > ger...@wireshark.org > Sent: Friday, March 08, 2013 8:53 PM > To: wireshark-comm...@wireshark.org > Subject: [Wireshark-commits] wireshark-win32-libs rev 423: /tags/2013-03-09/ > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&root=Wireshark-win32-libs&revision=423 > > User: gerald > Date: 2013/03/08 05:52 PM > > Log: > Update WinPcap to 4.1.3. > ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Old ethereal.com list archives back online
Since www.ethereal.com is no longer serving up pages I added the old mailing list archives to http://www.wireshark.org/lists/ . ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] wireshark-win32-libs rev 423: /tags/2013-03-09/
Is there an updated WpdPack? I don't see one at https://www.winpcap.org/archive/, but then again I don't see a 4.1.2-WpdPack.zip there either. -Original Message- From: wireshark-commits-boun...@wireshark.org [mailto:wireshark-commits-boun...@wireshark.org] On Behalf Of ger...@wireshark.org Sent: Friday, March 08, 2013 8:53 PM To: wireshark-comm...@wireshark.org Subject: [Wireshark-commits] wireshark-win32-libs rev 423: /tags/2013-03-09/ http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&root=Wireshark-win32-libs&revision=423 User: gerald Date: 2013/03/08 05:52 PM Log: Update WinPcap to 4.1.3. -- CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email. Thank you. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
