Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
Hi, I prefer also ENC_NA for single-byte. I think, it will be complicated to have a automatically tools for check if ENC_BIG_ENDIAN and ENC_LITTLE_ENDIAN will be autorise.. Yes, Petri-dish/pre-commit is guard but need all people use it... Regards, On Mon, Dec 15, 2014 at 8:23 AM, Michal Labedzki wrote: > > Personally I prefer ENC_NA for single-byte. Some dissectors can mix > endianess, like file-elf. What use in case like that? > > Maybe there is a need to add something new like ENC_NO_ENDIAN? > (ENC_HOST_ENDIAN?) > That can be used to fetch value that is always in host endian (magic > number?) > > By the way: I use ENC_NA to improve readability too. I take a quick > look and see my single-byte field, where around is a lot of multibyte > fields. > > About copy-paste bugs: now there is a guard like Petri-Dish/pre-commit. > > On 15 December 2014 at 01:43, Jeff Morriss > wrote: > > On 12/14/2014 03:03 PM, Bill Meier wrote: > >> > >> On 12/14/2014 2:22 PM, Stephen Fisher wrote: > >>> > >>> On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: > >>> > That being said, the convention (certainly not enforced) seems to be > to use ENC_..._ENDIAN for fetching all integral types. > >>> > >>> > >>> Could this be related to when we made the change from using FALSE / > TRUE > >>> to specify if its "big endian" in things like proto_tree_add_item() ? > >> > >> > >> > >> Good point ! > >> > >> fix-encoding-args.pl (used to do the change) just converted FALSE|0 to > >> BIG_ENDIAN and etc, so the "convention" actually kind-of-happened > >> because previously TRUE|1 or FALSE|0 were the only choices for the > >> 'encoding-arg". > >> > >> So, I stand corrected. > >> > >> Maybe what I should be doing is converting all the single-byte fetches > >> to use ENC_NA. > >> > >> Thoughts ? > > > > > > We discussed this some time ago; the consensus at the time seemed to be > use > > ENC_*_ENDIAN for 1-byte fields: > > > > https://www.wireshark.org/lists/wireshark-dev/201107/msg00404.html > > > > > > > ___ > > Sent via:Wireshark-dev mailing list > > Archives:http://www.wireshark.org/lists/wireshark-dev > > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > > > > -- > > Pozdrawiam / Best regards > > - > Michał Łabędzki, Software Engineer > Tieto Corporation > > Product Development Services > > http://www.tieto.com / http://www.tieto.pl > --- > ASCII: Michal Labedzki > location: Swobodna 1 Street, 50-088 Wrocław, Poland > room: 5.01 (desk next to 5.08) > --- > Please note: The information contained in this message may be legally > privileged and confidential and protected from disclosure. If the > reader of this message is not the intended recipient, you are hereby > notified that any unauthorised use, distribution or copying of this > communication is strictly prohibited. If you have received this > communication in error, please notify us immediately by replying to > the message and deleting it from your computer. Thank You. > --- > Please consider the environment before printing this e-mail. > --- > Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w > Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym > Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego > Rejestru Sądowego pod numerem 124858. NIP: 8542085557. REGON: > 812023656. Kapitał zakładowy: 4 271500 PLN > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Ubuntu PPA for Wireshark stable branch
On Fri, Dec 12, 2014 at 10:53 PM, Bálint Réczey wrote: > > Hi All, > > I have created a PPA for the stable Wireshark branch point releases: > https://launchpad.net/~wireshark-dev/+archive/ubuntu/stable > > The packages are back-ported from latest packaged version in Debian > unstable to prevent upgrade problems. > > Since in Debian we are in "freeze" phase I can't upload 1.12.2-1, but > when it is over in a few weeks I will follow the Wireshark releases > closely again. > > It is not an official announcement, just a short status update. The > packages are building on Launchpad for the first time and haven't been > tested yet. If you feel so please try them and send feedback. > > Currently packages for Ubuntu 14.10 (Trusty) are building, and I plan > adding all supported Ubuntu versions. > > Cheers, > Balint > Nice work ! thanks ! > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
Personally I prefer ENC_NA for single-byte. Some dissectors can mix endianess, like file-elf. What use in case like that? Maybe there is a need to add something new like ENC_NO_ENDIAN? (ENC_HOST_ENDIAN?) That can be used to fetch value that is always in host endian (magic number?) By the way: I use ENC_NA to improve readability too. I take a quick look and see my single-byte field, where around is a lot of multibyte fields. About copy-paste bugs: now there is a guard like Petri-Dish/pre-commit. On 15 December 2014 at 01:43, Jeff Morriss wrote: > On 12/14/2014 03:03 PM, Bill Meier wrote: >> >> On 12/14/2014 2:22 PM, Stephen Fisher wrote: >>> >>> On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: >>> That being said, the convention (certainly not enforced) seems to be to use ENC_..._ENDIAN for fetching all integral types. >>> >>> >>> Could this be related to when we made the change from using FALSE / TRUE >>> to specify if its "big endian" in things like proto_tree_add_item() ? >> >> >> >> Good point ! >> >> fix-encoding-args.pl (used to do the change) just converted FALSE|0 to >> BIG_ENDIAN and etc, so the "convention" actually kind-of-happened >> because previously TRUE|1 or FALSE|0 were the only choices for the >> 'encoding-arg". >> >> So, I stand corrected. >> >> Maybe what I should be doing is converting all the single-byte fetches >> to use ENC_NA. >> >> Thoughts ? > > > We discussed this some time ago; the consensus at the time seemed to be use > ENC_*_ENDIAN for 1-byte fields: > > https://www.wireshark.org/lists/wireshark-dev/201107/msg00404.html > > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe -- Pozdrawiam / Best regards - Michał Łabędzki, Software Engineer Tieto Corporation Product Development Services http://www.tieto.com / http://www.tieto.pl --- ASCII: Michal Labedzki location: Swobodna 1 Street, 50-088 Wrocław, Poland room: 5.01 (desk next to 5.08) --- Please note: The information contained in this message may be legally privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any unauthorised use, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank You. --- Please consider the environment before printing this e-mail. --- Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego Rejestru Sądowego pod numerem 124858. NIP: 8542085557. REGON: 812023656. Kapitał zakładowy: 4 271500 PLN ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Bugzilla permissions
On 12/12/2014 01:14 PM, Stephen Fisher wrote: On Fri, Dec 12, 2014 at 09:25:00AM -0500, Bill Meier wrote: ISTR a reason the "assigned to" is left unchanged is something about email notices about the bug need to go to the administrator or something. I recall another reason (although I may be recalling incorrectly), that leaving it assigned to wireshark-bugs keeps updates going to the wireshark-bugs mailing list whereas if its assigned to a particular person those e-mail updates wouldn't go out. Yes, but that's no longer needed: Gerald changed it quite some time ago so that wireshark-bugs gets all bug updates, not just for bugs assigned-to (or Cc:) wireshark-bugs. That's why the bottom of the -bugs mails now say: You are receiving this mail because: You are watching all bug changes. ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
On 12/14/2014 03:03 PM, Bill Meier wrote: On 12/14/2014 2:22 PM, Stephen Fisher wrote: On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: That being said, the convention (certainly not enforced) seems to be to use ENC_..._ENDIAN for fetching all integral types. Could this be related to when we made the change from using FALSE / TRUE to specify if its "big endian" in things like proto_tree_add_item() ? Good point ! fix-encoding-args.pl (used to do the change) just converted FALSE|0 to BIG_ENDIAN and etc, so the "convention" actually kind-of-happened because previously TRUE|1 or FALSE|0 were the only choices for the 'encoding-arg". So, I stand corrected. Maybe what I should be doing is converting all the single-byte fetches to use ENC_NA. Thoughts ? We discussed this some time ago; the consensus at the time seemed to be use ENC_*_ENDIAN for 1-byte fields: https://www.wireshark.org/lists/wireshark-dev/201107/msg00404.html ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
On Dec 14, 2014 3:04 PM, "Bill Meier" wrote: > > On 12/14/2014 2:22 PM, Stephen Fisher wrote: >> >> On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: >> >>> That being said, the convention (certainly not enforced) seems to be >>> to use ENC_..._ENDIAN for fetching all integral types. >> >> >> Could this be related to when we made the change from using FALSE / TRUE >> to specify if its "big endian" in things like proto_tree_add_item() ? > > > > Good point ! > > fix-encoding-args.pl (used to do the change) just converted FALSE|0 to BIG_ENDIAN and etc, so the "convention" actually kind-of-happened because previously TRUE|1 or FALSE|0 were the only choices for the 'encoding-arg". > > So, I stand corrected. > > Maybe what I should be doing is converting all the single-byte fetches to use ENC_NA. > > Thoughts ? This makes sense to me. > Bill > > > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
Den 14 dec 2014 21:03 skrev "Bill Meier" : > > On 12/14/2014 2:22 PM, Stephen Fisher wrote: >> >> On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: >> >>> That being said, the convention (certainly not enforced) seems to be >>> to use ENC_..._ENDIAN for fetching all integral types. >> >> >> Could this be related to when we made the change from using FALSE / TRUE >> to specify if its "big endian" in things like proto_tree_add_item() ? > > > > Good point ! > > fix-encoding-args.pl (used to do the change) just converted FALSE|0 to BIG_ENDIAN and etc, so the "convention" actually kind-of-happened because previously TRUE|1 or FALSE|0 were the only choices for the 'encoding-arg". > > So, I stand corrected. > > Maybe what I should be doing is converting all the single-byte fetches to use ENC_NA. > > Thoughts ? > > Bill > > To me using the same endianess as beeing used for other integers in the dissector would make the most sense. Regards Anders > > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
On 12/14/2014 2:22 PM, Stephen Fisher wrote: On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: That being said, the convention (certainly not enforced) seems to be to use ENC_..._ENDIAN for fetching all integral types. Could this be related to when we made the change from using FALSE / TRUE to specify if its "big endian" in things like proto_tree_add_item() ? Good point ! fix-encoding-args.pl (used to do the change) just converted FALSE|0 to BIG_ENDIAN and etc, so the "convention" actually kind-of-happened because previously TRUE|1 or FALSE|0 were the only choices for the 'encoding-arg". So, I stand corrected. Maybe what I should be doing is converting all the single-byte fetches to use ENC_NA. Thoughts ? Bill ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: > That being said, the convention (certainly not enforced) seems to be > to use ENC_..._ENDIAN for fetching all integral types. Could this be related to when we made the change from using FALSE / TRUE to specify if its "big endian" in things like proto_tree_add_item() ? ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
On 12/13/2014 4:56 PM, Evan Huus wrote: I didn't think single-byte fields could really have an endianess, so I thought ENC_NA was appropriate for them? Evan Using ENC_NA is certainly reasonable (and makes logical sense) for fetching single-byte fields. That being said, the convention (certainly not enforced) seems to be to use ENC_..._ENDIAN for fetching all integral types. Looking at the current (non-generated) dissector source before I started making changes, I noted that the usage for singe-byte fetches (for proto_tree_add_item(), etc) was more or less as follows: ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN:~12.5K ENC_NA ~ 2.7K I also noted that the ASN.1 generated dissectors appear to be using the ENC_..._ENDIAN convention as well when fetching single-byte fields. -- If there's a consensus that ENC_NA should be used when fetching single-byte fields, it might be a bit of work, but probably fairly simple to do a wholesale change Bill ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Ubuntu PPA for Wireshark stable branch
Hi, 2014-12-12 22:56 GMT+01:00 Evan Huus : > Very cool, thanks Balint! > > Also on the topic of Ubuntu and Wireshark, it looks like the packages > that ship with Ubuntu are finally getting some security love: > https://bugs.launchpad.net/ubuntu/+source/wireshark/+bug/1397091 Great! > > Evan > > On Fri, Dec 12, 2014 at 4:53 PM, Bálint Réczey wrote: >> Hi All, >> >> I have created a PPA for the stable Wireshark branch point releases: >> https://launchpad.net/~wireshark-dev/+archive/ubuntu/stable >> >> The packages are back-ported from latest packaged version in Debian >> unstable to prevent upgrade problems. >> >> Since in Debian we are in "freeze" phase I can't upload 1.12.2-1, but >> when it is over in a few weeks I will follow the Wireshark releases >> closely again. >> >> It is not an official announcement, just a short status update. The >> packages are building on Launchpad for the first time and haven't been >> tested yet. If you feel so please try them and send feedback. >> >> Currently packages for Ubuntu 14.10 (Trusty) are building, and I plan >> adding all supported Ubuntu versions. I have uploaded and tested the versions built for 14.04 and 12.04. For now I don't plan providing a version for 10.04, because it is not supported on desktop, but if there is a need for it it can be added easily. The scripts I used for packaging are available at https://github.com/rbalint/pkg-wireshark-ubuntu-ppa . I think we could make a formal announcement about it in a few days. Gerald, would you like to announce the availability of the packages? Cheers, Balint ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
