Re: [Wireshark-dev] Some planned cleanups of the 802.11 dissector
great idea. I'll wait for your changes before adding a feature - I'd like to be able to filter out beacons by writing wlan.beacon, probes by wlan.probe_request, etc. Simon On Sun, Jun 26, 2016 at 3:07 PM, Joerg Mayer wrote: > Hello, > > I plan to do some cleanups to > - somewhat improve the readability of the code > 1) Get rid of reduntant author entries and code comments, see > https://code.wireshark.org/review/16154 > 2) Get rid of those fixed field functions that only add one of two items. > Call the remaining functions directly (without the indirection of > add_fixed_field()). > - make the use of filters more straight forward: We currently register the > following top level filters within the file: > wlan_aggregate > wlan > wlan_mgt > wlan_rsna_eapol > I'd like to merge at least wlan_mgt into wlan. I don't see the gain in > the > separation and it definitely confuses me: > a) wlan_mgt is not only managemnt frames but also control frames while > data frames are just wlan. > b) The addresses inside wlan_mgt frames are addressed via wlan.xxx > > Let me know what you think about these things. > > Thanks >Jörg > > -- > Joerg Mayer > We are stuck with technology when what we really want is just stuff that > works. Some say that should read Microsoft instead of technology. > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64
On Jun 26, 2016, at 6:16 PM, Jim Young wrote: > Time for a Petri Dish for OS X? I'd say "time for a Petri dish that tests with several optional packages enabled and disabled, including libpcap and GeoIP", GeoIP being the issue here (builds without warnings with GeoIP, gets warnings without GeoIP), but there's a tradeoff - too many tests means the Petri dish takes too long, which might discourage people from using it beforehand. But, yes, an OS X buildbot would also be useful, for other reasons, and I guess we could make it a designated "without GeoIP" builder, to test whether building without GeoIP works. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64
>> Buildslave for this Build: osx-10.6-x64 >> >> Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered >> this build >> Build Source Stamp: [branch master] b84637b4f6a1f3f910b97c21264ff6132a9c19c4 >> Blamelist: Jörg Mayer >> >> BUILD FAILED: failed compile_1 > >Not me :-) > >[ 39%] Building CXX object ui/qt/CMakeFiles/qtui.dir/file_set_dialog.cpp.o >cc1plus: warnings being treated as errors >/Users/buildslave/Documents/wireshark-trunk/osx106x64/build/ui/qt/endpoint_dialog.cpp: > In member function 'QVariant EndpointTreeWidgetItem::colData(int, bool, bool) >const': >/Users/buildslave/Documents/wireshark-trunk/osx106x64/build/ui/qt/endpoint_dialog.cpp:350: > warning: control reaches end of non-void function >make[2]: *** [ui/qt/CMakeFiles/qtui.dir/endpoint_dialog.cpp.o] Error 1 >make[2]: *** Waiting for unfinished jobs It looks like 974a530 https://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11331 Time for a Petri Dish for OS X? Jim Y. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64
On Sun, Jun 26, 2016 at 05:30:56PM +, buildbot-no-re...@wireshark.org wrote: > The Buildbot has detected a new failure on builder OSX 10.6 x64 while > building wireshark. Full details are available at: > > http://buildbot.wireshark.org/wireshark-master/builders/OSX%2010.6%20x64/builds/11328 > > Buildbot URL: http://buildbot.wireshark.org/wireshark-master/ > > Buildslave for this Build: osx-10.6-x64 > > Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered > this build > Build Source Stamp: [branch master] b84637b4f6a1f3f910b97c21264ff6132a9c19c4 > Blamelist: Jörg Mayer > > BUILD FAILED: failed compile_1 Not me :-) [ 39%] Building CXX object ui/qt/CMakeFiles/qtui.dir/file_set_dialog.cpp.o cc1plus: warnings being treated as errors /Users/buildslave/Documents/wireshark-trunk/osx106x64/build/ui/qt/endpoint_dialog.cpp: In member function 'QVariant EndpointTreeWidgetItem::colData(int, bool, bool) const': /Users/buildslave/Documents/wireshark-trunk/osx106x64/build/ui/qt/endpoint_dialog.cpp:350: warning: control reaches end of non-void function make[2]: *** [ui/qt/CMakeFiles/qtui.dir/endpoint_dialog.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Some planned cleanups of the 802.11 dissector
Hello, I plan to do some cleanups to - somewhat improve the readability of the code 1) Get rid of reduntant author entries and code comments, see https://code.wireshark.org/review/16154 2) Get rid of those fixed field functions that only add one of two items. Call the remaining functions directly (without the indirection of add_fixed_field()). - make the use of filters more straight forward: We currently register the following top level filters within the file: wlan_aggregate wlan wlan_mgt wlan_rsna_eapol I'd like to merge at least wlan_mgt into wlan. I don't see the gain in the separation and it definitely confuses me: a) wlan_mgt is not only managemnt frames but also control frames while data frames are just wlan. b) The addresses inside wlan_mgt frames are addressed via wlan.xxx Let me know what you think about these things. Thanks Jörg -- Joerg Mayer We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
