great idea. I'll wait for your changes before adding a feature - I'd like to be able to filter out beacons by writing wlan.beacon, probes by wlan.probe_request, etc.
Simon On Sun, Jun 26, 2016 at 3:07 PM, Joerg Mayer <jma...@loplof.de> wrote: > Hello, > > I plan to do some cleanups to > - somewhat improve the readability of the code > 1) Get rid of reduntant author entries and code comments, see > https://code.wireshark.org/review/16154 > 2) Get rid of those fixed field functions that only add one of two items. > Call the remaining functions directly (without the indirection of > add_fixed_field()). > - make the use of filters more straight forward: We currently register the > following top level filters within the file: > wlan_aggregate > wlan > wlan_mgt > wlan_rsna_eapol > I'd like to merge at least wlan_mgt into wlan. I don't see the gain in > the > separation and it definitely confuses me: > a) wlan_mgt is not only managemnt frames but also control frames while > data frames are just wlan. > b) The addresses inside wlan_mgt frames are addressed via wlan.xxx > > Let me know what you think about these things. > > Thanks > Jörg > > -- > Joerg Mayer <jma...@loplof.de> > We are stuck with technology when what we really want is just stuff that > works. Some say that should read Microsoft instead of technology. > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe