[Wireshark-dev] How is wireshark unpacking SMB Packets?

2018-02-04 Thread senaps
Hi all, smb is reading and unpacking packets sent/recived by a smb server.
it unpacks NTLM hashes and shows the username, network name and stuff like
that.
i need to take a look at the source code of wireshark for this part.
anybody to help me out with that?
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Luacov with Wireshark Lua dissector plugin

2018-02-04 Thread Shakthi Kannan
Hi,

--- On Fri, Feb 2, 2018 at 9:01 PM, Peter Wu  wrote:
> It looks like "console.lua" is setting the "debug" function. Perhaps
> those "helpers" should be removed or namespaced, as a workaround you can
> just comment the debug function:
>
> -- function debug(x) ... end

I tried the above, but, when Wireshark is started, it actually throws
the error at:

"~/.luarocks/share/lua/5.1/luacov/hook.lua:26:attempt to index global
'debug' (a function value)".

In hook.lua, when the local variable "name" is assigned to the full
path of the Lua plugin prefixed by "@", the coverage statistics get
generated. Bascially, the following is used to retrieve the name:

  local name = debug.getinfo(level, "S").source -- returns "@dissector.lua"

So, the following hard-coded assginment works:

  local name = "@dissector.lua"
  local prefixed_name = string.match(name, "^@(.*)")

I am not sure why debug module or function is used to retrieve the
path to the Wireshark Lua plugin. Will check with the Luacov author.

Thanks for your reply. Appreciate it!

SK

-- 
Shakthi Kannan
http://www.shakthimaan.com
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning

2018-02-04 Thread Roland Knall
Actually, I'd also much rather prefer to create one 2.6 and create 2.5 as a
-rc.

It would make developing that much easier. If we plan on release 2.5 as a
regular release that I am fine with it.

cheers
Roland

On Sun, Feb 4, 2018 at 9:13 PM, Alexis La Goutte 
wrote:

>
>
> On Fri, Feb 2, 2018 at 11:45 PM, Gerald Combs 
> wrote:
>
>> I think we've fixed the major issues identified by Stig, Jim, and others
>> so I'd like to release 2.5.0 on February 6. This would let us release 2.6.0
>> this spring, followed by 3.0.0 in the fall:
>>
>>
>> March: Create master-2.6 after one or two 2.5.x releases.
>>
>> April: Release 2.6.0, probably after SharkFest Asia.
>>
>> August: Release 2.9.0.
>>
>> September 7, 2018: The 2.2 branch reaches EOL.
>>
>> September or October: Create master-3.0 after one or more 2.9.x releases.
>>
>> October or November: Release 3.0.0, either before or after SharkFest
>> Europe.
>>
> Two major release this year ?
> 2.6 will be a TLS release ?
>
> For avoid a lot of cherry-pick it is better for create master(-2.6 or
> -3.0) only 2 or 3 week before 2.6 release ?
>
>>
>>
>> As discussed on this list and (IIRC) at SharkFest EU we can start
>> removing legacy support in master after master-2.6 is branched. This
>> includes, but is not limited to:
>>
>> - The GTK+ UI
>> - Older versions of GLib
>> - Qt 4.8
>> 
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscr
>> ibe
>
>
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] 2.5.0, 2.6, and 3.0 release planning

2018-02-04 Thread Alexis La Goutte
On Fri, Feb 2, 2018 at 11:45 PM, Gerald Combs  wrote:

> I think we've fixed the major issues identified by Stig, Jim, and others
> so I'd like to release 2.5.0 on February 6. This would let us release 2.6.0
> this spring, followed by 3.0.0 in the fall:
>
>
> March: Create master-2.6 after one or two 2.5.x releases.
>
> April: Release 2.6.0, probably after SharkFest Asia.
>
> August: Release 2.9.0.
>
> September 7, 2018: The 2.2 branch reaches EOL.
>
> September or October: Create master-3.0 after one or more 2.9.x releases.
>
> October or November: Release 3.0.0, either before or after SharkFest
> Europe.
>
Two major release this year ?
2.6 will be a TLS release ?

For avoid a lot of cherry-pick it is better for create master(-2.6 or -3.0)
only 2 or 3 week before 2.6 release ?

>
>
> As discussed on this list and (IIRC) at SharkFest EU we can start removing
> legacy support in master after master-2.6 is branched. This includes, but
> is not limited to:
>
> - The GTK+ UI
> - Older versions of GLib
> - Qt 4.8
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe