Re: [Wireshark-dev] QtShark Translation
Hi, Do we really want to allow for a translation of the program name? r41389:main_welcome.cpp: QString banner = QString(tr(Wireshark)); Thanks, Jaap On 03/04/2012 08:21 PM, Alexis La Goutte wrote: Hi, I realized a patch to add the i10n version of QtShark. The goal is only to translate the Gui (not dissector) Actually, there is only a french translations ! To test, launch qtshark with LANG=fr ./qtshark (in ui/qt folder) For make your own translation! it is easy ! * Add your translation (wireshark_XX.ts) in QtShark.pro * Launch lupdate QtShark.pro to generate/update your translation file * Translate with Qt Linguist * Launch lrelease QtShark.pro to create/update wireshark_xx.qm file More information about Qt Translation is available in http://qt-project.org/doc/qt-4.8/linguist-manual.html It missing some feature : * Add preference to select(force) your language * Support of Cmake * Some text it is no available for translation... Regards, ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
Hi Jaap, On Thu, Apr 12, 2012 at 8:50 PM, Jaap Keuter jaap.keu...@xs4all.nl wrote: Hi, Do we really want to allow for a translation of the program name? r41389:main_welcome.cpp: QString banner = QString(tr(Wireshark)); Mmh Yes ! for the next 1st April ;-) Fil de Requin is a good name ? ;-) Thanks, Jaap On 03/04/2012 08:21 PM, Alexis La Goutte wrote: Hi, I realized a patch to add the i10n version of QtShark. The goal is only to translate the Gui (not dissector) Actually, there is only a french translations ! To test, launch qtshark with LANG=fr ./qtshark (in ui/qt folder) For make your own translation! it is easy ! * Add your translation (wireshark_XX.ts) in QtShark.pro * Launch lupdate QtShark.pro to generate/update your translation file * Translate with Qt Linguist * Launch lrelease QtShark.pro to create/update wireshark_xx.qm file More information about Qt Translation is available in http://qt-project.org/doc/qt-**4.8/linguist-manual.htmlhttp://qt-project.org/doc/qt-4.8/linguist-manual.html It missing some feature : * Add preference to select(force) your language * Support of Cmake * Some text it is no available for translation... Regards, ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
Hi Committed in Revision 41389 and 41390 for you Cmake patch ! (thanks) Regards, On Mon, Mar 5, 2012 at 5:48 PM, Joerg Mayer jma...@loplof.de wrote: On Mon, Mar 05, 2012 at 10:10:40AM +0100, Alexis La Goutte wrote: You might try the following instructions for cmake: http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software but I'd be willing to do this once internationalization is committed. I tried but... no work ! (for the moment...) The attached patch will make it (amost) work (this assumes some of the renames I proposed but you will get the idea from it). It will cause compilation to fail unless either a) source dir is also the build dir or b) you manually create a link for qtshark_fr.qm into the source dir I will eventually look into the dependency problem, but for now I'm happy it works at all Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
Hi Joerg, On Sun, Mar 4, 2012 at 10:50 PM, Joerg Mayer jma...@loplof.de wrote: Hello Alexis, nice piece of work. I have one annotation and one question: You might try the following instructions for cmake: http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software but I'd be willing to do this once internationalization is committed. I tried but... no work ! (for the moment...) While looking at the translation file: It seems to contain the line numbers of the english original - does this mean the translation will fail if the line numbers change because someone makes changes to the code? No ! The line is only for information... when the translator translate ! (with Qt linguist) (there is a source view to see the context of the translation...) and the line is auto-generated by lupdate ! Thanks Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
Hello Alexis, On Mon, Mar 05, 2012 at 10:10:40AM +0100, Alexis La Goutte wrote: You might try the following instructions for cmake: http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software but I'd be willing to do this once internationalization is committed. I tried but... no work ! (for the moment...) No problem - as I wrote: I will try it once it is committed. While looking at the translation file: It seems to contain the line numbers of the english original - does this mean the translation will fail if the line numbers change because someone makes changes to the code? No ! The line is only for information... when the translator translate ! (with Qt linguist) (there is a source view to see the context of the translation...) and the line is auto-generated by lupdate ! Ah, good. Maybe you could add a file ui/qt/README.translate or whatever on how to go and translate into another language or update an existing one (I didn't know about Qt linguit). Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
On Mon, Mar 5, 2012 at 12:14 PM, Joerg Mayer jma...@loplof.de wrote: Hello Alexis, On Mon, Mar 05, 2012 at 10:10:40AM +0100, Alexis La Goutte wrote: You might try the following instructions for cmake: http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software but I'd be willing to do this once internationalization is committed. I tried but... no work ! (for the moment...) No problem - as I wrote: I will try it once it is committed. While looking at the translation file: It seems to contain the line numbers of the english original - does this mean the translation will fail if the line numbers change because someone makes changes to the code? No ! The line is only for information... when the translator translate ! (with Qt linguist) (there is a source view to see the context of the translation...) and the line is auto-generated by lupdate ! Ah, good. Maybe you could add a file ui/qt/README.translate or whatever on how to go and translate into another language or update an existing one (I didn't know about Qt linguit). I think add a chapite to doc/Readme.qt Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
On Sun, Mar 04, 2012 at 08:21:14PM +0100, Alexis La Goutte wrote: I realized a patch to add the i10n version of QtShark. The goal is only to translate the Gui (not dissector) Actually, there is only a french translations ! To test, launch qtshark with LANG=fr ./qtshark (in ui/qt folder) For make your own translation! it is easy ! - Add your translation (wireshark_XX.ts) in QtShark.pro - Launch lupdate QtShark.pro to generate/update your translation file - Translate with Qt Linguist - Launch lrelease QtShark.pro to create/update wireshark_xx.qm file OK, some summary feedback (we talked about some of this already): - please rename wireshark_XX.ts to qtshark_XX.ts as the executable is name qtshark. - please rename i10n.qrc to i18n.qrc - what is the use of i10n.qrc anyway (couldn't find it in any examples More information about Qt Translation is available in http://qt-project.org/doc/qt-4.8/linguist-manual.html - Please add the stuff to README.qt It missing some feature : * Add preference to select(force) your language Might make sense as some people would prefer the Enligsh GUI even if the rest of the applications are in their netive language. * Support of Cmake I'm working on it - but it isn't working (same as you found out) so far. * Some text it is no available for translation... I don't understand this one :) How about committing this soon'ish? Ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
On Mon, Mar 05, 2012 at 03:45:09PM +0100, Joerg Mayer wrote: OK, some summary feedback (we talked about some of this already): One more thing ;-) - It looks like the qt-specific initialization is done in wireshark_main.cpp while you do the i18 stuff in main.cpp. ciao Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
On Mon, Mar 05, 2012 at 10:10:40AM +0100, Alexis La Goutte wrote:
You might try the following instructions for cmake:
http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software
but I'd be willing to do this once internationalization is committed.
I tried but... no work ! (for the moment...)
The attached patch will make it (amost) work (this assumes some of the renames
I proposed but you will get the idea from it).
It will cause compilation to fail unless either
a) source dir is also the build dir or
b) you manually create a link for qtshark_fr.qm into the source dir
I will eventually look into the dependency problem, but for now I'm happy
it works at all
Ciao
Jörg
--
Joerg Mayer jma...@loplof.de
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
Index: CMakeLists.txt
===
--- CMakeLists.txt (revision 41354)
+++ CMakeLists.txt (working copy)
@@ -92,15 +92,22 @@
set(QTSHARK_QRC
display_filter.qrc
+ i18n.qrc
toolbar.qrc
welcome.qrc
)
+set(QTSHARK_TS
+ qtshark_fr.ts
+)
+
include_directories(
${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_CURRENT_BINARY_DIR}
)
+QT4_ADD_TRANSLATION(QTSHARK_TS_QM ${QTSHARK_TS})
+
QT4_ADD_RESOURCES(QTSHARK_QRC_SRC ${QTSHARK_QRC})
QT4_WRAP_UI(QTSHARK_UI_SRC ${QTSHARK_UI})
@@ -132,6 +139,7 @@
${QTSHARK_UI_SRC}
${QTSHARK_MOC_SRC}
${QTSHARK_QRC_SRC}
+ ${QTSHARK_TS_QM}
)
set_target_properties(qtui PROPERTIES LINK_FLAGS ${WS_LINK_FLAGS})
Index: wireshark_application.cpp
===
--- wireshark_application.cpp (revision 41354)
+++ wireshark_application.cpp (working copy)
@@ -264,6 +264,7 @@
wsApp = this;
Q_INIT_RESOURCE(display_filter);
+Q_INIT_RESOURCE(i18n);
Q_INIT_RESOURCE(toolbar);
Q_INIT_RESOURCE(welcome);
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] QtShark Translation
Hello Alexis, nice piece of work. I have one annotation and one question: You might try the following instructions for cmake: http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software but I'd be willing to do this once internationalization is committed. While looking at the translation file: It seems to contain the line numbers of the english original - does this mean the translation will fail if the line numbers change because someone makes changes to the code? Thanks Jörg -- Joerg Mayer jma...@loplof.de We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. Qtshark-translation-in-French.patch Description: Binary data ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
