Re: [Wireshark-dev] Request for submission
On Thu, Apr 11, 2013 at 7:05 AM, Roland Knall wrote: > Next step will be conversations and a tap interface, but for that I want > this code in first, so to not mix changes and get confused. > If that's the only reason that prevents you from doing additional development you could try using git. With that you could commit locally and continue to work (and then eventually rebase the patch as the Wireshark development progresses). ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Request for submission
Hi First of all it is not 100kb, but more important, this patch removes the bad dissection code done using a byte array, which was responsible for some crashes in regard to openSAFETY packages. Instead I changed the code to tvb functions, which improves stability greatly. The additional changes implement some additional dissection of the openSAFETY protocol and fix some logical bugs. Next step will be conversations and a tap interface, but for that I want this code in first, so to not mix changes and get confused. Regards, Roland Am Dienstag, 9. April 2013 schrieb Jaap Keuter : > Ok, > > Who has time to review this 100kB patch? > > Thanks, > Jaap > > On 04/09/2013 03:00 PM, Roland Knall wrote: > > Hi > > > > Could I please bump my request one more time on the buglist? I am > > starting to work on some topics for new features on the dissector, and > > only want to really start it, as soon as the existing patch went > > through. > > > > kind regards, > > Roland > > > > On Fri, Apr 5, 2013 at 12:25 AM, Evan Huus > > wrote: > >> On Thu, Apr 4, 2013 at 2:50 PM, Roland Knall > >> > > wrote: > >>> Hello > >>> > >>> Could I please kindly ask some of the main developers to commit the > >>> patch in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8505 ? > >>> Evan Huus, who kindly lend me an ear in getting the patch ready is > >>> busy at the moment with exams, but has already cleared the patch. > >>> > >>> All there is left to do would be to submit the patch. > >> > >> It needs a once-over, as I haven't really looked at it since it was > >> rewritten to use TVBs, but most of what was in the first patch made > >> sense so it's probably fine. > >> > >> I'm also in a theatre production starting next week. I don't know why > >> I thought lining that up with my exams was a good idea, but there you > >> go :P > >> > >> (Which is to say: I'm going to be very scarce here for a while.) > >> > >> Cheers, > >> Evan > > ___ > Sent via:Wireshark-dev mailing list > > > > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe > ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Request for submission
Ok, Who has time to review this 100kB patch? Thanks, Jaap On 04/09/2013 03:00 PM, Roland Knall wrote: > Hi > > Could I please bump my request one more time on the buglist? I am > starting to work on some topics for new features on the dissector, and > only want to really start it, as soon as the existing patch went > through. > > kind regards, > Roland > > On Fri, Apr 5, 2013 at 12:25 AM, Evan Huus wrote: >> On Thu, Apr 4, 2013 at 2:50 PM, Roland Knall wrote: >>> Hello >>> >>> Could I please kindly ask some of the main developers to commit the >>> patch in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8505 ? >>> Evan Huus, who kindly lend me an ear in getting the patch ready is >>> busy at the moment with exams, but has already cleared the patch. >>> >>> All there is left to do would be to submit the patch. >> >> It needs a once-over, as I haven't really looked at it since it was >> rewritten to use TVBs, but most of what was in the first patch made >> sense so it's probably fine. >> >> I'm also in a theatre production starting next week. I don't know why >> I thought lining that up with my exams was a good idea, but there you >> go :P >> >> (Which is to say: I'm going to be very scarce here for a while.) >> >> Cheers, >> Evan ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Request for submission
Hi Could I please bump my request one more time on the buglist? I am starting to work on some topics for new features on the dissector, and only want to really start it, as soon as the existing patch went through. kind regards, Roland On Fri, Apr 5, 2013 at 12:25 AM, Evan Huus wrote: > On Thu, Apr 4, 2013 at 2:50 PM, Roland Knall wrote: >> Hello >> >> Could I please kindly ask some of the main developers to commit the >> patch in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8505 ? >> Evan Huus, who kindly lend me an ear in getting the patch ready is >> busy at the moment with exams, but has already cleared the patch. >> >> All there is left to do would be to submit the patch. > > It needs a once-over, as I haven't really looked at it since it was > rewritten to use TVBs, but most of what was in the first patch made > sense so it's probably fine. > > I'm also in a theatre production starting next week. I don't know why > I thought lining that up with my exams was a good idea, but there you > go :P > > (Which is to say: I'm going to be very scarce here for a while.) > > Cheers, > Evan > ___ > Sent via:Wireshark-dev mailing list > Archives:http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Request for submission
On Thu, Apr 4, 2013 at 2:50 PM, Roland Knall wrote: > Hello > > Could I please kindly ask some of the main developers to commit the > patch in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8505 ? > Evan Huus, who kindly lend me an ear in getting the patch ready is > busy at the moment with exams, but has already cleared the patch. > > All there is left to do would be to submit the patch. It needs a once-over, as I haven't really looked at it since it was rewritten to use TVBs, but most of what was in the first patch made sense so it's probably fine. I'm also in a theatre production starting next week. I don't know why I thought lining that up with my exams was a good idea, but there you go :P (Which is to say: I'm going to be very scarce here for a while.) Cheers, Evan ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
[Wireshark-dev] Request for submission
Hello Could I please kindly ask some of the main developers to commit the patch in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8505 ? Evan Huus, who kindly lend me an ear in getting the patch ready is busy at the moment with exams, but has already cleared the patch. All there is left to do would be to submit the patch. kind regards, Roland ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
