Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On Fri, Aug 15, 2014 at 10:41 PM, Evan Huus eapa...@gmail.com wrote: On Fri, Aug 15, 2014 at 4:07 PM, Gerald Combs ger...@wireshark.org wrote: On 8/15/14 12:17 PM, Jeff Morriss wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. Are you pressing the Publish Comments or Publish and Submit button when this happens? We're currently using the default MaxWithBlock setting[1] for the Code-Review label, which means that submission requires at least one +2 set and no -2s. It would be nice if Gerrit disabled Publish and Submit when the required conditions aren't met but its development team seems to prefer error messages. For what it's worth I've been trying to reduce this behavior in the Qt interface.[2] FWIW, I'm using the new review screen (you can enable it in preferences) where there is no Publish and Submit button so this problem doesn't exist. I quite like the new screen but it still has a few quirks, which is probably why it isn't default yet. It is the default version for the next major release of Gerrit (2.9.x) Personalty i don't like the new screen... ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On 16 August 2014 09:03, Alexis La Goutte alexis.lagou...@gmail.com wrote: On Fri, Aug 15, 2014 at 10:41 PM, Evan Huus eapa...@gmail.com wrote: On Fri, Aug 15, 2014 at 4:07 PM, Gerald Combs ger...@wireshark.org wrote: On 8/15/14 12:17 PM, Jeff Morriss wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. Are you pressing the Publish Comments or Publish and Submit button when this happens? We're currently using the default MaxWithBlock setting[1] for the Code-Review label, which means that submission requires at least one +2 set and no -2s. It would be nice if Gerrit disabled Publish and Submit when the required conditions aren't met but its development team seems to prefer error messages. For what it's worth I've been trying to reduce this behavior in the Qt interface.[2] FWIW, I'm using the new review screen (you can enable it in preferences) where there is no Publish and Submit button so this problem doesn't exist. I quite like the new screen but it still has a few quirks, which is probably why it isn't default yet. It is the default version for the next major release of Gerrit (2.9.x) Personalty i don't like the new screen... I think I've always been using the new screen, so never came across the issues. What's wrong with the new screen? -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On Sat, Aug 16, 2014 at 11:43 AM, Graham Bloice graham.blo...@trihedral.com wrote: On 16 August 2014 09:03, Alexis La Goutte alexis.lagou...@gmail.com wrote: On Fri, Aug 15, 2014 at 10:41 PM, Evan Huus eapa...@gmail.com wrote: On Fri, Aug 15, 2014 at 4:07 PM, Gerald Combs ger...@wireshark.org wrote: On 8/15/14 12:17 PM, Jeff Morriss wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. Are you pressing the Publish Comments or Publish and Submit button when this happens? We're currently using the default MaxWithBlock setting[1] for the Code-Review label, which means that submission requires at least one +2 set and no -2s. It would be nice if Gerrit disabled Publish and Submit when the required conditions aren't met but its development team seems to prefer error messages. For what it's worth I've been trying to reduce this behavior in the Qt interface.[2] FWIW, I'm using the new review screen (you can enable it in preferences) where there is no Publish and Submit button so this problem doesn't exist. I quite like the new screen but it still has a few quirks, which is probably why it isn't default yet. It is the default version for the next major release of Gerrit (2.9.x) Personalty i don't like the new screen... I think I've always been using the new screen, so never came across the issues. What's wrong with the new screen? by default, the configuration is old... I found the interface no good (no see button and need a click for get link for source (i don't use git review..)) -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On 15 August 2014 20:17, Jeff Morriss jeff.morriss...@gmail.com wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. I haven't seen that when I've set the Petri-dish flag. I do have difficulty forcing a subsequent Petri-Dish build after the first one though, does anyone know the incantations for that? Also re. Chris's comment on 3624, I don't think we have auto-merge running yet. The item has to be at + 2 and then you can hit the Submit button. There is no mandatory Petri-Dish flag yet. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On Fri, Aug 15, 2014 at 3:36 PM, Graham Bloice graham.blo...@trihedral.com wrote: On 15 August 2014 20:17, Jeff Morriss jeff.morriss...@gmail.com wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. I haven't seen that when I've set the Petri-dish flag. I haven't seen that either. I do have difficulty forcing a subsequent Petri-Dish build after the first one though, does anyone know the incantations for that? If you upload a new patch version then the flag is reset and you can trigger again normally on the new version. If you want to retrigger on the same version for some reason, you should be able to reset the flag to 0, then back to +1 and it should get picked up. Also re. Chris's comment on 3624, I don't think we have auto-merge running yet. The item has to be at + 2 and then you can hit the Submit button. There is no mandatory Petri-Dish flag yet. Yes, currently the only requirement for submission is a core dev +2. Eventually we will also require a Verified+1, though that may be set manually by -core or by petridish. Eventually eventually we may limit Verified+1 to petridish only. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On 8/15/14 12:17 PM, Jeff Morriss wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. Are you pressing the Publish Comments or Publish and Submit button when this happens? We're currently using the default MaxWithBlock setting[1] for the Code-Review label, which means that submission requires at least one +2 set and no -2s. It would be nice if Gerrit disabled Publish and Submit when the required conditions aren't met but its development team seems to prefer error messages. For what it's worth I've been trying to reduce this behavior in the Qt interface.[2] [1]https://code.wireshark.org/review/Documentation/config-labels.html#label_function [2]http://ux.stackexchange.com/questions/334/is-it-better-to-prevent-a-forbidden-action-or-display-an-error-explanation-messa ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On 08/15/2014 04:07 PM, Gerald Combs wrote: On 8/15/14 12:17 PM, Jeff Morriss wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. Are you pressing the Publish Comments or Publish and Submit button when this happens? We're currently using the default MaxWithBlock setting[1] for the Code-Review label, which means that submission requires at least one +2 set and no -2s. Ah, that's it. I was (apparently--I had to try it out to confirm) Publish and Submit since, well, the other button (Publish Comments) is decidedly *not* what I want to do: I want to submit my +1 (and I don't *have* any comments so I really didn't think I wanted to do that). But I guess Submit means Submit for merge or some such, not Submit my changed value. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On Aug 15, 2014, at 1:07 PM, Gerald Combs ger...@wireshark.org wrote: For what it's worth I've been trying to reduce this behavior in the Qt interface: http://ux.stackexchange.com/questions/334/is-it-better-to-prevent-a-forbidden-action-or-display-an-error-explanation-messa Note that they also mention a disable with tooltip option; I seem to remember reading about that *many* years ago (I think one of the original Mac software designers may either have wanted that in the original design or suggested it later after some experience). The tooltip would indicate why a given option *isn't* available. I don't know whether Qt or Gerrit would allow that. I suspect not, as the disable with tooltip idea isn't as common as might be nice. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
Jeff Morriss jeff.morriss.ws@... writes: Ah, that's it. I was (apparently--I had to try it out to confirm) Publish and Submit since, well, the other button (Publish Comments) is decidedly *not* what I want to do: I want to submit my +1 (and I don't *have* any comments so I really didn't think I wanted to do that). But I guess Submit means Submit for merge or some such, not Submit my changed value. I was doing the same thing, and for the same reason. - Chris ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] Petri-Dish +1 gives an error: needs code review
On Fri, Aug 15, 2014 at 4:07 PM, Gerald Combs ger...@wireshark.org wrote: On 8/15/14 12:17 PM, Jeff Morriss wrote: Hi folks, One thing I've noticed about the Petri-Dish flag in Gerrit is that every time I set it to +1 I get an error saying needs code review. Since Chris just noticed and complained about that too (on change 3624) I thought I'd mention it here. Are you pressing the Publish Comments or Publish and Submit button when this happens? We're currently using the default MaxWithBlock setting[1] for the Code-Review label, which means that submission requires at least one +2 set and no -2s. It would be nice if Gerrit disabled Publish and Submit when the required conditions aren't met but its development team seems to prefer error messages. For what it's worth I've been trying to reduce this behavior in the Qt interface.[2] FWIW, I'm using the new review screen (you can enable it in preferences) where there is no Publish and Submit button so this problem doesn't exist. I quite like the new screen but it still has a few quirks, which is probably why it isn't default yet. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
