Re: [WiX-users] Problem with Including under TFS 2010 Build Agent
Well, that goes without saying ($(sys.CURRENTDIR) points to a very different path on the build agent). :) But making it relative didn't help much. Ultimately, shortening the command line (removing a bunch of long var defines) from candle helped. The previous build engineer had apparently never heard of using either a wxi or wixproj to define path vars. By the way, this problem existed on both 3.5 and 3.6. The choice to use a wxi instead of embedding in wixproj is simple--there's a workflow build activity that regex's and adjusts the values in the wxi each build. It WAS doing that to my Product.wxs with predictable fragility. I have nightmares thinking about a build activity hacking a wixproj just before it builds. -- jmc -Original Message- From: Rob Mensching [mailto:r...@robmensching.com] Sent: Friday, July 15, 2011 12:24 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Problem with Including under TFS 2010 Build Agent Giving the magic 8 ball a shake, I'll take a guess and say that the $(sys.CURRENTDIR) is set differently on the build machine. $(sys.CURRENTDIR) is a very volatile value. It is set to where you launch the build from. Instead, I would recommend using a relative path to the .wxi file. The Include will search relative to the .wxs file with the Include statement. Alternaively, push all the variables up into the .wixproj file and get rid of the .wxi file completely. This is what I would do personally. But I'm not a fan of .wxi files. smile/ On Thu, Jul 14, 2011 at 1:39 PM, John Cooper jocoo...@jackhenry.com wrote: Got a challenging problem. I have an include file that has versioning constants in it. Running from the Desktop, all goes well, the constants are defined, and the correct version number is set on the MSI. However, on the TFS 2010 Build agent, the include doesn't seem to work. I get the following error: e:\Builds\35\639\Sources\main\FedLine\Source\Install\FedLineWix\Produc t.wxs (15): Undefined preprocessor variable '$(var.ProductMajor)'. FedLineVersion.wxi: Include xmlns=http://schemas.microsoft.com/wix/2006/wi; !-- the build template may update these -- ?define ProductMajor = 1 ? ?define ProductMinor = 0 ? ?define BuildMajor = 674 ? !-- ignored by MSI API -- ?define Release = 0 ? /Include Snippet from Product.wxs: ?xml version=1.0 encoding=UTF-8? Wix xmlns=http://schemas.microsoft.com/wix/2006/wi; xmlns:iis=http://schemas.microsoft.com/wix/IIsExtension; xmlns:netfx=http://schemas.microsoft.com/wix/NetFxExtension; xmlns:util=http://schemas.microsoft.com/wix/UtilExtension; ?include $(sys.CURRENTDIR)FedLineVersion.wxi ? ?define Version = $(var.ProductMajor).$(var.ProductMinor).$(var.BuildMajor) ? Product Id=* Name=!(loc.ProductName) Language=!(loc.LCID) Version=$(var.Version) Manufacturer=!(loc.ProductManufacturer) UpgradeCode=B73A1EEA-3509-4474-825A-E02C230B0424 Any clues why this breaks on the Build Agent, but not locally on my desktop? -- John Merryweather Cooper Jack Henry Associates, Inc. (Premier Tech, Inc.) Build Install Engineer - jXchange Office: 913-341-3434 x791011 jocoo...@jackhenry.commailto:jocoo...@jackhenry.com NOTICE: This electronic mail message and any files transmitted with it are intended exclusively for the individual or entity to which it is addressed. The message, together with any attachment, may contain confidential and/or privileged information. Any unauthorized review, use, printing, saving, copying, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email and delete all copies. -- AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on Lean Startup Secrets Revealed. This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev ___ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users -- virtually, Rob Mensching - http://RobMensching.com LLC -- AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on Lean Startup Secrets Revealed. This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev ___ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users NOTICE: This electronic mail message and any files
[WiX-users] Problem with Including under TFS 2010 Build Agent
Got a challenging problem. I have an include file that has versioning constants in it. Running from the Desktop, all goes well, the constants are defined, and the correct version number is set on the MSI. However, on the TFS 2010 Build agent, the include doesn't seem to work. I get the following error: e:\Builds\35\639\Sources\main\FedLine\Source\Install\FedLineWix\Product.wxs (15): Undefined preprocessor variable '$(var.ProductMajor)'. FedLineVersion.wxi: Include xmlns=http://schemas.microsoft.com/wix/2006/wi; !-- the build template may update these -- ?define ProductMajor = 1 ? ?define ProductMinor = 0 ? ?define BuildMajor = 674 ? !-- ignored by MSI API -- ?define Release = 0 ? /Include Snippet from Product.wxs: ?xml version=1.0 encoding=UTF-8? Wix xmlns=http://schemas.microsoft.com/wix/2006/wi; xmlns:iis=http://schemas.microsoft.com/wix/IIsExtension; xmlns:netfx=http://schemas.microsoft.com/wix/NetFxExtension; xmlns:util=http://schemas.microsoft.com/wix/UtilExtension; ?include $(sys.CURRENTDIR)FedLineVersion.wxi ? ?define Version = $(var.ProductMajor).$(var.ProductMinor).$(var.BuildMajor) ? Product Id=* Name=!(loc.ProductName) Language=!(loc.LCID) Version=$(var.Version) Manufacturer=!(loc.ProductManufacturer) UpgradeCode=B73A1EEA-3509-4474-825A-E02C230B0424 Any clues why this breaks on the Build Agent, but not locally on my desktop? -- John Merryweather Cooper Jack Henry Associates, Inc. (Premier Tech, Inc.) Build Install Engineer - jXchange Office: 913-341-3434 x791011 jocoo...@jackhenry.commailto:jocoo...@jackhenry.com NOTICE: This electronic mail message and any files transmitted with it are intended exclusively for the individual or entity to which it is addressed. The message, together with any attachment, may contain confidential and/or privileged information. Any unauthorized review, use, printing, saving, copying, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email and delete all copies. -- AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on Lean Startup Secrets Revealed. This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev ___ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
Re: [WiX-users] Problem with Including under TFS 2010 Build Agent
Giving the magic 8 ball a shake, I'll take a guess and say that the $(sys.CURRENTDIR) is set differently on the build machine. $(sys.CURRENTDIR) is a very volatile value. It is set to where you launch the build from. Instead, I would recommend using a relative path to the .wxi file. The Include will search relative to the .wxs file with the Include statement. Alternaively, push all the variables up into the .wixproj file and get rid of the .wxi file completely. This is what I would do personally. But I'm not a fan of .wxi files. smile/ On Thu, Jul 14, 2011 at 1:39 PM, John Cooper jocoo...@jackhenry.com wrote: Got a challenging problem. I have an include file that has versioning constants in it. Running from the Desktop, all goes well, the constants are defined, and the correct version number is set on the MSI. However, on the TFS 2010 Build agent, the include doesn't seem to work. I get the following error: e:\Builds\35\639\Sources\main\FedLine\Source\Install\FedLineWix\Product.wxs (15): Undefined preprocessor variable '$(var.ProductMajor)'. FedLineVersion.wxi: Include xmlns=http://schemas.microsoft.com/wix/2006/wi; !-- the build template may update these -- ?define ProductMajor = 1 ? ?define ProductMinor = 0 ? ?define BuildMajor = 674 ? !-- ignored by MSI API -- ?define Release = 0 ? /Include Snippet from Product.wxs: ?xml version=1.0 encoding=UTF-8? Wix xmlns=http://schemas.microsoft.com/wix/2006/wi; xmlns:iis=http://schemas.microsoft.com/wix/IIsExtension; xmlns:netfx=http://schemas.microsoft.com/wix/NetFxExtension; xmlns:util=http://schemas.microsoft.com/wix/UtilExtension; ?include $(sys.CURRENTDIR)FedLineVersion.wxi ? ?define Version = $(var.ProductMajor).$(var.ProductMinor).$(var.BuildMajor) ? Product Id=* Name=!(loc.ProductName) Language=!(loc.LCID) Version=$(var.Version) Manufacturer=!(loc.ProductManufacturer) UpgradeCode=B73A1EEA-3509-4474-825A-E02C230B0424 Any clues why this breaks on the Build Agent, but not locally on my desktop? -- John Merryweather Cooper Jack Henry Associates, Inc. (Premier Tech, Inc.) Build Install Engineer - jXchange Office: 913-341-3434 x791011 jocoo...@jackhenry.commailto:jocoo...@jackhenry.com NOTICE: This electronic mail message and any files transmitted with it are intended exclusively for the individual or entity to which it is addressed. The message, together with any attachment, may contain confidential and/or privileged information. Any unauthorized review, use, printing, saving, copying, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email and delete all copies. -- AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on Lean Startup Secrets Revealed. This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev ___ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users -- virtually, Rob Mensching - http://RobMensching.com LLC -- AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on Lean Startup Secrets Revealed. This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev ___ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
