Re: [PATCH 3/4] 3 Save iconpath if icon will be used

2013-01-25 Thread Carlos R. Mafra
On Fri, 25 Jan 2013 at  1:06:58 +0100, Rodolfo García Peñas wrote:
 
 I changed the behavior for the winspector. Can you test it now?
 
 More testers are welcome. If the patch is ok, I will write the commit info.

I'm a bit lost about which behavior is being fixed. What is the test
case to aim for?

On the other hand, if Zoltan says it fixes his issues, I'll apply
without testing it myself :-)


-- 
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.


Re: [PATCH 3/4] 3 Save iconpath if icon will be used

2013-01-25 Thread BALATON Zoltan

On Fri, 25 Jan 2013, Carlos R. Mafra wrote:

On Fri, 25 Jan 2013 at  1:06:58 +0100, Rodolfo García Peñas wrote:

I changed the behavior for the winspector. Can you test it now?

More testers are welcome. If the patch is ok, I will write the commit info.


I'm a bit lost about which behavior is being fixed. What is the test
case to aim for?

On the other hand, if Zoltan says it fixes his issues, I'll apply
without testing it myself :-)


I don't have time to test it now but I've described the problem, 
testing procedure and provided a test case in the thread starting at


http://lists.windowmaker.org/dev/msg04395.html

The test case is here:
http://lists.windowmaker.org/dev/msg04396.html
(Should show a white rectangle in the app icon which is the icon window.)

The procedure to test Ignore app icon is here:
http://lists.windowmaker.org/dev/msg04452.html

Hope this helps.

Regards,
BALATON Zoltan

[PATCH] autoconf: add remaining parameter for AC_SEARCH_LIBS

2013-01-25 Thread Wade Berrier
According to:

http://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Libraries.html

Found this while trying to compile for RHEL6.  Otherwise, configure
failed.
---
 configure.ac |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index d8acbeb..6820f15 100644
--- a/configure.ac
+++ b/configure.ac
@@ -165,7 +165,8 @@ AC_ARG_ENABLE([boehm-gc],
 AS_IF([test x$with_boehm_gc = xyes],
 AC_SEARCH_LIBS([GC_malloc], [gc],
 [AC_DEFINE(USE_BOEHM_GC, 1, [Define if Boehm GC is to be used])],
-[AC_MSG_FAILURE([--enable-boehm-gc specified but test for libgc 
failed])]
+[AC_MSG_FAILURE([--enable-boehm-gc specified but test for libgc 
failed])],
+[]
 )
 )
 
@@ -210,10 +211,12 @@ AC_ARG_WITH([libbsd],
 tmp_libs=$LIBS
 AC_SEARCH_LIBS([strlcat],[$with_libbsd],
   [AC_DEFINE(HAVE_STRLCAT, 1, [Define if strlcat is available])],
+  [],
   []
 )
 AC_SEARCH_LIBS([strlcpy],[$with_libbsd],
   [AC_DEFINE(HAVE_STRLCAT, 1, [Define if strlcpy is available])],
+  [],
   []
 )
 LIBS=$tmp_libs
-- 
1.7.9.5


-- 
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.