Re: [PATCH 3/4] 3 Save iconpath if icon will be used
Hello, On Sun, 27 Jan 2013, Rodolfo García Peñas wrote: better, but... I would like to know your oppinion before send the patches. My opinion is as before: code cleanup patches should not change behaviour so everything should work the same after your patches as they worked before them. (The last behaviour changing patch for icon.c selection seems to be ee1f13da45a8f3371a0dfe4a2a636c402ddf7b3d and the order is described in that commit message.) I can't offer help in checking code changes because I don't understand your code and don't have time to get knowledgeable about this part of Window Maker. So don't wait for comments about patches from me. The test case, test procedure and descriptions in my previous messages of how I think it should work were the best I could offer I'm afraid. Regards, BALATON Zoltan
Re: [repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.4-16-gfd7b117
On Sun, 27 Jan 2013, Rodolfo García Peñas wrote: Zoltan, test it!! :-) All should continue ok. Please, try it, you have a lot of knowledge about this. I don't have time for that but I gave you the procedure to test it yourself. If it passes that I'm fine with it too. I read the previous mail with Carlos, should I try to set the textbox to "grey" or something like to avoid that the user could edit it without set the checkbox? Don't touch the textbox. I said the switch should be grey when there's nothing in the textbox. Then the warning is not needed. Regards, BALATON Zoltan
