Re: Re : Re: [PATCH 06/19] wmaker: Reorganised the header 'funcs.h'
On Sun, 12 May 2013 at 13:13:45 +0200, Christophe wrote: > > - Rodolfo García Peñas (kix) a écrit : > > > > Only one comment about this patch. The file funcs.h contains prototypes > > for multiple files, and funcs.c doesn't exist. IMO, is better move the > > prototypes to the right header file, and remove funcs.h. > > Hi, Short answer: That's beyond the goal of this patch. This patch does > not conceptually changes the header, it just makes it easier to work > with. > > Long answer: Well, now that's easier to split it ;-) The current > situation for header is not great, there are a few things worse and > working on this patch series pointed it to me. On personal taste, I'm > in favour to not expand unwisely the alreay-to-big number of header. > Specifically, I dislike headers for just one or two definitions; but I > also approve your idea to have things separated, specially when it > tries to lead to overbig header files... > > So basically, before doing anything there, I'll wait to get the project > maintainer's point of view... (Carlos, that's a subtle hint to catch > you into the troll!) I tend to prefer having separate header files matching their .c files. It is simpler conceptually. I have no strong feelings about it though. You are doing a great job and you can proceed as you think it's best to fix the remaining issues. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re : Re: [PATCH 06/19] wmaker: Reorganised the header 'funcs.h'
- Rodolfo García Peñas (kix) a écrit : > On 12/05/2013 0:24, Christophe wrote: > > From: Christophe CURIS > > > > The functions are now grouped by source file (groups in alphabetic > > order) with the traditional separation mark. This makes the file > > easier to work with. > > --- > > src/funcs.h | 53 ++--- > > 1 file changed, 38 insertions(+), 15 deletions(-) > > > > Hi Christophe, > > thanks a lot for your patches. Hard work. > > Only one comment about this patch. The file funcs.h contains prototypes > for multiple files, and funcs.c doesn't exist. IMO, is better move the > prototypes to the right header file, and remove funcs.h. Hi, Short answer: That's beyond the goal of this patch. This patch does not conceptually changes the header, it just makes it easier to work with. Long answer: Well, now that's easier to split it ;-) The current situation for header is not great, there are a few things worse and working on this patch series pointed it to me. On personal taste, I'm in favour to not expand unwisely the alreay-to-big number of header. Specifically, I dislike headers for just one or two definitions; but I also approve your idea to have things separated, specially when it tries to lead to overbig header files... So basically, before doing anything there, I'll wait to get the project maintainer's point of view... (Carlos, that's a subtle hint to catch you into the troll!) > > Probably we can apply this idea for src/keybind.h > > Other options (fuzzy): > - Files like extend_pixmaps.h and def_pixmaps.h could be merged. IMHO, not a good idea. Those are not even correct. Header should not create things, they should only declare. This right way to handle those is to actually split them: creating a 'bitmap/' or 'images/' or whatever, and place them in "image_name.xbm", because that's what they really are. > - GNUstep.h and WindowMaker.h probably could be checked,... > > Again, thanks for your work. > kix. > -- > ||// //\\// Rodolfo "kix" Garcia > ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Add dock icon to wmaker
On 11/05/2013 22:00, BALATON Zoltan wrote: > On Sat, 11 May 2013, "Rodolfo García Peñas (kix)" wrote: >> is possible add that [1] icon to wmaker? I am thinking add the icon to >> the available icons in wmaker. Using it as default dock icon is other >> story. >> >> [1] http://lists.windowmaker.org/dev/msg04515.html > > I don't have that icon either that's why I was asking the same question > but I never got an answer. > > Regards, > BALATON Zoltan I sent a tweet to @crunchbang, because is a distro... and perhaps they included that file. -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
