Re: [PATCH] Basic WINGs theming
On Sun, 3 Nov 2013 at 23:29:33 -0600, Doug Torrance wrote:
WINGs widgets use a palette of six colors. (Essentially, just four. There
are
two colors used only for unselected tabs in tabviews.) This patch allows a
user
to declare these six colors in ~/GNUstep/Defaults/WMGLOBAL, e.g.,
{
Background = color1;
Foreground = color2;
Shadow = color3;
Highlight = color4;
UnselectedTabBackground = color5;
UnselectedTabHighlight = color6;
}
---
WINGs/WINGs/WINGs.h | 4
WINGs/WINGs/WINGsP.h | 13 +++
WINGs/wcolor.c | 61
WINGs/widgets.c | 2 ++
WINGs/wtabview.c | 4 ++--
5 files changed, 78 insertions(+), 6 deletions(-)
I'm not sure about whether this is a good idea. The default look is
classic and I'd guess few people would ever want to change how
wmaker looks like.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
RE: [PATCH] Basic WINGs theming
I'm not sure about whether this is a good idea. The default look is classic and I'd guess few people would ever want to change how wmaker looks like. For the classic look, a user just has to not touch the WMGLOBAL file. It's still the default. As the writer of the patch, I'm certainly one of the people who would like to change the look. :) The window manager itself is extremely customizable. I think it would be nice if the corresponding widgets were as well. (It's still nowhere near as powerful. There's no gradient or pixmap support, just solid colors.) Doug -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] Basic WINGs theming
Quoth Carlos R. Mafra, I'm not sure about whether this is a good idea. The default look is classic and I'd guess few people would ever want to change how wmaker looks like. The chances of making a third-party application look consistent with wmaker is fairly slim these days, old GTK2 apps with the GTK2-Step theme notwithstanding. If we can approach the problem the other way and make wmaker look like the apps then I'm in favour. That said, I struggled to come up with any colourschemes which don't look bad because the same colours are used in too many places due to the limited palette. If we could expand that palette I think there is real potential here. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
patch fixing ./configure --enable-png
Otherwise it tells that yes/no (from --enable/--disable-png) are wrong options. Amadeusz Sławiński From 4e261703a7c4ea7263932e33c5900cdda5bc2761 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= am...@asmblr.net Date: Mon, 4 Nov 2013 17:42:43 +0100 Subject: [PATCH] Fix wrong variable name --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 270bf3b..605bc8f 100644 --- a/configure.ac +++ b/configure.ac @@ -659,7 +659,7 @@ dnl PNG Support dnl === AC_ARG_ENABLE([png], [AS_HELP_STRING([--disable-png], [disable PNG support through libpng])], -[AS_CASE([$enablebal], +[AS_CASE([$enableval], [yes|no], [], [AC_MSG_ERROR([bad value $enableval for --enable-png])] )], [enable_png=auto]) -- 1.8.4.2
Re: [PATCH] Basic WINGs theming
On Mon, 4 Nov 2013 at 16:35:16 +, Iain Patterson wrote: Quoth Carlos R. Mafra, I'm not sure about whether this is a good idea. The default look is classic and I'd guess few people would ever want to change how wmaker looks like. The chances of making a third-party application look consistent with wmaker is fairly slim these days, old GTK2 apps with the GTK2-Step theme notwithstanding. If we can approach the problem the other way and make wmaker look like the apps then I'm in favour. I don't think that this is a problem. wmaker successfully reproduces the look and feel of NeXTSTEP and most applications don't. But that's how things are. WINGs looks like it was supposed to look, so that's why it is hardcoded. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
fix another problem with --enable-png
I haven't noticed this one when building manually because LDFLAGS are
being set only by package manager (portage).
export LDFLAGS=-Wl,-O1 -Wl,--as-needed
./configure --enable-png
...
checking X11/xpm.h presence... yes
checking for X11/xpm.h... yes
checking for PNG support library... configure: error: explicit PNG support
requested but no library found
It's fixed by moving saved LDFLAGS to be after passed linker flags.
Amadeusz Sławiński
From 1ec32d4ff21436cf744706ed930aba8a8bc9b6f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= am...@asmblr.net
Date: Mon, 4 Nov 2013 18:54:10 +0100
Subject: [PATCH] Fix failing check when LDFLAGS are set
export LDFLAGS=-Wl,-O1 -Wl,--as-needed
./configure --enable-png
...
checking X11/xpm.h presence... yes
checking for X11/xpm.h... yes
checking for PNG support library... configure: error: explicit PNG support requested but no library found
---
m4/wm_imgfmt_check.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/wm_imgfmt_check.m4 b/m4/wm_imgfmt_check.m4
index 9368266..8f3b224 100644
--- a/m4/wm_imgfmt_check.m4
+++ b/m4/wm_imgfmt_check.m4
@@ -263,7 +263,7 @@ AC_DEFUN_ONCE([_WM_IMGFMT_CHECK_FUNCTS],
@%:@ Assumes that LDFLAGS have been saved in 'wm_save_LDFLAGS' by caller
wm_fn_imgfmt_try_link ()
{
- LDFLAGS=$wm_save_LDFLAGS $[]2
+ LDFLAGS=$[]2 $wm_save_LDFLAGS
AC_TRY_LINK_FUNC([$[]1],
[wm_retval=0],
[wm_retval=1])
--
1.8.4.2
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-144-g8b1babc
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via 8b1babc5b36bafdc4f46da8176a438587e14af08 (commit) via 0d45deff07d1a1aae9cfa3710c637b8878f9b5a1 (commit) from 34da09a0a3d4aadb979d9bbaa010f365c66afde7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://repo.or.cz/w/wmaker-crm.git/commit/8b1babc5b36bafdc4f46da8176a438587e14af08 commit 8b1babc5b36bafdc4f46da8176a438587e14af08 Author: Doug Torrance dtorra...@monmouthcollege.edu Date: Fri Nov 1 19:12:31 2013 -0500 Remove newlines in legal panel. The label containing the legal information in the legal panel was set to wrap. However, there were redundant newlines in the text itself. In wider fonts, this had the effect of the legal text not completely fitting in the legal panel. This patch removes the unnecessary newlines. diff --git a/src/dialog.c b/src/dialog.c index 0608f67..3dcf31b 100644 --- a/src/dialog.c +++ b/src/dialog.c @@ -1419,17 +1419,17 @@ void wShowLegalPanel(WScreen * scr) WMMoveWidget(panel-licenseL, 10, 10); WMSetLabelTextAlignment(panel-licenseL, WALeft); WMSetLabelText(panel-licenseL, - _(Window Maker is free software; you can redistribute it and/orn -modify it under the terms of the GNU General Public License asn -published by the Free Software Foundation; either version 2 of then + _(Window Maker is free software; you can redistribute it and/or +modify it under the terms of the GNU General Public License as +published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.nn -Window Maker is distributed in the hope that it will be useful,n -but WITHOUT ANY WARRANTY; without even the implied warrantyn -of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.n +Window Maker is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty +of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.nn -You should have received a copy of the GNU General Publicn -License along with this program; if not, write to the Free Softwaren -Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MAn +You should have received a copy of the GNU General Public +License along with this program; if not, write to the Free Software +Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.)); WMSetLabelRelief(panel-licenseL, WRGroove); http://repo.or.cz/w/wmaker-crm.git/commit/0d45deff07d1a1aae9cfa3710c637b8878f9b5a1 commit 0d45deff07d1a1aae9cfa3710c637b8878f9b5a1 Author: Doug Torrance dtorra...@monmouthcollege.edu Date: Fri Nov 1 18:34:08 2013 -0500 Remove default Microsoft fonts. In keeping with the spirit of free software, this patch removes several Microsoft fonts (Trebuchet, Arial, and Verdana) from being the default fonts for Window Maker and WINGs. This patch has the added advantage of allowing users some control over the appearance of WINGs widgets. Formerly, there was no way to control the font if the Trebuchet MS font was installed. Now the WINGs font can be changed by setting the sans-serif alias in fonts.conf. diff --git a/WINGs/configuration.c b/WINGs/configuration.c index 8e53ba6..0aaf31a 100644 --- a/WINGs/configuration.c +++ b/WINGs/configuration.c @@ -6,8 +6,8 @@ _WINGsConfiguration WINGsConfiguration; -#define SYSTEM_FONT Trebuchet MS,sans serif -#define BOLD_SYSTEM_FONT Trebuchet MS,sans serif:bold +#define SYSTEM_FONT sans serif +#define BOLD_SYSTEM_FONT sans serif:bold #define DEFAULT_FONT_SIZE 12 #define FLOPPY_PATH /floppy diff --git a/src/wconfig.h.in b/src/wconfig.h.in index c2a79a3..bb267fe 100644 --- a/src/wconfig.h.in +++ b/src/wconfig.h.in @@ -164,13 +164,13 @@ #define DEF_FRAME_COLOR white /* default fonts */ -#define DEF_TITLE_FONT Trebuchet MS,sans serif:bold:pixelsize=12 -#define DEF_MENU_TITLE_FONT Trebuchet MS,sans serif:bold:pixelsize=12 -#define DEF_MENU_ENTRY_FONT Trebuchet MS,sans
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-156-gc53fc32
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via c53fc32dcd1084f17cfbe30822799a0adc3a87d5 (commit)
via 00a7d07e8c8a62510a8bc7b016eab2d204f2a6c0 (commit)
via 04894e94c8b2055e2f43c2d41acf5863bbd544d6 (commit)
via f59b263993983a4e89dc7e51e7fa37c858304937 (commit)
via 45a976b5d47e7968dfee8768c1bf4373015b8593 (commit)
via 9fb260d046f96575bb11423549b85b8d284c30e7 (commit)
from e74afba8d7e7e8f003735208be30328bd5d2ce25 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/c53fc32dcd1084f17cfbe30822799a0adc3a87d5
commit c53fc32dcd1084f17cfbe30822799a0adc3a87d5
Author: Christophe CURIS christophe.cu...@free.fr
Date: Sun Nov 3 14:38:03 2013 +0100
WPrefs: Marked args as unused for compiler in callback code
The function is a callback, which means having a fixed argument list.
It is then correct to not use all the arguments, so this patch adds the
appropriate stuff to avoid a false report from compiler.
Signed-off-by: Christophe CURIS christophe.cu...@free.fr
diff --git a/WPrefs.app/Menu.c b/WPrefs.app/Menu.c
index 2b7f4fb..59d407e 100644
--- a/WPrefs.app/Menu.c
+++ b/WPrefs.app/Menu.c
@@ -1274,6 +1274,9 @@ static void menuItemEdited(struct WEditMenuDelegate
*delegate, WEditMenu * menu,
_Panel *panel = (_Panel *) delegate-data;
WEditMenu *submenu;
+ /* Parameter not used, but tell the compiler it is ok */
+ (void) menu;
+
updateFrameTitle(panel, WGetEditMenuItemTitle(item),
panel-currentType);
submenu = WGetEditMenuSubmenu(item);
http://repo.or.cz/w/wmaker-crm.git/commit/00a7d07e8c8a62510a8bc7b016eab2d204f2a6c0
commit 00a7d07e8c8a62510a8bc7b016eab2d204f2a6c0
Author: Christophe CURIS christophe.cu...@free.fr
Date: Sun Nov 3 14:38:02 2013 +0100
WPrefs: Removed unused argument in function 'WGetEditMenuSubmenu'
The function did not use the argument 'mPtr', so removed it.
Signed-off-by: Christophe CURIS christophe.cu...@free.fr
diff --git a/WPrefs.app/Menu.c b/WPrefs.app/Menu.c
index 7d1961c..2b7f4fb 100644
--- a/WPrefs.app/Menu.c
+++ b/WPrefs.app/Menu.c
@@ -1276,7 +1276,7 @@ static void menuItemEdited(struct WEditMenuDelegate
*delegate, WEditMenu * menu,
updateFrameTitle(panel, WGetEditMenuItemTitle(item),
panel-currentType);
- submenu = WGetEditMenuSubmenu(menu, item);
+ submenu = WGetEditMenuSubmenu(item);
if (submenu) {
WSetEditMenuTitle(submenu, WGetEditMenuItemTitle(item));
}
@@ -1289,7 +1289,7 @@ static Bool shouldRemoveItem(struct WEditMenuDelegate
*delegate, WEditMenu * men
if (panel-dontAsk)
return True;
- if (WGetEditMenuSubmenu(menu, item)) {
+ if (WGetEditMenuSubmenu(item)) {
int res;
res = WMRunAlertPanel(WMWidgetScreen(menu), NULL,
@@ -1683,7 +1683,7 @@ static WMPropList *processSubmenu(WEditMenu * menu)
s = WGetEditMenuItemTitle(item);
- submenu = WGetEditMenuSubmenu(menu, item);
+ submenu = WGetEditMenuSubmenu(item);
if (submenu) {
pl = processSubmenu(submenu);
} else {
diff --git a/WPrefs.app/editmenu.c b/WPrefs.app/editmenu.c
index 69cb38f..c3cf296 100644
--- a/WPrefs.app/editmenu.c
+++ b/WPrefs.app/editmenu.c
@@ -507,7 +507,7 @@ void WSetEditMenuSubmenu(WEditMenu * mPtr, WEditMenuItem *
item, WEditMenu * sub
paintEditMenuItem(item);
}
-WEditMenu *WGetEditMenuSubmenu(WEditMenu * mPtr, WEditMenuItem * item)
+WEditMenu *WGetEditMenuSubmenu(WEditMenuItem *item)
{
return item-submenu;
}
@@ -622,7 +622,7 @@ void WEditMenuHide(WEditMenu * mPtr)
while ((item = WGetEditMenuItem(mPtr, i++))) {
WEditMenu *submenu;
- submenu = WGetEditMenuSubmenu(mPtr, item);
+ submenu = WGetEditMenuSubmenu(item);
if (submenu) {
WEditMenuHide(submenu);
}
@@ -640,7 +640,7 @@ void WEditMenuUnhide(WEditMenu * mPtr)
while ((item = WGetEditMenuItem(mPtr, i++))) {
WEditMenu *submenu;
- submenu = WGetEditMenuSubmenu(mPtr, item);
+ submenu = WGetEditMenuSubmenu(item);
if (submenu) {
WEditMenuUnhide(submenu);
}
diff --git a/WPrefs.app/editmenu.h b/WPrefs.app/editmenu.h
index 3fde0b5..1195fe0 100644
--- a/WPrefs.app/editmenu.h
+++ b/WPrefs.app/editmenu.h
@@ -81,7 +81,7 @@ void WSetEditMenuSubmenu(WEditMenu *mPtr,
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-161-g2494473
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 249447363a5158589a0dca3949328f248f17dd19 (commit)
from 24c900a8326df46dbf024d89b30bdb6e711b53f0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/249447363a5158589a0dca3949328f248f17dd19
commit 249447363a5158589a0dca3949328f248f17dd19
Author: Amadeusz SÅawiÅski am...@asmblr.net
Date: Mon Nov 4 18:54:10 2013 +0100
configure: Fix failing check when LDFLAGS are set
export LDFLAGS=-Wl,-O1 -Wl,--as-needed
./configure --enable-png
...
checking X11/xpm.h presence... yes
checking for X11/xpm.h... yes
checking for PNG support library... configure: error: explicit PNG support
requested but no library found
diff --git a/m4/wm_imgfmt_check.m4 b/m4/wm_imgfmt_check.m4
index 9368266..8f3b224 100644
--- a/m4/wm_imgfmt_check.m4
+++ b/m4/wm_imgfmt_check.m4
@@ -263,7 +263,7 @@ AC_DEFUN_ONCE([_WM_IMGFMT_CHECK_FUNCTS],
@%:@ Assumes that LDFLAGS have been saved in 'wm_save_LDFLAGS' by caller
wm_fn_imgfmt_try_link ()
{
- LDFLAGS=$wm_save_LDFLAGS $[]2
+ LDFLAGS=$[]2 $wm_save_LDFLAGS
AC_TRY_LINK_FUNC([$[]1],
[wm_retval=0],
[wm_retval=1])
---
Summary of changes:
m4/wm_imgfmt_check.m4 |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
repo.or.cz automatic notification. Contact project admin crma...@gmail.com
if you want to unsubscribe, or site admin ad...@repo.or.cz if you receive
no reply.
--
wmaker-crm.git (The Window Maker window manager)
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-149-g246068a
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 246068a634bad42cccbd11d4f9a74901e58a434c (commit)
via 415ac91afc4fd46cf70f446a6e2ebd943a1e2d07 (commit)
via 5ed02b58be9009f3f73eccf06d4d6d3567f132a8 (commit)
from b565b48b92f7ad770158b88213dc18ba71659ac5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/246068a634bad42cccbd11d4f9a74901e58a434c
commit 246068a634bad42cccbd11d4f9a74901e58a434c
Author: Rodolfo GarcÃa Peñas (kix) k...@kix.es
Date: Sat Nov 2 20:02:27 2013 +0100
Legal Panel size with variables
This patch uses two variables to set the width and the height for the
Info Panel. It also includes a margin space.
Signed-off-by: Rodolfo GarcÃa Peñas (kix) k...@kix.es
diff --git a/src/dialog.c b/src/dialog.c
index adf19e3..3a019cf 100644
--- a/src/dialog.c
+++ b/src/dialog.c
@@ -1364,11 +1364,8 @@ void wShowInfoPanel(WScreen *scr)
typedef struct {
WScreen *scr;
-
WWindow *wwin;
-
WMWindow *win;
-
WMLabel *licenseL;
} LegalPanel;
@@ -1382,21 +1379,21 @@ static void destroyLegalPanel(WCoreWindow * foo, void
*data, XEvent * event)
(void) event;
WMUnmapWidget(legalPanel-win);
-
WMDestroyWidget(legalPanel-win);
-
wUnmanageWindow(legalPanel-wwin, False, False);
-
wfree(legalPanel);
-
legalPanel = NULL;
}
-void wShowLegalPanel(WScreen * scr)
+void wShowLegalPanel(WScreen *scr)
{
+ const int win_width = 420;
+ const int win_height = 250;
+ const int margin = 10;
LegalPanel *panel;
Window parent;
WWindow *wwin;
+ WMPoint center;
if (legalPanel) {
if (legalPanel-scr == scr) {
@@ -1407,16 +1404,14 @@ void wShowLegalPanel(WScreen * scr)
}
panel = wmalloc(sizeof(LegalPanel));
-
panel-scr = scr;
-
panel-win = WMCreateWindow(scr-wmscreen, legal);
- WMResizeWidget(panel-win, 420, 250);
+ WMResizeWidget(panel-win, win_width, win_height);
panel-licenseL = WMCreateLabel(panel-win);
WMSetLabelWraps(panel-licenseL, True);
- WMResizeWidget(panel-licenseL, 400, 230);
- WMMoveWidget(panel-licenseL, 10, 10);
+ WMResizeWidget(panel-licenseL, win_width - (2 * margin), win_height -
(2 * margin));
+ WMMoveWidget(panel-licenseL, margin, margin);
WMSetLabelTextAlignment(panel-licenseL, WALeft);
WMSetLabelText(panel-licenseL,
_(Window Maker is free software; you can
redistribute it and/or
@@ -1436,15 +1431,10 @@ void wShowLegalPanel(WScreen * scr)
WMRealizeWidget(panel-win);
WMMapSubwidgets(panel-win);
- parent = XCreateSimpleWindow(dpy, scr-root_win, 0, 0, 420, 250, 0, 0,
0);
-
+ parent = XCreateSimpleWindow(dpy, scr-root_win, 0, 0, win_width,
win_height, 0, 0, 0);
XReparentWindow(dpy, WMWidgetXID(panel-win), parent, 0, 0);
-
- {
- WMPoint center = getCenter(scr, 420, 250);
-
- wwin = wManageInternalWindow(scr, parent, None, _(Legal),
center.x, center.y, 420, 250);
- }
+ center = getCenter(scr, win_width, win_height);
+ wwin = wManageInternalWindow(scr, parent, None, _(Legal), center.x,
center.y, win_width, win_height);
WSETUFLAG(wwin, no_closable, 0);
WSETUFLAG(wwin, no_close_button, 0);
@@ -1454,13 +1444,10 @@ void wShowLegalPanel(WScreen * scr)
wFrameWindowHideButton(wwin-frame, WFF_LANGUAGE_BUTTON);
#endif
wwin-frame-on_click_right = destroyLegalPanel;
-
panel-wwin = wwin;
WMMapWidget(panel-win);
-
wWindowMap(wwin);
-
legalPanel = panel;
}
http://repo.or.cz/w/wmaker-crm.git/commit/415ac91afc4fd46cf70f446a6e2ebd943a1e2d07
commit 415ac91afc4fd46cf70f446a6e2ebd943a1e2d07
Author: Rodolfo GarcÃa Peñas (kix) k...@kix.es
Date: Sat Nov 2 20:02:26 2013 +0100
Window Maker Developers Team Copyright
This patch includes the Dev Team Copyright in the info panel.
Signed-off-by: Rodolfo GarcÃa Peñas (kix) k...@kix.es
diff --git a/src/dialog.c b/src/dialog.c
index 5655cd5..adf19e3 100644
--- a/src/dialog.c
+++ b/src/dialog.c
@@ -1105,7 +1105,8 @@ typedef struct {
#define COPYRIGHT_TEXT Copyright xc2xa9 1997-2006 Alfredo K. Kojiman-
Copyright xc2xa9 1998-2006 Dan Pascu
+Copyright xc2xa9 1998-2006 Dan Pascun+Copyright xc2xa9 2013 Window
Maker Developers Team
static InfoPanel *thePanel = NULL;
@@ -1126,7 +1127,7 @@ static void destroyInfoPanel(WCoreWindow *foo, void
*data, XEvent
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-160-g24c900a
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via 24c900a8326df46dbf024d89b30bdb6e711b53f0 (commit) from ad98a1a338f5e64c8d978b8958f1fe2556f6e0da (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://repo.or.cz/w/wmaker-crm.git/commit/24c900a8326df46dbf024d89b30bdb6e711b53f0 commit 24c900a8326df46dbf024d89b30bdb6e711b53f0 Author: Amadeusz SÅawiÅski am...@asmblr.net Date: Mon Nov 4 17:42:43 2013 +0100 configure: Fix wrong variable name in --enable-png Otherwise it tells that yes/no (from --enable/--disable-png) are wrong options. diff --git a/configure.ac b/configure.ac index 270bf3b..605bc8f 100644 --- a/configure.ac +++ b/configure.ac @@ -659,7 +659,7 @@ dnl PNG Support dnl === AC_ARG_ENABLE([png], [AS_HELP_STRING([--disable-png], [disable PNG support through libpng])], -[AS_CASE([$enablebal], +[AS_CASE([$enableval], [yes|no], [], [AC_MSG_ERROR([bad value $enableval for --enable-png])] )], [enable_png=auto]) --- Summary of changes: configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) repo.or.cz automatic notification. Contact project admin crma...@gmail.com if you want to unsubscribe, or site admin ad...@repo.or.cz if you receive no reply. -- wmaker-crm.git (The Window Maker window manager) -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-159-gad98a1a
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via ad98a1a338f5e64c8d978b8958f1fe2556f6e0da (commit) via add823ef6a9efdd6e4192d21a69c7bda6c6c5e69 (commit) via 77c34804f9742a898728f8a389f209b5c5747e8c (commit) from c53fc32dcd1084f17cfbe30822799a0adc3a87d5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://repo.or.cz/w/wmaker-crm.git/commit/ad98a1a338f5e64c8d978b8958f1fe2556f6e0da commit ad98a1a338f5e64c8d978b8958f1fe2556f6e0da Author: Christophe CURIS christophe.cu...@free.fr Date: Sun Nov 3 19:27:59 2013 +0100 wrlib: Moved configure's detection of TIFF support to a dedicated macro The original check was not compliant with autoconf's syntax, did not have a very good behaviour for user and was not easy to make evolve. The new macro: - uses as much as possible autoconf macros for portability and code consistency; - provides a consistent behaviour on yes/no/auto (if user explicitly enables support, do not silently disable if not found; if library is found but not the header, complain to let user install it or explicitly disable support); - makes uses of shell functions to keep generated configure smaller by sharing reusable stuff; - uses an automake conditional to avoid compiling the file is support is not enabled Signed-off-by: Christophe CURIS christophe.cu...@free.fr diff --git a/configure.ac b/configure.ac index 7950f08..270bf3b 100644 --- a/configure.ac +++ b/configure.ac @@ -690,55 +690,20 @@ WM_IMGFMT_CHECK_GIF dnl TIFF Support dnl -AC_ARG_ENABLE(tiff, -AS_HELP_STRING([--disable-tiff], [disable use of TIFF images through libtiff]), - tif=$enableval, tif=yes, tif=no) - -# -# TIFF can optionally have JPEG and/or zlib support. Must find out -# when they are supported so that correct library flags are passed during -# detection and linkage -# -# -# By default use xpm icons if tiff is not found. -ICONEXT=xpm -# - -if test $tif = yes; then -my_libname= -WM_CHECK_LIB(tiff, TIFFGetVersion, [-lm]) -if test x$ac_cv_lib_tiff_TIFFGetVersion = xyes; then - my_libname=-ltiff -fi -dnl -dnl Retry with zlib -dnl -unset ac_cv_lib_tiff_TIFFGetVersion -if test x$my_libname = x; then - WM_CHECK_LIB(tiff, TIFFGetVersion, [$ljpeg -lz -lm]) - if test x$ac_cv_lib_tiff_TIFFGetVersion = xyes; then - my_libname=-ltiff -lz - fi -fi +AC_ARG_ENABLE([tiff], +[AS_HELP_STRING([--disable-tiff], [disable use of TIFF images through libtiff])], +[AS_CASE([$enableval], +[yes|no], [], +[AC_MSG_ERROR([bad value $enableval for --enable-tiff])] )], +[enable_tiff=auto]) +WM_IMGFMT_CHECK_TIFF -if test x$my_libname = x; then - WM_CHECK_LIB(tiff34, TIFFGetVersion, [$ljpeg -lm]) - if test x$ac_cv_lib_tiff34_TIFFGetVersion = xyes; then - my_libname=-ltiff34 - fi -fi +# Choice of the default format for icons +AS_IF([test x$enable_tiff != xno], +[ICONEXT=tiff], +[ICONEXT=xpm]) -if test x$my_libname != x; then - WM_CHECK_HEADER(tiffio.h) - if test x$ac_cv_header_tiffio_h = xyes; then - GFXLIBS=$my_libname $GFXLIBS - ICONEXT=tiff -supported_gfx=$supported_gfx TIFF -AC_DEFINE(USE_TIFF, 1, [define if TIFF libraries are available (set by configure)]) - fi -fi -fi LIBRARY_SEARCH_PATH=$lib_search_path HEADER_SEARCH_PATH=$inc_search_path diff --git a/m4/wm_imgfmt_check.m4 b/m4/wm_imgfmt_check.m4 index 987325d..9368266 100644 --- a/m4/wm_imgfmt_check.m4 +++ b/m4/wm_imgfmt_check.m4 @@ -188,6 +188,66 @@ AM_CONDITIONAL([USE_PNG], [test x$enable_png != xno])dnl ]) dnl AC_DEFUN +# WM_IMGFMT_CHECK_TIFF +# +# +# Check for TIFF file support through 'libtiff' +# The check depends on variable 'enable_tiff' being either: +# yes - detect, fail if not found +# no - do not detect, disable support +# auto - detect, disable if not found +# +# When found, append appropriate stuff in GFXLIBS, and append info to +# the variable 'supported_gfx' +# When not found, append info to variable 'unsupported' +AC_DEFUN_ONCE([WM_IMGFMT_CHECK_TIFF], +[AC_REQUIRE([_WM_IMGFMT_CHECK_FUNCTS]) +AS_IF([test x$enable_tiff = xno], +[unsupported=$unsupported TIFF], +[AC_CACHE_CHECK([for TIFF support library], [wm_cv_imgfmt_tiff], +[wm_cv_imgfmt_tiff=no + dnl + dnl We check first if one of the known libraries is available + wm_save_LDFLAGS=$LDFLAGS + for wm_arg in -ltiff + dnl TIFF can have a
Problem with full screen windows
Hey, Another problem, this time with usability. Start xterm and firefox, enter fullscreen (F11) in firefox, now win-tab (or alt-tab, whatever you use to change windows ;) and select other window. Notice that firefox still stays shown on top, while other window has focus. Also if one has bind for windowmenu it gets activated but is not shown above fullscreened window. Now I'm not sure what the correct solution would be. * disable some shortcuts when focused windows is fullscreen * don't make fullscreen window special with relation to stacking, just raise it on top when fullscreening I would prefer second solution, however I would like to have some confirmation before writing patch. Amadeusz Sławiński -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 0/4] Fixes for Image Format detection
From: Christophe CURIS christophe.cu...@free.fr Hello, Following the reported by Amadeusz, I had a deeper look, so I am proposing new version for the 4 patches: - patch 1 replaces 45a976b5d47e7968dfee8768c1bf4373015b8593 - patch 2 replaces 77c34804f9742a898728f8a389f209b5c5747e8c - patch 3 replaces add823ef6a9efdd6e4192d21a69c7bda6c6c5e69 - patch 4 replaces ad98a1a338f5e64c8d978b8958f1fe2556f6e0da Basically, the core problem was using LDFLAGS, when the proper variable to use is LIBS (still wondering how I missed it...). I also took the liberty to merge Amadeusz typo fix so the history will remain simple, while we're still on #next. Carlos, If this resubmission happens to be too annoying work for you, let me know if there's a way to make your work easier. Best regards, Christophe. Christophe CURIS (4): configure: Moved detection of GIF support to a dedicated macro wrlib: Moved configure's detection of JPEG support to a dedicated macro wrlib: Moved configure's detection of PNG support to a dedicated macro wrlib: Moved configure's detection of TIFF support to a dedicated macro WPrefs.app/Menu.c | 9 +- WPrefs.app/editmenu.c | 6 +- WPrefs.app/editmenu.h | 2 +- configure.ac | 191 + m4/wm_imgfmt_check.m4 | 290 ++ wrlib/Makefile.am | 21 +++- wrlib/gif.c | 19 +++- wrlib/jpeg.c | 4 - wrlib/png.c | 4 - wrlib/tiff.c | 4 - 10 files changed, 382 insertions(+), 168 deletions(-) create mode 100644 m4/wm_imgfmt_check.m4 -- 1.8.4.rc3 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 1/4] configure: Moved detection of GIF support to a dedicated macro
From: Christophe CURIS christophe.cu...@free.fr
The original check was not compliant with autoconf's syntax, did not
have a very good behaviour for user and was not easy to make evolve.
The new macro:
- uses as much as possible autoconf macros for portability and code
consistency;
- provides a consistent behaviour on yes/no/auto (if user explicitly
enables support, do not silently disable if not found; if library is found
but not the header, complain to let user install it or explicitly disable
support);
- makes uses of shell functions to keep generated configure smaller by
sharing reusable stuff;
- introduces a tracking of unsupported things to be reported to user
It includes a fixes from a problem found by Amadeusz S-B�awi�ski, because-A
the function 'wm_fn_imgfmt_try_link' modified the variable LDFLAGS
instead of LIBS.
Signed-off-by: Christophe CURIS christophe.cu...@free.fr
---
configure.ac | 44 +++-
m4/wm_imgfmt_check.m4 | 110 ++
2 files changed, 124 insertions(+), 30 deletions(-)
create mode 100644 m4/wm_imgfmt_check.m4
diff --git a/configure.ac b/configure.ac
index eb944a6..4ebce21 100644
--- a/configure.ac
+++ b/configure.ac
@@ -120,6 +120,12 @@ AS_IF([test x$debug = xyes],
AX_CFLAGS_GCC_OPTION([-Wno-deprecated-declarations])
])
+
+dnl Tracking on what is detected for final status
+dnl =
+unsupported=
+
+
dnl Platform-specific Makefile setup
dnl
AS_CASE([$host],
@@ -709,36 +715,13 @@ fi
dnl GIF Support
dnl
-gif=yes
-AC_ARG_ENABLE(gif, AS_HELP_STRING([--disable-gif], [disable GIF support
through libgif or libungif]),
- gif=$enableval, gif=yes, gif=no)
-
-if test $gif = yes; then
-my_libname=
-WM_CHECK_LIB(ungif, DGifOpenFileName, [$XLFLAGS $XLIBS])
-if test x$ac_cv_lib_ungif_DGifOpenFileName = xyes; then
-my_libname=-lungif
-fi
-dnl
-dnl libungif is the same thing as libgif for all practical purposes.
-dnl
-if test x$my_libname = x; then
-WM_CHECK_LIB(gif, DGifOpenFileName, [$XLFLAGS $XLIBS])
-if test x$ac_cv_lib_gif_DGifOpenFileName = xyes; then
-my_libname=-lgif
-fi
-fi
-
-if test $my_libname != x; then
- WM_CHECK_HEADER(gif_lib.h)
- if test x$ac_cv_header_gif_lib_h = xyes; then
- GFXLIBS=$GFXLIBS $my_libname
- supported_gfx=$supported_gfx GIF
-AC_DEFINE(USE_GIF, 1, [define if GIF libraries are available (set
by configure)])
- fi
-fi
-fi
-
+AC_ARG_ENABLE(gif,
+[AS_HELP_STRING([--disable-gif], [disable GIF support through libgif or
libungif])],
+[AS_CASE([$enableval],
+[yes|no], [],
+[AC_MSG_ERROR([bad value $enableval for --enable-gif])] )],
+[enable_gif=auto])
+WM_IMGFMT_CHECK_GIF
dnl TIFF Support
@@ -924,6 +907,7 @@ echo Installation path for binaries : $_bindir
echo Installation path for libraries : $libdir
echo Installation path for WPrefs.app: $wprefs_base_dir | sed -e
's|\${prefix}|'$prefix|
echo Supported graphic format libraries : $supported_gfx
+echo Unsupported features:$unsupported
echo Antialiased text support in WINGs : $xft
echo Xinerama extension support : $xinerama
echo XRandR extension support: $xrandr
diff --git a/m4/wm_imgfmt_check.m4 b/m4/wm_imgfmt_check.m4
new file mode 100644
index 000..8f7a3a8
--- /dev/null
+++ b/m4/wm_imgfmt_check.m4
@@ -0,0 +1,110 @@
+# wm_imgfmt_check.m4 - Macros to check for image file format support libraries
+#
+# Copyright (c) 2013 Christophe CURIS
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+# WM_IMGFMT_CHECK_GIF
+# ---
+#
+# Check for GIF file support through 'libgif' or 'libungif'
+# The check depends on variable 'enable_gif' being either:
+# yes - detect, fail if not found
+# no - do not detect, disable support
+# auto - detect, disable if not found
+#
+# When found, append appropriate stuff in GFXLIBS, and append info to
+# the variable 'supported_gfx'
+# When not found, append info to variable 'unsupported'
+AC_DEFUN_ONCE([WM_IMGFMT_CHECK_GIF],
+[AC_REQUIRE([_WM_IMGFMT_CHECK_FUNCTS])
+AS_IF([test x$enable_gif = xno],
+
[PATCH 3/4] wrlib: Moved configure's detection of PNG support to a dedicated macro
From: Christophe CURIS christophe.cu...@free.fr The original check was not compliant with autoconf's syntax, did not have a very good behaviour for user and was not easy to make evolve. The new macro: - uses as much as possible autoconf macros for portability and code consistency; - provides a consistent behaviour on yes/no/auto (if user explicitly enables support, do not silently disable if not found; if library is found but not the header, complain to let user install it or explicitly disable support); - makes uses of shell functions to keep generated configure smaller by sharing reusable stuff; - uses an automake conditional to avoid compiling the file is support is not enabled It includes a typo fixed by Amadeusz S-B�awi�ski.-A Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- configure.ac | 37 +++- m4/wm_imgfmt_check.m4 | 52 +++ wrlib/Makefile.am | 5 - wrlib/png.c | 4 4 files changed, 63 insertions(+), 35 deletions(-) diff --git a/configure.ac b/configure.ac index 63d1729..7c65c30 100644 --- a/configure.ac +++ b/configure.ac @@ -657,36 +657,13 @@ dnl === dnl PNG Support dnl === -png=yes -AC_ARG_ENABLE(png, AS_HELP_STRING([--disable-png], [disable PNG support through libpng]), - png=$enableval, png=yes, png=no) - -if test $png = yes ; then -my_libname= -WM_CHECK_LIB(png, png_get_valid, [-lm]) -if test x$ac_cv_lib_png_png_get_valid = xyes; then - my_libname=-lpng -fi -dnl -dnl Retry with zlib -dnl -if test x$my_libname = x; then -unset ac_cv_lib_png_png_get_valid -WM_CHECK_LIB(png, png_get_valid, [-lz -lm]) - if test x$ac_cv_lib_png_png_get_valid = xyes; then - my_libname=-lpng -lz - fi -fi - -if test x$ac_cv_lib_png_png_get_valid = xyes; then - WM_CHECK_HEADER(png.h) - if test x$ac_cv_header_png_h = xyes; then - GFXLIBS=$GFXLIBS $my_libname - supported_gfx=$supported_gfx PNG -AC_DEFINE(USE_PNG, 1, [define if PNG libraries are available (set by configure)]) - fi -fi -fi +AC_ARG_ENABLE([png], +[AS_HELP_STRING([--disable-png], [disable PNG support through libpng])], +[AS_CASE([$enableval], +[yes|no], [], +[AC_MSG_ERROR([bad value $enableval for --enable-png])] )], +[enable_png=auto]) +WM_IMGFMT_CHECK_PNG dnl JPEG Support diff --git a/m4/wm_imgfmt_check.m4 b/m4/wm_imgfmt_check.m4 index 3231f7b..2d53e43 100644 --- a/m4/wm_imgfmt_check.m4 +++ b/m4/wm_imgfmt_check.m4 @@ -136,6 +136,58 @@ AM_CONDITIONAL([USE_JPEG], [test x$enable_jpeg != xno])dnl ]) dnl AC_DEFUN +# WM_IMGFMT_CHECK_PNG +# --- +# +# Check for PNG file support through 'libpng' +# The check depends on variable 'enable_png' being either: +# yes - detect, fail if not found +# no - do not detect, disable support +# auto - detect, disable if not found +# +# When found, append appropriate stuff in GFXLIBS, and append info to +# the variable 'supported_gfx' +# When not found, append info to variable 'unsupported' +AC_DEFUN_ONCE([WM_IMGFMT_CHECK_PNG], +[AC_REQUIRE([_WM_IMGFMT_CHECK_FUNCTS]) +AS_IF([test x$enable_png = xno], +[unsupported=$unsupported PNG], +[AC_CACHE_CHECK([for PNG support library], [wm_cv_imgfmt_png], +[wm_cv_imgfmt_png=no + dnl + dnl We check first if one of the known libraries is available + wm_save_LIBS=$LIBS + for wm_arg in -lpng -lpng -lz -lpng -lz -lm ; do + AS_IF([wm_fn_imgfmt_try_link png_get_valid $XLFLAGS $XLIBS $wm_arg], + [wm_cv_imgfmt_png=$wm_arg ; break]) + done + LIBS=$wm_save_LIBS + AS_IF([test x$enable_png$wm_cv_imgfmt_png = xyesno], + [AC_MSG_ERROR([explicit PNG support requested but no library found])]) + AS_IF([test x$wm_cv_imgfmt_png != xno], + [dnl +dnl A library was found, now check for the appropriate header +wm_save_CFLAGS=$CFLAGS +AS_IF([wm_fn_imgfmt_try_compile png.h return 0 ], + [], + [AC_MSG_ERROR([found $wm_cv_imgfmt_png but could not find appropriate header - are you missing libpng-dev package?])]) +AS_IF([wm_fn_imgfmt_try_compile png.h png_get_valid(NULL, NULL, PNG_INFO_tRNS) ], + [], + [AC_MSG_ERROR([found $wm_cv_imgfmt_png and header, but cannot compile - unsupported version?])]) +CFLAGS=$wm_save_CFLAGS]) + ]) +AS_IF([test x$wm_cv_imgfmt_png = xno], +[unsupported=$unsupported PNG + enable_png=no], +[supported_gfx=$supported_gfx PNG + GFXLIBS=$GFXLIBS $wm_cv_imgfmt_png + AC_DEFINE([USE_PNG], [1], + [defined when valid PNG library with header was found])]) +]) +AM_CONDITIONAL([USE_PNG], [test x$enable_png != xno])dnl
Re: Problem with full screen windows
On Mon, 04 Nov 2013, Amadeusz Sławiński escribió: Hey, Another problem, this time with usability. Start xterm and firefox, enter fullscreen (F11) in firefox, now win-tab (or alt-tab, whatever you use to change windows ;) and select other window. Notice that firefox still stays shown on top, while other window has focus. Also if one has bind for windowmenu it gets activated but is not shown above fullscreened window. Now I'm not sure what the correct solution would be. * disable some shortcuts when focused windows is fullscreen IMO is better hold the same behavior always. Change the behavior could disturb the user. * don't make fullscreen window special with relation to stacking, just raise it on top when fullscreening I would prefer second solution, however I would like to have some confirmation before writing patch. +1 for second solution. Cheers, kix Amadeusz Sławiński -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org. -- ||// //\\// Rodolfo kix Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-159-g98d7538
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated discards 249447363a5158589a0dca3949328f248f17dd19 (commit) discards 24c900a8326df46dbf024d89b30bdb6e711b53f0 (commit) discards ad98a1a338f5e64c8d978b8958f1fe2556f6e0da (commit) discards add823ef6a9efdd6e4192d21a69c7bda6c6c5e69 (commit) discards 77c34804f9742a898728f8a389f209b5c5747e8c (commit) discards c53fc32dcd1084f17cfbe30822799a0adc3a87d5 (commit) discards 00a7d07e8c8a62510a8bc7b016eab2d204f2a6c0 (commit) discards 04894e94c8b2055e2f43c2d41acf5863bbd544d6 (commit) discards f59b263993983a4e89dc7e51e7fa37c858304937 (commit) discards 45a976b5d47e7968dfee8768c1bf4373015b8593 (commit) via 98d753801d90b4f8293e197d8cb951eb46ac83cb (commit) via ea6dd2748de0f8fcdaad7deaa97c21b3740c88af (commit) via c516f2bc4363a6d7e9e1e1e1dfef5fe55edcb469 (commit) via f7479659b157281938c5e71479849b20837a9737 (commit) via 102e62d8ab341ee72c652deb794a6654c093f5a7 (commit) via 3f26e2de3400acad55631ca8b612320be6b7c913 (commit) via ea63dd30181932aaf89741bd2c60b995672dbde8 (commit) via f07b5e4f143d8cd57b60780b1672e5e57b4ed665 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (249447363a5158589a0dca3949328f248f17dd19) N -- N -- N (98d753801d90b4f8293e197d8cb951eb46ac83cb) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://repo.or.cz/w/wmaker-crm.git/commit/98d753801d90b4f8293e197d8cb951eb46ac83cb commit 98d753801d90b4f8293e197d8cb951eb46ac83cb Author: Christophe CURIS christophe.cu...@free.fr Date: Mon Nov 4 20:52:31 2013 +0100 wrlib: Moved configure's detection of TIFF support to a dedicated macro The original check was not compliant with autoconf's syntax, did not have a very good behaviour for user and was not easy to make evolve. The new macro: - uses as much as possible autoconf macros for portability and code consistency; - provides a consistent behaviour on yes/no/auto (if user explicitly enables support, do not silently disable if not found; if library is found but not the header, complain to let user install it or explicitly disable support); - makes uses of shell functions to keep generated configure smaller by sharing reusable stuff; - uses an automake conditional to avoid compiling the file is support is not enabled Signed-off-by: Christophe CURIS christophe.cu...@free.fr diff --git a/configure.ac b/configure.ac index 7c65c30..605bc8f 100644 --- a/configure.ac +++ b/configure.ac @@ -690,55 +690,20 @@ WM_IMGFMT_CHECK_GIF dnl TIFF Support dnl -AC_ARG_ENABLE(tiff, -AS_HELP_STRING([--disable-tiff], [disable use of TIFF images through libtiff]), - tif=$enableval, tif=yes, tif=no) - -# -# TIFF can optionally have JPEG and/or zlib support. Must find out -# when they are supported so that correct library flags are passed during -# detection and linkage -# -# -# By default use xpm icons if tiff is not found. -ICONEXT=xpm -# - -if test $tif = yes; then -my_libname= -WM_CHECK_LIB(tiff, TIFFGetVersion, [-lm]) -if test x$ac_cv_lib_tiff_TIFFGetVersion = xyes; then - my_libname=-ltiff -fi -dnl -dnl Retry with zlib -dnl -unset ac_cv_lib_tiff_TIFFGetVersion -if test x$my_libname = x; then - WM_CHECK_LIB(tiff, TIFFGetVersion, [$ljpeg -lz -lm]) - if test x$ac_cv_lib_tiff_TIFFGetVersion = xyes; then - my_libname=-ltiff -lz - fi -fi +AC_ARG_ENABLE([tiff], +[AS_HELP_STRING([--disable-tiff], [disable use of TIFF images through libtiff])], +[AS_CASE([$enableval], +[yes|no], [], +[AC_MSG_ERROR([bad value $enableval for --enable-tiff])] )], +[enable_tiff=auto]) +WM_IMGFMT_CHECK_TIFF -if test x$my_libname = x; then - WM_CHECK_LIB(tiff34, TIFFGetVersion, [$ljpeg -lm]) - if test x$ac_cv_lib_tiff34_TIFFGetVersion = xyes; then - my_libname=-ltiff34 - fi -fi +# Choice of the default format for icons +AS_IF([test x$enable_tiff != xno], +[ICONEXT=tiff], +[ICONEXT=xpm]) -if test x$my_libname != x; then - WM_CHECK_HEADER(tiffio.h) - if test x$ac_cv_header_tiffio_h = xyes; then -
Re: Problem with full screen windows
On Mon, 04 Nov 2013 23:14:33 +0300 Yury Tarasievich yury.tarasiev...@gmail.com wrote: Would you explain, what'd the second solution actually do? On 11/04/2013 11:04 PM, Rodolfo García Peñas wrote: On Mon, 04 Nov 2013, Amadeusz Sławiński escribió: ... * don't make fullscreen window special with relation to stacking, just raise it on top when fullscreening I would prefer second solution, however I would like to have some confirmation before writing patch. +1 for second solution. So while I reinstall git with send-email support... The patches I wrote set fullscreened window to WMNormalLevel and raise them. Fullscreened windows still take whole screen and aren't moveable/resizable. Only noticeable difference apart from fixing focusing issues is that windows with Keep on top really stay on top. (I consider this correct behaviour.) Amadeusz Sławiński -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 2/2] Raise fullscreened window
Make sure that fullscreened window covers all normal windows --- src/actions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/actions.c b/src/actions.c index 36a0ca1..2087953 100644 --- a/src/actions.c +++ b/src/actions.c @@ -702,6 +702,7 @@ void wFullscreenWindow(WWindow *wwin) wWindowConfigureBorders(wwin); ChangeStackingLevel(wwin-frame-core, WMNormalLevel); + wRaiseFrame(wwin-frame-core); wwin-bfs_geometry.x = wwin-frame_x; wwin-bfs_geometry.y = wwin-frame_y; -- 1.8.4.2 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 1/2] Remove WMFullscreenLevel
Make fullscreen windows be on the same level as normal ones.
---
src/WindowMaker.h | 1 -
src/actions.c | 14 +-
src/wmspec.c | 2 +-
3 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/WindowMaker.h b/src/WindowMaker.h
index f4fa5b8..543f2e3 100644
--- a/src/WindowMaker.h
+++ b/src/WindowMaker.h
@@ -58,7 +58,6 @@ enum {
WMSubmenuLevel = 15,
WMMainMenuLevel = 20,
WMStatusLevel = 21,
-WMFullscreenLevel = 50,
WMModalLevel = 100,
WMPopUpLevel = 101,
WMScreensaverLevel = 1000,
diff --git a/src/actions.c b/src/actions.c
index 17dc965..36a0ca1 100644
--- a/src/actions.c
+++ b/src/actions.c
@@ -701,7 +701,7 @@ void wFullscreenWindow(WWindow *wwin)
wWindowConfigureBorders(wwin);
- ChangeStackingLevel(wwin-frame-core, WMFullscreenLevel);
+ ChangeStackingLevel(wwin-frame-core, WMNormalLevel);
wwin-bfs_geometry.x = wwin-frame_x;
wwin-bfs_geometry.y = wwin-frame_y;
@@ -725,14 +725,10 @@ void wUnfullscreenWindow(WWindow *wwin)
wwin-flags.fullscreen = False;
- if (wwin-frame-core-stacking-window_level == WMFullscreenLevel) {
- if (WFLAGP(wwin, sunken)) {
- ChangeStackingLevel(wwin-frame-core, WMSunkenLevel);
- } else if (WFLAGP(wwin, floating)) {
- ChangeStackingLevel(wwin-frame-core, WMFloatingLevel);
- } else {
- ChangeStackingLevel(wwin-frame-core, WMNormalLevel);
- }
+ if (WFLAGP(wwin, sunken)) {
+ ChangeStackingLevel(wwin-frame-core, WMSunkenLevel);
+ } else if (WFLAGP(wwin, floating)) {
+ ChangeStackingLevel(wwin-frame-core, WMFloatingLevel);
}
wWindowConfigure(wwin, wwin-bfs_geometry.x, wwin-bfs_geometry.y,
diff --git a/src/wmspec.c b/src/wmspec.c
index b4a8cfa..58c7f9f 100644
--- a/src/wmspec.c
+++ b/src/wmspec.c
@@ -927,7 +927,7 @@ static int getWindowLayer(WWindow *wwin)
if (wwin-transient_for) {
WWindow *parent = wWindowFor(wwin-transient_for);
if (parent parent-flags.fullscreen)
- layer = WMFullscreenLevel;
+ layer = WMNormalLevel;
}
/* //layer = WMPopUpLevel; // this seems a bad idea -Dan */
} else if (wwin-type == net_wm_window_type_normal) {
--
1.8.4.2
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] Basic WINGs theming
Let me raise my voice as the guy who made the Debian Linux spinoff Window Maker Live (aka wmlive) available, which uses Window Maker as default graphical interface, and who was forced to base some design decisions based only(!) on the theming shortcomings of WINGs. On 11/04/2013 06:00 PM, Carlos R. Mafra wrote: wmaker successfully reproduces the look and feel of NeXTSTEP and most applications don't. But that's how things are. The way things are, at least for GTK2 based applications someone was able to create a NeXTish theme, and this allowed wmlive to have a more or less homogeneous look and (almost) feel. Luckily this also applies to some extend to some QT based applications, for which a compatibility theming layer to GTK2 exists. All things GTK3 had to be excluded in wmlive simply because there is still no way to make it adapt to this limited NeXTish looks of WINGs. The other way round would have simply been impossible, as WINGs does not offer anything providing the depth of theming capabilities other toolkits provide. In fact, in order to have wmlive look minimally consistent, everything needed to be adapted to and to revolve around WINGs. This is so 90's! WINGs looks like it was supposed to look, so that's why it is hardcoded. I certainly would love to have these shortcomings of WINGs to be amended, and for this i do welcome Doug's patches. Thanks Doug! Personally i don't like Window Maker because it looks and feels like NeXTSTEP or because to some degree even shares some common ground with GNUstep (which i don't care about anymore in context of real life BTW). No, i like it because of its window manager capabilities, and i would definitely prefer it to be able to also acquire some other looks. Yes, this is cosmetics, but then again it is also cosmetics limiting Window Maker and WINGs to just one outdated boring look. So if there is a possibility to get rid of this visual monotony, i am all in for it. Furthermore, in context of the usual standard desktop mess of Linux, wmaker is well advised to offer as much compatibility as possible, and this defintely also includes theming capabilities. There are a multitude of standard applications out there who have stood the test of time and simply define desktop standards which wmaker/WINGs has no choice to ignore anymore. I for one would love to see Window Maker finally enter the 21st century instead of eternally staying stuck in last century's 90's. Thanks again, Doug! -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Alt+Tab and mouse
Personally I like of speeding up the activation of a window by hovering the mouse over the alt tab dialog. Perhaps an option should be available for configuring this behaviour... Em 04/11/2013 22:52, Nerijus Baliunas neri...@users.sourceforge.net escreveu: Hello, when Alt+Tabbing, is it possible to ignore mouse? Sometimes mouse cursor is in the center of the screen, and Alt+Tab ends not where I intended to. Regards, Nerijus -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Alt+Tab and mouse
Happens even if mouse cursor isn't inside the blue rounded rectangle (BRR). If the cursor is, say, higher than BRR and off to the right, then window currently next in priority list gets pre-switched-to. -Yury On 11/05/2013 10:01 AM, Rodolfo García Peñas (kix) wrote: Nerijus Baliunas neri...@users.sourceforge.net escribió: ... when Alt+Tabbing, is it possible to ignore mouse? Sometimes mouse cursor is in the center of the screen, and Alt+Tab ends not where I intended to. You move the mouse? (perhaps only a bit?) and then wmaker detects a mouse_move event or the problem happends without moving the mouse? -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
