Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
On 09/22/2014 04:13 AM, Iain Patterson wrote: > Sounds good. We'd need to change the option heading. How about: > > "Dragging a maximized window:" > - "Like other windows" > - "Window's unmaximized geometry will be restored" > - "Window will be considered unmaximized" > - "Window will not move" Great ideas! I'll work on a revised patch soon. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
On 09/22/2014 12:13 PM, Iain Patterson wrote: ... Sounds good. We'd need to change the option heading. How about: "Dragging a maximized window:" - "Like other windows" ... This one, how about "window changes position (normal behaviour)"? Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
Quoth Yury Tarasievich, Well, to me the "ideal" name of the option is the end result of its activation. So, respectively, "window will be considered unmaximised" and "window will not move". Sounds good. We'd need to change the option heading. How about: "Dragging a maximized window:" - "Like other windows" - "Window's unmaximized geometry will be restored" - "Window will be considered unmaximized" - "Window will not move" -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
On 09/22/2014 11:38 AM, Iain Patterson wrote: ... Perhaps "is prevented" would be better. "Forbidden" implies you're being naughty if you do rather than you literally can't. Well, to me the "ideal" name of the option is the end result of its activation. So, respectively, "window will be considered unmaximised" and "window will not move". Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
Quoth Yury Tarasievich, Why not name the 3rd option "becomes unmaximised (status/flag changed only)"? That makes sense to us developers but to an end user with no interest in this mailing list it would probably be confusing. "What status/flag does it speak of?" our hypothetical end user would ask. "Why does it say it becomes unmaximised when I move it and its dimensions don't change?" he'd wonder. Seems like a very sane 4th option. Name it on the lines of "is forbidden", though. Perhaps "is prevented" would be better. "Forbidden" implies you're being naughty if you do rather than you literally can't. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
On 09/22/2014 10:16 AM, Iain Patterson wrote: ... Having thought some more about it I propose that in WPrefs the setting be shown as a heading "Moving a maximized window" followed by a dropdown with three settings: "behaves normally" (current default), "restores original size" (shrink on move) and "commits new dimensions" (clear flags). ... Why not name the 3rd option "becomes unmaximised (status/flag changed only)"? completeness we might now add it with a fourth description along the lines of "is prevented." Seems like a very sane 4th option. Name it on the lines of "is forbidden", though. Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
Quoth Yury Tarasievich, I foresee folks developing certain subconscious fear of moving the Wmaker's windows in general - what if it'll change its size? I can see the reasoning behind it and I think that Doug's suggestion of having all three possibilities is the way forward. I'd always prefer that users be given the choice. Having thought some more about it I propose that in WPrefs the setting be shown as a heading "Moving a maximized window" followed by a dropdown with three settings: "behaves normally" (current default), "restores original size" (shrink on move) and "commits new dimensions" (clear flags). At one point in the past I thought about adding the option of locking a maximised window into place by disabling all movement when it was flagged. Since my main goal for doing that was to prevent losing the ability to restore the dimensions I abandoned the idea when the (now) current behaviour was made to work. For completeness we might now add it with a fourth description along the lines of "is prevented." -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
*Moving* maximised windows is not a problem, it's maximised window (suddenly) *changing size* when moved that's a problem. I only moved it, what? I foresee folks developing certain subconscious fear of moving the Wmaker's windows in general - what if it'll change its size? Perceptionally, what's the distinction between moving the max'ed and the unmax'ed windows? None. Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
On 09/21/2014 01:55 PM, Iain Patterson wrote: > Quoth Doug Torrance, > >> This patch changes the behavior by clearing the maximization flag when a >> maximized window is moved. Then, when a window is maximized and then >> moved, it >> can be maximized again without issues. > > [The old way] is explicitly done like that so you can move a > maximised window around without losing the ability to restore its old > size. Under the old(er) behaviour, which this patch would now > restore, moving a maximised window even one pixel in any one direction > was enough to cause wmaker to forget the original dimensions and make > restoring to them impossible. > > I imagine that most people would ask "but why would you want to do > that?" in response to the idea of moving a fully-maximised window > around but consider that a Maximusized, half- or corner-maximised > window is also "maximised" as far as wmaker is concerned, and moving > them is more intuitively reasonable. > > In fact I fairly often find myself moving "really" maximised windows > about as well. As an example, a particularly naughty website doesn't > quite render in my (small) Firefox window. Maximise Firefox. Now I > can see the content but I can't see the email underneath where a > colleague was asking me to look at the page. Move Firefox about. Now > I can see. Now I've finished. Hit the shortcut key and Firefox > bounces back to the position and size it was before. > > On balance I found it less annoying and illogical to have moveable > maximised windows than to have windows which could be maximimised and > never restored. Thanks for pointing out the advantages of the current behavior. Perhaps a compromise would be allowing three possibilities: the current behavior (set as default), moving clearing the maximized flag, and moving restoring the original geometry. I'll work on a new patch soon. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
Quoth Doug Torrance, This patch changes the behavior by clearing the maximization flag when a maximized window is moved. Then, when a window is maximized and then moved, it can be maximized again without issues. [The old way] is explicitly done like that so you can move a maximised window around without losing the ability to restore its old size. Under the old(er) behaviour, which this patch would now restore, moving a maximised window even one pixel in any one direction was enough to cause wmaker to forget the original dimensions and make restoring to them impossible. I imagine that most people would ask "but why would you want to do that?" in response to the idea of moving a fully-maximised window around but consider that a Maximusized, half- or corner-maximised window is also "maximised" as far as wmaker is concerned, and moving them is more intuitively reasonable. In fact I fairly often find myself moving "really" maximised windows about as well. As an example, a particularly naughty website doesn't quite render in my (small) Firefox window. Maximise Firefox. Now I can see the content but I can't see the email underneath where a colleague was asking me to look at the page. Move Firefox about. Now I can see. Now I've finished. Hit the shortcut key and Firefox bounces back to the position and size it was before. On balance I found it less annoying and illogical to have moveable maximised windows than to have windows which could be maximimised and never restored. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.
If a user moves a window which is currently maximized, the current behavior is
to keep the window geometry and maximized status unchanged. This can lead to
peculiar behavior. For example, suppose a user maximizes a window to the
right half of the screen (either through the window menu, keyboard shortcut, or
new snapping feature), then moves it, and then attempts maximize it to the
right half of the screen again. Instead of the expected result, the window is
unmaximized and returned to its original geometry.
This patch changes the behavior by clearing the maximization flag when a
maximized window is moved. Then, when a window is maximized and then moved, it
can be maximized again without issues.
---
src/moveres.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/moveres.c b/src/moveres.c
index 6899a86..64dc50c 100644
--- a/src/moveres.c
+++ b/src/moveres.c
@@ -1723,6 +1723,11 @@ int wMouseMoveWindow(WWindow * wwin, XEvent * ev)
} else if (abs(ev->xmotion.x_root -
event.xmotion.x_root) >= MOVE_THRESHOLD
|| abs(ev->xmotion.y_root -
event.xmotion.y_root) >= MOVE_THRESHOLD) {
+ if (wwin->flags.maximized) {
+ wwin->flags.maximized = 0;
+ wwin->flags.old_maximized = 0;
+ }
+
XChangeActivePointerGrab(dpy, ButtonMotionMask
| ButtonReleaseMask |
ButtonPressMask,
wPreferences.cursor[WCUR_MOVE], CurrentTime);
--
1.9.1
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
