RE: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency
> > From: Carlos R. Mafra [crma...@gmail.com] > Sent: Monday, January 05, 2015 9:39 AM > To: wmaker-dev@lists.windowmaker.org > Subject: Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for > consistency > > > I suppose not too many programs use the library anyway. Do you know > > > any? > > > > WPrefs? Ok, that was an easy one ;-) > > > > I don't think there are a lot of app left, but on the other hand the > > change would impact apps that use only WUtil, not WINGs, and that's > > probably even less... > There's wdm, I've just realized. On Debian-based systems, a reverse dependency lookup on the library packages reveals two more: wmforecast (which I maintain and can easily update) and fookb-wmaker (which depends on WUtil but not WINGs). Doug -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency
Carlos R. Mafra schreef: There's wdm, I've just realized. wdm stopped working for me in my openSUSE a long time ago (probably because of systemd but I'm not sure). I'd like to ask if anyone is using it currently in a modern distro, but I think that unless wdm development comes back and we could somehow synchronize changes to both wmaker and wdm, we cannot really break binary compatibility right now. I'd really like to use wdm myself, so if there are people out there using it I'd like to know. I'm using it on 2 PC's at home. It's still available, and works fine in Gentoo Linux, although the package seems unmaintaned upstream (http://voins.program.ru/wdm/ is offline for some years maybe). I'm using OpenRC. These are the libs it depends on: # readelf -d /usr/bin/wdm Dynamic section at offset 0x15db8 contains 35 entries: TagType Name/Value 0x0001 (NEEDED) Shared library: [libcrypt.so.1] 0x0001 (NEEDED) Shared library: [libX11.so.6] 0x0001 (NEEDED) Shared library: [libWUtil.so.5] 0x0001 (NEEDED) Shared library: [libpam.so.0] 0x0001 (NEEDED) Shared library: [libXmu.so.6] 0x0001 (NEEDED) Shared library: [libXau.so.6] 0x0001 (NEEDED) Shared library: [libXdmcp.so.6] 0x0001 (NEEDED) Shared library: [libc.so.6] (...) # readelf -d /usr/bin/wdmLogin Dynamic section at offset 0x7dd8 contains 33 entries: TagType Name/Value 0x0001 (NEEDED) Shared library: [libX11.so.6] 0x0001 (NEEDED) Shared library: [libXinerama.so.1] 0x0001 (NEEDED) Shared library: [libWINGs.so.3] 0x0001 (NEEDED) Shared library: [libWUtil.so.5] 0x0001 (NEEDED) Shared library: [libwraster.so.5] 0x0001 (NEEDED) Shared library: [libc.so.6] (...) -- [alwin] -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency
On Mon, 5 Jan 2015 at 16:10:50 +0100, Christophe wrote: > - Carlos R. Mafra a écrit : > > On Mon, 5 Jan 2015 at 11:06:32 +0100, Christophe CURIS wrote: > > > For historical reason, some functions defined in WINGs.h are actually > > > compiled into the WUtil.so library. Although it would be better to compile > > > them in the appropriate library instead (and fix the code accordingly to > > > make it work), this would break the binary compatibility. > > > > I think you could try the better approach you mentioned above since > > I suppose not too many programs use the library anyway. Do you know > > any? > > WPrefs? Ok, that was an easy one ;-) > > I don't think there are a lot of app left, but on the other hand the > change would impact apps that use only WUtil, not WINGs, and that's > probably even less... There's wdm, I've just realized. wdm stopped working for me in my openSUSE a long time ago (probably because of systemd but I'm not sure). I'd like to ask if anyone is using it currently in a modern distro, but I think that unless wdm development comes back and we could somehow synchronize changes to both wmaker and wdm, we cannot really break binary compatibility right now. I'd really like to use wdm myself, so if there are people out there using it I'd like to know. > Will see what I can do (I already started to look at it, but stopped > considereing the compatibility break). > > Patch 1 and 2 are still valid, though... Already applied, will wait a bit till the dust settles to apply the rest. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency
- Carlos R. Mafra a écrit : > On Mon, 5 Jan 2015 at 11:06:32 +0100, Christophe CURIS wrote: > > For historical reason, some functions defined in WINGs.h are actually > > compiled into the WUtil.so library. Although it would be better to compile > > them in the appropriate library instead (and fix the code accordingly to > > make it work), this would break the binary compatibility. > > I think you could try the better approach you mentioned above since > I suppose not too many programs use the library anyway. Do you know > any? WPrefs? Ok, that was an easy one ;-) I don't think there are a lot of app left, but on the other hand the change would impact apps that use only WUtil, not WINGs, and that's probably even less... Will see what I can do (I already started to look at it, but stopped considereing the compatibility break). Patch 1 and 2 are still valid, though... -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency
On Mon, 5 Jan 2015 at 11:06:32 +0100, Christophe CURIS wrote: > For historical reason, some functions defined in WINGs.h are actually > compiled into the WUtil.so library. Although it would be better to compile > them in the appropriate library instead (and fix the code accordingly to > make it work), this would break the binary compatibility. I think you could try the better approach you mentioned above since I suppose not too many programs use the library anyway. Do you know any? -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency
For historical reason, some functions defined in WINGs.h are actually
compiled into the WUtil.so library. Although it would be better to compile
them in the appropriate library instead (and fix the code accordingly to
make it work), this would break the binary compatibility.
This patch moves the declaration from WINGs.h to the WUtil.h header to be
consistent with what is really done; This will not break backward
compatibility because WINGs.h starts by including the WUtil.h header, so on
source side it is equivalent.
Versions for WUtil and WINGs are, of course, not changed then as the whole
purpose of this patch is to keep both source and binary compatibility.
Signed-off-by: Christophe CURIS
---
WINGs/WINGs/WINGs.h | 17 +
WINGs/WINGs/WUtil.h | 23 +++
2 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/WINGs/WINGs/WINGs.h b/WINGs/WINGs/WINGs.h
index 4798174..7760431 100644
--- a/WINGs/WINGs/WINGs.h
+++ b/WINGs/WINGs/WINGs.h
@@ -26,7 +26,7 @@
#include
#include
-#define WINGS_H_VERSION 20141205
+#define WINGS_H_VERSION 20141220
#ifdef __cplusplus
@@ -639,21 +639,6 @@ WMRect wmkrect(int x, int y, unsigned int width, unsigned
int height);
#define wmkpoint(x, y) (WMPoint){(x), (y)}
#endif
-/* ---[ WINGs/wapplication.c ] */
-
-
-void WMInitializeApplication(const char *applicationName, int *argc, char
**argv);
-
-/* You're supposed to call this funtion before exiting so WINGs can terminate
properly */
-void WMReleaseApplication(void);
-
-void WMSetResourcePath(const char *path);
-
-/* don't free the returned string */
-char* WMGetApplicationName(void);
-
-/* Try to locate resource file. ext may be NULL */
-char* WMPathForResourceOfType(const char *resource, const char *ext);
/* ---[ WINGs/widgets.c ]- */
diff --git a/WINGs/WINGs/WUtil.h b/WINGs/WINGs/WUtil.h
index 04e1197..e312c92 100644
--- a/WINGs/WINGs/WUtil.h
+++ b/WINGs/WINGs/WUtil.h
@@ -298,6 +298,29 @@ void wutil_shutdown(void);
void wusleep(unsigned int usec);
+
+/* ---[ WINGs/wapplication.c ] */
+
+/*
+ * Conceptually, these functions should be part of WINGs, not WUtil, but for
+ * historical reason they have been compiled into WUtil, so to avoid beaking
+ * binary compatibility we keep them here
+ */
+
+void WMInitializeApplication(const char *applicationName, int *argc, char
**argv);
+
+/* You're supposed to call this funtion before exiting so WINGs can terminate
properly */
+void WMReleaseApplication(void);
+
+void WMSetResourcePath(const char *path);
+
+/* don't free the returned string */
+char* WMGetApplicationName(void);
+
+/* Try to locate resource file. ext may be NULL */
+char* WMPathForResourceOfType(const char *resource, const char *ext);
+
+
/* ---[ WINGs/handlers.c ] */
/* Event handlers: timer, idle, input */
--
2.1.4
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
