Re: [repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.94.0-crm-305-ga750fe0

[Ambrus Szabo]

On Sat, 2 Apr 2011, Carlos R. Mafra wrote:


On Sat,  2 Apr 2011 at 12:03:54 +0200, Tamas TEVESZ wrote:

On Wed, 30 Mar 2011, crmafra wrote:

 commit a750fe03f424cf47e4f7aa462fd24e9b38c4d196
 Author: Ambrus Szabo don...@donamo.hu
 Date:   Wed Mar 30 00:06:18 2011 +0200

 opaque resize

 WPrefs:
  WindowHandling page: Mouse opaque resize
  Expert page: Opaque move and resize with keyboard

i may be missing the forest, but what again is the reason for making
the keyboard one separate option?


Yeah, I'd prefer only one option to control the opaqueness for both
mouse and keyboard.



Opeque means, don't draw frame around the window, but redraw the window at 
the new position.

With mouse, either move or resize, no problem. Because:
 - Mouse move and opaquemove, no draw frame.
 - Mouse move and noopaquemove, draw frame.
 - Mouse resize and opaqueresize, no draw frame.
 - Mouse resuze and noopaqueresuze, draw frame.

With keyboard, move and resize are one operation. The problem:
 - Keyboard Resize/Move and opaquemove and opaqueresize,  no draw frame,
 - Keyboard Resize/Move and noopaquemove and noopaqueresize, draw frame
 - Keyboard Resize/Move and noopaquemove and opaqueresize, ???
 - Keyboard Resize/Move and opaquemove and noopaqueresize, ???

The are three solution:

1., only one button. (all Opaque enabled/disabled)

2., two button, Opaq resize and Opaq mouse, but what should happen 
when using keyboard?

 - if all button true, then opaque resize/mouse
 - if any button true then opaque resize/mouse

3., three button. (current solution) 2 mouse, 1 keyboard
 - i  move to with keyboard  options from expert panel to  Window 
Handling preferences panel





--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.94.0-crm-305-ga750fe0

[crmafra]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.

The branch, next has been updated
   via  a750fe03f424cf47e4f7aa462fd24e9b38c4d196 (commit)
  from  8fd4821155e19f5e659b05a756ac308fc052b323 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/a750fe03f424cf47e4f7aa462fd24e9b38c4d196

commit a750fe03f424cf47e4f7aa462fd24e9b38c4d196
Author: Ambrus Szabo don...@donamo.hu
Date:   Wed Mar 30 00:06:18 2011 +0200

opaque resize

WPrefs:
 WindowHandling page: Mouse opaque resize
 Expert page: Opaque move and resize with keyboard

diff --git a/WPrefs.app/Expert.c b/WPrefs.app/Expert.c
index 5ef14a9..e86480d 100644
--- a/WPrefs.app/Expert.c
+++ b/WPrefs.app/Expert.c
@@ -31,7 +31,7 @@ typedef struct _Panel {
 
WMWidget *parent;
 
-   WMButton *swi[12];
+   WMButton *swi[13];
 
 } _Panel;
 
@@ -53,6 +53,7 @@ static void showData(_Panel * panel)
WMSetButtonSelected(panel-swi[9], GetBoolForKey(ShowClipTitle));
WMSetButtonSelected(panel-swi[10], 
GetBoolForKey(BounceAppIconsWhenUrgent));
WMSetButtonSelected(panel-swi[11], 
GetBoolForKey(RaiseAppIconsWhenBouncing));
+   WMSetButtonSelected(panel-swi[12], 
GetBoolForKey(OpaqueMoveResizeKeyboard));
 }
 
 static void createPanel(Panel * p)
@@ -95,6 +96,7 @@ static void createPanel(Panel * p)
WMSetButtonText(panel-swi[9], _(Show workspace title on Clip.));
WMSetButtonText(panel-swi[10], _(Bounce AppIcons when the application 
wants attention.));
WMSetButtonText(panel-swi[11], _(Raise AppIcons when bouncing.));
+   WMSetButtonText(panel-swi[12], _(Opaque Move,Resize with keyboard.));
 
/* If the item is default true, enable the button here */
WMSetButtonEnabled(panel-swi[6], True);
@@ -126,6 +128,7 @@ static void storeDefaults(_Panel * panel)
SetBoolForKey(WMGetButtonSelected(panel-swi[9]), ShowClipTitle);
SetBoolForKey(WMGetButtonSelected(panel-swi[10]), 
BounceAppIconsWhenUrgent);
SetBoolForKey(WMGetButtonSelected(panel-swi[11]), 
RaiseAppIconsWhenBouncing);
+   SetBoolForKey(WMGetButtonSelected(panel-swi[12]), 
OpaqueMoveResizeKeyboard);
 }
 
 Panel *InitExpert(WMScreen * scr, WMWidget * parent)
diff --git a/WPrefs.app/WindowHandling.c b/WPrefs.app/WindowHandling.c
index 39d2b7d..88b5fef 100644
--- a/WPrefs.app/WindowHandling.c
+++ b/WPrefs.app/WindowHandling.c
@@ -59,6 +59,8 @@ typedef struct _Panel {
WMFrame *opaqF;
WMButton *opaqB;
 
+   WMButton *opaqresizeB;
+
WMFrame *tranF;
WMButton *tranB;
 } _Panel;
@@ -69,6 +71,10 @@ typedef struct _Panel {
 
 #define NON_OPAQUE_MOVE_PIXMAP nonopaque
 
+#define OPAQUE_RESIZE_PIXMAP opaqueresize
+
+#define NON_OPAQUE_RESIZE_PIXMAP noopaqueresize
+
 #define THUMB_SIZE 16
 
 static char *placements[] = {
@@ -190,6 +196,8 @@ static void showData(_Panel * panel)
 
WMSetButtonSelected(panel-opaqB, GetBoolForKey(OpaqueMove));
 
+   WMSetButtonSelected(panel-opaqresizeB, GetBoolForKey(OpaqueResize));
+
WMSetButtonSelected(panel-miconB, GetBoolForKey(NoWindowOverIcons));
 
WMSetButtonSelected(panel-mdockB, GetBoolForKey(NoWindowOverDock));
@@ -208,6 +216,7 @@ static void storeData(_Panel * panel)
SetBoolForKey(WMGetButtonSelected(panel-miconB), NoWindowOverIcons);
SetBoolForKey(WMGetButtonSelected(panel-mdockB), NoWindowOverDock);
SetBoolForKey(WMGetButtonSelected(panel-opaqB), OpaqueMove);
+   SetBoolForKey(WMGetButtonSelected(panel-opaqresizeB), OpaqueResize);
SetBoolForKey(WMGetButtonSelected(panel-tranB), 
OpenTransientOnOwnerWorkspace);
SetStringForKey(placements[WMGetPopUpButtonSelectedItem(panel-placP)], 
WindowPlacement);
sprintf(x, %i, WMGetSliderValue(panel-hsli));
@@ -317,19 +326,19 @@ static void createPanel(Panel * p)
 
WMMapSubwidgets(panel-placF);
 
-/** Opaque Move ***/
+/** Opaque Move, Resize ***/
panel-opaqF = WMCreateFrame(hbox);
WMMapWidget(panel-opaqF);
-   WMAddBoxSubview(hbox, WMWidgetView(panel-opaqF), False, True, 110, 0, 
0);
+   WMAddBoxSubview(hbox, WMWidgetView(panel-opaqF), False, True, 122, 0, 
0);
 
-   WMSetFrameTitle(panel-opaqF, _(Opaque Move));
-   WMSetBalloonTextForView(_(Whether the window contents should be movedn
- when dragging windows aroung or if only an
- frame should be displayed.n), 
WMWidgetView(panel-opaqF));
+   WMSetFrameTitle(panel-opaqF, _(Opaque Move/Resize));
+   WMSetBalloonTextForView(_(Whether the window