Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Monday 2015-08-24 05:35:05 Rodolfo García Peñas wrote: > Quoting Josip Deanovic : > > I have compiled a newest version and tested every combination I could > > think of and works fine. > > > > No crash any more, feature works as expected. > > > > I would say that we can close this case. > > Thanks Josip, Thank you for the effort and the time. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
Quoting Josip Deanovic : On Sunday 2015-08-23 22:21:59 Carlos R. Mafra wrote: It is there now. I have compiled a newest version and tested every combination I could think of and works fine. No crash any more, feature works as expected. I would say that we can close this case. Thanks Josip, Regards, kix Rodolfo García Peñas (kix) http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sun, 23 Aug 2015 at 23:38:08 +0200, Josip Deanovic wrote: > On Sunday 2015-08-23 22:21:59 Carlos R. Mafra wrote: > > It is there now. > > I have compiled a newest version and tested every combination I could > think of and works fine. > > No crash any more, feature works as expected. > > I would say that we can close this case. Great, thanks to both of you. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 22:21:59 Carlos R. Mafra wrote: > It is there now. I have compiled a newest version and tested every combination I could think of and works fine. No crash any more, feature works as expected. I would say that we can close this case. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 22:21:59 Carlos R. Mafra wrote: > > Ok, where can I get the newest change? I didn't notice any patch > > attached. > It is there now. Ok, I'll test it now. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sun, 23 Aug 2015 at 23:09:59 +0200, Josip Deanovic wrote: > On Sunday 2015-08-23 22:06:30 Carlos R. Mafra wrote: > > On Sun, 23 Aug 2015 at 21:28:02 +0200, Josip Deanovic wrote: > > > On Sunday 2015-08-23 18:58:01 Rodolfo García Peñas wrote: > > > > Solved. > > > > > > > > Thanks for your report. > > > > > > Thank you for the effort. > > > > > > I have just tested the code from the fresh next branch and > > > the issue still exist (Windowmaker crashes and restarts). > > > > But the #next branch doesn't contain Rodolfo's patches yet. > > He, he, that might be the source of the problem. :-) > > Ok, where can I get the newest change? I didn't notice any patch attached. It is there now. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 22:06:30 Carlos R. Mafra wrote: > On Sun, 23 Aug 2015 at 21:28:02 +0200, Josip Deanovic wrote: > > On Sunday 2015-08-23 18:58:01 Rodolfo García Peñas wrote: > > > Solved. > > > > > > Thanks for your report. > > > > Thank you for the effort. > > > > I have just tested the code from the fresh next branch and > > the issue still exist (Windowmaker crashes and restarts). > > But the #next branch doesn't contain Rodolfo's patches yet. He, he, that might be the source of the problem. :-) Ok, where can I get the newest change? I didn't notice any patch attached. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sun, 23 Aug 2015 at 21:28:02 +0200, Josip Deanovic wrote: > On Sunday 2015-08-23 18:58:01 Rodolfo García Peñas wrote: > > Solved. > > > > Thanks for your report. > > Thank you for the effort. > > I have just tested the code from the fresh next branch and > the issue still exist (Windowmaker crashes and restarts). But the #next branch doesn't contain Rodolfo's patches yet. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 20:17:08 Rodolfo García Peñas wrote: > Thanks, > > I will continue with this problem tomorrow. I think I know the > problem, but I need do a deep analysis. Ok, thank you. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
Quoting Josip Deanovic : On Sunday 2015-08-23 20:02:58 Rodolfo García Peñas wrote: Quoting Josip Deanovic : > On Sunday 2015-08-23 18:58:01 Rodolfo García Peñas wrote: >> Solved. >> >> Thanks for your report. > > Thank you for the effort. > > I have just tested the code from the fresh next branch and > the issue still exist (Windowmaker crashes and restarts). Using the same steps? Yes. I have even relog (not just restart) to make sure that wmaker has been completely restarted. Thanks, I will continue with this problem tomorrow. I think I know the problem, but I need do a deep analysis. Regards, kix. Rodolfo García Peñas (kix) http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 20:02:58 Rodolfo García Peñas wrote: > Quoting Josip Deanovic : > > On Sunday 2015-08-23 18:58:01 Rodolfo García Peñas wrote: > >> Solved. > >> > >> Thanks for your report. > > > > Thank you for the effort. > > > > I have just tested the code from the fresh next branch and > > the issue still exist (Windowmaker crashes and restarts). > > Using the same steps? Yes. I have even relog (not just restart) to make sure that wmaker has been completely restarted. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
Quoting Josip Deanovic : On Sunday 2015-08-23 18:58:01 Rodolfo García Peñas wrote: Solved. Thanks for your report. Thank you for the effort. I have just tested the code from the fresh next branch and the issue still exist (Windowmaker crashes and restarts). Using the same steps? Rodolfo García Peñas (kix) http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 18:58:01 Rodolfo García Peñas wrote: > Solved. > > Thanks for your report. Thank you for the effort. I have just tested the code from the fresh next branch and the issue still exist (Windowmaker crashes and restarts). -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
Josip Deanovic escribió: On Sunday 2015-08-23 18:32:06 Rodolfo García Peñas wrote: Hi Josip, confirmed, I am working on it. Thanks Cool. Thank you. Solved. Thanks for your report. kix Rodolfo García Peñas (kix) http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 18:32:06 Rodolfo García Peñas wrote: > Hi Josip, > > confirmed, I am working on it. > > Thanks Cool. Thank you. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
Josip Deanovic escribió: Josip DeanovicOn Sunday 2015-08-23 19:25:32 wrote: On Sunday 2015-08-23 18:04:37 Carlos R. Mafra wrote: > Josip, the patch should fix the issue and it's in the #next > branch already. Would you mind testing it? I'll test it in the next 30 minutes. Ok, I have tested it and I can confirm that feature now works but while testing it I have encountered undesirable issues such as windowmaker crash and restart. So this is the procedure I used while testing: 1. I am using kwrite application for my tests 2. Start kwrite application on the command line 3. Checking Application Specific window attributes - No application icon - unselected - Shared application icon - selected 4. Drag the application icon to the dock 5. Enable (select) the option No application icon for the application 6. Close the application and run multiple instances of the application using double-click on the docked icon - everything works fine 7. In the application Specific menu disable (unselect) the option No application icon - windowmaker crashes and restarts -- Josip Deanovic Hi Josip, confirmed, I am working on it. Thanks Rodolfo García Peñas (kix) http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 18:48:27 Carlos R. Mafra wrote: > Perhaps it would be better to not even have an option for this, > it should always be possible to execute a docked app multiple times. It already is but only if you use right click and Launch menu option. Double-click has different behavior based on whether the "No application icon" is enabled or not for a specific application. I have checked and described the behavior thoroughly in the thread with the subject: "Double-click on application in wmdock does not launch the application if one instance is already running" > And indeed, one needs to think about what to do with the appicons. > Perhaps just silently behaving as "no appicon" is set starting from > the second instance, I don't know. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sun, 23 Aug 2015 at 19:25:32 +0200, Josip Deanovic wrote: > On Sunday 2015-08-23 18:04:37 Carlos R. Mafra wrote: > > On Sun, 23 Aug 2015 at 18:16:32 +0200, Josip Deanovic wrote: > > > On Sunday 2015-08-23 15:41:04 Rodolfo García Peñas wrote: > > > > Hi Josip, > > > > > > > > thanks for your report. Sorry about that. Patch is attached. > > > > Thank you, Rodolfo. > > Yes, thank you from me too. > > > Josip, the patch should fix the issue and it's in the #next > > branch already. Would you mind testing it? > > I'll test it in the next 30 minutes. > > > > > Perhaps we should use a different flag to run the application more > > > > times from the same dock icon. > > > > > > I have no objections to that as long as that feature exists and the > > > option is intuitive and logical and doesn't break anything else. :-) > > > > Note that the issue you found is not intuitive nor logical :-) > > I didn't find it, my friend pointed it to me and I somehow still > remembered that feature from like 20 years ago so I needed to inspect > it to confirm that it actually stopped working few years ago. > > Anyway I didn't put that feature there but it's handy. :-) > > > There is no reason why the setting of the "No application icon" should > > have an effect on being able to execute multiple instances of a docked > > application. The "No application icon" option should control just the > > application icon, nothing else. > > I agree. > > > So what Rodolfo did originally was correct -- he enforced the behavior > > that the option stands for. The "execute multiple instances" happened > > to work before by chance. > > > > But nevermind, a regression is a regression and thank you for > > reporting it multiple times; it should work again with the latest > > patch but ideally this behavior should not be coupled with this > > particular option. > > It would be nice to decouple them then. > It would help to avoid loosing the feature in the future. > I would suggest adding another option to the Application Specific > menu of the Window attributes window. > > There is a plenty of space there and the only thing that is left > to discuss in that case is whether this option should work only in > case application icons are disabled for the specific docked application > or always. > > If the option is allowed to be activated even if the application icon > is not disabled that could produce some confusion. > So in my opinion, ideally the new option should be inactive > (disabled/grayed-out) unless the "No application icon" is selected. > And by default the new option should be disabled (unselected) by default. Perhaps it would be better to not even have an option for this, it should always be possible to execute a docked app multiple times. And indeed, one needs to think about what to do with the appicons. Perhaps just silently behaving as "no appicon" is set starting from the second instance, I don't know. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
Josip DeanovicOn Sunday 2015-08-23 19:25:32 wrote: > On Sunday 2015-08-23 18:04:37 Carlos R. Mafra wrote: > > Josip, the patch should fix the issue and it's in the #next > > branch already. Would you mind testing it? > > I'll test it in the next 30 minutes. Ok, I have tested it and I can confirm that feature now works but while testing it I have encountered undesirable issues such as windowmaker crash and restart. So this is the procedure I used while testing: 1. I am using kwrite application for my tests 2. Start kwrite application on the command line 3. Checking Application Specific window attributes - No application icon - unselected - Shared application icon - selected 4. Drag the application icon to the dock 5. Enable (select) the option No application icon for the application 6. Close the application and run multiple instances of the application using double-click on the docked icon - everything works fine 7. In the application Specific menu disable (unselect) the option No application icon - windowmaker crashes and restarts -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: Regression fix (was Re: Question about menus (usermenu, appmenu))
On Sunday 2015-08-23 18:04:37 Carlos R. Mafra wrote: > On Sun, 23 Aug 2015 at 18:16:32 +0200, Josip Deanovic wrote: > > On Sunday 2015-08-23 15:41:04 Rodolfo García Peñas wrote: > > > Hi Josip, > > > > > > thanks for your report. Sorry about that. Patch is attached. > > Thank you, Rodolfo. Yes, thank you from me too. > Josip, the patch should fix the issue and it's in the #next > branch already. Would you mind testing it? I'll test it in the next 30 minutes. > > > Perhaps we should use a different flag to run the application more > > > times from the same dock icon. > > > > I have no objections to that as long as that feature exists and the > > option is intuitive and logical and doesn't break anything else. :-) > > Note that the issue you found is not intuitive nor logical :-) I didn't find it, my friend pointed it to me and I somehow still remembered that feature from like 20 years ago so I needed to inspect it to confirm that it actually stopped working few years ago. Anyway I didn't put that feature there but it's handy. :-) > There is no reason why the setting of the "No application icon" should > have an effect on being able to execute multiple instances of a docked > application. The "No application icon" option should control just the > application icon, nothing else. I agree. > So what Rodolfo did originally was correct -- he enforced the behavior > that the option stands for. The "execute multiple instances" happened > to work before by chance. > > But nevermind, a regression is a regression and thank you for > reporting it multiple times; it should work again with the latest > patch but ideally this behavior should not be coupled with this > particular option. It would be nice to decouple them then. It would help to avoid loosing the feature in the future. I would suggest adding another option to the Application Specific menu of the Window attributes window. There is a plenty of space there and the only thing that is left to discuss in that case is whether this option should work only in case application icons are disabled for the specific docked application or always. If the option is allowed to be activated even if the application icon is not disabled that could produce some confusion. So in my opinion, ideally the new option should be inactive (disabled/grayed-out) unless the "No application icon" is selected. And by default the new option should be disabled (unselected) by default. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
