[X2Go-Dev] Updated XFCE wiki section: "No workarounds required"
Hi, I just want to let you all know I updated the wiki section of "Always compatible - No workarounds required" for XFCE (spoiler, a workaround is required): https://wiki.x2go.org/doku.php/doc:de-compat#always_compatible_and_no_workarounds_required So, XFCE actually needs a workaround now due to a compositor issue with either XFCE or X2Go, see ticket in xfwm4 project: https://gitlab.xfce.org/xfce/xfwm4/-/issues/551 Wiki Diff: https://wiki.x2go.org/doku.php/doc:de-compat?do=diff&rev2%5B0%5D=1595856306&rev2%5B1%5D=1632346422&difftype=sidebyside So you know :)... Regards, Melroy van den Berg melro...@pm.me___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] GitLab Install LXC - Update (issue)
Hi Uli and the rest, I know that Stefan has some personal issues several months ago. Hopefully he is able to push GitLab towards production and have everybody aligned. I'm ready when you are. See the wiki page for the work packages I identified so far: https://wiki.x2go.org/doku.php/wiki:development:gitlab There is one issue... I noticed that the server is down? https://gitlab.x2go.org/ I was also unable to ping 188.40.111.169. Which is not a good sign?... somebody? Regards, Melroy van den Berg melro...@pm.me ‐‐‐ Original Message ‐‐‐ Op donderdag, april 1, 2021 1:59 PM, Ulrich Sibiller schreef: > Hi, > > any progress on this? > > Uli > > On Tue, Jul 14, 2020 at 6:58 PM Melroy van den Berg > melro...@protonmail.com wrote: > > > Hi Mike and others, > > The latest state is that the installation is indeed working except the > > httpS (SSL) by Let's Encrypt. For some reason the installation fails to > > authenticate/verify itself correctly to the Let's encrypt server. Normally > > this works fine, and you will get a free Let's Encrypt certificate that is > > used by GitLab instance. > > For now the instance is using a self-signed certificate (which is not > > ideal). > > You can execute: 'gitlab-ctl reconfigure' on the VM to trigger a > > certificate deployment of Let's Encrypt. > > Maybe somebody knows why is goes wrong in this VM? > > More info: https://docs.gitlab.com/omnibus/settings/ssl.html > > Off-topic: Too bad I also hurt by wrist, so that is why I take it a bit > > easy now. > > Sorry about that, a wrist injury is taking some time to heal again. :\ > > Kind regards, > > Melroy van den Berg > > ‐‐‐ Original Message ‐‐‐‐‐‐‐ > > Op dinsdag, juli 7, 2020 11:06 PM, Mike Gabriel > > mike.gabr...@das-netzwerkteam.de schreef: > > > > > HI Melroy, > > > On Di 09 Jun 2020 23:01:24 CEST, Melroy van den Berg wrote: > > > > > > > Hi, > > > > I just discovered that GitLab tries to also set the following during > > > > > "sysctl -e --system" command: > > > > cat /etc/sysctl.d/90-omnibus-gitlab-kernel.sem.conf > > > > kernel.sem = 250 32000 32 262 > > > > And also: > > > > cat /etc/sysctl.d/protect-links.conf > > > > ### > > > > Protected links > > > > > > > > == > > > > Protects against creating or following links under certain conditions > > > > == > > > > Debian kernels have both set to 1 (restricted) > > > > === > > > > See https://www.kernel.org/doc/Documentation/sysctl/fs.txt > > > > === > > > > fs.protected_hardlinks = 1 > > > > fs.protected_symlinks = 1 > > > > You maybe want to change this as well in the host & container? > > > > I disabled the command "reload all sysctrl conf" for now in in the > > > > > GitLab recipes (Ruby code): > > > > /opt/gitlab/embedded/cookbooks/package/recipes/sysctl.rb > > > > As well as, I commented-out where "reload all sysctrl conf" is used in: > > > > /opt/gitlab/embedded/cookbooks/package/resources/gitlab_sysctl.rb > > > > I will create a GitLab issue or comment on an existing GitLab issue > > > > > regarding support LXC containers without this much hassle. > > > > Next issue I'm facing is regarding Let's Encrypt. But the terminal > is > > > > now in use by somebody else... > > > > Regards, > > > > Melroy van den Berg > > > > > > I haven't got back to your mail, I am sorry. > > > Unfortunately, the host hosting gitlab.x2go.org has been taken offline by > > > the provide due to some NIC misconfiguration. We are investigating on > > > that. > > > I'd like to use gitlab.x2go.org starting next week for some new projects > > > related to X2Go. Melroy, do you think the system is already usable (once > > > it's online again)? > > > Sorry, for having not followed up on your work, but I was really busy the > > > last bit of June. > > > Mike > > > > > > DAS-NETZWERKTEAM > > > c\o Technik- und Ökologiezentrum Eckernförde > > > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde > > > mobile: +49 (1520) 1976 148 > > > landline: +49 (4351) 850 8940 > > > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 > > > mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de > > > > x2go-dev mailing list > > x2go-dev@lists.x2go.org > > https://lists.x2go.org/listinfo/x2go-dev ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] GitLab Install LXC - Update (issue)
Hi Mike and others, The latest state is that the installation is indeed working except the httpS (SSL) by Let's Encrypt. For some reason the installation fails to authenticate/verify itself correctly to the Let's encrypt server. Normally this works fine, and you will get a free Let's Encrypt certificate that is used by GitLab instance. For now the instance is using a self-signed certificate (which is not ideal). You can execute: 'gitlab-ctl reconfigure' on the VM to trigger a certificate deployment of Let's Encrypt. Maybe somebody knows why is goes wrong in this VM? More info: https://docs.gitlab.com/omnibus/settings/ssl.html Off-topic: Too bad I also hurt by wrist, so that is why I take it a bit easy now. Sorry about that, a wrist injury is taking some time to heal again. :\ Kind regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op dinsdag, juli 7, 2020 11:06 PM, Mike Gabriel schreef: > HI Melroy, > > On Di 09 Jun 2020 23:01:24 CEST, Melroy van den Berg wrote: > > > Hi, > > I just discovered that GitLab tries to also set the following during > > > "sysctl -e --system" command: > > cat /etc/sysctl.d/90-omnibus-gitlab-kernel.sem.conf > > kernel.sem = 250 32000 32 262 > > And also: > > cat /etc/sysctl.d/protect-links.conf > > ### > > > > Protected links > > > > > > > > == > > > > Protects against creating or following links under certain conditions > > > > == > > > > Debian kernels have both set to 1 (restricted) > > > > === > > > > See https://www.kernel.org/doc/Documentation/sysctl/fs.txt > > > > === > > > > fs.protected_hardlinks = 1 > > fs.protected_symlinks = 1 > > You maybe want to change this as well in the host & container? > > I disabled the command "reload all sysctrl conf" for now in in the > GitLab > > recipes (Ruby code): > > /opt/gitlab/embedded/cookbooks/package/recipes/sysctl.rb > > As well as, I commented-out where "reload all sysctrl conf" is used in: > > /opt/gitlab/embedded/cookbooks/package/resources/gitlab_sysctl.rb > > I will create a GitLab issue or comment on an existing GitLab issue > > > regarding support LXC containers without this much hassle. > > Next issue I'm facing is regarding Let's Encrypt. But the terminal > is now > > in use by somebody else... > > Regards, > > Melroy van den Berg > > I haven't got back to your mail, I am sorry. > > Unfortunately, the host hosting gitlab.x2go.org has been taken offline by the > provide due to some NIC misconfiguration. We are investigating on that. > > I'd like to use gitlab.x2go.org starting next week for some new projects > related to X2Go. Melroy, do you think the system is already usable (once it's > online again)? > > Sorry, for having not followed up on your work, but I was really busy the > last bit of June. > > Mike > > > > DAS-NETZWERKTEAM > c\o Technik- und Ökologiezentrum Eckernförde > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde > mobile: +49 (1520) 1976 148 > landline: +49 (4351) 850 8940 > > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 > mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] GitLab Install LXC - Update (issue)
Hi, I just discovered that GitLab tries to also set the following during "sysctl -e --system" command: cat /etc/sysctl.d/90-omnibus-gitlab-kernel.sem.conf kernel.sem = 250 32000 32 262 And also: cat /etc/sysctl.d/protect-links.conf ### # Protected links # # Protects against creating or following links under certain conditions # Debian kernels have both set to 1 (restricted) # See https://www.kernel.org/doc/Documentation/sysctl/fs.txt fs.protected_hardlinks = 1 fs.protected_symlinks = 1 You maybe want to change this as well in the host & container? I disabled the command "reload all sysctrl conf" for now in in the GitLab recipes (Ruby code): /opt/gitlab/embedded/cookbooks/package/recipes/sysctl.rb As well as, I commented-out where "reload all sysctrl conf" is used in: /opt/gitlab/embedded/cookbooks/package/resources/gitlab_sysctl.rb I will create a GitLab issue or comment on an existing GitLab issue regarding support LXC containers without this much hassle. Next issue I'm facing is regarding Let's Encrypt. But the terminal is now in use by somebody else... Regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op dinsdag, juni 9, 2020 5:56 AM, Mike Gabriel schreef: > On Di 09 Jun 2020 01:11:48 CEST, Melroy van den Berg wrote: > > > But I rather like to get this working in a correct manner. > > Maybe somebody add at this shmmax statement above to the host > > > /etc/sysctl.conf file? > > Done + echo'ed to /proc/sys/kernel/shmmax. > > Mike > > --- > > DAS-NETZWERKTEAM > c\o Technik- und Ökologiezentrum Eckernförde > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde > mobile: +49 (1520) 1976 148 > landline: +49 (4351) 850 8940 > > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 > mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] GitLab Install LXC - Update (issue)
Hi all, I tried to omnibus GitLab install on the VM. Failed on: Expected process to exit with [0], but received '255' Begin output of sysctl -e -p /opt/gitlab/embedded/etc/90-omnibus-gitlab-kernel.shmmax.conf STDOUT: STDERR: sysctl: setting key "kernel.shmmax": Read-only file system End output of sysctl -e -p /opt/gitlab/embedded/etc/90-omnibus-gitlab-kernel.shmmax.conf Ran sysctl -e -p /opt/gitlab/embedded/etc/90-omnibus-gitlab-kernel.shmmax.conf returned 255 Due to: command "sysctl -e -p /opt/gitlab/embedded/etc/90-omnibus-gitlab-kernel.shmmax.conf" causing the error: sysctl: setting key "kernel.shmmax": Read-only file system Read-only of the /sys/ directory is typical the case with LCX containers... But the advice value of the shmax is: cat /opt/gitlab/embedded/etc/90-omnibus-gitlab-kernel.shmmax.conf kernel.shmmax = 17179869184 I can complete the setup if you want, by using a workaround by commenting-out the related section in: /opt/gitlab/embedded/cookbooks/cache/cookbooks/package/resources/gitlab_sysctl.rb. And run: gitlab-ctl reconfigure. But I rather like to get this working in a correct manner. Maybe somebody add at this shmmax statement above to the host /etc/sysctl.conf file? Let me know if somebody can help me with this or which direction you want to go. Ps. where are not the only one on the internet: http://letmegooglethat.com/?q=STDERR%3A+sysctl%3A+setting+key+%22kernel.shmmax%22%3A+Read-only+file+system Thx! Kind regards, Melroy van den Berg___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Hi Juri/Mike, Please let me know where you have any update regarding the VM host with Debian Buster. I'm also running a omnibus installation myself, which is indeed the most logical choice. I also found the option to use docker container of omnibus, instead of using the deb installation in the Debian VM. See docker hub: https://hub.docker.com/r/gitlab/gitlab-ce/ And readme: https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/doc/docker/README.md Disclaimer: I don't know the performance impact of using docker image as the GitLab instance vs directly running it on the VM. But I can imagine an upgrade will be easier by pulling a new docker image from a new tag vs APT, etc. Kind regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op dinsdag, mei 26, 2020 12:02 AM, Mike Gabriel schreef: > Hi Melroy, > > On Do 21 Mai 2020 17:57:02 CEST, Melroy van den Berg wrote: > > > OK in that case. Let's go actions. Since I think everybody agrees. > > Mike also discussed other platforms like Gitlab. Which I think is a > good > > enabler. I'm able to help you with setting up your own gitlab > server for > > example (like I did for myself: > https://gitlab.melroy.org). Somebody said > > there was a Jenkins server. > > My question would be: which kind of server can I use to setup such > kind > > of infrastructure? Is there something arranged within X2Go? I > love to > > help, but you need some machines to execute it. Or has > somebody some vm > > in the cloud? > > If I have root access to such a machine, I can start. Also dns records etc. > > just a short HEADs up. An available VM Host is being prepared tonight (at > least, Juri promised that). A VM (LXC) will be deployed on that host after > that, providing a Debian 10 system. > > I'd suggest doing an Omnibus-DEB installation of GitLab on that machine then. > Public IPv4 and IPv6 will be available for you to deploy GitLab directly to > the internet. > > I'll ping you with more info, when available. Please send your SSH pubkey to > me privately, so that I already have that. > > Greets, > Mike > > --- > > DAS-NETZWERKTEAM > c\o Technik- und Ökologiezentrum Eckernförde > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde > mobile: +49 (1520) 1976 148 > landline: +49 (4351) 850 8940 > > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 > mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Development resources
Maybe this is just a feature proposal/improvement that needs a separate bug ticket. Could somebody document all this somewhere?... That would be nice, right? Best regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op dinsdag, mei 26, 2020 8:37 PM, Mike Gabriel schreef: > On Di 26 Mai 2020 10:59:34 CEST, Stefan Baur wrote: > > > (Socket forwarding could help in getting SSH agent forwarding added to > > X2Go, I guess... unless newer libssh versions already support that by > > themselves?) > > Annnddd.. the socket forwarding code should then use unix domain > socket on the server side (instead of localhost IP ports)... SSH 6.7 > and upwards does support that. > > Mike > > - > > DAS-NETZWERKTEAM > c\o Technik- und Ökologiezentrum Eckernförde > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde > mobile: +49 (1520) 1976 148 > landline: +49 (4351) 850 8940 > > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 > mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de > > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#1472: Bug#1472: New wiki account for melroy
Hey Mike, Kind reminder :)? Could I please get an account to getting started. Kind regards, Melroy van den Berg Original Message On May 19, 2020, 21:54, Melroy van den Berg wrote: > Hi Mike, > > Nice to meet you. First of all thanks for your fast reply and indeed a fair > question to ask. > > Several things (and properly more along the way), I will start however with > updating the Debian dependencies for software development: > https://wiki.x2go.org/doku.php/wiki:development:deb-buildguide > > Those package names have changed in recent Debian/Ubuntu based distros. > > Improving readability and new findings in general. Creating additional links > between the wiki pages for better traceability/findability. > > Last but not least, take some old wiki pages into question and discuss with > you about the any new content, like this page: > https://wiki.x2go.org/doku.php/wiki:development:roadmap > > Regards, > Melroy van den Berg > > ‐‐‐ Original Message ‐‐‐ > Op dinsdag, mei 19, 2020 9:40 PM, Mike Gabriel > schreef: > >> Hi Melroy, >> >> On Di 19 Mai 2020 18:39:46 CEST, Melroy van den Berg wrote: >> >> > Package: wiki.x2go.org >> > Please create a wiki account for me. >> > First name: Melroy >> > Last name: van den Berg >> > Account name: danger89 >> >> What kind of contact are you planning to contribute to the X2Go Wiki? >> >> Mike >> >> -- >> >> DAS-NETZWERKTEAM >> c\o Technik- und Ökologiezentrum Eckernförde >> Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde >> mobile: +49 (1520) 1976 148 >> landline: +49 (4351) 850 8940 >> >> GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 >> mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Hi Dave and others, I understand that a cloud based solution is easier in maintenance and setup. Which is true on that side. Like Stefan said before, there are some legal issues connected with going to the cloud. Moreover, you will have more freedom, control and more features available with the GitLab on-prem version then you have with the free cloud solution. GitLab core is open-source available where as both GitHub and BitBucket are proprietary solutions. GitHub has only a paid enterprise version available. And BitBucket is a mess with their products, they have different teams working on the on-prem products (incl. Bamboo vs Pipeline). So the on-prem is not using BitBucket Pipelines, instead they have Bamboo, which is not well integrated into BitBucket. Bottom-line: my preference would definitely be GitLab. According to the facts above. You may want to check several sites like the feature list for self-managed instances: https://about.gitlab.com/pricing/self-managed/feature-comparison/ With the free version you can also create integration between other 3rd party applications if needed. Regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op zaterdag, mei 23, 2020 8:29 PM, Stefan Baur schreef: > Am 23.05.20 um 12:15 schrieb Dave Chamberlin-Kidd: > > > Would it be worth considering cloud based GitHub, BitBucket or GitLab? All > > have free accounts available > > All of those have ideological and/or legal issues when it comes to X2Go > and its core team members, so, no. > > We will go the self-hosting route. Heinz-M. Graesing has already > stepped up to cover the costs for the additional IP, I'm waiting to hear > back from Juri regarding the LXC container. > > -Stefan > > - > > BAUR-ITCS UG (haftungsbeschränkt) > Geschäftsführer: Stefan Baur > Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 > Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 > > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
OK in that case. Let's go actions. Since I think everybody agrees. Mike also discussed other platforms like Gitlab. Which I think is a good enabler. I'm able to help you with setting up your own gitlab server for example (like I did for myself: https://gitlab.melroy.org). Somebody said there was a Jenkins server. My question would be: which kind of server can I use to setup such kind of infrastructure? Is there something arranged within X2Go? I love to help, but you need some machines to execute it. Or has somebody some vm in the cloud? If I have root access to such a machine, I can start. Also dns records etc. Kind regards, Melroy van den Berg Original Message On May 21, 2020, 17:38, Oleksandr Shneyder wrote: > Well, there are a lot of different ways to do everything in this life. > The way I'm doing, works at the moment well for me and for X2Go as well > since about 10 years. I didn't tell, that there is nothing which could > be improved. Every one knows, that we need a test facility, but no one > is doing this. So, if you want to use the project for your purposes and > you want to give something back, everyone here will appreciate your > commitment. Just think before you are starting to do something here if > you'll want to bring it to the end. We had so many people here, who were > talking a lot, but didn't do anything at the end, just wasted everyone's > time. The things you are saying are right, but believe me, you didn't > say anything that we didn't know before. So, to the point, if you'll > create a test facility for X2Go, I think everyone will be thankful to > you for that. We also appreciate your thoughts, but the actions we are > appreciating even more. > > regards > Alex > > Am 21.05.20 um 09:57 schrieb Melroy van den Berg: >> Hi Alex, >> >> Ah, you have paying customers? >> >> >> Testing is part of the development cycle. Meaning you code production >> code with your left hand. And write test cases with your right hand. >> From the customer perspective there is no such choice to implement a >> feature without tests. It's either a new feature with test cases, proper >> review, and static code analysis, etc. Or they have nothing. >> >> I don't want to be rude, but it's a mindset change. Hopefully you get my >> point. The same is done in all my projects and the company I work for. >> >> Best regards, >> Melroy van den Berg >> >> Original Message >> On May 21, 2020, 16:22, Oleksandr Shneyder < o.shney...@phoca-gmbh.de> >> wrote: >> >> >> Whatever test facilities are good and are very important. The problem >> is, to create them we need resources. No one of my customers wants to >> pay for it. Anyway, I'm concentrated on the features development. So >> whoever is willing to create such tests is very welcome. >> >> Alex >> >> Am 21.05.20 um 03:14 schrieb Stefan Baur: >> > Am 21.05.20 um 08:28 schrieb Mike Gabriel: >> >> >> >> With the video recorded session start tests, we will get a lot of >> noise >> >> from changes in desktop environments and other third party components >> >> that X2Go sits on top of. We may not even want to test this >> >> automatically. Dunno... >> > >> > That's why I said we need a reference GUI app that doesn't randomly >> > change. So either something simplistic that already exists, or >> someting >> > specially crafted for this purpose. >> > >> > Run OpenBox or another "simple" window manager, no task bar (else the >> > clock or some status popups will trigger a "this doesn't match"), run >> > the test robot, take a screenshot, compare to template. >> > >> > -Stefan >> > >> > >> > ___ >> > x2go-dev mailing list >> > x2go-dev@lists.x2go.org >> > https://lists.x2go.org/listinfo/x2go-dev >> > >> >> -- >> --- >> Oleksandr Shneyder | Email: o.shney...@phoca-gmbh.de >> phoca GmbH | Tel. : 0911 - 14870374 0 >> Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 >> D-90491 Nürnberg | Mobil: 0163 - 49 64 461 >> >> Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder >> >> Amtsgericht München | http://www.phoca-gmbh.de >> HRB 196 658 | http://www.x2go.org >> USt-IdNr.: DE281977973 >> --- >> >> _
Re: [X2Go-Dev] Code formatting
Hi Alex, Ah, you have paying customers? Testing is part of the development cycle. Meaning you code production code with your left hand. And write test cases with your right hand. From the customer perspective there is no such choice to implement a feature without tests. It's either a new feature with test cases, proper review, and static code analysis, etc. Or they have nothing. I don't want to be rude, but it's a mindset change. Hopefully you get my point. The same is done in all my projects and the company I work for. Best regards, Melroy van den Berg Original Message On May 21, 2020, 16:22, Oleksandr Shneyder wrote: > Whatever test facilities are good and are very important. The problem > is, to create them we need resources. No one of my customers wants to > pay for it. Anyway, I'm concentrated on the features development. So > whoever is willing to create such tests is very welcome. > > Alex > > Am 21.05.20 um 03:14 schrieb Stefan Baur: >> Am 21.05.20 um 08:28 schrieb Mike Gabriel: >>> >>> With the video recorded session start tests, we will get a lot of noise >>> from changes in desktop environments and other third party components >>> that X2Go sits on top of. We may not even want to test this >>> automatically. Dunno... >> >> That's why I said we need a reference GUI app that doesn't randomly >> change. So either something simplistic that already exists, or someting >> specially crafted for this purpose. >> >> Run OpenBox or another "simple" window manager, no task bar (else the >> clock or some status popups will trigger a "this doesn't match"), run >> the test robot, take a screenshot, compare to template. >> >> -Stefan >> >> >> ___ >> x2go-dev mailing list >> x2go-dev@lists.x2go.org >> https://lists.x2go.org/listinfo/x2go-dev >> > > -- > --- > Oleksandr Shneyder | Email: o.shney...@phoca-gmbh.de > phoca GmbH | Tel. : 0911 - 14870374 0 > Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 > D-90491 Nürnberg | Mobil: 0163 - 49 64 461 > > Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder > > Amtsgericht München | http://www.phoca-gmbh.de > HRB 196 658 | http://www.x2go.org > USt-IdNr.: DE281977973 > --- > > ___ > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Indeed Stefan! XFCE has even a docker image for their testing, check it out: https://hub.docker.com/r/schuellerf/xfce-test They capture actually a whole video and automatically post that on a YT channel: https://www.youtube.com/user/schuellerf/videos I found that fascinating. But maybe X2Go should first start creating unit testcases :P? Which should be the bare minimum in my opinion. As well as some automated pipeline triggering these kind of tests and other checks. Which should be part of the development cycle. Regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op woensdag, mei 20, 2020 10:33 PM, Stefan Baur schreef: > Am 20.05.20 um 22:09 schrieb Ulrich Sibiller: > > > Yeah, that's right. But I was referring to session start, ssh stuff and > > interactive user input. > > Actually, I could imagine setting up something that starts X2GoClient, > starts a session, fakes some user input and then takes a screenshot of > the remote screen and compares it to a reference image. > > This would need some demo application that always looks the same, so we > don't get false alerts from e.g. LibreOffice changing the default button > design. But some text fields would be nice, so we could also test > copy-pasting. > > No idea how to do that on a Mac, but for Linux (xdotool) and Windows > (AutoIt), I think it's doable, given we find (or code) a suitable > reference GUI application for the test. > > -Stefan > > > > > BAUR-ITCS UG (haftungsbeschränkt) > Geschäftsführer: Stefan Baur > Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 > Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 > > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Hi Uli,
Thanks for the links to Xorg.
> As always this is quite difficult to achieve for a client/server setup
> with interactive tools
I don't agree. Unit testing is a test technique were you isolate the code from
the rest of the context and create a stub/mock in place of that.
This allows you you test pieces of your code (like a function) in isolation.
Moreover, when something is hard to test means that you may want to invest time
in refactoring for test ability.
Only for integration testcases between client & server you need to create a
test approach, like you may want to mock the whole server side (if you want to
test the client side).
But the important take away from this mail is that there are different levels
of testing. Where unit testing in the first level and can easily be done.
Regards,
Melroy van den Berg
‐‐‐ Original Message ‐‐‐
Op woensdag, mei 20, 2020 5:44 PM, Ulrich Sibiller
schreef:
> On Wed, May 20, 2020 at 5:20 PM Melroy van den Berg
> melro...@protonmail.com wrote:
>
> > I'm afraid I was the cause of the start of the discussion. I'm also using
> > VS Code now, which has a built-in way to auto format the code (incl C++).
> > Using the shortcut: Ctrl + Shift + I (capital i)
> > Yet there are otherwise, like clang auto formatter. Instead of using right
> > away. We may need to discuss and agree as a community which tool we will
> > use.
> > And also which settings will be used, ideally be stored into the git repo
> > (root folder), which then get picked up by the relevant tool.
>
> For Xorg they simply used a shell script that took care of a clean
> formatting, see e.g. here:
> https://github.com/XQuartz/xorg-server/commit/9838b7032ea9792bec21af424c53c07078636d21
>
> > In fact, I'm would like to go to next level, namely automated CI/CD. Which
> > may include auto-formatter, other tools maybe like static code analysis
> > (cppcheck), generation of documentation (from source code) and running
> > testcases within a pipeline.
>
> Maybe Mihai and Mike#1 can explain what we already have here. IIRC
> there's jenkins server and there are nightly builds ("heuler" repos).
> For nx-libs we have some stuff on travis (including cppcheck) and on
> LGTM (non-working because it does not find the C sources for unknown
> reasons).
>
> > Read my message #62 on bug report:
> > https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1469#62
> > Ps. Where are the testcases? We may need to start creating
> > (integration/unit) testcases to avoid regression issues when changing code.
>
> As always this is quite difficult to achieve for a client/server setup
> with interactive tools
>
> Uli
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Hi Dave, I'm afraid I was the cause of the start of the discussion. I'm also using VS Code now, which has a built-in way to auto format the code (incl C++). Using the shortcut: Ctrl + Shift + I (capital i) Yet there are otherwise, like [clang auto formatter](https://clang.llvm.org/docs/ClangFormat.html). Instead of using right away. We may need to discuss and agree as a community which tool we will use. And also which settings will be used, ideally be stored into the git repo (root folder), which then get picked up by the relevant tool. In fact, I'm would like to go to next level, namely automated CI/CD. Which may include auto-formatter, other tools maybe like static code analysis (cppcheck), generation of documentation (from source code) and running testcases within a pipeline. Read my message #62 on bug report: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1469#62 Ps. Where are the testcases? We may need to start creating (integration/unit) testcases to avoid regression issues when changing code. Kind regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op woensdag, mei 20, 2020 1:23 AM, Dave Chamberlin-Kidd schreef: > Hi, > > I noticed someone else talking about auto code formatting. Is there a house > style? If so is there a recommend formatting tool (I'm currently using Vs > code and vi to edit)? > > Cheers > Dave___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#1469: Re: Bug#1469: But wait; there is more... patches!
Hi Mike, Thanks for your reply. Are are my thoughts. > Using (std::)endl is actually a bug Ah, thanks for the heads-up! I think in that case we should in fact remove all the endl instead of adding it :). > Strictly speaking, though, this should not cause any issues Why was I getting socket error then? I really hope everything got merged correctly now. Including my changes in the separate function. Since all the changes together made my socket error from libssh disappear now. > This code path is for old libssh versions only (pre-0.8) and still works > there, > so I don't see any reason to change it. I got deprecation warnings on this function/line while compiling. Why not merge it and remove build warnings? The change in within the #else, maybe if you think it should be in the #if you can apply the change in that section (but I think in my case the else part got compiled). Nevertheless, it's a deprecation that needs to be solved anyway. > Not changing return (...) vs. return ..., the actual change > looks good though. Why not changing the return(). This is wrong code, it's just a boolean! Bad practice, please don't it. Don't be afraid to change it. A generic remark: I think X2Go is missing a good pipeline with testcases and other quality checks. Which also hopefully increases your *trust in the code* and enables refactoring as well. I'm not afraid to refactor the code and clean-up the formatting, splitting functions and even into multiple files. If this all improve readability, debuggability and test-ability long-term. That is why I raise a request to create a decent pipeline to allow the necessary changes in further improve code maturity and the needed changes to do so. And maybe even a better diff tool to perform refactoring changes during review. Any ideas or suggestions? I'm running a GitLab instance myself for example; which enables DevOps and CI/CD within all my projects. Thanks once more! Kind regards, Melroy van den Berg___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Windows nightly crashes
Hi Uli, Try to debug the code using the debugger? Adding print lines is not the way to do it. I hope somebody can say how to re-compile the code with debug symbols and if gdb is good enough? Kind regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op woensdag, mei 20, 2020 2:16 PM, Ulrich Sibiller schreef: > Running with --libssh-packetlog shows a bit more: > [2020/05/20 14:08:36.287745, 2] ssh_socket_connect: Nonblocking > connection socket: 2228 > [2020/05/20 14:08:36.287745, 2] ssh_connect: Socket connecting, now > waiting for the callbacks to work > [2020/05/20 14:08:36.288743, 3] ssh_connect: Actual timeout : 6 > [2020/05/20 14:08:36.293743, 3] ssh_socket_pollcallback: Received > POLLOUT in connecting state > [2020/05/20 14:08:36.293743, 1] socket_callback_connected: Socket > connection callback: 1 (0) > [2020/05/20 14:08:36.295746, 3] ssh_socket_unbuffered_write: Enabling > POLLOUT for socket > [2020/05/20 14:08:36.309751, 3] callback_receive_banner: Received > banner: SSH-2.0-OpenSSH_5.8 > [2020/05/20 14:08:36.312765, 2] ssh_client_connection_callback: SSH > server banner: SSH-2.0-OpenSSH_5.8 > [2020/05/20 14:08:36.313757, 2] ssh_analyze_banner: Analyzing banner: > SSH-2.0-OpenSSH_5.8 > [2020/05/20 14:08:36.314750, 2] ssh_analyze_banner: We are talking to > an OpenSSH client version: 5.8 (50800) > [2020/05/20 14:08:37.352741, 3] ssh_client_select_hostkeys: Order of > wanted host keys: > "ssh-ed25519,ecdsa-sha2-nistp521,ecdsa-sha2-nistp384,ecdsa-sha2-nistp256,rsa-sha2-512,rsa-sha2-256,ssh-rsa,ssh-dss" > [2020/05/20 14:08:37.353749, 1] ssh_known_hosts_read_entries: Failed > to open the known_hosts file '/etc/ssh/ssh_known_hosts': No such file > or directory > [2020/05/20 14:08:37.354752, 3] ssh_client_select_hostkeys: > Algorithms found in known_hosts files: "ecdsa-sha2-nistp256" > [2020/05/20 14:08:37.355743, 3] ssh_client_select_hostkeys: Changing > host key method to > "ecdsa-sha2-nistp256,ssh-ed25519,ecdsa-sha2-nistp521,ecdsa-sha2-nistp384,rsa-sha2-512,rsa-sha2-256,ssh-rsa,ssh-dss" > [2020/05/20 14:08:37.355743, 3] ssh_socket_unbuffered_write: Enabling > POLLOUT for socket > [2020/05/20 14:08:37.356742, 3] packet_send2: packet: wrote [type=20, > len=940, padding_size=4, comp=935, payload=935] > [2020/05/20 14:08:37.356742, 3] ssh_send_kex: SSH_MSG_KEXINIT sent > [2020/05/20 14:08:37.357742, 3] ssh_packet_socket_callback: packet: > read type 20 [len=852,padding=5,comp=846,payload=846] > [2020/05/20 14:08:37.357742, 3] ssh_packet_process: Dispatching > handler for packet type 20 > [2020/05/20 14:08:37.357742, 2] ssh_kex_select_methods: Negotiated > ecdh-sha2-nistp256,ecdsa-sha2-nistp256,aes256-ctr,aes256-ctr,hmac-sha1,hmac-sha1,none,none,, > [2020/05/20 14:08:37.359741, 3] packet_send2: packet: wrote [type=30, > len=76, padding_size=5, comp=70, payload=70] > [2020/05/20 14:08:37.360741, 3] ssh_socket_unbuffered_write: Enabling > POLLOUT for socket > [2020/05/20 14:08:37.371817, 3] ssh_packet_socket_callback: packet: > read type 31 [len=292,padding=8,comp=283,payload=283] > [2020/05/20 14:08:37.371817, 3] ssh_packet_process: Dispatching > handler for packet type 31 > [2020/05/20 14:08:37.374742, 3] ssh_socket_unbuffered_write: Enabling > POLLOUT for socket > [2020/05/20 14:08:37.374742, 3] packet_send2: packet: wrote [type=21, > len=12, padding_size=10, comp=1, payload=1] > [2020/05/20 14:08:37.376744, 3] crypt_set_algorithms2: Set output > algorithm to aes256-ctr > [2020/05/20 14:08:37.376744, 3] crypt_set_algorithms2: Set HMAC > output algorithm to hmac-sha1 > [2020/05/20 14:08:37.377744, 3] crypt_set_algorithms2: Set input > algorithm to aes256-ctr > [2020/05/20 14:08:37.377744, 3] crypt_set_algorithms2: Set HMAC input > algorithm to hmac-sha1 > [2020/05/20 14:08:37.378742, 2] ssh_init_rekey_state: Set rekey after > 4294967296 blocks > [2020/05/20 14:08:37.378742, 2] ssh_init_rekey_state: Set rekey after > 4294967296 blocks > [2020/05/20 14:08:37.378742, 2] ssh_packet_client_ecdh_reply: > SSH_MSG_NEWKEYS sent > [2020/05/20 14:08:37.379742, 3] ssh_packet_socket_callback: > Processing 16 bytes left in socket buffer > [2020/05/20 14:08:37.379742, 3] ssh_packet_socket_callback: packet: > read type 21 [len=12,padding=10,comp=1,payload=1] > [2020/05/20 14:08:37.379742, 3] ssh_packet_process: Dispatching > handler for packet type 21 > [2020/05/20 14:08:37.380742, 2] ssh_packet_newkeys: Received SSH_MSG_NEWKEYS > [2020/05/20 14:08:37.382742, 2] ssh_packet_newkeys: Signature > verified and valid > [2020/05/20 14:08:37.382742, 3] ssh_connect: current state : 7 > x2go-DEBUG-../src/sshmasterconnection.cpp:869> Session port before > config file parse (part 2): 22 > x2go-DEBUG-../src/sshmasterconnection
[X2Go-Dev] Bug#1469: Bug#1469: Patch!
Hi, Well.. it was not unnecessary. The code was actually unreadable, wrong indentations and inconsistent throughout the whole file. I needed to execute this auto-formatter, before I could even begin to understand the code. In fact, I urge you to execute this on the whole archive. And keep the code quality high via a CI pipeline or something. I can understand it makes it hard to read. I also fixed other some issues like this double error message during login and all the debug statements. What would be your approach? I think it's still wise to auto-format the code in consistent matter. Regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op dinsdag, mei 19, 2020 9:48 PM, Mike Gabriel schreef: > Hi Melroy, > > On Di 19 Mai 2020 03:59:16 CEST, Melroy van den Berg wrote: > > > Hi, > > I did some refactoring in the sshmasterconnection.cpp file. I think > it > > can definitely use some clean-up and further splitting functions > and even > > into multiple files eventually. > > I cloned the master branch of code.x2go.org/x2goclient repo. > > The changes I applied are in the attachment of this mail (a git > patch > > file). I think closing previous sessions and connection solved > my strange > > SSH connection is resulting into Socket error: No such > file or directory". > > Although X2Go client is calling libssh > calls (libssh version > currently > > in use runtime on my host is: 0.7.0). > > For some reason this vague error message popped-up by libssh, > properly a > > result of previous session being created and not > correctly closed. And/or > > not closed in the right order (/missing API > calls), like a good example: > > ssh_channel_send_eof(channel); > > ssh_channel_close(channel); > > ssh_channel_free(channel); > > And I created yet again a new YT video showing my result: > > https://youtu.be/vmASLJq0CKM > > (including some brief explanation what I did so far, I also ran an > > > formatted on the code, because it was very very hard to read with > all the > > wrong indents) > > I also made another video showing yet another bug I found regarding > the > > SSH tunneling (during some heavy testing), the only solution was > to > > restart the whole docker image: > > https://youtu.be/xEpIyo84fWc (I think this issue is unrelated, but > maybe > > wise to take serious as well) > > Again see attachment for the patch (branched from master). > > Regards, > > Melroy van den Berg > > Thanks for working on X2Go Client. With your patch, there is a problem > though. It is barely unreviewable, because you have so many changes (also > white space changes) in one patch file. > > Please clone the X2Go Client Git repo, add atomic changes with good commit > messages. Keep white-space changes and technical changes fully separate > (ideally: technical changes first, white-space changes last). > > Then export your patches using 'git format-patch > ..HEAD' and send us the set of patches instead this one > bulk commit/patch. > > Thanks for your efforts!!! > > Mike > > --- > > DAS-NETZWERKTEAM > c\o Technik- und Ökologiezentrum Eckernförde > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde > mobile: +49 (1520) 1976 148 > landline: +49 (4351) 850 8940 > > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 > mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#1472: Bug#1472: New wiki account for melroy
Hi Mike, Nice to meet you. First of all thanks for your fast reply and indeed a fair question to ask. Several things (and properly more along the way), I will start however with updating the Debian dependencies for software development: https://wiki.x2go.org/doku.php/wiki:development:deb-buildguide Those package names have changed in recent Debian/Ubuntu based distros. Improving readability and new findings in general. Creating additional links between the wiki pages for better traceability/findability. Last but not least, take some old wiki pages into question and discuss with you about the any new content, like this page: https://wiki.x2go.org/doku.php/wiki:development:roadmap Regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op dinsdag, mei 19, 2020 9:40 PM, Mike Gabriel schreef: > Hi Melroy, > > On Di 19 Mai 2020 18:39:46 CEST, Melroy van den Berg wrote: > > > Package: wiki.x2go.org > > Please create a wiki account for me. > > First name: Melroy > > Last name: van den Berg > > Account name: danger89 > > What kind of contact are you planning to contribute to the X2Go Wiki? > > Mike > > -- > > DAS-NETZWERKTEAM > c\o Technik- und Ökologiezentrum Eckernförde > Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde > mobile: +49 (1520) 1976 148 > landline: +49 (4351) 850 8940 > > GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 > mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#396: Let's encrypt
I think let's encrypt is now used, and is perfect. Please, could somebody close this bug? It's still open...___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#1472: New wiki account for melroy
Package: wiki.x2go.org Please create a wiki account for me. First name: Melroy Last name: van den Berg Account name: danger89___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#1469: Two additional remarks
In this additional mail I would like to add two things: 1) Additional attachments for the logs (see the attachments in the mail) 2) Trying to reproduce the same issue in the other client (pyhoca), I was NOT able to reproduce the issue in pyhoca. Everything worked as expected, meaning it's definitely an issue in the x2goclient v4.1.2.2. Regarding the pyhoca test, I created a second follow-up video which shows that this works: https://www.youtube.com/watch?v=meOZ3YEfkyM I can confirm even after stopping and starting pyhoca multiple times, it *always* works via pyhoca. Yet again not via x2goclient. That still gives often the error: Socket error: No such file or directory" (0). See my first mail. Kind regards, Melroy van den Berg⯠x2goclient --debug x2go-INFO-1> "Starting X2Go Client 4.1.2.2..." x2go-WARNING-1> English language requested, not loading translator. x2go-WARNING-1> English language requested, not loading translator. x2go-INFO-3> "Started X2Go Client." x2go-DEBUG-../src/onmainwindow.cpp:575> "$HOME=/home/melroy" x2go-DEBUG-../src/onmainwindow.cpp:2266> Reading 2 sessions from config file. x2go-DEBUG-../src/sessionbutton.cpp:361> Creating QPixmap with session icon: ":/img/icons/128x128/x2gosession.png". x2go-DEBUG-../src/sessionbutton.cpp:361> Creating QPixmap with session icon: ":/img/icons/128x128/x2gosession.png". x2go-DEBUG-../src/onmainwindow.cpp:13290> libssh not initialized yet. Initializing. x2go-DEBUG-../src/onmainwindow.cpp:2752> Creating QPixmap with session icon: '":/img/icons/128x128/x2gosession.png"'. x2go-INFO-8> "Starting connection to server: localhost:" x2go-DEBUG-../src/onmainwindow.cpp:2853> Starting new ssh connection to server:"localhost":"" krbLogin: false x2go-DEBUG-../src/sshmasterconnection.cpp:168> SshMasterConnection, host "localhost"; port ; user "melroy"; useproxy false; proxyserver ""; proxyport 22 x2go-DEBUG-../src/sshmasterconnection.cpp:248> Starting SSH connection without Kerberos authentication. x2go-DEBUG-../src/sshmasterconnection.cpp:250> SshMasterConnection, instance SshMasterConnection(0x55f68a896680) created. x2go-DEBUG-../src/sshmasterconnection.cpp:495> SshMasterConnection, instance SshMasterConnection(0x55f68a896680) entering thread. x2go-DEBUG-../src/sshmasterconnection.cpp:797> Session port before config file parse: x2go-DEBUG-../src/sshmasterconnection.cpp:807> Session port after config file parse: x2go-DEBUG-../src/sshmasterconnection.cpp:870> Session port before config file parse (part 2): x2go-DEBUG-../src/sshmasterconnection.cpp:880> Session port after config file parse (part 2): x2go-DEBUG-../src/sshmasterconnection.cpp:904> cserverAuth x2go-DEBUG-../src/sshmasterconnection.cpp:943> state: 1 x2go-DEBUG-../src/sshmasterconnection.cpp:1218> Trying password mechanism if available. x2go-DEBUG-../src/sshmasterconnection.cpp:1222> Password mechanism available. Continuing. x2go-DEBUG-../src/sshmasterconnection.cpp:687> User authentication OK. x2go-DEBUG-../src/sshmasterconnection.cpp:1708> LOGIN CHECK:"LOGIN OK " x2go-DEBUG-../src/sshmasterconnection.cpp:1711> don't have interaction x2go-DEBUG-../src/sshmasterconnection.cpp:1744> LOOP FINISHED x2go-DEBUG-../src/sshmasterconnection.cpp:1748> No interaction needed, continue session x2go-DEBUG-../src/sshmasterconnection.cpp:702> Login Check - OK x2go-DEBUG-../src/onmainwindow.cpp:2947> SSH connection established. x2go-DEBUG-../src/onmainwindow.cpp:3374> Continue normal X2Go session x2go-DEBUG-../src/sshprocess.cpp:199> Executing remote command via SshProcess object 0: "x2golistsessions" x2go-DEBUG-../src/sshprocess.cpp:213> this=SshProcess(0x55f68a89c6d0) Running masterCon->addChannelConnection(this, ' "30b0be62-d1b2-40fa-9a6f-da229662" ', ' "bash -l -c 'echo "X2GODATABEGIN:30b0be62-d1b2-40fa-9a6f-da229662"; export PATH="/usr/local/bin:/usr/bin:/bin";export TERM="dumb"; x2golistsessions; echo "X2GODATAEND:30b0be62-d1b2-40fa-9a6f-da229b" '); x2go-DEBUG-../src/sshmasterconnection.cpp:1810> Locking SSH channel connection MUTEX. x2go-DEBUG-../src/sshmasterconnection.cpp:1812> Passing new channel connection object to channelConnections. x2go-DEBUG-../src/sshmasterconnection.cpp:1814> Unlocking SSH channel connection MUTEX. x2go-DEBUG-../src/sshmasterconnection.cpp:1977> Creating new channel. x2go-DEBUG-../src/sshmasterconnection.cpp:1990> New channel:0x7fbcbc010780 x2go-DEBUG-../src/sshmasterconnection.cpp:2065> Executing remote: "bash -l -c 'echo "X2GODATABEGIN:30b0be62-d1b2-40fa-9a6f-da229662"; export PATH="/usr/local/bin:/usr/bin:/bin";export TERM="dumb"; x2golistsessions; echo "X2GODATAEND:30b0be62-d1b2-40fa-9a6f-da229662";'" x2go-DEBUG-../src/sshmasterconnection.cpp:2071> "ssh_channel_open_session failed": "Socket error: No such file or directory" x2go-DEBUG-../src/sshprocess.cpp:478> I/O error: "ssh_channel_open_session failed."" - Socket error: No such file or directory" (0). ⯠x2goclient --debug x2go-INFO-1> "Starting X2Go Client 4.
Re: [X2Go-Dev] X2Go Client connection issue (Socket error)
Hi Juri, Thanks for your fast reply. Yes, it's definitely a bug in x2goclient 4.1.2.2. 100% guaranteed. I created on your request another follow-up video, which is testing the pyhoca gui client (v0.6.1.1-0): https://youtu.be/meOZ3YEfkyM I can't reproduce this issue with pyhoca. Meaning it's not a docker/server issue. It's definitely a bug in the x2goclient. For your info, bug #1469 is created. I'm using the x2goclient for Bionic from this PPA: https://launchpad.net/~x2go/+archive/ubuntu/stable?field.series_filter=bionic You can also see the proof I'm of running version 4.1.2.2 in my previous video (if you didn't saw that one already). It's around the 30 seconds mark: https://youtu.be/LAlLtBNTIUo?t=32 Best Regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op maandag, mei 18, 2020 9:41 PM, schreef: > Hello, > > are you sure, that this is bug in x2goclient 4.1.2.2 ? > Did you tried another x2goclient version and it works always? > Maybe can you reproduce it with pyhoca client? > > Best Regards, > Juri Grabowski ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#1469: X2Go Client connection issue (Socket error)
Package: x2goclient Version: 4.1.2.2 I often get an error message when I try to connect to my Debian buster docker image, running x2goserver and XFCE, via the X2Go Client on my host machine. It will give the following error message (when using the --debug flag on the x2goclient): x2go-DEBUG-../src/sshmasterconnection.cpp:2071> "ssh_channel_open_session failed": "Socket error: No such file or directory" x2go-DEBUG-../src/sshprocess.cpp:478> I/O error: "ssh_channel_open_session failed."" - Socket error: No such file or directory" (0). I created a detailed video, I posted it on YouTube, please take a look at the video: https://youtu.be/LAlLtBNTIUo Logging details, reproducibility and more is explained in the video itself. You'll notice that I can sometimes connect to the XFCE session and sometimes I can't. Although connecting via the ssh cli command is always working without any issues. Meaning there is really some kind of bug in the X2Go Client. I'm afraid. Again, I really hope somebody could help me in finding the root-cause and fixing the issue. Since I really love X2Go. And I would like to use this tool in production. I'm also a software developer so maybe I can help debugging the problem. Similar (same) bug is reported in the past (from 2019): https://lists.x2go.org/pipermail/x2go-user/2019-March/005512.html All the details regarding this Docker image and setup can be found in this git repo: https://gitlab.melroy.org/melroy/xfcevdi See attachments for additional debug logs of the client itself. One when successful and one during the error. Thanks in advance! Kind regards, Melroy van den Berg Ps. You can contact me by mail of course. But I can understand that debugging this issue would be preferable be done via VoIP for example.___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] X2Go Client connection issue (Socket error)
Hi X2go devs, Package: x2goclient Version: 4.1.2.2 (Linux Mint based on Ubuntu Bionic, using PPA) I often get an error message when I try to connect to my Debian buster docker image, running x2goserver and XFCE, via the X2Go Client on my host machine. It will give the following error message (when using the --debug flag on the x2goclient): x2go-DEBUG-../src/sshmasterconnection.cpp:2071> "ssh_channel_open_session failed": "Socket error: No such file or directory" x2go-DEBUG-../src/sshprocess.cpp:478> I/O error: "ssh_channel_open_session failed."" - Socket error: No such file or directory" (0). I created a detailed video, I posted it on YouTube, please take a look at the video: https://youtu.be/LAlLtBNTIUo Logging details, reproducibility and more is explained in the video itself. You'll notice that I can sometimes connect to the XFCE session and sometimes I can't. Although connecting via the ssh cli command is always working without any issues. Meaning there is really some kind of bug in the X2Go Client. I'm afraid. Again, I really hope somebody could help me in finding the root-cause and fixing the issue. Since I really love X2Go. And I would like to use this tool in production. I'm also a software developer so maybe I can help debugging the problem. Similar (same) bug is reported in the past (from 2019): https://lists.x2go.org/pipermail/x2go-user/2019-March/005512.html All the details regarding this Docker image and setup can be found in this git repo: https://gitlab.melroy.org/melroy/xfcevdi See attachments for additional debug logs of the client itself. One when successful and one during the error. Thanks in advance! Kind regards, Melroy van den Berg Ps. You can contact me by mail of course. But I can understand that debugging this issue would be preferable be done via VoIP for example.⯠x2goclient --debug x2go-INFO-1> "Starting X2Go Client 4.1.2.2..." x2go-WARNING-1> English language requested, not loading translator. x2go-WARNING-1> English language requested, not loading translator. x2go-INFO-3> "Started X2Go Client." x2go-DEBUG-../src/onmainwindow.cpp:575> "$HOME=/home/melroy" x2go-DEBUG-../src/onmainwindow.cpp:2266> Reading 2 sessions from config file. x2go-DEBUG-../src/sessionbutton.cpp:361> Creating QPixmap with session icon: ":/img/icons/128x128/x2gosession.png". x2go-DEBUG-../src/sessionbutton.cpp:361> Creating QPixmap with session icon: ":/img/icons/128x128/x2gosession.png". x2go-DEBUG-../src/onmainwindow.cpp:13290> libssh not initialized yet. Initializing. x2go-DEBUG-../src/onmainwindow.cpp:2752> Creating QPixmap with session icon: '":/img/icons/128x128/x2gosession.png"'. x2go-INFO-8> "Starting connection to server: localhost:" x2go-DEBUG-../src/onmainwindow.cpp:2853> Starting new ssh connection to server:"localhost":"" krbLogin: false x2go-DEBUG-../src/sshmasterconnection.cpp:168> SshMasterConnection, host "localhost"; port ; user "melroy"; useproxy false; proxyserver ""; proxyport 22 x2go-DEBUG-../src/sshmasterconnection.cpp:248> Starting SSH connection without Kerberos authentication. x2go-DEBUG-../src/sshmasterconnection.cpp:250> SshMasterConnection, instance SshMasterConnection(0x55f68a896680) created. x2go-DEBUG-../src/sshmasterconnection.cpp:495> SshMasterConnection, instance SshMasterConnection(0x55f68a896680) entering thread. x2go-DEBUG-../src/sshmasterconnection.cpp:797> Session port before config file parse: x2go-DEBUG-../src/sshmasterconnection.cpp:807> Session port after config file parse: x2go-DEBUG-../src/sshmasterconnection.cpp:870> Session port before config file parse (part 2): x2go-DEBUG-../src/sshmasterconnection.cpp:880> Session port after config file parse (part 2): x2go-DEBUG-../src/sshmasterconnection.cpp:904> cserverAuth x2go-DEBUG-../src/sshmasterconnection.cpp:943> state: 1 x2go-DEBUG-../src/sshmasterconnection.cpp:1218> Trying password mechanism if available. x2go-DEBUG-../src/sshmasterconnection.cpp:1222> Password mechanism available. Continuing. x2go-DEBUG-../src/sshmasterconnection.cpp:687> User authentication OK. x2go-DEBUG-../src/sshmasterconnection.cpp:1708> LOGIN CHECK:"LOGIN OK " x2go-DEBUG-../src/sshmasterconnection.cpp:1711> don't have interaction x2go-DEBUG-../src/sshmasterconnection.cpp:1744> LOOP FINISHED x2go-DEBUG-../src/sshmasterconnection.cpp:1748> No interaction needed, continue session x2go-DEBUG-../src/sshmasterconnection.cpp:702> Login Check - OK x2go-DEBUG-../src/onmainwindow.cpp:2947> SSH connection established. x2go-DEBUG-../src/onmainwindow.cpp:3374> Continue normal X2Go session x2go-DEBUG-../src/sshprocess.cpp:199> Executing remote command via SshProcess object 0: &quo
