Re: [Xbmc-addons] [GIT Pull] Pandora Radio for XBMC
Added to frodo. Thanks! On Thu, Jan 23, 2014 at 1:34 AM, Roy Ivy III rivy@gmail.com wrote: * addon - script.audio.pandora * version - 2.3.2 * url - git://github.com/rivy/xbmc-script.audio.pandora.git * revision - ff6aff1 * branch - master * tag - R-v2.3.2 * xbmc version - frodo + gotham Pandora Radio for XBMC + includes XBMC-Addons recommended changes Thanks. -- Roy -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Git Pull] Pandora Radio for XBMC
1. This is a script, not a plugin. Would it be ok to rename it script.audio.pandora or script.pandora for consistency? 2. Remove the Thumbs.db files: addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Alaska/media/Thumbs.db is not allowed addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Smoke/media/Thumbs.db is not allowed 3. Please add the language tag. See http://wiki.xbmc.org/index.php?title=Addon.xml#.3Clanguage.3E 4. I saw you know setting PLAYER_CORE_* is deprecated, but it seems you need it, so it's ok for now. 5. Please add xml header with proper encoding to all your xml files: addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/settings.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/NTSC/script-pandora.xml 6. If possible, try to replace print statements with xbmc.log() On Wed, Jan 22, 2014 at 1:21 AM, Roy Ivy III rivy@gmail.com wrote: * addon - plugin.audio.pandora * version - 2.3.1 * url - git://github.com/rivy/xbmc-plugin.audio.pandora.git * revision - 011e214 * branch - master * tag - R-v2.3.1 * xbmc version - frodo + gotham Pandora Radio for XBMC + adds the ability to listen to Pandora audio streams + mature, in-use / development for almost 4 years Thanks for the consideration. -- Roy -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Git Pull] Pandora Radio for XBMC
Thanks for the reply and help getting this tuned up. I've addressed each notation, point by point, below: On Wed, Jan 22, 2014 at 8:37 AM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: 1. This is a script, not a plugin. Would it be ok to rename it script.audio.pandora or script.pandora for consistency? I'm not attached to the naming here; script.audio.pandora would be fine. But I think the current name might be more correct. I've read the Add-on Structure document, specifically the Directory Name section @ http://wiki.xbmc.org/index.php?title=Add-on_structure#Directory_Name, and looked at the LastFM plugin ( @ https://github.com/XBMC-Addons/plugin.audio.lastfm ). I've used these as references, and I'd like this to be A music add-on that will appear in the Music main menu, not to appear in the Program menu. Am I misreading this? After looking at the addon.xml again, I noticed that the xbmc.python.script was used as an extension point. I've changed it to xbmc.python.pluginsource. Does that correct this issue? And do you think that is the correct designation for the addon? Again... not attached to the name or extension point/type... I want it to be correct and consistent. 2. Remove the Thumbs.db files: addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Alaska/media/Thumbs.db is not allowed addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Smoke/media/Thumbs.db is not allowed Done. 3. Please add the language tag. See http://wiki.xbmc.org/index.php?title=Addon.xml#.3Clanguage.3E Done, added to addon.xml. Does it need to be anywhere else? 4. I saw you know setting PLAYER_CORE_* is deprecated, but it seems you need it, so it's ok for now. As you have likely seen, I have engaged in discussion about this ( http://forum.xbmc.org/showthread.php?tid=173887pid=1603435#pid1603435 ) and added a bug report as well ( http://trac.xbmc.org/ticket/14854 ). I'll be happy to remove it once there is an accepted alternative available. 5. Please add xml header with proper encoding to all your xml files: addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/settings.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/NTSC/script-pandora.xml Done. 6. If possible, try to replace print statements with xbmc.log() Done. On Wed, Jan 22, 2014 at 1:21 AM, Roy Ivy III rivy@gmail.com wrote: * addon - plugin.audio.pandora * version - 2.3.1 * url - git://github.com/rivy/xbmc-plugin.audio.pandora.git * revision - 011e214 * branch - master * tag - R-v2.3.1 * xbmc version - frodo + gotham Pandora Radio for XBMC + adds the ability to listen to Pandora audio streams + mature, in-use / development for almost 4 years Thanks for the consideration. -- Roy Thanks for taking the time to review the addon. I'll test these changes and then post another [Pull Git] request with the most recent update later today. -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Git Pull] Pandora Radio for XBMC
http://wiki.xbmc.org/index.php?title=Addon.xml#.3Cextension.3E Use script.addon.audio On 22 Jan 2014 20:32, Roy Ivy III rivy@gmail.com wrote: Thanks for the reply and help getting this tuned up. I've addressed each notation, point by point, below: On Wed, Jan 22, 2014 at 8:37 AM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: 1. This is a script, not a plugin. Would it be ok to rename it script.audio.pandora or script.pandora for consistency? I'm not attached to the naming here; script.audio.pandora would be fine. But I think the current name might be more correct. I've read the Add-on Structure document, specifically the Directory Name section @ http://wiki.xbmc.org/index.php?title=Add-on_structure#Directory_Name, and looked at the LastFM plugin ( @ https://github.com/XBMC-Addons/plugin.audio.lastfm ). I've used these as references, and I'd like this to be A music add-on that will appear in the Music main menu, not to appear in the Program menu. Am I misreading this? After looking at the addon.xml again, I noticed that the xbmc.python.script was used as an extension point. I've changed it to xbmc.python.pluginsource. Does that correct this issue? And do you think that is the correct designation for the addon? Again... not attached to the name or extension point/type... I want it to be correct and consistent. 2. Remove the Thumbs.db files: addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Alaska/media/Thumbs.db is not allowed addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Smoke/media/Thumbs.db is not allowed Done. 3. Please add the language tag. See http://wiki.xbmc.org/index.php?title=Addon.xml#.3Clanguage.3E Done, added to addon.xml. Does it need to be anywhere else? 4. I saw you know setting PLAYER_CORE_* is deprecated, but it seems you need it, so it's ok for now. As you have likely seen, I have engaged in discussion about this ( http://forum.xbmc.org/showthread.php?tid=173887pid=1603435#pid1603435 ) and added a bug report as well ( http://trac.xbmc.org/ticket/14854 ). I'll be happy to remove it once there is an accepted alternative available. 5. Please add xml header with proper encoding to all your xml files: addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/settings.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/NTSC/script-pandora.xml Done. 6. If possible, try to replace print statements with xbmc.log() Done. On Wed, Jan 22, 2014 at 1:21 AM, Roy Ivy III rivy@gmail.com wrote: * addon - plugin.audio.pandora * version - 2.3.1 * url - git://github.com/rivy/xbmc-plugin.audio.pandora.git * revision - 011e214 * branch - master * tag - R-v2.3.1 * xbmc version - frodo + gotham Pandora Radio for XBMC + adds the ability to listen to Pandora audio streams + mature, in-use / development for almost 4 years Thanks for the consideration. -- Roy Thanks for taking the time to review the addon. I'll test these changes and then post another [Pull Git] request with the most recent update later today. -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical
Re: [Xbmc-addons] [Git Pull] Pandora Radio for XBMC
Or xbmc.python.script with provides audio On 22 Jan 2014 20:37, Martijn Kaijser mart...@xbmc.org wrote: http://wiki.xbmc.org/index.php?title=Addon.xml#.3Cextension.3E Use script.addon.audio On 22 Jan 2014 20:32, Roy Ivy III rivy@gmail.com wrote: Thanks for the reply and help getting this tuned up. I've addressed each notation, point by point, below: On Wed, Jan 22, 2014 at 8:37 AM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: 1. This is a script, not a plugin. Would it be ok to rename it script.audio.pandora or script.pandora for consistency? I'm not attached to the naming here; script.audio.pandora would be fine. But I think the current name might be more correct. I've read the Add-on Structure document, specifically the Directory Name section @ http://wiki.xbmc.org/index.php?title=Add-on_structure#Directory_Name, and looked at the LastFM plugin ( @ https://github.com/XBMC-Addons/plugin.audio.lastfm ). I've used these as references, and I'd like this to be A music add-on that will appear in the Music main menu, not to appear in the Program menu. Am I misreading this? After looking at the addon.xml again, I noticed that the xbmc.python.script was used as an extension point. I've changed it to xbmc.python.pluginsource. Does that correct this issue? And do you think that is the correct designation for the addon? Again... not attached to the name or extension point/type... I want it to be correct and consistent. 2. Remove the Thumbs.db files: addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Alaska/media/Thumbs.db is not allowed addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Smoke/media/Thumbs.db is not allowed Done. 3. Please add the language tag. See http://wiki.xbmc.org/index.php?title=Addon.xml#.3Clanguage.3E Done, added to addon.xml. Does it need to be anywhere else? 4. I saw you know setting PLAYER_CORE_* is deprecated, but it seems you need it, so it's ok for now. As you have likely seen, I have engaged in discussion about this ( http://forum.xbmc.org/showthread.php?tid=173887pid=1603435#pid1603435 ) and added a bug report as well ( http://trac.xbmc.org/ticket/14854 ). I'll be happy to remove it once there is an accepted alternative available. 5. Please add xml header with proper encoding to all your xml files: addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/settings.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/NTSC/script-pandora.xml Done. 6. If possible, try to replace print statements with xbmc.log() Done. On Wed, Jan 22, 2014 at 1:21 AM, Roy Ivy III rivy@gmail.com wrote: * addon - plugin.audio.pandora * version - 2.3.1 * url - git://github.com/rivy/xbmc-plugin.audio.pandora.git * revision - 011e214 * branch - master * tag - R-v2.3.1 * xbmc version - frodo + gotham Pandora Radio for XBMC + adds the ability to listen to Pandora audio streams + mature, in-use / development for almost 4 years Thanks for the consideration. -- Roy Thanks for taking the time to review the addon. I'll test these changes and then post another [Pull Git] request with the most recent update later today. -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- CenturyLink Cloud: The
Re: [Xbmc-addons] [Git Pull] Pandora Radio for XBMC
After your email, I've looked more closely at the code of several other plugin.audio.XXX modules. I think I've started to understand the difference. The plugin.audio.XXX addons (eg, plugin.audio.tuneradio) seem to be designed as extensions of the basic player, adding an audio source, instead of replacing the front end completely. In it's current form, the Pandora Radio addon is taking over completely; it's more of a self-contained script, as you suggested. I may attempt to rewrite this as a true plugin in the future, but, for now, I'll gladly rename it as script.audio.pandora for the resubmission. Thanks for the prompt. On Wed, Jan 22, 2014 at 1:31 PM, Roy Ivy III rivy@gmail.com wrote: Thanks for the reply and help getting this tuned up. I've addressed each notation, point by point, below: On Wed, Jan 22, 2014 at 8:37 AM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: 1. This is a script, not a plugin. Would it be ok to rename it script.audio.pandora or script.pandora for consistency? I'm not attached to the naming here; script.audio.pandora would be fine. But I think the current name might be more correct. I've read the Add-on Structure document, specifically the Directory Name section @ http://wiki.xbmc.org/index.php?title=Add-on_structure#Directory_Name, and looked at the LastFM plugin ( @ https://github.com/XBMC-Addons/plugin.audio.lastfm ). I've used these as references, and I'd like this to be A music add-on that will appear in the Music main menu, not to appear in the Program menu. Am I misreading this? After looking at the addon.xml again, I noticed that the xbmc.python.script was used as an extension point. I've changed it to xbmc.python.pluginsource. Does that correct this issue? And do you think that is the correct designation for the addon? Again... not attached to the name or extension point/type... I want it to be correct and consistent. 2. Remove the Thumbs.db files: addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Alaska/media/Thumbs.db is not allowed addonpr.addonparser - ERROR - plugin.audio.pandora/resources/skins/Smoke/media/Thumbs.db is not allowed Done. 3. Please add the language tag. See http://wiki.xbmc.org/index.php?title=Addon.xml#.3Clanguage.3E Done, added to addon.xml. Does it need to be anywhere else? 4. I saw you know setting PLAYER_CORE_* is deprecated, but it seems you need it, so it's ok for now. As you have likely seen, I have engaged in discussion about this ( http://forum.xbmc.org/showthread.php?tid=173887pid=1603435#pid1603435 ) and added a bug report as well ( http://trac.xbmc.org/ticket/14854 ). I'll be happy to remove it once there is an accepted alternative available. 5. Please add xml header with proper encoding to all your xml files: addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/settings.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Alaska/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Default/NTSC/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/skin.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/720p/script-pandora.xml addonpr.addonparser - ERROR - No xml encoding specified in plugin.audio.pandora/resources/skins/Smoke/NTSC/script-pandora.xml Done. 6. If possible, try to replace print statements with xbmc.log() Done. On Wed, Jan 22, 2014 at 1:21 AM, Roy Ivy III rivy@gmail.com wrote: * addon - plugin.audio.pandora * version - 2.3.1 * url - git://github.com/rivy/xbmc-plugin.audio.pandora.git * revision - 011e214 * branch - master * tag - R-v2.3.1 * xbmc version - frodo + gotham Pandora Radio for XBMC + adds the ability to listen to Pandora audio streams + mature, in-use / development for almost 4 years Thanks for the consideration. -- Roy Thanks for taking the time to review the addon. I'll test these changes and then post another [Pull Git] request with the most recent update later today. -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads,
[Xbmc-addons] [GIT Pull] Pandora Radio for XBMC
* addon - script.audio.pandora * version - 2.3.2 * url - git://github.com/rivy/xbmc-script.audio.pandora.githttp://github.com/rivy/xbmc-plugin.audio.pandora.git * revision - ff6aff1 * branch - master * tag - R-v2.3.2 * xbmc version - frodo + gotham Pandora Radio for XBMC + includes XBMC-Addons recommended changes Thanks. -- Roy -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
