Re: [Xbmc-addons] [Please Read] script.module.requests API change
Great! Are we good for update then. Benjamin? On Sun, Aug 17, 2014 at 9:39 AM, Robert Hudson r...@deadlyduck.com wrote: OK, I have verified the Sonos addon, and that works fine with the new requests module. capfuturo has also confirmed that it works with TVTunes. Rob On 14/08/2014 11:12, Thomas Amland wrote: Aren't you the maintainer of the add-on? It would be better to have confirmation from the maintainer that it's ok to update. You can read the API changes here: http://docs.python-requests.org/en/latest/api/#migrating-to-2-x The main problem is that the add-ons use elaborate hacks around requests, so it's hard for me who doesn't know the code to immediately see. I would be surprised if those minor changes break anything though. On Mon, Aug 11, 2014 at 7:23 PM, Robert Hudson r...@deadlyduck.com wrote: Sorry, I haven't had a chance to check this out yet. Please can you post a request on the TvTunes forum - and maybe ask if this is something that capfuturo and/or wgstarks can assist with testing for TvTunes (They are normally very helpful) I should hopefully be able to get time to test the Sonos one sometime soon. Rob On 11/08/2014 14:55, Thomas Amland wrote: Any progress Rob? I have already manually tested theberrics and thrasherskateboard and they are not affected. (thrasherskateboard is current broken btw). cessfull, putio and putiov2 require login so I cannot test. If it's ok to ignore those less used plugins, only sonos and tvtune are left to test. On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND bee...@gmail.com wrote: Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Great! Are we good for update then. Benjamin? I already pushed version 2.3.0 the 17th of august! I haven't heard any complaint, so I guess we are good :-) /Benjamin On Sun, Aug 17, 2014 at 9:39 AM, Robert Hudson r...@deadlyduck.com wrote: OK, I have verified the Sonos addon, and that works fine with the new requests module. capfuturo has also confirmed that it works with TVTunes. Rob On 14/08/2014 11:12, Thomas Amland wrote: Aren't you the maintainer of the add-on? It would be better to have confirmation from the maintainer that it's ok to update. You can read the API changes here: http://docs.python-requests.org/en/latest/api/#migrating-to-2-x The main problem is that the add-ons use elaborate hacks around requests, so it's hard for me who doesn't know the code to immediately see. I would be surprised if those minor changes break anything though. On Mon, Aug 11, 2014 at 7:23 PM, Robert Hudson r...@deadlyduck.com wrote: Sorry, I haven't had a chance to check this out yet. Please can you post a request on the TvTunes forum - and maybe ask if this is something that capfuturo and/or wgstarks can assist with testing for TvTunes (They are normally very helpful) I should hopefully be able to get time to test the Sonos one sometime soon. Rob On 11/08/2014 14:55, Thomas Amland wrote: Any progress Rob? I have already manually tested theberrics and thrasherskateboard and they are not affected. (thrasherskateboard is current broken btw). cessfull, putio and putiov2 require login so I cannot test. If it's ok to ignore those less used plugins, only sonos and tvtune are left to test. On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND bee...@gmail.com wrote: Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
OK, I have verified the Sonos addon, and that works fine with the new requests module. capfuturo has also confirmed that it works with TVTunes. Rob On 14/08/2014 11:12, Thomas Amland wrote: Aren't you the maintainer of the add-on? It would be better to have confirmation from the maintainer that it's ok to update. You can read the API changes here: http://docs.python-requests.org/en/latest/api/#migrating-to-2-x The main problem is that the add-ons use elaborate hacks around requests, so it's hard for me who doesn't know the code to immediately see. I would be surprised if those minor changes break anything though. On Mon, Aug 11, 2014 at 7:23 PM, Robert Hudson r...@deadlyduck.com wrote: Sorry, I haven't had a chance to check this out yet. Please can you post a request on the TvTunes forum - and maybe ask if this is something that capfuturo and/or wgstarks can assist with testing for TvTunes (They are normally very helpful) I should hopefully be able to get time to test the Sonos one sometime soon. Rob On 11/08/2014 14:55, Thomas Amland wrote: Any progress Rob? I have already manually tested theberrics and thrasherskateboard and they are not affected. (thrasherskateboard is current broken btw). cessfull, putio and putiov2 require login so I cannot test. If it's ok to ignore those less used plugins, only sonos and tvtune are left to test. On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND bee...@gmail.com wrote: Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Aren't you the maintainer of the add-on? It would be better to have confirmation from the maintainer that it's ok to update. You can read the API changes here: http://docs.python-requests.org/en/latest/api/#migrating-to-2-x The main problem is that the add-ons use elaborate hacks around requests, so it's hard for me who doesn't know the code to immediately see. I would be surprised if those minor changes break anything though. On Mon, Aug 11, 2014 at 7:23 PM, Robert Hudson r...@deadlyduck.com wrote: Sorry, I haven't had a chance to check this out yet. Please can you post a request on the TvTunes forum - and maybe ask if this is something that capfuturo and/or wgstarks can assist with testing for TvTunes (They are normally very helpful) I should hopefully be able to get time to test the Sonos one sometime soon. Rob On 11/08/2014 14:55, Thomas Amland wrote: Any progress Rob? I have already manually tested theberrics and thrasherskateboard and they are not affected. (thrasherskateboard is current broken btw). cessfull, putio and putiov2 require login so I cannot test. If it's ok to ignore those less used plugins, only sonos and tvtune are left to test. On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND bee...@gmail.com wrote: Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
It's more a timing thing, I'm quite busy at the moment and as this is a testing activity (does it work with a different requests package) this could easily be done by the guys on the forum that are very helpful. Failing that, you could be in for quite a wait if you are blocked on me! Rob On 14 August 2014 11:12, Thomas Amland thomas.aml...@gmail.com wrote: Aren't you the maintainer of the add-on? It would be better to have confirmation from the maintainer that it's ok to update. You can read the API changes here: http://docs.python-requests.org/en/latest/api/#migrating-to-2-x The main problem is that the add-ons use elaborate hacks around requests, so it's hard for me who doesn't know the code to immediately see. I would be surprised if those minor changes break anything though. On Mon, Aug 11, 2014 at 7:23 PM, Robert Hudson r...@deadlyduck.com wrote: Sorry, I haven't had a chance to check this out yet. Please can you post a request on the TvTunes forum - and maybe ask if this is something that capfuturo and/or wgstarks can assist with testing for TvTunes (They are normally very helpful) I should hopefully be able to get time to test the Sonos one sometime soon. Rob On 11/08/2014 14:55, Thomas Amland wrote: Any progress Rob? I have already manually tested theberrics and thrasherskateboard and they are not affected. (thrasherskateboard is current broken btw). cessfull, putio and putiov2 require login so I cannot test. If it's ok to ignore those less used plugins, only sonos and tvtune are left to test. On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND bee...@gmail.com wrote: Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Any progress Rob? I have already manually tested theberrics and thrasherskateboard and they are not affected. (thrasherskateboard is current broken btw). cessfull, putio and putiov2 require login so I cannot test. If it's ok to ignore those less used plugins, only sonos and tvtune are left to test. On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND bee...@gmail.com wrote: Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Sorry, I haven't had a chance to check this out yet. Please can you post a request on the TvTunes forum - and maybe ask if this is something that capfuturo and/or wgstarks can assist with testing for TvTunes (They are normally very helpful) I should hopefully be able to get time to test the Sonos one sometime soon. Rob On 11/08/2014 14:55, Thomas Amland wrote: Any progress Rob? I have already manually tested theberrics and thrasherskateboard and they are not affected. (thrasherskateboard is current broken btw). cessfull, putio and putiov2 require login so I cannot test. If it's ok to ignore those less used plugins, only sonos and tvtune are left to test. On Tue, Aug 5, 2014 at 10:48 PM, Benjamin BERTRAND bee...@gmail.com wrote: Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Hi, Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I just pushed to my repo version 2.3.0: https://github.com/beenje/script.module.requests Branch: frodo Tag: v2.3.0 You can download a zip from github, but you’ll have to rename the root directory from script.module.requests-2.3.0 to script.module.requests. I can send you a proper zip if you prefer. Would be great if you can test with your addons. Thanks /Benjamin -- Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Hi All, Just to cover the two addon's in my areas: TvTunes: The requests package is currently used for getting TV/Movie themes from Grooveshark and Soundcloud websites (televisiontunes.com and goear.com are not affected). So if this was to be published and was incompatible with these bits - it would just impact users when they tried to download a theme for an new addition in their library - and only if they use one of these two sites). Sonos: The requests is used to communicate with the Sonos Speaker - so if a requests change breaks this one - nothing will work - However I think it may actually be OK with the latest requests version. So from my point of view, although I have no need for this to be upgraded - I do understand how frustrating it can be needing something in a more recent version, so I'm happy for it to be upgraded and if some-one can let me have a pre-release copy of the updated requests module, then I'll run a couple of tests - or even better, post onto the forums so that several users could verify - the TvTunes forum has lots of helpful users that I'm sure would give it a good test and feedback the results. (BTW: I'm for updating the existing rather than having a new module added). I know very late in the day now, but maybe a sort of OSGi-like versioning system could be added in future, where for module addons, there is a version of major.minor.mico so that changing the major version highlights an incompatible API change, then users could import them into their own product something like: import addon=script.module.requests version=1.1.0 match=latest/ To get the latest version, regardless of API change, so if there were a 2.0.0 - it would get that import addon=script.module.requests version=1.1.0 match=compatible/ To get the latest version for major version 1 (with 1.1.0 being the minimum version that can be used) - in this case 2.0.0 would not be used import addon=script.module.requests version=1.1.0 match=perfect/ To force the use of an exact version You could then default import addon=script.module.requests version=1.1.0/ To one of these - maybe latest? This way this sort of issue could be avoided in future? - However, I guess this would bring it's own challenges! Rob On 02/08/2014 13:12, Thomas Amland wrote: cc On Sat, Aug 2, 2014 at 12:59 PM, Thomas Amland thomas.aml...@gmail.com wrote: On Fri, Aug 1, 2014 at 11:53 PM, Benjamin BERTRAND bee...@gmail.com wrote: That’s nice that you want to help. I did a grep in the repo and here are the plugins and scripts using requests (I removed my add ons): Ok, here's my result. I just greped the whole repo too as it was much easier: Only use get/post etc. plugin.audio.abcradionational plugin.audio.jambmc plugin.audio.qobuz plugin.video.classiccinema plugin.video.filmarkivet plugin.video.khanacademy plugin.video.newyorktimes plugin.video.noco plugin.video.nrk plugin.video.redditmusic plugin.video.rsa plugin.video.the.daily.show plugin.video.the.colbert.report plugin.video.udacity plugin.video.xbmb3c script.sonos script.tvrage.com script.xbmc.subtitles Use requests2, not requests plugin.video.oodnurdtv script.artistslideshow Extensive API usage, hard to check: plugin.video.cessfull plugin.video.putio plugin.video.putiov2 script.tvtunes Use timeout (behavior change) plugin.video.theberrics plugin.video.thrasherskateboard Only the last 6 add-ons are possibly affected. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
On Fri, Aug 1, 2014 at 11:53 PM, Benjamin BERTRAND bee...@gmail.com wrote: That’s nice that you want to help. I did a grep in the repo and here are the plugins and scripts using requests (I removed my add ons): Ok, here's my result. I just greped the whole repo too as it was much easier: Only use get/post etc. plugin.audio.abcradionational plugin.audio.jambmc plugin.audio.qobuz plugin.video.classiccinema plugin.video.filmarkivet plugin.video.khanacademy plugin.video.newyorktimes plugin.video.noco plugin.video.nrk plugin.video.redditmusic plugin.video.rsa plugin.video.the.daily.show plugin.video.the.colbert.report plugin.video.udacity plugin.video.xbmb3c script.sonos script.tvrage.com script.xbmc.subtitles Use requests2, not requests plugin.video.oodnurdtv script.artistslideshow Extensive API usage, hard to check: plugin.video.cessfull plugin.video.putio plugin.video.putiov2 script.tvtunes Use timeout (behavior change) plugin.video.theberrics plugin.video.thrasherskateboard Only the last 6 add-ons are possibly affected. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
cc On Sat, Aug 2, 2014 at 12:59 PM, Thomas Amland thomas.aml...@gmail.com wrote: On Fri, Aug 1, 2014 at 11:53 PM, Benjamin BERTRAND bee...@gmail.com wrote: That’s nice that you want to help. I did a grep in the repo and here are the plugins and scripts using requests (I removed my add ons): Ok, here's my result. I just greped the whole repo too as it was much easier: Only use get/post etc. plugin.audio.abcradionational plugin.audio.jambmc plugin.audio.qobuz plugin.video.classiccinema plugin.video.filmarkivet plugin.video.khanacademy plugin.video.newyorktimes plugin.video.noco plugin.video.nrk plugin.video.redditmusic plugin.video.rsa plugin.video.the.daily.show plugin.video.the.colbert.report plugin.video.udacity plugin.video.xbmb3c script.sonos script.tvrage.com script.xbmc.subtitles Use requests2, not requests plugin.video.oodnurdtv script.artistslideshow Extensive API usage, hard to check: plugin.video.cessfull plugin.video.putio plugin.video.putiov2 script.tvtunes Use timeout (behavior change) plugin.video.theberrics plugin.video.thrasherskateboard Only the last 6 add-ons are possibly affected. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Maybe things like this should be posted in the forums in the future. I don't think anybody reads this list.. IMO creating a new module like this is a really bad idea. Since you have renamed the module to requests2, everything that use it will be incompatible for use outside of xbmc. And the other way around: if you want to use other modules that depend on requests, you have to either modify them to import requests2 be stuck with v1 forever. Last time, you updated the module from v0.x to v1.x, which as far as I know had far more API changes requiring several add-ons to be updated simultaneously. I don't see why it would be harder this time. On Tue, Jan 21, 2014 at 3:05 PM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: Hi all, I got a pull request to update script.module.requests to v2.2.0. Current version is 1.1.0. There are a few API changes when migrating to 2.x... But they are quite limited. They probably don't impact most plugins (but I haven't checked). So the question is, would the devs using requests prefer: 1. An update of the current requests module to 2.2.0. All devs have to check if changes are needed to their plugins. 2. Creation of a new module script.module.requests2. Thanks for the feedback. /beenje -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
no one reads the forums either regards, Martijn Kaijser Team XBMC On Fri, Aug 1, 2014 at 12:52 PM, Thomas Amland thomas.aml...@gmail.com wrote: Maybe things like this should be posted in the forums in the future. I don't think anybody reads this list.. IMO creating a new module like this is a really bad idea. Since you have renamed the module to requests2, everything that use it will be incompatible for use outside of xbmc. And the other way around: if you want to use other modules that depend on requests, you have to either modify them to import requests2 be stuck with v1 forever. Last time, you updated the module from v0.x to v1.x, which as far as I know had far more API changes requiring several add-ons to be updated simultaneously. I don't see why it would be harder this time. On Tue, Jan 21, 2014 at 3:05 PM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: Hi all, I got a pull request to update script.module.requests to v2.2.0. Current version is 1.1.0. There are a few API changes when migrating to 2.x... But they are quite limited. They probably don't impact most plugins (but I haven't checked). So the question is, would the devs using requests prefer: 1. An update of the current requests module to 2.2.0. All devs have to check if changes are needed to their plugins. 2. Creation of a new module script.module.requests2. Thanks for the feedback. /beenje -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Le 1 aug 2014 à 12:52, Thomas Amland thomas.aml...@gmail.com a écrit : Maybe things like this should be posted in the forums in the future. I don't think anybody reads this list.. I know... I got a few answers anyway. And some were against the API change... For a basic usage, requests v1 is fine. IMO creating a new module like this is a really bad idea. Since you have renamed the module to requests2, everything that use it will be incompatible for use outside of xbmc. And the other way around: if you want to use other modules that depend on requests, you have to either modify them to import requests2 be stuck with v1 forever. For the outside compatibility, you can do: try: import requests2 as requests except ImportError: import requests Last time, you updated the module from v0.x to v1.x, which as far as I know had far more API changes requiring several add-ons to be updated simultaneously. I don't see why it would be harder this time. v0.x was not a stable release. That's why I didn't want to stay with it and pushed for the API changes. It did require some work: all had to submit a new addon and I pushed all the changes at the same time. I even modified an addon myself. And not many addons were using requests. This time, I didn't get feedback for several addons. I didn't want to check myself if there was an impact or not on all addons. Anyway, there is no ideal solution. If I changed the API and it broke someone addon, I'm sure they would not have been happy... All that being said, I don't think many use the requests2 module (I have to check). And I agree that having to import requests2 is not very nice. I actually think it'd be better to upgrade the requests module to v2. I just don't want to break other addons. Not easy to warn everyone. I don't think the forum is really better than the mailing list. Any suggestion? /Benjamin On Tue, Jan 21, 2014 at 3:05 PM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: Hi all, I got a pull request to update script.module.requests to v2.2.0. Current version is 1.1.0. There are a few API changes when migrating to 2.x... But they are quite limited. They probably don't impact most plugins (but I haven't checked). So the question is, would the devs using requests prefer: 1. An update of the current requests module to 2.2.0. All devs have to check if changes are needed to their plugins. 2. Creation of a new module script.module.requests2. Thanks for the feedback. /beenje -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Thanks for the warning. I would update my addon if it is impacted. On Aug 1, 2014 9:04 AM, Benjamin Bertrand bee...@gmail.com wrote: Le 1 aug 2014 à 12:52, Thomas Amland thomas.aml...@gmail.com a écrit : Maybe things like this should be posted in the forums in the future. I don't think anybody reads this list.. I know... I got a few answers anyway. And some were against the API change... For a basic usage, requests v1 is fine. IMO creating a new module like this is a really bad idea. Since you have renamed the module to requests2, everything that use it will be incompatible for use outside of xbmc. And the other way around: if you want to use other modules that depend on requests, you have to either modify them to import requests2 be stuck with v1 forever. For the outside compatibility, you can do: try: import requests2 as requests except ImportError: import requests Last time, you updated the module from v0.x to v1.x, which as far as I know had far more API changes requiring several add-ons to be updated simultaneously. I don't see why it would be harder this time. v0.x was not a stable release. That's why I didn't want to stay with it and pushed for the API changes. It did require some work: all had to submit a new addon and I pushed all the changes at the same time. I even modified an addon myself. And not many addons were using requests. This time, I didn't get feedback for several addons. I didn't want to check myself if there was an impact or not on all addons. Anyway, there is no ideal solution. If I changed the API and it broke someone addon, I'm sure they would not have been happy... All that being said, I don't think many use the requests2 module (I have to check). And I agree that having to import requests2 is not very nice. I actually think it'd be better to upgrade the requests module to v2. I just don't want to break other addons. Not easy to warn everyone. I don't think the forum is really better than the mailing list. Any suggestion? /Benjamin On Tue, Jan 21, 2014 at 3:05 PM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: Hi all, I got a pull request to update script.module.requests to v2.2.0. Current version is 1.1.0. There are a few API changes when migrating to 2.x... But they are quite limited. They probably don't impact most plugins (but I haven't checked). So the question is, would the devs using requests prefer: 1. An update of the current requests module to 2.2.0. All devs have to check if changes are needed to their plugins. 2. Creation of a new module script.module.requests2. Thanks for the feedback. /beenje -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
On Fri, Aug 1, 2014 at 3:04 PM, Benjamin Bertrand bee...@gmail.com wrote: Le 1 aug 2014 à 12:52, Thomas Amland thomas.aml...@gmail.com a écrit : Maybe things like this should be posted in the forums in the future. I don't think anybody reads this list.. I know... I got a few answers anyway. And some were against the API change... For a basic usage, requests v1 is fine. Really? There's only one reply on the list (LS80) IMO creating a new module like this is a really bad idea. Since you have renamed the module to requests2, everything that use it will be incompatible for use outside of xbmc. And the other way around: if you want to use other modules that depend on requests, you have to either modify them to import requests2 be stuck with v1 forever. For the outside compatibility, you can do: try: import requests2 as requests except ImportError: import requests Sure, but it's more about having to maintain additional xbmc specific code. What about the next version? There are API changes, albeit minor, in v2.3.0. requests3? Last time, you updated the module from v0.x to v1.x, which as far as I know had far more API changes requiring several add-ons to be updated simultaneously. I don't see why it would be harder this time. v0.x was not a stable release. That's why I didn't want to stay with it and pushed for the API changes. It did require some work: all had to submit a new addon and I pushed all the changes at the same time. I even modified an addon myself. And not many addons were using requests. This time, I didn't get feedback for several addons. I didn't want to check myself if there was an impact or not on all addons. Anyway, there is no ideal solution. If I changed the API and it broke someone addon, I'm sure they would not have been happy... All that being said, I don't think many use the requests2 module (I have to check). And I agree that having to import requests2 is not very nice. I actually think it'd be better to upgrade the requests module to v2. I just don't want to break other addons. Not easy to warn everyone. I don't think the forum is really better than the mailing list. Any suggestion? /Benjamin I know very well, I was one of the people who had to push an update. This is all very hypothetical though. How many add-ons are we talking about here? And how many actually use the advances features that changed? Remember: v1 changed core parts of the API. v2 does not afaik, despite its version change. If you can provide a list of the add-on I'm happy to help checking them. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
This may seem obvious and perhaps bit of work, but is there any way to make the api backwards compatible by overloading for classes/functions that have changed arguments and perhaps using new names for those that return differently? Just wondering From: Benjamin Bertrand [mailto:bee...@gmail.com] Sent: Friday, August 01, 2014 9:04 AM To: Thomas Amland Cc: Benjamin Bertrand; xbmc-addons@lists.sourceforge.net Subject: Re: [Xbmc-addons] [Please Read] script.module.requests API change Le 1 aug 2014 à 12:52, Thomas Amland thomas.aml...@gmail.com mailto:thomas.aml...@gmail.com a écrit : Maybe things like this should be posted in the forums in the future. I don't think anybody reads this list.. I know... I got a few answers anyway. And some were against the API change... For a basic usage, requests v1 is fine. IMO creating a new module like this is a really bad idea. Since you have renamed the module to requests2, everything that use it will be incompatible for use outside of xbmc. And the other way around: if you want to use other modules that depend on requests, you have to either modify them to import requests2 be stuck with v1 forever. For the outside compatibility, you can do: try: import requests2 as requests except ImportError: import requests Last time, you updated the module from v0.x to v1.x, which as far as I know had far more API changes requiring several add-ons to be updated simultaneously. I don't see why it would be harder this time. v0.x was not a stable release. That's why I didn't want to stay with it and pushed for the API changes. It did require some work: all had to submit a new addon and I pushed all the changes at the same time. I even modified an addon myself. And not many addons were using requests. This time, I didn't get feedback for several addons. I didn't want to check myself if there was an impact or not on all addons. Anyway, there is no ideal solution. If I changed the API and it broke someone addon, I'm sure they would not have been happy... All that being said, I don't think many use the requests2 module (I have to check). And I agree that having to import requests2 is not very nice. I actually think it'd be better to upgrade the requests module to v2. I just don't want to break other addons. Not easy to warn everyone. I don't think the forum is really better than the mailing list. Any suggestion? /Benjamin On Tue, Jan 21, 2014 at 3:05 PM, Benjamin Bertrand bee...@xboxmediacenter.com mailto:bee...@xboxmediacenter.com wrote: Hi all, I got a pull request to update script.module.requests to v2.2.0. Current version is 1.1.0. There are a few API changes when migrating to 2.x... But they are quite limited. They probably don't impact most plugins (but I haven't checked). So the question is, would the devs using requests prefer: 1. An update of the current requests module to 2.2.0. All devs have to check if changes are needed to their plugins. 2. Creation of a new module script.module.requests2. Thanks for the feedback. /beenje -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431 http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktr k iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net mailto:Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net mailto:Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons http://s.bl-1.com/f9m3bR7.gif -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Le 1 août 2014 à 16:35, Thomas Amland thomas.aml...@gmail.com a écrit : On Fri, Aug 1, 2014 at 3:04 PM, Benjamin Bertrand bee...@gmail.com wrote: Le 1 aug 2014 à 12:52, Thomas Amland thomas.aml...@gmail.com a écrit : Maybe things like this should be posted in the forums in the future. I don't think anybody reads this list.. I know... I got a few answers anyway. And some were against the API change... For a basic usage, requests v1 is fine. Really? There's only one reply on the list (LS80) Might have got some addressed to me only and not to the list. Not many, 3 or 4 maybe. Don’t remember exactly. IMO creating a new module like this is a really bad idea. Since you have renamed the module to requests2, everything that use it will be incompatible for use outside of xbmc. And the other way around: if you want to use other modules that depend on requests, you have to either modify them to import requests2 be stuck with v1 forever. For the outside compatibility, you can do: try: import requests2 as requests except ImportError: import requests Sure, but it's more about having to maintain additional xbmc specific code. What about the next version? There are API changes, albeit minor, in v2.3.0. requests3? I’d propose request23 :-) Just kidding. Last time, you updated the module from v0.x to v1.x, which as far as I know had far more API changes requiring several add-ons to be updated simultaneously. I don't see why it would be harder this time. v0.x was not a stable release. That's why I didn't want to stay with it and pushed for the API changes. It did require some work: all had to submit a new addon and I pushed all the changes at the same time. I even modified an addon myself. And not many addons were using requests. This time, I didn't get feedback for several addons. I didn't want to check myself if there was an impact or not on all addons. Anyway, there is no ideal solution. If I changed the API and it broke someone addon, I'm sure they would not have been happy... All that being said, I don't think many use the requests2 module (I have to check). And I agree that having to import requests2 is not very nice. I actually think it'd be better to upgrade the requests module to v2. I just don't want to break other addons. Not easy to warn everyone. I don't think the forum is really better than the mailing list. Any suggestion? /Benjamin I know very well, I was one of the people who had to push an update. This is all very hypothetical though. How many add-ons are we talking about here? And how many actually use the advances features that changed? Remember: v1 changed core parts of the API. v2 does not afaik, despite its version change. If you can provide a list of the add-on I'm happy to help checking them. That’s nice that you want to help. I did a grep in the repo and here are the plugins and scripts using requests (I removed my add ons): plugin.audio.abcradionational plugin.audio.jambmc plugin.audio.qobuz plugin.video.abcradionational plugin.video.cessfull plugin.video.classiccinema plugin.video.filmarkivet plugin.video.khanacademy plugin.video.newyorktimes plugin.video.noco plugin.video.nrk plugin.video.oodnurdtv plugin.video.putio plugin.video.putiov2 plugin.video.redditmusic plugin.video.rsa plugin.video.the.colbert.report plugin.video.the.daily.show plugin.video.theberrics plugin.video.thrasherskateboard plugin.video.udacity plugin.video.xbmb3c script.artistslideshow script.sonos script.tvrage.com script.tvtunes script.xbmc.subtitles -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
A requests update sounds a good idea (I see it's now up to 2.2.1 btw) Looks as though the only API changes that could cause a problem are 1. DIfferent exceptions thrown in some situations 2. Specifying a proxy now requires the scheme http://docs.python-requests.org/en/latest/api/#migrating-to-2-x https://github.com/kennethreitz/requests/blob/master/HISTORY.rst The other API changes are new methods. I don't think a new module name is required, but either way it would be nice to have an update available. On 21 January 2014 14:05, Benjamin Bertrand bee...@xboxmediacenter.comwrote: Hi all, I got a pull request to update script.module.requests to v2.2.0. Current version is 1.1.0. There are a few API changes when migrating to 2.x... But they are quite limited. They probably don't impact most plugins (but I haven't checked). So the question is, would the devs using requests prefer: 1. An update of the current requests module to 2.2.0. All devs have to check if changes are needed to their plugins. 2. Creation of a new module script.module.requests2. Thanks for the feedback. /beenje -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
[Xbmc-addons] [Please Read] script.module.requests API change
Hi all, I got a pull request to update script.module.requests to v2.2.0. Current version is 1.1.0. There are a few API changes when migrating to 2.x... But they are quite limited. They probably don't impact most plugins (but I haven't checked). So the question is, would the devs using requests prefer: 1. An update of the current requests module to 2.2.0. All devs have to check if changes are needed to their plugins. 2. Creation of a new module script.module.requests2. Thanks for the feedback. /beenje -- CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431iu=/4140/ostg.clktrk ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Thanks for the replies. Will do the push when I got the updates for all the plugins. On Sat, Dec 29, 2012 at 11:56 PM, stacked xbmc stacked.x...@gmail.comwrote: I have no problem with the update. I just had to make a small change to make PBS compatible with requests v1.0.4 - stacked On Sat, Dec 29, 2012 at 2:33 PM, Jonathan Beluch jbelu...@gmail.comwrote: Making a new package is a possibility. That's why I'm asking the devs using it their opinion. But I think that for frodo, it would be better to move to v1.0.0 which has a stable API. Not that many plugins use the requests module. So, if all devs agree to send me an update, I can push them at the same time as the new requests module. That's the plan. I don't want to break anything. I agree we should just update the current package rather than making a new one. I'll work on my 3 addons (classiccinema, newyorktimes and redditmusic) that depend on requests and have updates to you in a day or so. Jon -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912 ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
How about making a new package instead? Name it requests1 or something? I maintain one of those (it will definitely break on update of requests). I can probably update my plugin next week, but the problem is that requests v1 is not forward compatible either. For instance Response.json was a property now changed to a method. Unless they're updated at the same time, the plugin *will* break. But if you're going to do it, I guess it's better to do it now when frodo is still in beta. On Sat, Dec 29, 2012 at 12:10 AM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: Hi all, Requests v1.0.0 was released a few days ago and defines the public API. Requests 0.13.2 is currently available in eden and frodo repos and is used by the following plugins: plugin.video.arretsurimages plugin.video.classiccinema plugin.video.filmarkivet plugin.video.m6groupe plugin.video.newyorktimes plugin.video.nrk plugin.video.pbs plugin.video.redditmusic I was thinking about updating it to v1.0.4 for frodo but there are some API changes. See http://kennethreitz.org/announcing-requests-v100.html for details. You can test your plugin with the new requests available here: https://github.com/beenje/script.module.requests/archive/v1.0.4.zip Would all the devs impacted be ok to update their plugin (if needed) for this new release? That would be a good occasion to update the plugins for frodo (with xbmc.python 2.1.0) ;-) I could wait a few days for the updates before to do the push. If your plugin is impacted, please reply. Thanks beenje -- Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812 ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Making a new package is a possibility. That's why I'm asking the devs using it their opinion. But I think that for frodo, it would be better to move to v1.0.0 which has a stable API. Not that many plugins use the requests module. So, if all devs agree to send me an update, I can push them at the same time as the new requests module. That's the plan. I don't want to break anything. I agree we should just update the current package rather than making a new one. I'll work on my 3 addons (classiccinema, newyorktimes and redditmusic) that depend on requests and have updates to you in a day or so. Jon -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
Re: [Xbmc-addons] [Please Read] script.module.requests API change
Le 29 déc. 2012 à 22:29, Thomas Amland thomas.aml...@gmail.com a écrit : How about making a new package instead? Name it requests1 or something? I maintain one of those (it will definitely break on update of requests). I can probably update my plugin next week, but the problem is that requests v1 is not forward compatible either. For instance Response.json was a property now changed to a method. Unless they're updated at the same time, the plugin will break. But if you're going to do it, I guess it's better to do it now when frodo is still in beta. Making a new package is a possibility. That's why I'm asking the devs using it their opinion. But I think that for frodo, it would be better to move to v1.0.0 which has a stable API. Not that many plugins use the requests module. So, if all devs agree to send me an update, I can push them at the same time as the new requests module. That's the plan. I don't want to break anything. On Sat, Dec 29, 2012 at 12:10 AM, Benjamin Bertrand bee...@xboxmediacenter.com wrote: Hi all, Requests v1.0.0 was released a few days ago and defines the public API. Requests 0.13.2 is currently available in eden and frodo repos and is used by the following plugins: plugin.video.arretsurimages plugin.video.classiccinema plugin.video.filmarkivet plugin.video.m6groupe plugin.video.newyorktimes plugin.video.nrk plugin.video.pbs plugin.video.redditmusic I was thinking about updating it to v1.0.4 for frodo but there are some API changes. See http://kennethreitz.org/announcing-requests-v100.html for details. You can test your plugin with the new requests available here: https://github.com/beenje/script.module.requests/archive/v1.0.4.zip Would all the devs impacted be ok to update their plugin (if needed) for this new release? That would be a good occasion to update the plugins for frodo (with xbmc.python 2.1.0) ;-) I could wait a few days for the updates before to do the push. If your plugin is impacted, please reply. Thanks beenje -- Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812 ___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
[Xbmc-addons] [Please Read] script.module.requests API change
Hi all, Requests v1.0.0 was released a few days ago and defines the public API. Requests 0.13.2 is currently available in eden and frodo repos and is used by the following plugins: plugin.video.arretsurimages plugin.video.classiccinema plugin.video.filmarkivet plugin.video.m6groupe plugin.video.newyorktimes plugin.video.nrk plugin.video.pbs plugin.video.redditmusic I was thinking about updating it to v1.0.4 for frodo but there are some API changes. See http://kennethreitz.org/announcing-requests-v100.html for details. You can test your plugin with the new requests available here: https://github.com/beenje/script.module.requests/archive/v1.0.4.zip Would all the devs impacted be ok to update their plugin (if needed) for this new release? That would be a good occasion to update the plugins for frodo (with xbmc.python 2.1.0) ;-) I could wait a few days for the updates before to do the push. If your plugin is impacted, please reply. Thanks beenje -- Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812___ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
