[Xen-devel] [ovmf baseline-only test] 68026: all pass
This run is configured for baseline tests only. flight 68026 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68026/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf faabc5d49700a5042535ff30a07e2c9577ed3cd8 baseline version: ovmf c3c9892c3b4dafd1d0ccdc8e5e017d80e8c4361e Last test of basis68021 2016-11-09 17:16:38 Z3 days Testing same since68026 2016-11-10 17:16:47 Z2 days1 attempts People who touched revisions under test: Maurice Ma jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvopspass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass sg-report-flight on osstest.xs.citrite.net logs: /home/osstest/logs images: /home/osstest/images Logs, config files, etc. are available at http://osstest.xs.citrite.net/~osstest/testlogs/logs Test harness code can be found at http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary Push not applicable. commit faabc5d49700a5042535ff30a07e2c9577ed3cd8 Author: Maurice Ma Date: Tue Nov 8 15:54:24 2016 -0800 CorebootPayloadPkg: Fix GCC build issue on macro definition The previous change to disable deprecated APIs in CorebootPayloadPkg used "/D" instead of "-D". It caused Linux GCC build error. Correct it to use "-D" instead. Cc: Prince Agyeman Cc: Rusty Coleman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma Reviewed-by: Prince Agyeman Reviewed-by: Rusty Coleman ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [qemu-mainline test] 102163: regressions - trouble: blocked/broken/fail/pass
flight 102163 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/102163/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3863 host-install(3)broken REGR. vs. 101909 test-amd64-amd64-libvirt 11 guest-start fail REGR. vs. 101909 test-amd64-amd64-xl-qcow2 9 debian-di-installfail REGR. vs. 101909 test-amd64-amd64-libvirt-xsm 11 guest-start fail REGR. vs. 101909 test-amd64-amd64-libvirt-vhd 9 debian-di-installfail REGR. vs. 101909 test-armhf-armhf-libvirt-qcow2 9 debian-di-install fail REGR. vs. 101909 test-amd64-amd64-libvirt-pair 20 guest-start/debian fail REGR. vs. 101909 test-armhf-armhf-libvirt-raw 9 debian-di-installfail REGR. vs. 101909 test-armhf-armhf-xl-vhd 9 debian-di-installfail REGR. vs. 101909 test-armhf-armhf-libvirt-xsm 11 guest-start fail REGR. vs. 101909 test-armhf-armhf-libvirt 11 guest-start fail REGR. vs. 101909 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail like 101909 test-amd64-amd64-xl-rtds 9 debian-install fail like 101909 Tests which did not succeed, but are not blocking: test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-winxpsp3 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a build-i386-libvirt1 build-check(1) blocked n/a test-amd64-i386-xl1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-arndale 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass version targeted for testing: qemuu83c83f9a5266ff113060f887f106a47920fa6974 baseline version: qemuu199a5bde46b0eab898ab1ec591f423000302569f Last test of basis 101909 2016-11-03 23:21:40 Z9 days Failing since101943 2016-11-04 22:40:48 Z8 days 14 attempts Testing same since 102163 2016-11-12 17:17:54 Z0 days1 attempts People who touched revisions under test: ann.zhuangyany...@huawei.com Christian Borntraeger Cornelia Huck Doug Evans Eric Blake Fam Zheng Gerd Hoffmann John Snow Julian Brown Kevin Wolf Li Qiang Marc-André Lureau Marcin Krzeminski Max Reitz Michael Tokarev Olaf Hering Paolo Bonzini Peter Korsgaard Peter Maydell Prasad J Pandit Samuel Thibault Sander Eikel
[Xen-devel] [xen-unstable test] 102160: regressions - trouble: broken/fail/pass
flight 102160 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/102160/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 3 host-install(3) broken REGR. vs. 102146 test-amd64-amd64-xl-qemut-winxpsp3 3 host-install(3) broken REGR. vs. 102146 test-armhf-armhf-xl-xsm 15 guest-start/debian.repeat fail REGR. vs. 102133 test-armhf-armhf-xl-cubietruck 15 guest-start/debian.repeat fail REGR. vs. 102146 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 6 xen-boot fail REGR. vs. 102146 test-armhf-armhf-xl-rtds15 guest-start/debian.repeat fail REGR. vs. 102146 test-armhf-armhf-libvirt-xsm 13 saverestore-support-checkfail like 102146 test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 102146 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stopfail like 102146 test-armhf-armhf-libvirt-raw 12 saverestore-support-checkfail like 102146 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 102146 test-armhf-armhf-libvirt-qcow2 12 saverestore-support-check fail like 102146 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail like 102146 test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail like 102146 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-amd64-i386-libvirt 12 migrate-support-checkfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 11 migrate-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-arndale 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-vhd 11 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 12 saverestore-support-checkfail never pass version targeted for testing: xen 67b5b302f5319f70288587dc98ab505c4deada1e baseline version: xen 043ad80d4fad75651e825ef3f935be52f2d6fda0 Last test of basis 102146 2016-11-12 04:58:02 Z0 days Testing same since 102160 2016-11-12 14:27:38 Z0 days1 attempts People who touched revisions under test: Andrew Cooper Boris Ostrovsky Jan Beulich Wei Liu jobs: build-amd64-xsm pass build-armhf-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-armhf-libvirt pass
[Xen-devel] [linux-3.4 baseline-only test] 68023: regressions - FAIL
This run is configured for baseline tests only. flight 68023 linux-3.4 real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68023/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-raw9 debian-di-install fail REGR. vs. 44372 test-amd64-amd64-libvirt-vhd 9 debian-di-install fail REGR. vs. 44372 test-amd64-amd64-amd64-pvgrub 9 debian-di-installfail REGR. vs. 44372 test-amd64-amd64-xl-qcow2 9 debian-di-install fail REGR. vs. 44372 test-amd64-amd64-pygrub 9 debian-di-install fail REGR. vs. 44372 test-amd64-amd64-i386-pvgrub 9 debian-di-install fail REGR. vs. 44372 Tests which did not succeed, but are not blocking: test-amd64-amd64-rumprun-amd64 1 build-check(1) blocked n/a test-amd64-i386-rumprun-i386 1 build-check(1) blocked n/a build-amd64-rumprun 6 xen-buildfail never pass test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-i386-libvirt 12 migrate-support-checkfail never pass build-i386-rumprun6 xen-buildfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail never pass test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stop fail never pass test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail never pass test-amd64-amd64-qemuu-nested-intel 16 debian-hvm-install/l1/l2 fail never pass test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass version targeted for testing: linux8d1988f838a95e836342b505398d38b223181f17 baseline version: linux343a5fbeef08baf2097b8cf4e26137cebe3cfef4 Last test of basis44372 2016-04-29 15:54:02 Z 197 days Testing same since68023 2016-11-10 04:17:17 Z2 days1 attempts People who touched revisions under test: "Suzuki K. Poulose" Aaro Koskinen Al Viro Alan Stern Aleksander Morgado Alex Thorlton Alexandru Cornea Alexey Khoroshilov Amitkumar Karwar Andrew Banman Andrew Morton Andrey Ryabinin Anson Huang Arnaldo Carvalho de Melo Arnaldo Carvalho de Melo Arnd Bergmann Ben Hutchings Bjørn Mork Boris Brezillon Borislav Petkov Brian Norris Charles Keepax Chen Yu Christoph Hellwig Chunfeng Yun Clemens Ladisch Colin Ian King Cong Wang Daeho Jeong Dan Carpenter Darren Hart Dave Airlie David Howells David Rientjes David S. Miller David Turner David Vrabel David Woodhouse Dmitry Tunin Dmitry V. Levin Dmitry Vyukov Eric Dumazet Eric Dumazet Felipe Balbi Filipe Manana Francesco Ruggeri Francesco Ruggeri Greg Kroah-Hartman Helge Deller Herbert Xu Hillf Danton Hobin Woo Hu Ingo Molnar James Bottomley James Bottomley James Morris Jan Beulich Jan Kara Jason A. Donenfeld Jeff Layton Jeff Layton Jens Axboe Jiri Kosina Jiri Slaby Joe Thornber Johan Hovold Johannes Berg Johannes Thumshirn John Stultz Jonathan Cameron Joseph Qi Kalle Valo Karl Heiss Kashyap Desai Kees Cook Kinglong Mee Kirill A. Shutemov Konrad Rzeszutek Wilk Konstantin Khlebnikov Konstantin Shkolnyy Larry Finger Li Bin libin Linus Torvalds lucien Lv Zheng Maciej W. Rozycki Marc Kleine-Budde Marcel Holtmann Marcelo Ricardo Leitner Mark Brown Martin K. Petersen Mathias Nyman Mauricio Faria de Oliveira Michal Hocko Michal Kubecek Michal KubeÄek Mike Snitzer Miklos Szeredi Mikulas Patocka Mirza Krak Naoya Horiguchi Neal Cardwell Neil Horman Nicolas Dichtel Nikolay Aleksandrov Paul Bolle Pavel Tikhomirov Pete Zaitcev Peter Hurley Peter Oberparleiter Peter Zijlstra (Intel) Peter Zijlstra Rafael J. Wysocki Ralf Baechle Richard Purdie Robert Jarzmik Roger Pau Monné Roman Gushchin Russell King Sabrina Dubroca Sachin Pandhare Sebastian Reichel Sergei Shtylyov Stefan Richter Stephan Mueller Steven Rostedt (Red Hat) Steven Rostedt Sumit Saxena sumit.sax...@avagotech.com Takashi Iwai
[Xen-devel] [qemu-mainline test] 102151: regressions - FAIL
flight 102151 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/102151/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 11 guest-start fail REGR. vs. 101909 test-amd64-i386-libvirt 11 guest-start fail REGR. vs. 101909 test-amd64-amd64-libvirt-xsm 11 guest-start fail REGR. vs. 101909 test-amd64-i386-libvirt-pair 20 guest-start/debian fail REGR. vs. 101909 test-amd64-amd64-libvirt-vhd 9 debian-di-installfail REGR. vs. 101909 test-amd64-amd64-xl-qcow2 9 debian-di-installfail REGR. vs. 101909 test-amd64-i386-libvirt-xsm 11 guest-start fail REGR. vs. 101909 test-amd64-amd64-libvirt-pair 20 guest-start/debian fail REGR. vs. 101909 test-armhf-armhf-libvirt-raw 9 debian-di-installfail REGR. vs. 101909 test-armhf-armhf-libvirt-xsm 11 guest-start fail REGR. vs. 101909 test-armhf-armhf-libvirt 11 guest-start fail REGR. vs. 101909 test-armhf-armhf-xl-vhd 9 debian-di-installfail REGR. vs. 101909 test-armhf-armhf-libvirt-qcow2 9 debian-di-install fail in 102138 REGR. vs. 101909 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 15 guest-start/debian.repeat fail in 102138 pass in 102151 test-amd64-amd64-amd64-pvgrub 9 debian-di-install fail in 102138 pass in 102151 test-armhf-armhf-libvirt-qcow2 6 xen-boot fail pass in 102138 Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 101909 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail like 101909 test-armhf-armhf-xl-rtds 15 guest-start/debian.repeatfail like 101909 test-amd64-amd64-xl-rtds 9 debian-install fail like 101909 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-arndale 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-xl-xsm 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass version targeted for testing: qemuu6bbcb76301a72dc80c8d29af13d40bb9a759c9c6 baseline version: qemuu199a5bde46b0eab898ab1ec591f423000302569f Last test of basis 101909 2016-11-03 23:21:40 Z8 days Failing since101943 2016-11-04 22:40:48 Z7 days 13 attempts Testing same since 102100 2016-11-11 00:42:45 Z1 days4 attempts People who touched revisions under test: Christian Borntraeger Cornelia Huck Fam Zheng Gerd Hoffmann John Snow Julian Brown Kevin Wolf Li Qiang Marcin Krzeminski Max Reitz Olaf Hering Paolo Bonzini Peter Korsgaard Peter Maydell Prasad J Pandit Samuel Thibault Sander Eikelenboom Stefan Hajnoczi Stefano Stabellini Thomas Huth Wei Liu jobs: build-amd64-xsm pass build-armhf-xsm pass build-i386-xsm pass build-amd64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-armhf-libvirt pass build-i386-libvirt
Re: [Xen-devel] [PATCH v2 03/11] pvh: Set online VCPU map to avail_vcpus
On Fri, Nov 11, 2016 at 02:57:58PM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 09, 2016 at 09:39:51AM -0500, Boris Ostrovsky wrote: > > ACPI builder marks VCPUS set in vcpu_online map as enabled in MADT. > > With ACPI-based CPU hotplug we only want VCPUs that are started by > > the guest to be marked as such. Remaining VCPUs will be set to > > "enable" by AML code during hotplug. > > > > Signed-off-by: Boris Ostrovsky > > Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 10/12] xenstore: add helper functions for wire argument parsing
On Fri, Nov 11, 2016 at 09:00:08AM +0100, Juergen Gross wrote: > The xenstore wire command argument parsing of the different commands > is repeating some patterns multiple times. Add some helper functions > to avoid the duplicated code. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 11/12] xenstore: add small default data buffer to internal struct
On Fri, Nov 11, 2016 at 09:00:09AM +0100, Juergen Gross wrote: > Instead of always allocating a data buffer for incoming or outgoing > xenstore wire data add a small buffer to the buffered_data structure > of xenstored. This has the advantage that especially sending simple > response messages like errors or "OK" will no longer need allocating > a data buffer. This requires adding a memory context where the > allocated buffer was used for that purpose. > > In order to avoid allocating a new buffered_data structure for each > response reuse the structure of the original request. This in turn > will avoid any new memory allocations for sending e.g. an ENOMEM > response making it possible to send it at all. To do this the > allocation of the buffered_data structure for the incoming request > must be done when a new request is recognized instead of doing it > when accepting a new connect. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 12/12] xenstore: handle memory allocation failures in xenstored
On Fri, Nov 11, 2016 at 12:07:16PM +0100, Juergen Gross wrote: > On 11/11/16 09:00, Juergen Gross wrote: > > Check for failures when allocating new memory in xenstored. > > > > Unfortunately there are several conditions which might render those > > checks void: It might be impossible to send an "ENOMEM" response as > > this requires allocating some memory. > > Uuh, sorry. This paragraph can be deleted, as patch 11 now takes > care of the situation. > > In case another round is needed I'll modify the commit message. > Otherwise I can either resend just this patch if necessary. > Acked-by: Wei Liu > > Juergen ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 04/12] xenstore: add per-node generation counter
On Fri, Nov 11, 2016 at 09:00:02AM +0100, Juergen Gross wrote: > In order to be able to support reading the list of a node's children in > multiple chunks (needed for list sizes > 4096 bytes) without having to > allocate a temporary buffer we need some kind of generation counter for > each node. This will help to recognize a node has changed between > reading two chunks. > > As removing a node and reintroducing it must result in different > generation counts each generation value has to be globally unique. This > can be ensured only by using a global 64 bit counter. > > For handling of transactions there is already such a counter available, > it just has to be expanded to 64 bits and must be stored in each > modified node. > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 08/12] xenstore: let command functions return error or success
On Fri, Nov 11, 2016 at 09:00:06AM +0100, Juergen Gross wrote: > Add a return value to all wire command functions of xenstored. If such > a function returns an error send the error message in > process_message(). > > Signed-off-by: Juergen Gross As far as I can tell, this is merely refactoring existing code and has no functional change -- we should probably say so in the commit message. Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 06/12] xenstore: support XS_DIRECTORY_PART in libxenstore
On Fri, Nov 11, 2016 at 09:00:04AM +0100, Juergen Gross wrote: > This will enable all users of libxenstore to handle xenstore nodes > with a huge amount of children. > > In order to not depend completely on the XS_DIRECTORY_PART > functionality use it only in case of E2BIG returned by XS_DIRECTORY. > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 05/12] xenstore: add support for reading directory with many children
On Fri, Nov 11, 2016 at 09:00:03AM +0100, Juergen Gross wrote: > As the payload size for one xenstore wire command is limited to 4096 > bytes it is impossible to read the children names of a node with a > large number of children (e.g. /local/domain in case of a host with > more than about 2000 domains). This effectively limits the maximum > number of domains a host can support. > > In order to support such long directory outputs add a new wire command > XS_DIRECTORY_PART which will return only some entries in each call and > can be called in a loop to get all entries. > > Input data are the path of the node and the byte offset into the child > list where returned data should start. > > Output is the generation count of the node (which will change each time > the node is being modified) and a list of child names starting with > the specified index. The end of the list is indicated by an empty > child name. It is the responsibility of the caller to check for data > consistency by comparing the generation counts of all returned data > sets to be the same for one node. > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu (with Jan's comment addressed) ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 07/12] xenstore: use array for xenstore wire command handling
On Fri, Nov 11, 2016 at 09:00:05AM +0100, Juergen Gross wrote: > Instead of switch() statements for selecting wire command actions use > an array for this purpose. > > While doing this add the XS_RESTRICT type for diagnostic prints and > correct the printed string for XS_IS_DOMAIN_INTRODUCED. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 03/12] xenstore: use common tdb record header in xenstore
On Fri, Nov 11, 2016 at 09:00:01AM +0100, Juergen Gross wrote: > The layout of the tdb record of xenstored is defined at multiple > places: read_node(), write_node() and in xs_tdb_dump.c > > Use a common structure instead. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 02/12] xenstore: call add_change_node() directly when writing node
On Fri, Nov 11, 2016 at 09:00:00AM +0100, Juergen Gross wrote:
> Instead of calling add_change_node() at places where write_node() is
> called, do that inside write_node().
>
> Signed-off-by: Juergen Gross
There seems to be a subtle change in behaviour -- previously in
create_node, there is no add_chnage_node called. Now it has.
> ---
> tools/xenstore/xenstored_core.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
> index de1a9b4..1354387 100644
> --- a/tools/xenstore/xenstored_core.c
> +++ b/tools/xenstore/xenstored_core.c
> @@ -456,7 +456,7 @@ static struct node *read_node(struct connection *conn,
> const void *ctx,
> return node;
> }
>
> -static bool write_node(struct connection *conn, const struct node *node)
> +static bool write_node(struct connection *conn, struct node *node)
> {
> /*
>* conn will be null when this is called from manual_node.
> @@ -476,6 +476,8 @@ static bool write_node(struct connection *conn, const
> struct node *node)
> if (domain_is_unprivileged(conn) && data.dsize >= quota_max_entry_size)
> goto error;
>
> + add_change_node(conn, node, false);
> +
Another subtle change of behaviour -- there is another goto error after
this, which means the change is not made as far as the caller is
concerned if that path is taken.
Not saying that all these changes are wrong, but they are worth pointing
out and probably we should put the reasoning into commit message.
> data.dptr = talloc_size(node, data.dsize);
> ((uint32_t *)data.dptr)[0] = node->num_perms;
> ((uint32_t *)data.dptr)[1] = node->datalen;
> @@ -976,7 +978,6 @@ static void do_write(struct connection *conn, struct
> buffered_data *in)
> }
> }
>
> - add_change_node(conn, node, false);
> fire_watches(conn, in, name, false);
> send_ack(conn, XS_WRITE);
> }
> @@ -1007,7 +1008,6 @@ static void do_mkdir(struct connection *conn, struct
> buffered_data *in)
> send_error(conn, errno);
> return;
> }
> - add_change_node(conn, node, false);
> fire_watches(conn, in, name, false);
> }
> send_ack(conn, XS_MKDIR);
> @@ -1209,7 +1209,6 @@ static void do_set_perms(struct connection *conn,
> struct buffered_data *in)
> return;
> }
>
> - add_change_node(conn, node, false);
> fire_watches(conn, in, name, false);
> send_ack(conn, XS_SET_PERMS);
> }
> --
> 2.6.6
>
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 01/12] xenstore: modify add_change_node() parameter types
On Fri, Nov 11, 2016 at 08:59:59AM +0100, Juergen Gross wrote: > In order to prepare adding a generation count to each node modify > add_change_node() to take the connection pointer and a node pointer > instead of the transaction pointer and node name as parameters. This > requires moving the call of add_change_node() from do_rm() to > delete_node_single(). > > While at it correct the comment for the prototype: there is no > longjmp() involved. > > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v7 1/6] VMX: Permanently assign PI hook vmx_pi_switch_to()
On November 12, 2016 4:14:50 AM EST, "Wu, Feng" wrote: >> > diff --git a/xen/arch/x86/hvm/vmx/vmx.c >b/xen/arch/x86/hvm/vmx/vmx.c >> > index 3d330b6..10546af 100644 >> > --- a/xen/arch/x86/hvm/vmx/vmx.c >> > +++ b/xen/arch/x86/hvm/vmx/vmx.c >> > @@ -222,8 +222,13 @@ void vmx_pi_hooks_deassign(struct domain *d) >> > >> > d->arch.hvm_domain.vmx.vcpu_block = NULL; >> > d->arch.hvm_domain.vmx.pi_switch_from = NULL; >> > -d->arch.hvm_domain.vmx.pi_switch_to = NULL; >> > d->arch.hvm_domain.vmx.pi_do_resume = NULL; >> > + >> > +/* >> > + * In fact, we could remove 'vmx_pi_switch_to' inside itself >if no new >> device >> >> I am having a hard time parsing that. What is the 'inside itself'? > >Thanks for your review. It means we could set ' >d->arch.hvm_domain.vmx.pi_switch_to' >to NULL in vmx_pi_switch_to(). It would be good if you have any better >description! :) Your above description is perfect: "We could set d-arch.hvm_domain.vmx.pi_switch_to to NULL in vmx_pi_switch_to() if no new device ..." Thanks! ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [xen-unstable test] 102146: tolerable FAIL
flight 102146 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/102146/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-xsm 6 xen-boot fail pass in 102133 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt-xsm 13 saverestore-support-checkfail like 102133 test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 102133 test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 102133 test-amd64-amd64-xl-qemut-win7-amd64 16 guest-stopfail like 102133 test-armhf-armhf-libvirt-raw 12 saverestore-support-checkfail like 102133 test-armhf-armhf-libvirt-qcow2 12 saverestore-support-check fail like 102133 test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail like 102133 test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail like 102133 test-amd64-amd64-xl-rtds 9 debian-install fail like 102133 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-xsm 12 migrate-support-check fail in 102133 never pass test-armhf-armhf-xl-xsm 13 saverestore-support-check fail in 102133 never pass test-amd64-amd64-xl-pvh-amd 11 guest-start fail never pass test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-amd64-amd64-xl-pvh-intel 11 guest-start fail never pass test-amd64-i386-libvirt 12 migrate-support-checkfail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 11 migrate-support-checkfail never pass test-amd64-amd64-qemuu-nested-amd 16 debian-hvm-install/l1/l2 fail never pass test-armhf-armhf-xl-arndale 12 migrate-support-checkfail never pass test-armhf-armhf-xl-arndale 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 12 migrate-support-checkfail never pass test-armhf-armhf-xl-credit2 13 saverestore-support-checkfail never pass test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-cubietruck 12 migrate-support-checkfail never pass test-armhf-armhf-xl-cubietruck 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-multivcpu 12 migrate-support-checkfail never pass test-armhf-armhf-xl-multivcpu 13 saverestore-support-checkfail never pass test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 12 migrate-support-checkfail never pass test-armhf-armhf-xl-rtds 13 saverestore-support-checkfail never pass test-armhf-armhf-xl-vhd 11 migrate-support-checkfail never pass test-armhf-armhf-xl-vhd 12 saverestore-support-checkfail never pass version targeted for testing: xen 043ad80d4fad75651e825ef3f935be52f2d6fda0 baseline version: xen 043ad80d4fad75651e825ef3f935be52f2d6fda0 Last test of basis 102146 2016-11-12 04:58:02 Z0 days Testing same since0 1970-01-01 00:00:00 Z 17117 days0 attempts jobs: build-amd64-xsm pass build-armhf-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-oldkern pass build-i386-oldkern pass build-amd64-prev pass build-i386-prev pass build-amd64-pvopspass build-armhf-pvopspass build-i386-pvops
Re: [Xen-devel] [PATCH v8] This is ABI for the two halves of a Para-virtual sound driver to communicate with each to other.
Hi, Konrad! First of all thank you for reviewing and providing valuable comments! I will put action items/TODOs at the very beginning, so we can see the summary. Also, please see answers inline. 1. Change frontend-id to frontend_id 2. Think about having a single sound card configured with a bunch of different devices/streams 3. State that sample rates and formats expressed as decimals w/o any particular ordering 4. Put description of migration/disconnection state 5. Change __attribute__((packed)) to __packed (scripts/checkpatch.pl) 6. Padding to fit cache line? What is its size (ARM/x86...) - need to discuss 7. Change GPL header to BSD 8. Remove #ifdef __KERNEL 9. Remove "Multiple PV drivers are allowed in the domain at the same time." 10. Support a single card as device/stream configuration allows fine tuning already 11. Explicitly say which indices in XenStore configuration are contiguous 12. For strings "If not defined then use frontend's default." add more description: "This default is depends on concrete PV frontend implementation" 13. Make names of cards/devices optional Thank you very much, Oleksandr On Fri, Nov 11, 2016 at 11:24 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 04, 2016 at 10:51:33PM +0200, Andrushchenko, Oleksandr wrote: >> Signed-off-by: Oleksandr Dmytryshyn >> Signed-off-by: Iurii Konovalenko >> Signed-off-by: Andrushchenko, Oleksandr >> Signed-off-by: Oleksandr Grytsov >> --- >> Changes since v1: >> * removed __attribute__((__packed__)) from all structures definitions >> >> Changes since v2: >> * removed all C structures >> * added protocol description between frontend and backend drivers >> >> Changes since v3: >> * fixed some typos >> * renamed XENSND_PCM_FORMAT_FLOAT_** to XENSND_PCM_FORMAT_F32_** >> * renamed XENSND_PCM_FORMAT_FLOAT64_** to XENSND_PCM_FORMAT_F64_** >> * added 'id' field to the request and response packets >> * renamed 'stream_id' to 'stream' in the packets description >> * renamed 'pcm_data_rate' to 'pcm_rate' in the packets description >> * renamed 'pcm_stream_type' to 'pcm_type' in the packets description >> * removed 'stream_id' field from the response packets >> >> Changes since v4: >> * renamed 'stream_id' back to the to 'stream' in the packets description >> * moved 'id' field to the upper position in the response packets >> >> Changes since v5: >> * Slightly reworked request/response packets >> * Size of the request/response packet is changed to the 64 bytes >> * Now parameters for the XENSND_OP_SET_VOLUME/XENSND_OP_GET_VOLUME are >>passed via shared page >> * Added parameters for the XenBus nodes (now each stream can be mapped >>to the defined sound device in the backend using those parameters) >> * Added XenBus state diagrams description >> >> Changes since v6: >> * Reworked streams description in the Backend XenBus Nodes >> >> Changes since v7: >> * re-worked backend device parameters to be more generic and flexible >> * extended frontend device parameters >> * slightly updated state machine description added mute/unmute commands >> * added constants for XenStore configuration strings >>(fields, PCM formats etc.) >> * changed request/response structure size from 64 octets to 16 >> * introduced dynamic buffer allocation instead of >>static XENSND_MAX_PAGES_PER_REQUEST >> * re-worked open request to allow dynamic buffer allocation >> * re-worked read/write/volume requests, so they don't pass grefs: >>buffer from the open request is used for these operations to pass data >> * specified type of the volume value to be a signed value in steps >>of 0.001 dBm, while 0 being 0dBm. >> * added Linux include file with structure definitions >> --- >> --- >> xen/include/public/io/sndif.h | 583 >> >> xen/include/public/io/sndif_linux.h | 114 +++ >> 2 files changed, 697 insertions(+) >> create mode 100644 xen/include/public/io/sndif.h >> create mode 100644 xen/include/public/io/sndif_linux.h >> >> diff --git a/xen/include/public/io/sndif.h b/xen/include/public/io/sndif.h >> new file mode 100644 >> index 000..df705a6 >> --- /dev/null >> +++ b/xen/include/public/io/sndif.h >> @@ -0,0 +1,583 @@ >> +/** >> + * sndif.h >> + * >> + * Unified sound-device I/O interface for Xen guest OSes. >> + * >> + * Permission is hereby granted, free of charge, to any person obtaining a >> copy >> + * of this software and associated documentation files (the "Software"), to >> + * deal in the Software without restriction, including without limitation >> the >> + * rights to use, copy, modify, merge, publish, distribute, sublicense, >> and/or >> + * sell copies of the Software, and to permit persons to whom the Software >> is >> + * furnished to do so, subject to the following conditions: >> + * >> + * The above copyright notice and this permission notice shall be included >> in >> + * all co
[Xen-devel] [xen-unstable-smoke test] 102149: tolerable all pass - PUSHED
flight 102149 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/102149/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass
test-armhf-armhf-xl 12 migrate-support-checkfail never pass
test-armhf-armhf-xl 13 saverestore-support-checkfail never pass
version targeted for testing:
xen 67b5b302f5319f70288587dc98ab505c4deada1e
baseline version:
xen 043ad80d4fad75651e825ef3f935be52f2d6fda0
Last test of basis 102129 2016-11-11 17:12:03 Z0 days
Testing same since 102149 2016-11-12 07:01:51 Z0 days1 attempts
People who touched revisions under test:
Andrew Cooper
Boris Ostrovsky
Jan Beulich
Wei Liu
jobs:
build-amd64 pass
build-armhf pass
build-amd64-libvirt pass
test-armhf-armhf-xl pass
test-amd64-amd64-xl-qemuu-debianhvm-i386 pass
test-amd64-amd64-libvirt pass
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Pushing revision :
+ branch=xen-unstable-smoke
+ revision=67b5b302f5319f70288587dc98ab505c4deada1e
+ . ./cri-lock-repos
++ . ./cri-common
+++ . ./cri-getconfig
+++ umask 002
+++ getrepos
getconfig Repos
perl -e '
use Osstest;
readglobalconfig();
print $c{"Repos"} or die $!;
'
+++ local repos=/home/osstest/repos
+++ '[' -z /home/osstest/repos ']'
+++ '[' '!' -d /home/osstest/repos ']'
+++ echo /home/osstest/repos
++ repos=/home/osstest/repos
++ repos_lock=/home/osstest/repos/lock
++ '[' x '!=' x/home/osstest/repos/lock ']'
++ OSSTEST_REPOS_LOCK_LOCKED=/home/osstest/repos/lock
++ exec with-lock-ex -w /home/osstest/repos/lock ./ap-push xen-unstable-smoke
67b5b302f5319f70288587dc98ab505c4deada1e
+ branch=xen-unstable-smoke
+ revision=67b5b302f5319f70288587dc98ab505c4deada1e
+ . ./cri-lock-repos
++ . ./cri-common
+++ . ./cri-getconfig
+++ umask 002
+++ getrepos
getconfig Repos
perl -e '
use Osstest;
readglobalconfig();
print $c{"Repos"} or die $!;
'
+++ local repos=/home/osstest/repos
+++ '[' -z /home/osstest/repos ']'
+++ '[' '!' -d /home/osstest/repos ']'
+++ echo /home/osstest/repos
++ repos=/home/osstest/repos
++ repos_lock=/home/osstest/repos/lock
++ '[' x/home/osstest/repos/lock '!=' x/home/osstest/repos/lock ']'
+ . ./cri-common
++ . ./cri-getconfig
++ umask 002
+ select_xenbranch
+ case "$branch" in
+ tree=xen
+ xenbranch=xen-unstable-smoke
+ qemuubranch=qemu-upstream-unstable
+ '[' xxen = xlinux ']'
+ linuxbranch=
+ '[' xqemu-upstream-unstable = x ']'
+ select_prevxenbranch
++ ./cri-getprevxenbranch xen-unstable-smoke
+ prevxenbranch=xen-4.7-testing
+ '[' x67b5b302f5319f70288587dc98ab505c4deada1e = x ']'
+ : tested/2.6.39.x
+ . ./ap-common
++ : osst...@xenbits.xen.org
+++ getconfig OsstestUpstream
+++ perl -e '
use Osstest;
readglobalconfig();
print $c{"OsstestUpstream"} or die $!;
'
++ :
++ : git://xenbits.xen.org/xen.git
++ : osst...@xenbits.xen.org:/home/xen/git/xen.git
++ : git://xenbits.xen.org/qemu-xen-traditional.git
++ : git://git.kernel.org
++ : git://git.kernel.org/pub/scm/linux/kernel/git
++ : git
++ : git://xenbits.xen.org/xtf.git
++ : osst...@xenbits.xen.org:/home/xen/git/xtf.git
++ : git://xenbits.xen.org/xtf.git
++ : git://xenbits.xen.org/libvirt.git
++ : osst...@xenbits.xen.org:/home/xen/git/libvirt.git
++ : git://xenbits.xen.org/libvirt.git
++ : git://xenbits.xen.org/osstest/rumprun.git
++ : git
++ : git://xenbits.xen.org/osstest/rumprun.git
++ : osst...@xenbits.xen.org:/home/xen/git/osstest/rumprun.git
++ : git://git.seabios.org/seabios.git
++ : osst...@xenbits.xen.org:/home/xen/git/osstest/seabios.git
++ : git://xenbits.xen.org/osstest/seabios.git
++ : https://github.com/tianocore/edk2.git
++ : osst...@xenbits.xen.org:/home/xen/git/osstest/ovmf.git
++ : git://xenbits.xen.org/osstest/ovmf.git
++ : git://xenbits.xen.org/osstest/linux-firmware.git
++ : osst...@xenbits.xen.org:/home/osstest/ext/linux-firmware.git
++ : git://gi
Re: [Xen-devel] [PATCH v7 1/6] VMX: Permanently assign PI hook vmx_pi_switch_to()
> > diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c > > index 3d330b6..10546af 100644 > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -222,8 +222,13 @@ void vmx_pi_hooks_deassign(struct domain *d) > > > > d->arch.hvm_domain.vmx.vcpu_block = NULL; > > d->arch.hvm_domain.vmx.pi_switch_from = NULL; > > -d->arch.hvm_domain.vmx.pi_switch_to = NULL; > > d->arch.hvm_domain.vmx.pi_do_resume = NULL; > > + > > +/* > > + * In fact, we could remove 'vmx_pi_switch_to' inside itself if no new > device > > I am having a hard time parsing that. What is the 'inside itself'? Thanks for your review. It means we could set ' d->arch.hvm_domain.vmx.pi_switch_to' to NULL in vmx_pi_switch_to(). It would be good if you have any better description! :) Thanks, Feng > > Otherwise, > Reviewed-by: Konrad Rzeszutek Wilk > > + * is in the process of getting assigned and "from" hook is NULL. > > However, > > + * it is not straightforward to find a clear solution, so just leave > > it here. > > + */ > > } > > > > static int vmx_domain_initialise(struct domain *d) > > -- > > 2.1.0 > > > > > > ___ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > https://lists.xen.org/xen-devel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [libvirt test] 102144: tolerable all pass - PUSHED
flight 102144 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/102144/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
test-armhf-armhf-libvirt 13 saverestore-support-checkfail like 102082
test-armhf-armhf-libvirt-qcow2 12 saverestore-support-check fail like 102082
test-armhf-armhf-libvirt-xsm 13 saverestore-support-checkfail like 102082
test-armhf-armhf-libvirt-raw 12 saverestore-support-checkfail like 102082
Tests which did not succeed, but are not blocking:
test-amd64-i386-libvirt-xsm 12 migrate-support-checkfail never pass
test-amd64-amd64-libvirt-xsm 12 migrate-support-checkfail never pass
test-amd64-i386-libvirt 12 migrate-support-checkfail never pass
test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check
fail never pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 10 migrate-support-check
fail never pass
test-amd64-amd64-libvirt-vhd 11 migrate-support-checkfail never pass
test-armhf-armhf-libvirt 12 migrate-support-checkfail never pass
test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass
test-armhf-armhf-libvirt-xsm 12 migrate-support-checkfail never pass
test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass
version targeted for testing:
libvirt 85b0721095d4149285d7f1ab248c168aeb7239a9
baseline version:
libvirt c5492563dad1a30701a085b63566dd835fac6bf0
Last test of basis 102082 2016-11-10 04:21:45 Z2 days
Failing since102108 2016-11-11 04:20:04 Z1 days2 attempts
Testing same since 102144 2016-11-12 04:20:09 Z0 days1 attempts
People who touched revisions under test:
Daniel P. Berrange
Eric Farman
Erik Skultety
John Ferlan
Martin Kletzander
Michal Privoznik
Peter Krempa
jobs:
build-amd64-xsm pass
build-armhf-xsm pass
build-i386-xsm pass
build-amd64 pass
build-armhf pass
build-i386 pass
build-amd64-libvirt pass
build-armhf-libvirt pass
build-i386-libvirt pass
build-amd64-pvopspass
build-armhf-pvopspass
build-i386-pvops pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsmpass
test-amd64-amd64-libvirt-xsm pass
test-armhf-armhf-libvirt-xsm pass
test-amd64-i386-libvirt-xsm pass
test-amd64-amd64-libvirt pass
test-armhf-armhf-libvirt pass
test-amd64-i386-libvirt pass
test-amd64-amd64-libvirt-pairpass
test-amd64-i386-libvirt-pair pass
test-armhf-armhf-libvirt-qcow2 pass
test-armhf-armhf-libvirt-raw pass
test-amd64-amd64-libvirt-vhd pass
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Pushing revision :
+ branch=libvirt
+ revision=85b0721095d4149285d7f1ab248c168aeb7239a9
+ . ./cri-lock-repos
++ . ./cri-common
+++ . ./cri-getconfig
+++ umask 002
+++ getrepos
getconfig Repos
perl -e '
use Osstest;
readglobalconfig();
print $c{"Repos"} or die $!;
'
+++ local repos=/home/osstest/repos
+++ '[' -z /home/osstest/repos ']'
+++ '[' '!' -d /home/osstest/repos ']'
+++ echo /home/osstest/repos
++ repos=/home/osstest/repos
++ repos_lock=/home/osstest/repos/lock
++ '[' x '!=' x/home/o
