Re: [Xen-devel] [PATCH v13 3/9] iommu: push use of type-safe DFN and MFN into iommu_ops
On 10/3/18 12:00 AM, Paul Durrant wrote: > This patch modifies the methods in struct iommu_ops to use type-safe DFN > and MFN. This follows on from the prior patch that modified the functions > exported in xen/iommu.h. > > Signed-off-by: Paul Durrant > Reviewed-by: Wei Liu > Reviewed-by: Kevin Tian > Reviewed-by: Roger Pau Monne > Acked-by: Jan Beulich > --- > Cc: Suravee Suthikulpanit > Cc: Andrew Cooper > Cc: George Dunlap Acked-by: Suravee Suthikulpanit Thanks, Suravee ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v13 1/9] iommu: introduce the concept of DFN...
Hi, On 10/3/18 12:00 AM, Paul Durrant wrote: > ...meaning 'device DMA frame number' i.e. a frame number mapped in the IOMMU > (rather than the MMU) and hence used for DMA address translation. > > This patch is a largely cosmetic change that substitutes the terms 'gfn' > and 'gaddr' for 'dfn' and 'daddr' in all the places where the frame number > or address relate to a device rather than the CPU. > > The parts that are not purely cosmetic are: > > - the introduction of a type-safe declaration of dfn_t and definition of > INVALID_DFN to make the substitution of gfn_x(INVALID_GFN) mechanical. > - the introduction of __dfn_to_daddr and __daddr_to_dfn (and type-safe > variants without the leading __) with some use of the former. > > Subsequent patches will convert code to make use of type-safe DFNs. > > Signed-off-by: Paul Durrant > Acked-by: Jan Beulich > Reviewed-by: Kevin Tian > Acked-by: Julien Grall > --- > Cc: Wei Liu > Cc: Suravee Suthikulpanit > Cc: Stefano Stabellini Acked-by: Suravee Suthikulpanit Thanks, Suravee ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
Re: [Xen-devel] [PATCH v2 2/2] amd/iommu: remove hidden AMD inclusive mappings
Roger,
On 10/2/18 3:08 PM, Roger Pau Monne wrote:
> And just rely on arch_iommu_hwdom_init to setup the correct inclusive
> mappings as it's done for Intel.
>
> AMD has code in amd_iommu_hwdom_init to setup inclusive mappings up to
> max_pdx, remove this since it's now a duplication of
> arch_iommu_hwdom_init. Note that AMD mapped every page with a valid
> mfn up to max_pdx, arch_iommu_hwdom_init will only do so for memory
> below 4GB, so this is a functional change for AMD.
>
> Move the default setting of iommu_hwdom_{inclusive/reserved} to
> arch_iommu_hwdom_init since the defaults are now the same for both
> Intel and AMD.
>
> Reported-by: Paul Durrant
> Signed-off-by: Roger Pau Monné
> Reviewed-by: Jan Beulich
> Reviewed-by: Kevin Tian
> ---
> Cc: Suravee Suthikulpanit
> Cc: Brian Woods
> Cc: Kevin Tian
> Cc: Jan Beulich
> Cc: Paul Durrant
> ---
> xen/drivers/passthrough/amd/pci_amd_iommu.c | 39 -
> xen/drivers/passthrough/vtd/iommu.c | 7
> xen/drivers/passthrough/x86/iommu.c | 8 -
> 3 files changed, 7 insertions(+), 47 deletions(-)
>
Acked-by: Suravee Suthikulpanit
Thanks,
Suravee
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
