Re: [PATCH 5/6] x86/ipipe: fix build with CONFIG_X86_UV enabled
On 07.09.20 17:18, Philippe Gerum wrote: > > Philippe Gerum writes: > >> Jan Kiszka writes: >> >>> On 07.09.20 15:09, Philippe Gerum wrote: From: Philippe Gerum Signed-off-by: Philippe Gerum --- arch/x86/kernel/ipipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c index 3f3afcecc1b9..c5ebfdf2dfb3 100644 --- a/arch/x86/kernel/ipipe.c +++ b/arch/x86/kernel/ipipe.c @@ -72,6 +72,7 @@ void smp_irq_move_cleanup_interrupt(struct pt_regs *regs); void smp_reboot_interrupt(void); void smp_thermal_interrupt(struct pt_regs *regs); void smp_threshold_interrupt(struct pt_regs *regs); +void uv_bau_message_interrupt(struct pt_regs *regs); void __ipipe_do_IRQ(unsigned int irq, void *cookie); >>> >>> IIRC, I broke that intentionally. There is more needed, and no one >>> should get something building but subtly not working. But we may better do >>> >>> depends on !IPIPE >>> >> >> Indeed, otherwise plain build tests with e.g. allyesconfig fail miserably. > > I meant "allnoconfig" of course, but you get the point. > I've added https://gitlab.denx.de/Xenomai/ipipe-x86/-/commit/fe5928a3ea7d24eaad0e4a293e25bd1463312c17 instead to 4.19-x86 All other patches merged (and now part of ipipe-core-4.19.140-cip33-x86-14), the generic ones also the ipipe-noarch. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
Re: [PATCH 5/6] x86/ipipe: fix build with CONFIG_X86_UV enabled
Philippe Gerum writes: > Jan Kiszka writes: > >> On 07.09.20 15:09, Philippe Gerum wrote: >>> From: Philippe Gerum >>> >>> Signed-off-by: Philippe Gerum >>> --- >>> arch/x86/kernel/ipipe.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c >>> index 3f3afcecc1b9..c5ebfdf2dfb3 100644 >>> --- a/arch/x86/kernel/ipipe.c >>> +++ b/arch/x86/kernel/ipipe.c >>> @@ -72,6 +72,7 @@ void smp_irq_move_cleanup_interrupt(struct pt_regs *regs); >>> void smp_reboot_interrupt(void); >>> void smp_thermal_interrupt(struct pt_regs *regs); >>> void smp_threshold_interrupt(struct pt_regs *regs); >>> +void uv_bau_message_interrupt(struct pt_regs *regs); >>> >>> void __ipipe_do_IRQ(unsigned int irq, void *cookie); >>> >>> >> >> IIRC, I broke that intentionally. There is more needed, and no one >> should get something building but subtly not working. But we may better do >> >> depends on !IPIPE >> > > Indeed, otherwise plain build tests with e.g. allyesconfig fail miserably. I meant "allnoconfig" of course, but you get the point. -- Philippe.
Re: [PATCH 5/6] x86/ipipe: fix build with CONFIG_X86_UV enabled
Jan Kiszka writes: > On 07.09.20 15:09, Philippe Gerum wrote: >> From: Philippe Gerum >> >> Signed-off-by: Philippe Gerum >> --- >> arch/x86/kernel/ipipe.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c >> index 3f3afcecc1b9..c5ebfdf2dfb3 100644 >> --- a/arch/x86/kernel/ipipe.c >> +++ b/arch/x86/kernel/ipipe.c >> @@ -72,6 +72,7 @@ void smp_irq_move_cleanup_interrupt(struct pt_regs *regs); >> void smp_reboot_interrupt(void); >> void smp_thermal_interrupt(struct pt_regs *regs); >> void smp_threshold_interrupt(struct pt_regs *regs); >> +void uv_bau_message_interrupt(struct pt_regs *regs); >> >> void __ipipe_do_IRQ(unsigned int irq, void *cookie); >> >> > > IIRC, I broke that intentionally. There is more needed, and no one > should get something building but subtly not working. But we may better do > > depends on !IPIPE > Indeed, otherwise plain build tests with e.g. allyesconfig fail miserably. -- Philippe.
Re: [PATCH 5/6] x86/ipipe: fix build with CONFIG_X86_UV enabled
On 07.09.20 15:09, Philippe Gerum wrote: > From: Philippe Gerum > > Signed-off-by: Philippe Gerum > --- > arch/x86/kernel/ipipe.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c > index 3f3afcecc1b9..c5ebfdf2dfb3 100644 > --- a/arch/x86/kernel/ipipe.c > +++ b/arch/x86/kernel/ipipe.c > @@ -72,6 +72,7 @@ void smp_irq_move_cleanup_interrupt(struct pt_regs *regs); > void smp_reboot_interrupt(void); > void smp_thermal_interrupt(struct pt_regs *regs); > void smp_threshold_interrupt(struct pt_regs *regs); > +void uv_bau_message_interrupt(struct pt_regs *regs); > > void __ipipe_do_IRQ(unsigned int irq, void *cookie); > > IIRC, I broke that intentionally. There is more needed, and no one should get something building but subtly not working. But we may better do depends on !IPIPE Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
[PATCH 5/6] x86/ipipe: fix build with CONFIG_X86_UV enabled
From: Philippe Gerum Signed-off-by: Philippe Gerum --- arch/x86/kernel/ipipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c index 3f3afcecc1b9..c5ebfdf2dfb3 100644 --- a/arch/x86/kernel/ipipe.c +++ b/arch/x86/kernel/ipipe.c @@ -72,6 +72,7 @@ void smp_irq_move_cleanup_interrupt(struct pt_regs *regs); void smp_reboot_interrupt(void); void smp_thermal_interrupt(struct pt_regs *regs); void smp_threshold_interrupt(struct pt_regs *regs); +void uv_bau_message_interrupt(struct pt_regs *regs); void __ipipe_do_IRQ(unsigned int irq, void *cookie); -- 2.26.2
