[xmail] Relay problems solved - patch (again)

2002-10-23 Thread Matt Parlane 
Sorry bout that - the patch didn't make it through.

Here it is again - hopefully as text/plain, and I've inlined it below as
well.

Matt


--- /tmp/SMTPSvr.cpp 2002-09-09 13:00:50.0 +1200
+++ /usr/src/xmail-1.11/SMTPSvr.cpp 2002-10-24 11:21:38.0 +1300
@@ -1683,7 +1683,12 @@


///
 //  Check relay permission


///
-if (SMTPCheckRelayCapability(SMTPS, szDestDomain) < 0)
+  char   szFromUser[MAX_ADDR_NAME] = "",
+   szFromDomain[MAX_ADDR_NAME] = "";
+
+   USmtpSplitEmailAddr(SMTPS.pszFrom, szFromUser, szFromDomain);
+
+if (SMTPCheckRelayCapability(SMTPS, szDestDomain) < 0 &&
MDomIsHandledDomain(szFromDomain) < 0)
 {
 ErrorPush();



-- Attached file included as plaintext by Ecartis --
-- File: relay.patch.txt

--- /tmp/SMTPSvr.cpp2002-09-09 13:00:50.0 +1200
+++ /usr/src/xmail-1.11/SMTPSvr.cpp 2002-10-24 11:21:38.0 +1300
@@ -1683,7 +1683,12 @@
 ///
 //  Check relay permission
 ///
-if (SMTPCheckRelayCapability(SMTPS, szDestDomain) < 0)
+   char   szFromUser[MAX_ADDR_NAME] = "",
+  szFromDomain[MAX_ADDR_NAME] = "";
+
+   USmtpSplitEmailAddr(SMTPS.pszFrom, szFromUser, szFromDomain);
+
+if (SMTPCheckRelayCapability(SMTPS, szDestDomain) < 0 && 
+MDomIsHandledDomain(szFromDomain) < 0)
 {
 ErrorPush();
 

-
To unsubscribe from this list: send the line "unsubscribe xmail" in
the body of a message to [EMAIL PROTECTED]
For general help: send the line "help" in the body of a message to
[EMAIL PROTECTED]

[xmail] Relay problems solved - patch

2002-10-23 Thread Matt Parlane 
Hi list...

I have been using XMail for a while now, and have been struggling with
relaying problems.

I migrated from MDaemon, and they relay messages if they are either TO or
FROM a local domain.  XMail is different - it only relays a message if it is
TO a local domain, but not if it's FROM a local domain.

The attached patch changes the way XMail checks to see if a message can be
relayed by checking if either the FROM domain or the TO domain is local.  It
is to be applied against SMTPSvr.cpp

I think this makes life much easier for the administrator, as clients don't
have to have SMTP authentication turned on, and the administrator doesn't
have to keep track of client IP addresses.  I have checked this patch with 3
different open relay testing engines, and none of them reported any
problems.

Davide - what do you think of this patch?  Can you see any security
problems?  I realize that it could be implemented a lot better, but do you
think it could be included in your release?


Regards,

Matt Parlane
Zevi Interactive
[EMAIL PROTECTED]


-- Binary/unsupported file stripped by Ecartis --
-- Type: application/octet-stream
-- File: relay.patch


-
To unsubscribe from this list: send the line "unsubscribe xmail" in
the body of a message to [EMAIL PROTECTED]
For general help: send the line "help" in the body of a message to
[EMAIL PROTECTED]