Re: [xml] Entering freeze for release of libxml2-2.9.9
Daniel Veillard schrieb am 29.11.18 um 21:20: > On Mon, Nov 26, 2018 at 11:48:37AM +0100, Nikolai Weibull via xml wrote: >> Stefan Behnel, 2018-11-25 15:37: >>> Nikolai Weibull schrieb am 24.11.18 um 00:12: Yes, it seems that my patch for data in interleaves was added and this may be the cause of these issues. The regression tests didn’t display them, so this is something different. Could we perhaps get a minimal test that breaks? >> >>> Here is what I could come up with so far. Since it's heavily stripped >>> down, >>> it probably isn't very reasonable anymore. The original schema is here: https://raw.githubusercontent.com/lxml/lxml/82601a09d015bc3e7a4090223fcbb9a5d5d4590d/src/lxml/isoschematron/resources/rng/iso-schematron.rng This is the direct file link now. I had attached the shortened test files here: https://mail.gnome.org/archives/xml/2018-November/msg00023.html >> Thank you! As far as my tests go, with the patches that I’ve provided, this >> validates without any issues. I really hope we can get my patches from the >> merge request into master so that this issue can be fixed. > > TBH it's weird it fails to validate for me with 2.9.8, with 2.9.9-rc1 and > with 2.9.9-rc1 with the data interleave patch reverted ... I tried both lxml's test suite and my stripped down test files with 2.9.8 and the two RCs now, and all of them pass with 2.9.8, but fail with both 2.9.9-rc1 and 2.9.9-rc2. I figured out how to build libxml2 from a git checkout now so that I could bisect it. The bug was definitely introduced in c8e5f9588, which is Nikolai's change from November 22nd. I used git bisect run bash -c "make clean && make && ./xmllint --relaxng ../iso-schematron.rng ../fail_schema.sch" The change looks simple, but also a bit opaque to me. It could be that it's related to the interleaving of optional tags/attributes and text somehow. At least, that's what this part of the change might suggest: -groups[nbgroups]->defs = xmlRelaxNGGetElements(ctxt, cur, 0); +groups[nbgroups]->defs = xmlRelaxNGGetElements(ctxt, cur, 2); And, in fact, changing that line in the latest master branch back to the original "0" argument makes the validation pass for me. It probably also reverts most of the intented behaviour that Nikolai wanted to achieve. :( Stefan ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Entering freeze for release of libxml2-2.9.9
I pushed RC2 in git and pushed signed tarball and rpms to the usual place: ftp://xmlsoft.org/libxml2 we have a couple of issues which were raised against rc1 and not completely solved, depending on how we resolve those and if no new ones pop-up I will either push an rc3 around Monday or proceed to 2.9.9 release. So please ocntinue to give it some testing, thanks everybody, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/ ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Entering freeze for release of libxml2-2.9.9
On Fri, Nov 23, 2018 at 11:12:13PM +0100, Nick Wellnhofer wrote: > On 23/11/2018 22:38, Nick Wellnhofer wrote: > > On 23/11/2018 20:51, Shlomi Fish wrote: > > > I am getting a failure in one of the tests of > > > https://github.com/shlomif/perl-XML-LibXML - it works fine with 2.9.8: > > > > Can you check if it's caused by one of the following commits? > > Nevermind, it's this commit: > > https://gitlab.gnome.org/GNOME/libxml2/commit/bfec41b3de1cbd35e547b57c80ae3a5101f8891c > > It seems that XML::LibXML implements its own workaround for > xmlTextReaderNextSibling only being supported on preparsed documents: > > https://github.com/shlomif/perl-XML-LibXML/blob/master/LibXML.xs#L8667 > > The function now claims to work without preparsed documents, so the > workaround isn't used. But apparently there's problem with the commit. I'm > CC'ing the author. If we can't get this fixed, let's revert. Nick, I let you double check this post RC2, we can either delay or just revert, tell me what you think, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/ ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
Re: [xml] Entering freeze for release of libxml2-2.9.9
On Mon, Nov 26, 2018 at 11:48:37AM +0100, Nikolai Weibull via xml wrote: > Hi! > > Stefan Behnel, 2018-11-25 15:37: > > > Nikolai Weibull schrieb am 24.11.18 um 00:12: > > > > Yes, it seems that my patch for data in interleaves was added and > > > this may be the cause of these issues. The regression tests didn’t > > > display them, so this is something different. Could we perhaps get a > > > minimal test that breaks? > > > Here is what I could come up with so far. Since it's heavily stripped > > down, > > it probably isn't very reasonable anymore. The original schema is here: > > Thank you! As far as my tests go, with the patches that I’ve provided, this > validates without any issues. I really hope we can get my patches from the > merge request into master so that this issue can be fixed. TBH it's weird it fails to validate for me with 2.9.8, with 2.9.9-rc1 and with 2.9.9-rc1 with the data interleave patch reverted ... I'm getting quite confused and starting to wonder if the schema I got from github is correct (github interface serves me first ahn html page, then I have to guess to use raw, to dwoload that and pray that it is actually the data one is supposed to use. --- thinkpad2:~/XML -> ./xmllint --relaxng iso-schematron.rng fail_to_validate.xml http://purl.oclc.org/dsdl/schematron";> Open Model BBB element is not present CCC element is not present fail_to_validate.xml:2: element title: Relax-NG validity error : Expecting element ns, got title fail_to_validate.xml:1: element schema: Relax-NG validity error : Expecting an element ns, got nothing fail_to_validate.xml:2: element title: Relax-NG validity error : Expecting element p, got title fail_to_validate.xml:1: element schema: Relax-NG validity error : Expecting an element p, got nothing fail_to_validate.xml:2: element title: Relax-NG validity error : Expecting element let, got title fail_to_validate.xml:3: element rule: Relax-NG validity error : Invalid sequence in interleave fail_to_validate.xml:3: element rule: Relax-NG validity error : Element schema failed to validate content fail_to_validate.xml fails to validate thinkpad2:~/XML -> --- the "email patch" from gitlab seems to get me back to some sanity there, it still makes it a mess to review and apply cleanly. The 4 patches looks sensible, seems to not introduce regression in existing tests, the behaviour seems to be exactly the same with Stefan's tests so I will assume that's unrelated or I didn't get the tests correctly. I will push them to RC2 and if Stephan still has troubles with it can you please send mail to the error case as attachments. thanks ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veill...@redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/ ___ xml mailing list, project page http://xmlsoft.org/ xml@gnome.org https://mail.gnome.org/mailman/listinfo/xml
