-fno-strict-aliasing in CWARNFLAGS?
Hi, When building Xming on Linux with a MinGW cross-compiler for Windows... I only get warnings about strict-aliasing from libX11 and libXt (i.e. when not using -fno-strict-aliasing). The xserver, pixman and Mesa are all happy bunnies strict. Now whether they work strict is another question! I'm trialling this at the moment (with only libX11 and libX11 built no-strict). Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
-fno-strict-aliasing in CWARNFLAGS?
Hi, Michel Dänzer wrote: > Traditionally, -fno-strict-aliasing was definitely necessary for the X > server and/or some drivers to work correctly. Strict aliasing used to be a can'o worms... http://lkml.org/lkml/2003/2/26/158 and last time I tried strict aliasing for Xming (many moons ago) I fell flat on my face. But is series 4 gcc now much better? We shall see (I'm testing with libX11 and libXt unchanged; but everything else ...most X.Org libs, most clients, pixman, Mesa and xserver... with strict aliasing) BTW I use -Os optimisation for all except -O2 for pixman and don't build any xserver drivers. So far I can't see any problems (famous last words, as they will be very subtle!) Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
[PULL] Assorted Cygwin/X related patches
All look good to me. Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [Patch] hw/xwin: remove glx subdirectory.
Hi, Any new hw/xwin/glx code (thanks John Turney) does not need to include the glcore.h file. So best go ahead and sync up the gl headers and glapi/indirect code anyway between Mesa, glproto and xserver/glx. AFAICS should not be a problem for the xwin ddx. Thanks, Colin harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL] A few Cygwin/X patches
Hi, These all look good to me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] exa: avoid calling non existent SourceValidate callback
Hi,
The last commit neads this to build...
--- ./exa/save_exa_unaccel.c2010-04-26 18:25:02.0 +0100
+++ ./exa/exa_unaccel.c 2010-04-26 18:33:13.0 +0100
@@ -462,7 +462,7 @@
REGION_UNION(pScreen, dst, dst, ®);
REGION_UNINIT(pScreen, ®);
-if (pExaScr->SourceValidate) {
+if (pExaScr->SavedSourceValidate) {
swap(pExaScr, pScreen, SourceValidate);
pScreen->SourceValidate(pDrawable, x, y, width, height);
swap(pExaScr, pScreen, SourceValidate);
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Bugfix for "Pre-validate ChangeGC XIDs": off-by-one in loop index.
Hi, Your patch fixes the git master xserver for me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] dixSetPrivate regressions in DDX xwin
Hi,
Patches for a few typos and a regression in DDX xwin...
--- ./hw/xwin/save_winallpriv.c 2010-06-06 06:02:02.0 +0100
+++ ./hw/xwin/winallpriv.c 2010-06-06 17:45:40.0 +0100
@@ -74,25 +74,31 @@
/* Intialize private structure members */
pScreenPriv->fActive = TRUE;
+ if (!dixRegisterPrivateKey(g_iScreenPrivateKey, PRIVATE_SCREEN, 0))
+{
+ ErrorF ("winAllocatePrivates - AllocateScreenPrivate () failed\n");
+ return FALSE;
+}
+
/* Save the screen private pointer */
winSetScreenPriv (pScreen, pScreenPriv);
/* Reserve GC memory for our privates */
- if (!dixRequestPrivateKey(g_iGCPrivateKey, PRIVATE_GC, sizeof
(winPrivGCRec)))
+ if (!dixRegisterPrivateKey(g_iGCPrivateKey, PRIVATE_GC, sizeof
(winPrivGCRec)))
{
ErrorF ("winAllocatePrivates - AllocateGCPrivate () failed\n");
return FALSE;
}
/* Reserve Pixmap memory for our privates */
- if (!dixRequestPrivateKey(g_iPixmapPrivateKey, PRIVATE_PIXMAP, sizeof
(winPrivPixmapRec)))
+ if (!dixRegisterPrivateKey(g_iPixmapPrivateKey, PRIVATE_PIXMAP, sizeof
(winPrivPixmapRec)))
{
ErrorF ("winAllocatePrivates - AllocatePixmapPrivates () failed\n");
return FALSE;
}
/* Reserve Window memory for our privates */
- if (!dixRequestPrivateKey(g_iWindowPrivateKey, PRIVATE_WINDOW, sizeof
(winPrivWinRec)))
+ if (!dixRegisterPrivateKey(g_iWindowPrivateKey, PRIVATE_WINDOW, sizeof
(winPrivWinRec)))
{
ErrorF ("winAllocatePrivates () - AllocateWindowPrivates ()
failed\n");
return FALSE;
--- ./hw/xwin/save_win.h2010-06-06 06:02:02.0 +0100
+++ ./hw/xwin/win.h 2010-06-06 07:15:38.0 +0100
@@ -631,7 +631,7 @@
extern DevPrivateKeyRecg_iScreenPrivateKeyRec;
#define g_iScreenPrivateKey(&g_iScreenPrivateKeyRec)
extern DevPrivateKeyRecg_iCmapPrivateKeyRec;
-#define g_iCmapPrivateKeyRec (&g_iCmapPrivateKeyRec)
+#define g_iCmapPrivateKey (&g_iCmapPrivateKeyRec)
extern DevPrivateKeyRecg_iGCPrivateKeyRec;
#define g_iGCPrivateKey(&g_iGCPrivateKeyRec)
extern DevPrivateKeyRecg_iPixmapPrivateKeyRec;
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
problem with xFillPolygon and over 1million vertices
Hi, Why not use something like this to calculate the max number of points? XFillPolygon() points: XMaxRequestSize(dpy) - 4 Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 00/12] Cygwin/X: Various patches
First look...more checks to follow.
1/12, 3/12, 5/12 OK
7/12 OK but one opportunity to use the cached CLIPBOARD atom missed in
winclipboardwndproc.c
@@ -399,17 +341,11 @@
/* Reassert ownership of the CLIPBOARD */
iReturn = XSetSelectionOwner (pDisplay,
- XInternAtom (pDisplay,
- "CLIPBOARD",
- False),
+ atomClipboard,
iWindow,
CurrentTime);
-
if (iReturn == BadAtom || iReturn == BadWindow ||
- XGetSelectionOwner (pDisplay,
-XInternAtom (pDisplay,
- "CLIPBOARD",
- False)) != iWindow)
+ XGetSelectionOwner (pDisplay, atomClipboard) != iWindow)
{
winErrorFVerb (1, "winClipboardWindowProc - WM_DRAWCLIPBOARD - "
"Could not reassert ownership of CLIPBOARD\n");
Thanks
Colin
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 00/12] Cygwin/X: Various patches
More checks done ...more to follow 8/12, 9/12, 10/12, 12/12 OK Colin ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
gcc3 source code in xorg-server-1.6.1.901
Hi, You get the same problem including 'recent' GNU GCC headers and libraries in your code. Just mention this exception to avoid taint... http://www.gnu.org/licenses/gcc-exception.html Thanks Colin ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
Testing requested for pixman 0.16.1
Hi, How about this one in pixman-trap.c _pixman_edge_multi_init() Shouldn't the type of nx be 'pixman_fixed_48_16_t' not 'int'? Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Rootless: src drawable window can now be NULL
Hi, This is one for Jeremy Huddleston and Jon Turney. Found when testing rootless modes in Xming using the new xeyes (uses Xrender to anti-alias). Patch to fix the crash and make it work... --- ./xserver/miext/rootless/rootlessScreen.c 2009-08-23 10:10:35.0 +0100 +++ ./test/miext/rootless/rootlessScreen.c 2009-10-13 09:34:49.0 +0100 @@ -257,8 +257,9 @@ RootlessComposite(CARD8 op, PicturePtr p maskWin = (pMask->pDrawable->type == DRAWABLE_WINDOW) ? (WindowPtr)pMask->pDrawable : NULL; } -srcWin = (pSrc->pDrawable->type == DRAWABLE_WINDOW) ? - (WindowPtr)pSrc->pDrawable : NULL; +if (!pSrc->pDrawable) srcWin = NULL; +else srcWin = (pSrc->pDrawable->type == DRAWABLE_WINDOW) ? + (WindowPtr)pSrc->pDrawable : NULL; dstWin = (pDst->pDrawable->type == DRAWABLE_WINDOW) ? (WindowPtr)pDst->pDrawable : NULL; Thanks, Colin Harrison ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel
PATCH Lost parenthesis in a recent libXaw change
Hi,
Dont we still need the parenthesis in the recent libXaw change?
http://lists.freedesktop.org/archives/xorg-commit/2009-October/023796.html
--- ./src/save_AsciiSrc.c 2009-10-20 16:29:07.0 +0100
+++ ./src/AsciiSrc.c2009-10-20 16:34:55.0 +0100
@@ -1292,7 +1292,7 @@
{
int fd;
-if (fd = creat(name, 0666) == -1)
+if ((fd = creat(name, 0666)) == -1)
return (False);
if (write(fd, string, length) == -1) {
Thanks,
Colin
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Lost parenthesis in a recent libXaw change
> -Original Message-
> From: Colin Harrison [mailto:colin.harri...@virgin.net]
> Sent: 20 October 2009 17:34
> To: 'xorg-devel@lists.x.org'
> Subject: PATCH Lost parenthesis in a recent libXaw change
>
> Hi,
>
> Dont we still need the parenthesis in the recent libXaw change?
>
> http://lists.freedesktop.org/archives/xorg-commit/2009-October
> /023796.html
>
>
> --- ./src/save_AsciiSrc.c 2009-10-20 16:29:07.0 +0100
> +++ ./src/AsciiSrc.c2009-10-20 16:34:55.0 +0100
> @@ -1292,7 +1292,7 @@
> {
> int fd;
>
> -if (fd = creat(name, 0666) == -1)
> +if ((fd = creat(name, 0666)) == -1)
> return (False);
>
> if (write(fd, string, length) == -1) {
>
> Thanks,
> Colin
>
PS and the proof
#include
int main(int argc, char* argv[])
{
int i1, i2;
if (i1 = sizeof(int) == 4) printf ("Bad i1 = %d\n", i1);
if ((i2 = sizeof(int)) == 4) printf ("Good i2 = %d\n", i2);
return 0;
}
# cc -Wall test.c
test.c: In function `main':
test.c:6: warning: suggest parentheses around assignment used as truth value
# ./a.out
Bad i1 = 1
Good i2 = 4
Don't you just love C coding.
Thanks,
Colin
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] XWin: Fix for static libXfont use
Hi, All XWin DDX builds use libXfont built static. The following libXfont patch is needed following recent master git changes (use of register_fpe_functions from libXfont in the server)... --- ./src/util/save_miscutil.c 2010-06-21 16:47:00.0 +0100 +++ ./src/util/miscutil.c 2010-06-28 11:25:19.0 +0100 @@ -48,8 +48,10 @@ extern void BuiltinRegisterFpeFunctions(void); +#ifndef WIN32 /* make sure everything initializes themselves at least once */ weak long serverGeneration = 1; +#endif weak void register_fpe_functions (void) Should also fix the Cygwin build tinderbox. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] XWin: Fix for static libXfont use
Hi, Julien Cristau wrote: > What did you test exactly? I know this question was not directed to me, but can comment on builds for Microsoft Windows. AFAIK no compilers for Microsoft Windows can cope properly with weak definitions (like those in libXfont). There is a lot of discussion on this on the internet, but the line-of-least-resistance, is static build libXfont for the xserver. In my case (Xming) I therefore don't make a DLL from libXfont and put up with binary size increase when the library is linked elsewhere. My patch may therefore affect other Cygwin/X uses of libXfont but what else needs serverGeneration other than the xserver? Fixing the xserver build for Cygwin/X should be the top priority and my patch does that (but the Cygwin/X builders may disagree?) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] XWin: Fix for static libXfont use
Hi, Tiago Vignattiw wrote > all right, I do agree. So if WIN32 macro means Xming only then I'd give my > review for your patch: No that covers all Microsoft Windows builds...but lets hear what the Cygwin/X people say. Their tinderbox build is busted (and Xming) without this. See also http://lists.x.org/archives/xorg-devel/2010-June/010538.html So my patch strays a little out of my comfort zone :) Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] XWin: Fix for static libXfont use
Hi, Jon Turney wrote: > That is not correct. WIN32 is not defined under cygwin and >I can't just change it to check defined(__MINGW__) || defined(__CYGWIN__) Woops..I should also stay well clear of WIN32 and _WIN32, they aren't mine to mess with. (force of habit). MinGW defines (__MINGW32__) and so that's the best one for me to use to isolate Xming only changes :) (not __MINGW__ either) Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] XWin: Fix for static libXfont use
Hi, Jon Turney wrote: > This isn't a very clean way of fixing the problem, but I don't really see any good alternatives. I'm with Jon on this. Things are better with the fix than without..but it's not very elegant! I'll put a Reviewed-by: on Jon's lastest version of the patch. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] XWin: Fix for static libXfont use
Hi, Looks like the commit in libXfont... 8f75706901da0141590d46f0f898e5678feac953 fixed the Cygwin tinderbox but broke Mac. Some conditional bodging needed? Could just ditch defining NO_WEAK_SYMBOLS and go for :#if !defined(WIN32) && !defined(__CYGWIN__) /* make sure everything initializes themselves at least once */ weak long serverGeneration = 1; +#endif in ./src/util/miscutil.c Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: libXfont: Changes to 'master'
Hi, See http://lists.x.org/archives/xorg-devel/2010-July/011042.html commit 8f75706901da0141590d46f0f898e5678feac953 needed reverting and --- ./src/util/save_miscutil.c 2010-07-10 18:27:20.0 +0100 +++ ./src/util/miscutil.c 2010-07-10 18:28:08.0 +0100 @@ -48,8 +48,10 @@ from The Open Group. extern void BuiltinRegisterFpeFunctions(void); +#if !defined(WIN32) && !defined(__CYGWIN__) /* make sure everything initializes themselves at least once */ weak long serverGeneration = 1; +#endif weak void register_fpe_functions (void) applied to ./src/util/miscutil.c instead. Thanks Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: libXfont: Changes to 'master'
Hi, Looks like this libXfont problem is finally fixed in all tinderbox builds. Thanks Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xwin sets ROOTLESS_PROTECT_ALPHA to "NO": bug?
Hi, Jamey Sharp wrote: > When the server is built on Windows, ROOTLESS_PROTECT_ALPHA is defined to NO, so rootless will protect the alpha channel. Counter-intuitive to say the least I've always applied this patch in Xming to match the __APPLE__ case and remind me of the truth in the code... --- ./miext/rootless/save_rootlessConfig.h 2010-05-20 17:31:07.0 +0100 +++ ./miext/rootless/rootlessConfig.h 2010-06-28 17:57:52.0 +0100 @@ -53,7 +53,7 @@ #if defined(__CYGWIN__) || defined(WIN32) # define ROOTLESS_GLOBAL_COORDS TRUE -# define ROOTLESS_PROTECT_ALPHA NO +# define ROOTLESS_PROTECT_ALPHA TRUE # define ROOTLESS_REDISPLAY_DELAY 10 # undef ROOTLESS_RESIZE_GRAVITY # undef ROOTLESS_TRACK_DAMAGE I've never built Xwin without the ROOTLESS_PROTECT_ALPHA code and so would be happy to have it hard-wired in. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 1/3] rootless: ROOTLESS_PROTECT_ALPHA is always set, so unifdef it.
Hi, Just tried the opposite in Xming (i.e. #undef ROOTLESS_PROTECT_ALPHA) and can't see any difference in rootless modes. But my tests are probably not good enough and I don't understand the rootless code deep enough :) I can't therefore see why the #if defined(__CYGWIN__) || defined(WIN32) version has to be different for the #ifdef __APPLE__ one on this. Either way the miext/rootless code is unloved, buggy and ugly and simplifying it may make it easier to handle and fix (thanks Jamey). So given the choice of ROOTLESS_PROTECT_ALPHA 'in' or 'out'..I'm with 'in', "the way it has always been" for me, for what that is worth. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] rootless: change the last calls to compatibility wrapper fbCopyRegion()
Hi,
Another cleanup in the rootless code..miext/rootless contains the last calls
to compatibility wrapper fbCopyRegion().
This patch updates to the new function...
--- ./miext/rootless/save_rootlessWindow.c 2010-06-06
06:21:44.0 +0100
+++ ./miext/rootless/rootlessWindow.c 2010-06-06 06:22:50.0 +0100
@@ -701,7 +701,7 @@
if (gResizeDeathCount == 1) {
/* Simple case, we only have a single source pixmap. */
-fbCopyRegion(&gResizeDeathPix[0]->drawable,
+miCopyRegion(&gResizeDeathPix[0]->drawable,
&pScreen->GetWindowPixmap(pWin)->drawable, 0,
&rgnDst, dx, dy, fbCopyWindowProc, 0, 0);
}
@@ -717,7 +717,7 @@
RegionNull(&clipped);
RegionIntersect(&rgnDst, &clip, &clipped);
-fbCopyRegion(&gResizeDeathPix[i]->drawable,
+miCopyRegion(&gResizeDeathPix[i]->drawable,
&pScreen->GetWindowPixmap(pWin)->drawable, 0,
&clipped, dx, dy, fbCopyWindowProc, 0, 0);
@@ -798,7 +798,7 @@
else {
RootlessStartDrawing(pWin);
-fbCopyRegion((DrawablePtr) pWin, (DrawablePtr) pWin,
+miCopyRegion((DrawablePtr) pWin, (DrawablePtr) pWin,
0, &rgnDst, dx, dy, fbCopyWindowProc, 0, 0);
/* prgnSrc has been translated to dst position */
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] rootless: change the last calls to compatibility wrapper fbCopyRegion()
Hi,
As a PS to the rootless patch, in the first message, the following cleanup
can now be made in the xserver...
--- ./fb/save_fb.h 2010-06-06 06:21:44.0 +0100
+++ ./fb/fb.h 2010-07-16 21:12:22.0 +0100
@@ -1345,33 +1345,6 @@
Pixel bitplane,
void*closure);
-/* Compatibility wrapper, to be removed at next ABI change. */
-extern _X_EXPORT void
-fbCopyRegion (DrawablePtr pSrcDrawable,
- DrawablePtr pDstDrawable,
- GCPtr pGC,
- RegionPtr pDstRegion,
- int dx,
- int dy,
- fbCopyProccopyProc,
- Pixel bitPlane,
- void *closure);
-
-/* Compatibility wrapper, to be removed at next ABI change. */
-extern _X_EXPORT RegionPtr
-fbDoCopy (DrawablePtr pSrcDrawable,
- DrawablePtr pDstDrawable,
- GCPtr pGC,
- int xIn,
- int yIn,
- int widthSrc,
- int heightSrc,
- int xOut,
- int yOut,
- fbCopyProccopyProc,
- Pixel bitplane,
- void *closure);
-
extern _X_EXPORT void
fbCopy1toN (DrawablePtrpSrcDrawable,
DrawablePtr pDstDrawable,
--- ./fb/save_fbcopy.c 2010-05-20 17:31:07.0 +0100
+++ ./fb/fbcopy.c 2010-07-16 21:13:15.0 +0100
@@ -28,39 +28,6 @@
#include "fb.h"
-/* Compatibility wrapper, to be removed at next ABI change. */
-void
-fbCopyRegion (DrawablePtr pSrcDrawable,
- DrawablePtr pDstDrawable,
- GCPtr pGC,
- RegionPtr pDstRegion,
- int dx,
- int dy,
- fbCopyProccopyProc,
- Pixel bitPlane,
- void *closure)
-{
-miCopyRegion(pSrcDrawable, pDstDrawable, pGC, pDstRegion, dx, dy,
copyProc, bitPlane, closure);
-}
-
-/* Compatibility wrapper, to be removed at next ABI change. */
-RegionPtr
-fbDoCopy (DrawablePtr pSrcDrawable,
- DrawablePtr pDstDrawable,
- GCPtr pGC,
- int xIn,
- int yIn,
- int widthSrc,
- int heightSrc,
- int xOut,
- int yOut,
- fbCopyProccopyProc,
- Pixel bitPlane,
- void *closure)
-{
-return miDoCopy(pSrcDrawable, pDstDrawable, pGC, xIn, yIn, widthSrc,
heightSrc, xOut, yOut, copyProc, bitPlane, closu
re);
-}
-
void
fbCopyNtoN (DrawablePtrpSrcDrawable,
DrawablePtr pDstDrawable,
--- ./fb/save_wfbrename.h 2010-06-06 06:02:02.0 +0100
+++ ./fb/wfbrename.h2010-07-16 21:14:26.0 +0100
@@ -58,7 +58,6 @@
#define fbCopyNto1 wfbCopyNto1
#define fbCopyNtoN wfbCopyNtoN
#define fbCopyPlane wfbCopyPlane
-#define fbCopyRegion wfbCopyRegion
#define fbCopyWindow wfbCopyWindow
#define fbCopyWindowProc wfbCopyWindowProc
#define fbCreateDefColormap wfbCreateDefColormap
@@ -68,7 +67,6 @@
#define fbCreateWindow wfbCreateWindow
#define fbDestroyPixmap wfbDestroyPixmap
#define fbDestroyWindow wfbDestroyWindow
-#define fbDoCopy wfbDoCopy
#define fbDots wfbDots
#define fbDots16 wfbDots16
#define fbDots24 wfbDots24
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] rootless: Adjust the frame size of the native root window in RootlessResizeWindow
Hi, Jeremy wrote: > my guess is that you guys don't even enter this codepath. You're right, I can't currently get to that code. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/3] GLX changes to support XWin AIGLX
Hi, I'm happy to say "Reviewed-by:" for these changes. I'm already using most of them :) Other users mileage may differ with different make methods/environments, and I don't use dixmods. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] rootless: fix uninitialized private key assert in non-rootless modes on cygwin
Hi, I've reviewed and tested this patch, but only using the XWin DDX. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Cygwin/X: Fix glxWinCreateDrawable() for API change
Hi, I've had to use these changes myself since commit 9de0e31746d5f0d9d39d11c94ec3cbc04a9935fc (dri2: Take an XID for tracking the DRI2 drawable, 11 May 2010), so am very happy to add 'Tested-by' and 'Reviewed-by' to Jon's patch. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Fix Xwin build after af0f9f91
Hi, Jon's fix is good for me Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Typo in xserver Xvasprintf()
Hi, I needed this patch in the wrapper around vsnprintf() in os/xprintf.c (MinGW for Windows build) to correct various crashes. --- ./os/save_xprintf.c 2010-12-09 00:01:19.0 + +++ ./os/xprintf.c 2010-12-09 23:47:34.0 + @@ -108,7 +108,7 @@ return -1; vsnprintf(*ret, size + 1, format, va); -ret[size] = 0; +(*ret)[size] = 0; return size; #endif } Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Typo in xserver Xvasprintf()
Hi, Alan Coopersmith wrote: >...since the vsnprintf should be null terminating it... Best forced to be always null..it's anarchy, with this functions family, outside the world of *nix :) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] change output of colors to hex instead of decimal
Hi, Now xset has this, what about xdpyinfo? At xdpyinfo.c:512 Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)
Hi, On Wed, Feb 15, 2012 Peter Hutterer wrote: > This is the corrected version after the initial fix in bbb6b8c834e0e1491ca14403b5d0840dd14380d3. Works for me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: indent quirks
Hi, Your newly auto-indented xserver/os/access.c file has indent quirks on the lines following the use of the MakeHost(h,l) macro but only when it is used without a (superfluous) trailing semicolon. Of cause this makes no difference to the binary, but it makes the code more tricky to read for us mere mortals. e.g. MakeHost(host, len) if (!host) return; Should be MakeHost(host, len) if (!host) return; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL updated] XQuartz pending & formatting cleanup
Hi, Why did the line va_start(args, f); get removed from xserver/os/log.c? Isn't args uninitialized without it? Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] os: Add CryptoAPI as a choice of SHA1 implementation
Reviewed-by: Colin Harrison Tested-by: Colin Harrison This patch works well for me. However the line.. #define WIN32_LEAN_AND_MEAN in os/xsha1.c is superfluous as the code should be built with that defined elsewhere. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xserver: Branch 'master' - 14 commits
Hi, Peter Hutterer wrote: > enterleave.c: In function 'DeviceFocusOutEvents': > enterleave.c:618:9: error: implicit declaration of function > 'DeviceFocusEvent' [-Werror=implicit-function-declaration] > enterleave.c:618:9: warning: nested extern declaration of 'DeviceFocusEvent' > [-Wnested-externs] Trivial to fix with... --- ./dix/save_enterleave.c 2012-03-26 18:46:59.432816397 +0100 +++ ./dix/enterleave.c 2012-05-14 20:51:43.343698453 +0100 @@ -35,6 +35,7 @@ #include "scrnintstr.h" #include "exglobals.h" #include "enterleave.h" +#include "exevents.h" /** * @file Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: git pull api break - squashed
Hi,
Tinderbox for CYGWIN will probably build but crash.
In xserver/hw/xwin...
Need to remove redundant pBlockData from winBlockHandler() function and
pWakeupData from winWakeupHandler() function e.g.
--- ./hw/xwin/save_winblock.c 2012-06-05 17:00:47.831477850 +0100
+++ ./hw/xwin/winblock.c2012-06-05 17:44:04.512482055 +0100
@@ -37,10 +37,10 @@
/* See Porting Layer Definition - p. 6 */
void
winBlockHandler(ScreenPtr pScreen,
-pointer pBlockData, pointer pTimeout, pointer pReadMask)
+pointer pTimeout, pointer pReadMask)
{
#if defined(XWIN_CLIPBOARD) || defined(XWIN_MULTIWINDOW)
-winScreenPriv((ScreenPtr) pBlockData);
+winScreenPriv(pScreen);
#endif
MSG msg;
Etc.
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/3] extmod changes fallout
Hi, All Jon's series works OK for me: Reviewed-by: Colin Harrison Tested-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Xext/xres.c: Possible buffer underrun
Hi,
I got a crash at free(counts) in ProcXResQueryClientResources() in
Xext/xres.c when using client xrestop.
Traced to an out-by-one error in ResFindAllRes() (please check code and
confirm?).
Fixed, for me (MinGW compilation for Windows), with the patch...
--- ./Xext/save_xres.c 2012-07-10 11:16:44.191904782 +0100
+++ ./Xext/xres.c 2012-07-16 16:19:50.078292944 +0100
@@ -274,7 +274,7 @@
{
int *counts = (int *) cdata;
-counts[(type & TypeMask) - 1]++;
+counts[(type & TypeMask)]++;
}
static int
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH v7 04/15] Add LogMessageVerbSigSafe() for logging messages while in signal context
Hi, Jon Turney: wrote: "Is there a typo here and this should be an #ifndef WIN32 guard around a use of fsync(), like the other uses of fsync() in log.c?" fysnc() can be replaced with _commit() in this instance for MinGW. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Current tinderbox regression (xserver, randr)
Hi, I think Keith was waiting for someone to review this patch... http://lists.x.org/archives/xorg-devel/2011-February/019390.html and RandR 1.4 fixes... http://lists.x.org/archives/xorg-devel/2011-February/019389.html The patch makes the code compile for me (MinGW for Windows)..but I haven't got suitable tests to say Rand 1.4 is OK. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/3] XWin: Find GL specs, rather than downloading them
Hi, A move in the right direction that is OK by me. Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: libXdmcp is not ready for Windows
Hi, Yes WSAStartup() is called by an application and is not needed in this library. I always link to Winsock ws2_32 and replace all 'int fd's with 'SOCKET fd' in all apps. Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] glx: Add _glapi_create_table_from_handle
Hi, I just leave glapi_gentable.c out of my xserver build. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 2/2] glx: Synchronize Xserver glx/rensize.c with mesa src/glx/compsize.c
Hi, Isn't there a case: GL_RG: as well? --- ./glx/save_rensize.c +++ ./glx/rensize.c @@ -214,12 +214,14 @@ case GL_INTENSITY: elementsPerGroup = 1; break; + case GL_RG: case GL_422_EXT: case GL_422_REV_EXT: case GL_422_AVERAGE_EXT: case GL_422_REV_AVERAGE_EXT: case GL_DEPTH_STENCIL_NV: case GL_DEPTH_STENCIL_MESA: + case GL_YCBCR_422_APPLE: case GL_YCBCR_MESA: case GL_LUMINANCE_ALPHA: elementsPerGroup = 2; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Remove hw/xwin/xlaunch
Hi, I agree, the xlaunch directory should now be removed. Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xinit 0/1] startx: Pass "-nolisten tcp" by default
Hi, 'this day and age' 'this time and age' Time is good: it allows evolution (or erosion) to slowly happen. But I for one vote that X11 network transparency remains default. Cheers, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xinit 0/1] startx: Pass "-nolisten tcp" by default
Hi, Make Kettenis wrote: 'use "ssh -X" to achieve X11 network transparency' even that is old school... "ssh -2 -X" is surely the way to go? Encryption is good when you have control of the keys and protocols used (or know all who can access/use them)...but new school 'Apps' send your personal data, over public networks, without you knowing what is being encrypted, to massive 'potentially Orwellian' data centres. So I don't think X11 network transparency is much of a threat to your privacy, in 'this time and age', there is an elephant in the room! Reduction of the established/proven complexity of 'consumer' software potentially forces you to use 'cloud services' or rent on-line software to do real work (just look at the Teletubby GUIs of modern 'consumer' operating systems with their 'swarms' of useless highly intrusive apps) Fessing up: I have a vested interest in producing X servers for private companies and individuals, not producing databases and servers for huge anonymous data centres! Cheers, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xinit 0/1] startx: Pass "-nolisten tcp" by default
Hi, Alan Coopersmith wrote: "Allowing people to connect to your machine and throw crap at it to trigger all our overflows is simply stupid." If they on your local private network (AKA your 'private cloud')...you at least know who they are, get bug reports and can maybe even help fix :) I would never propose using X11 network transparency over a public internet or even though a bridge or router. Anyway SSH exposes bugs as well. In fact any connection can! Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] xdmcp: Simplify format specifier in XdmcpFatal() for vpnprintf()
Hi, There are instances of this format also in os/access.c (not that I ever get sight of them!) Probably best fixed in vpnprintf() but your xdmcp patch fixes the most seen instance (for me). Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Reference: xorg/app/xauth Update DISPLAY parsing to work with new launchd paths in Yosemite
Hi, In the latest commit to xauth there are two added instances of: buf[sizeof(path) - 1] = '\0'; shouldn't those be? path[sizeof(path) - 1] = '\0'; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Fix a crash with XDMCP error handler
Hi, I much prefer Jon Turney's more universal fix to this problem. http://lists.x.org/archives/xorg-devel/2014-November/044568.html and having tested Jon's fix it can have Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
RE: [PULL] Misc patches
Hi,
Builds for me on MinGW-w64. I suspect the '#ifdef INXQUARTZ' ...'#endif', 5
lines, removal in exinit.h needs reverting for Jeremy?
Sorry, I can't test for the Darwin build.
Thanks,
Colin Harrison
> -Original Message-
> From: Jeremy Huddleston Sequoia [mailto:jerem...@gmail.com]
> Sent: 29 March 2015 20:59
> To: Jon TURNEY
> Cc: xorg-devel; Colin Harrison; Keith Packard
> Subject: Re: [PULL] Misc patches
>
> Hey Jon,
>
> Sorry, I didn't get around to reviewing or testing these earlier. I
suspect this
> might be the cause of the build failure fallout on tinderbox:
>
> http://tinderbox.x.org/builds/2015-03-29-0002/logs/xserver/#build
>
> ../../mi/miinitext.c:261:6: error: use of undeclared identifier
> 'PseudoramiXExtensionInit'; did you mean 'PanoramiXExtensionInit'?
> [Semantic Issue]
> {PseudoramiXExtensionInit, "PseudoramiX", &noPseudoramiXExtension},
> ^~~~
> PanoramiXExtensionInit
> ../../include/extinit.h:87:13: note: 'PanoramiXExtensionInit' declared
here
> [Semantic Issue]
> extern void PanoramiXExtensionInit(void);
> ^
> ../../mi/miinitext.c:261:48: error: use of undeclared identifier
> 'noPseudoramiXExtension'; did you mean 'noPanoramiXExtension'?
> [Semantic Issue]
> {PseudoramiXExtensionInit, "PseudoramiX", &noPseudoramiXExtension},
>^~
>noPanoramiXExtension
> ../../include/extinit.h:86:23: note: 'noPanoramiXExtension' declared here
> [Semantic Issue]
> extern _X_EXPORT Bool noPanoramiXExtension;
> ^
> 2 errors generated.
>
>
> > On Mar 27, 2015, at 06:45, Keith Packard wrote:
> >
> > Jon TURNEY writes:
> >
> >> Jon TURNEY (13):
> >> ephyr: Avoid a segfault with 'DISPLAY= Xephy -glamor'
> >> os: XDMCP options like -query etc. should imply -listen tcp
> >> os: Teach vpnprintf() how to handle "%*.*s"
> >> hw/xwin/glx: Refactor parsing of the XML element
> >> hw/xwin/glx: Improve code generator to deal with latest Khronos
> OpenGL registry XML
> >> hw/xwin: Report Cygwin version information in log
> >> hw/xwin: Turn on -hostintitle by default
> >> Make PseudoramiXExtensionInit() prototype more generally available
> >> hw/xwin: Register native screens with pseudoramiX
> >> hw/xwin: Only set native positions if XINERAMA is enabled
> >> hw/xwin: Remove Shadow DirectDraw engine
> >> hw/xwin: Report OS version in log
> >> Don't allow both RandR XINERAMA and pseudoramiX XINERAMA
> extensions to register
> >
> > Merged.
> >
> > --
> > -keith
> > ___
> > xorg-devel@lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: http://lists.x.org/mailman/listinfo/xorg-devel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/5] hw/xwin fixes and more (v2)
Hi, I'm happy with Jon making code changes in xwin to try and sort this glx-dispatch mess out (i.e. xwin is currently broken in xserver git master!) but am unable to spare much time mangling changes at the moment. Thanks Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 00/37] Warning fixes (post 1.15 proposed changes)
ontPathElementPtr fpe, char** namep, int* namelenp, char** resolvedp, int* resolvedlenp, - pointer private); + void * private); typedef void (*SetPathFunc)(void); I've not had any problems elsewhere after applying these changes. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 00/37] Warning fixes (post 1.15 proposed changes)
Hi,
This message was sent before the last one?
(maybe Biff the dog ran off and buried it!)
Apologies if it now appears twice!
Some const GC funcs and ops were missed in rootless...
--- ./miext/rootless/save_rootlessGC.c 2014-01-13 08:09:28.124320860 +
+++ ./miext/rootless/rootlessGC.c 2014-01-13 18:31:27.668467154 +
@@ -403,7 +403,7 @@
#define GCOP_UNWRAP(pGC) \
RootlessGCRec *gcrec = (RootlessGCRec *) \
dixLookupPrivate(&(pGC)->devPrivates, rootlessGCPrivateKey); \
-GCFuncs *saveFuncs = pGC->funcs; \
+const GCFuncs *saveFuncs = pGC->funcs; \
(pGC)->funcs = gcrec->originalFuncs; \
(pGC)->ops = gcrec->originalOps;
And
--- ./miext/rootless/save_rootlessCommon.h 2013-05-24
07:01:08.0 +0100
+++ ./miext/rootless/rootlessCommon.h 2014-01-13 15:37:06.933788427 +
@@ -70,8 +70,8 @@
// RootlessGCRec: private per-gc data
typedef struct {
-GCFuncs *originalFuncs;
-GCOps *originalOps;
+const GCFuncs *originalFuncs;
+const GCOps *originalOps;
} RootlessGCRec;
// RootlessScreenRec: per-screen private data
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 00/37] Warning fixes (post 1.15 proposed changes)
Hi,
Some const GC funcs and ops were missed in rootless...
--- ./miext/rootless/save_rootlessGC.c 2014-01-13 08:09:28.124320860 +
+++ ./miext/rootless/rootlessGC.c 2014-01-13 18:31:27.668467154 +
@@ -403,7 +403,7 @@
#define GCOP_UNWRAP(pGC) \
RootlessGCRec *gcrec = (RootlessGCRec *) \
dixLookupPrivate(&(pGC)->devPrivates, rootlessGCPrivateKey); \
-GCFuncs *saveFuncs = pGC->funcs; \
+const GCFuncs *saveFuncs = pGC->funcs; \
(pGC)->funcs = gcrec->originalFuncs; \
(pGC)->ops = gcrec->originalOps;
And
--- ./miext/rootless/save_rootlessCommon.h 2013-05-24
07:01:08.0 +0100
+++ ./miext/rootless/rootlessCommon.h 2014-01-13 15:37:06.933788427 +
@@ -70,8 +70,8 @@
// RootlessGCRec: private per-gc data
typedef struct {
-GCFuncs *originalFuncs;
-GCOps *originalOps;
+const GCFuncs *originalFuncs;
+const GCOps *originalOps;
} RootlessGCRec;
// RootlessScreenRec: per-screen private data
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] hw/xwin: link dynamically and export symbols
Reviewed-by: Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXfont] Make shared library work on Cygwin/MinGW
Reviewed-by: Colin Harrison And works for me cross-compiling with MinGW-w64 for Microsoft Windows (a magic patch solving an old/large problem!) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/2] hw/xwin build fixes
Reviewed-by: Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: XI18N_OBJS and XLC_LOCALE.pre
Hi, In order for the new Czech keyboard locale directory to actually appear in a distribution I had to add cs_CZ.UTF-8 to the list of AC_SUBST(locales) in libX11/configure.ac Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL] hw/xwin fixes + a warning fix
Hi, > This looks like it's missing > x = dx; > y = dy; With this in I get no mouse events (on the left monitor) when the main display is not leftmost with multiple monitors. The casting is probably messing up negative x's on Windows? As in the [PULL] I can't detect any position errors. Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)
Hi,
On my Windows build this patch...
diff --git a/render/animcur.c b/render/animcur.c
index 4cf1fdf..0f174fd 100644
--- a/render/animcur.c
+++ b/render/animcur.c
@@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev,
AnimCurScreenPtras = GetAnimCurScreen(pScreen);
Bool ret;
+if (IsFloating(pDev))
+ return FALSE;
+
Unwrap (as, pScreen, DisplayCursor);
if (IsAnimCur(pCursor))
{
causes the 'default' cursor to disappear...(I like to party_like_its 1989!)
I always need a cursor as when the X root window isn't hidden on Windows you
can't easily control anything as the 'black or stippled X window' blots out
Microsoft's stuff :)
Thanks,
Colin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL] hw/xwin fixes + a warning fix
Hi,
Looking into it further the code at the end of miPointerSetPosition() maybe
the cause of this...
/* In the event we actually change screen or we get confined, we just
* drop the float component on the floor
* FIXME: only drop remainder for ConstrainCursorHarder, not for screen
* crossings */
if (x != trunc(*screenx))
*screenx = x;
if (y != trunc(*screeny))
*screeny = y;
this was introduced at the same time the function switched to doubles.
If I revert those traps and then call the function...
void winEnqueueMotion(int x, int y)
{
int valuators[2];
ValuatorMask mask;
double dx = (double)x;
double dy = (double)y;
miPointerSetPosition(g_pwinPointer, POINTER_RELATIVE, &dx, &dy);
x = trunc(dx);
y = trunc(dy);
valuators[0] = x;
valuators[1] = y;
valuator_mask_set_range(&mask, 0, 2, valuators);
QueuePointerEvents(g_pwinPointer, MotionNotify, 0,
POINTER_ABSOLUTE | POINTER_SCREEN, &mask);
}
I now get no problem...I could however do better by just using doubles for x
and y in the hw/xwin function headers and get rid of those hacky casts and
trunc()'s. Will now test that + use of POINTER_RELATIVE looks dodgy!
Thanks,
Colin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL] hw/xwin fixes + a warning fix
Hi, Daniel wrote: > > Why are you actually calling miPointerSetPosition at all? Someone had to be daft enough to use it. As in "if it isn't defined static then it must be useful" And if it is then "I want to access it anyway" :) It's late...more coffee is required to wash away the dust! Thanks, Colin ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/7] Resume breaking ABI
Hi, In xserver/include/dixstruct.h struct _Client: isn't clientState type ClientState not int? Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/7] Resume breaking ABI
Hi, Keith, I didn't check the bit packing on this but my compiler gave a scattering of... "warning: case label value exceeds maximum value for type" which may be best not to ignore. So patched... --- ./include/save_dixstruct.h 2012-10-04 19:31:00.451081236 +0100 +++ ./include/dixstruct.h 2012-10-04 20:17:55.131273403 +0100 @@ -95,7 +95,7 @@ int big_requests:1; /* supports large requests */ int clientGone:1; int closeDownMode:2; -int clientState:2; +ClientState clientState:2; char smart_priority; short noClientException; /* this client died or needs to be killed */ int priority; Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/7] Resume breaking ABI
Hi, > Probably needs to be 'unsigned int' instead. I still don't know if we > can use the enum type here. My compiler is happy with 'unsigned int', which is the safest bet I reckon for all (I had to dig out my K&R ANSI C on this...and read it once more!) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/7] Resume breaking ABI
Hi,
> Care to submit a patch which updates all of the changed bitfields to
> unsigned?
Ooops...I meant probably OK for all compilers...not all fields.
K&R ANSI quotes stuff like...
"The ANSI standard makes fields even more implementation-dependent then did
the first edition."
I'm cross-compiling using gcc via MinGW for Windows...other compiler users
mileage may vary as bit-fields are not that common.
My patch is still only one line...and the compiler output should be checked,
I suppose, from an objdump that uses ClientRec?
--- ./include/save_dixstruct.h 2012-10-05 01:24:03.981982326 +0100
+++ ./include/dixstruct.h 2012-10-05 08:04:21.244045996 +0100
@@ -95,7 +95,7 @@
int big_requests:1; /* supports large requests */
int clientGone:1;
int closeDownMode:2;
-int clientState:2;
+unsigned int clientState:2;
char smart_priority;
short noClientException; /* this client died or needs to be killed
*/
int priority;
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/7] Resume breaking ABI
Hi,
Thinking about this after strong coffee: all those bit-fields would be
better unsigned...
--- ./include/save_dixstruct.h 2012-10-05 01:24:03.981982326 +0100
+++ ./include/dixstruct.h 2012-10-05 20:13:19.803253520 +0100
@@ -90,12 +90,12 @@ typedef struct _Client {
Mask clientAsMask;
short index;
unsigned char majorOp, minorOp;
-int swapped:1;
-int local:1;
-int big_requests:1; /* supports large requests */
-int clientGone:1;
-int closeDownMode:2;
-int clientState:2;
+unsigned swapped:1;
+unsigned local:1;
+unsigned big_requests:1; /* supports large requests */
+unsigned clientGone:1;
+unsigned closeDownMode:2;
+unsigned clientState:2;
char smart_priority;
short noClientException; /* this client died or needs to be killed
*/
int priority;
Thanks,
Colin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xproto] Do not use visibility attributes on MinGW
Hi, That patch is essential. Reviewed-by and Tested-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH proto/x11proto] Adjust wrapping to work with MinGW-w64 headers as well
Hi, Jon's changes to proto/x11proto Xwindows.h are OK by me. Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH lib/libXaw] Include winsock header on WIN32 to provide fd_set etc.
Hi, Ryan's change to libXaw/src/TextAction.c is OK by me. Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH lib/libXpm] Define NO_ZPIPE when building for MinGW
Hi, Jon's change to libXpm/configure.ac is OK by me. Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH lib/libXfont] Provide a dummy readlink on WIN32
Hi,
I have just used something like this to avoid the symlink problem...
--- ./src/fontfile/save_catalogue.c 2011-09-17 07:30:41.710991917 +0100
+++ ./src/fontfile/catalogue.c 2011-11-03 21:12:30.800542536 +
@@ -154,6 +154,7 @@
}
CatalogueUnrefFPEs (fpe);
+#ifndef __MINGW32__
while (entry = readdir(dir), entry != NULL)
{
snprintf(link, sizeof link, "%s/%s", path, entry->d_name);
@@ -218,6 +219,7 @@
continue;
}
}
+#endif
closedir(dir);
Thanks,
Colin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH lib/libXpm] Define NO_ZPIPE when building for MinGW
Hi, > Ángel González wrote: There's no reason for decompression via pipe not to work under Windows. Luckily I haven't found an instance where I use libXpm, in anger, to decompress an XPM file via a pipe on Windows ...until I can find a useful/modern/test case (and hence motivation to write code) I lazily just like it to compile :) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 2/4] doc: Update documentation about Windows platforms support
Hi, > Jon Turney wrote: +Windows-dependent code assumes at least NT 5.0. Window 2000 and earlier are <1% of global OS use and it reached the end of its lifecycle in 2010 Can't we make this NT 5.1? I can't test XP properly either...but that is used by ~44% so still worth the trouble to try. Luckily most old Windows stuff (let's say 5.1 now defines old!) will probably still run on Windows 8 (well not on 8 RT...but that's for big cloudy phones...used for putting your private data on someone else's machine...somewhere...for 'non-evil' search and use by people unknown :) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 2/4] doc: Update documentation about Windows platforms support
Hi, At least NT 5.1 it is then. Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXfont] Omit catalogue support on systems without symlinks
Hi, That's much better than my hatchet job patch. Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH proto/x11proto] Adjust wrapping to work with MinGW-w64 headers as well
Hi, Jon's patch to Xwindow.h is as far as I get OK at the moment...your extras cause me problems in a 32-bit build of the xserver. I'll get back, when I have time, with the reason...quick look...something to do with the INT64's used in wgl wrappers. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH proto/x11proto] Adjust wrapping to work with MinGW-w64 headers as well
Hi, http://lists.x.org/archives/xorg-devel/2012-October/034096.html works for me (MinGW 32-bit) for both Xwinsock.h and Xwindows.h Reviewed-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dix/resource: bug out if we get 0 type resource added
Hi, AddResource() gets called with type == RT_NONE in StoreFontClientFont() in dix/dixfonts()? Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dix/resource: bug out if we get 0 type resource added
Hi, It gets called, for me (MinGW build for Windows), and messes up xrestop, but I haven't traced back through libXfont, to try and work out the logic or why. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dix/resource: bug out if we get 0 type resource added
Hi, I still use this empirical patch (AKA a bodge!) to fix the xrestop crash. http://lists.x.org/archives/xorg-devel/2012-July/032898.html Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dix: Make small bitfields that store enums unsigned
Hi, Reviewed-by: Colin Harrison And first reported in October... http://lists.x.org/archives/xorg-devel/2012-October/033868.html Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
RE: [PATCH mkfontscale] Prefer original file over symlink (v2)
Hi,
Yes that's more elegant than an if(0) bodge that I used quickly to get me
compiling again!
Reviewed-by: Colin Harrison
Thanks,
Colin Harrison
> -Original Message-
> From: Jon TURNEY [mailto:jon.tur...@dronecode.org.uk]
> Sent: 11 January 2013 15:14
> To: xorg-devel
> Cc: Egbert Eich; Colin Harrison
> Subject: Re: [PATCH mkfontscale] Prefer original file over symlink (v2)
>
> On 03/01/2013 20:30, Egbert Eich wrote:
> > +#define PRIO(x) ((x << 1) + tprio)
> > +#ifdef DT_LNK
> > + if (entry->d_type != DT_UNKNOWN) {
> > + if (entry->d_type == DT_LNK)
> > + tprio = 0;
> > + } else
> > +#endif
> > + {
> > + if (lstat(filename, &f_stat))
> > + goto done;
> > + if (S_ISLNK(f_stat.st_mode))
> > + tprio = 0;
> > + }
> > if(doBitmaps)
> > rc = bitmapIdentify(filename, &xlfd_name);
> > else
>
> Unfortunately, S_ISLNK isn't defined on MinGW (see [1]), so perhaps the
> attached is needed.
>
> [1] http://tinderbox.freedesktop.org/builds/2013-01-10-
> 0020/logs/mkfontscale/
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH app/xhost 0/4] xhost fixes for Windows MinGW
For the series: Reviewed-by: Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dix/resource: bug out if we get 0 type resource added
Hi,
As a follow up to part of the last entry in the closed Bugzilla...
https://bugs.freedesktop.org/show_bug.cgi?id=57448
I now use this patch...
--- ./Xext/save_xres.c 2012-11-05 21:11:15.070319535 +
+++ ./Xext/xres.c 2013-02-26 21:32:12.726008604 +
@@ -272,7 +272,7 @@
{
int *counts = (int *) cdata;
-counts[(type & TypeMask) - 1]++;
+if ((type & TypeMask) != RT_NONE) counts[(type & TypeMask) - 1]++;
}
to avoid xrestop crashing the server...which has got to be a good thing?
Thanks,
Colin Harrison
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL unreviewed] touch fixes for #56578
Hi,
I got some log spam from the "Abstract cursor refcounting" change and so
just commented it out...
--- ./dix/save_cursor.c 2013-05-24 07:01:07.905179181 +0100
+++ ./dix/cursor.c 2013-05-24 07:21:53.055169797 +0100
@@ -134,12 +134,12 @@
CursorPtr
RefCursor(CursorPtr cursor)
{
-ErrorF("%s : cursor is %p", __func__, cursor);
+/* ErrorF("%s : cursor is %p", __func__, cursor); */
if (cursor) {
xorg_backtrace();
cursor->refcnt++;
}
-ErrorF("\n");
+/* ErrorF("\n"); */
return cursor;
}
Thanks,
Colin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:libXt 2/6] Avoid shadowing variables.
Hi, This patch caused problems for me with local clients (xcalc...boundary boxes scrunched, xlogo.. has black not red X). (libXt Cross-compiled with mingw-w64 on Linux for Windows x86 and x64) I can dig deeper if required (if I can't get away with being lazy by just sending this vague report!) Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Syntax error in recent twm commit
Hi, twm needs a typo/syntax correction following a recent commit... --- ./src/save_session.c2013-07-18 09:26:03.384198809 +0100 +++ ./src/session.c 2013-07-18 10:14:14.435276234 +0100 @@ -721,7 +721,7 @@ static char * unique_filename ( const char *path, -const char *prefix +const char *prefix) #else static char * unique_filename ( Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Syntax error in recent twm commit
Hi, B) No POSIX on Windows (mingw-w64), so quicker to list the stuff I have, than functions like mkstemp() that I haven't! Autotools not at fault this time. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 16/19] glx: Remove screen number from __GLXconfig
Hi, Jon's patch works for me. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Obfuscated code in xserver/os/io.c ?
Hi, This code at xserver/os/io.c ~line 459 if (SmartScheduleDisable) if (++timesThisConnection >= MAX_TIMES_PER) YieldControl(); is either obfuscated or wrong? if (SmartScheduleDisable && ++timesThisConnection >= MAX_TIMES_PER) YieldControl(); is what it does at present. Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Missing end comment in libXpm/src/parse.c
Hi, CVS tag removal chopped too much out in this case... --- ./src/save_parse.c 2010-10-07 08:45:17.0 +0100 +++ ./src/parse.c 2010-10-07 08:53:35.0 +0100 @@ -21,6 +21,7 @@ * Except as contained in this notice, the name of GROUPE BULL shall not be * used in advertising or otherwise to promote the sale, use or other dealings * in this Software without prior written authorization from GROUPE BULL. + */ /*** **\ * parse.c: Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
